Re: [vpp-dev] Can I submit commit to vpp GitHub repo instead of gerrit?

2020-09-29 Thread Dimitrios Markou
g,_Building,_Running,_Hacking_and_Pushing_VPP_Code – anyone can sign up for an account with Linux Foundation and login to fd.io’s gerrit. Chris. From: vpp-dev@lists.fd.io On Behalf Of Dimitrios Markou Sent: Monday, September 28, 2020 12:07 To: vpp-dev@lists.fd.io Subject: [EXTERNAL] [vpp-dev] Can I submit commi

Re: [vpp-dev] Can I submit commit to vpp GitHub repo instead of gerrit?

2020-09-28 Thread Dengfeng Liu
[Edited Message Follows] github is a good choice, It will attract more developer to join vpp project. -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#17568): https://lists.fd.io/g/vpp-dev/message/17568 Mute This Topic:

Re: [vpp-dev] Can I submit commit to vpp GitHub repo instead of gerrit?

2020-09-28 Thread Dengfeng Liu
github is a good choice, I will attract more developer to join vpp project. -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#17568): https://lists.fd.io/g/vpp-dev/message/17568 Mute This Topic: https://lists.fd.io/mt/77178878/21656 Group Owner:

Re: [vpp-dev] Can I submit commit to vpp GitHub repo instead of gerrit?

2020-09-28 Thread Chris Luke
: [EXTERNAL] [vpp-dev] Can I submit commit to vpp GitHub repo instead of gerrit? Hello all, I would like to ask if it is possible to create pull requests to the vpp github repo. I am not sure if I am allowed to do so or I must use only the gerrit path. I am asking because I am seeing couple pull

[vpp-dev] Can I submit commit to vpp GitHub repo instead of gerrit?

2020-09-28 Thread Dimitrios Markou
Hello all, I would like to ask if it is possible to create pull requests to the vpp github repo. I am not sure if I am allowed to do so or I must use only the gerrit path. I am asking because I am seeing couple pull requests in the github repo. https://github.com/FDio/vpp/pulls Regards,

Re: [vpp-dev] Can I submit commit to vpp GitHub repo instead of gerrit?

2020-09-28 Thread Damjan Marion via lists.fd.io
github is just a mirror. It is not used for code review. Please use gerrit… — Damjan > On 28.09.2020., at 19:08, Dimitrios Markou wrote: > > Hello all, > > I would like to ask if it is possible to create pull requests to the vpp > github repo. I am not sure if I am allowed to do so or I

[vpp-dev] Can I submit commit to vpp GitHub repo instead of gerrit?

2020-09-28 Thread Dimitrios Markou
Hello all, I would like to ask if it is possible to create pull requests to the vpp github repo. I am not sure if I am allowed to do so or I must use only the gerrit path. I am asking because I am seeing couple pull requests in the github repo. https://github.com/FDio/vpp/pulls Regards,