Re: [vpp-dev] Commit Subjects

2019-06-29 Thread Damjan Marion via Lists.Fd.Io 


> On 17 Jun 2019, at 23:40, Jon Loeliger via Lists.Fd.Io 
>  wrote:
> 
> On Mon, Jun 17, 2019 at 3:43 PM Damjan Marion  > wrote:
> 
>> On 17 Jun 2019, at 22:41, Jon Loeliger > > wrote:
>> 
>> On Mon, Jun 17, 2019 at 3:33 PM Damjan Marion > > wrote:
>> 
>> I tried to be as much descriptive as possible in those messages, but looks 
>> like I failed :(
>> 
>> Damjan,
>> 
>> No problem.  I am working on some improvements.
>> 
>> For example, fixing these problems:
>> 
>> $ echo "Consolidate IPv6 link-local-address functions." |  sed -e 
>> 's/\(.*\):.*/\1/'
>> Consolidate IPv6 link-local-address functions.
>>  
>> $ echo "foo: bar: baz: Consolidate IPv6 link-local-address functions." |  
>> sed -e 's/\(.*\):.*/\1/'
>> foo: bar: baz
> 
> Your commit message needs to be:
> 
> foo bar baz: consolidate...
> 
> Damjan,
> 
> I think there will be unexpected complications with this approach.  Consider 
> this:
> 
> $ echo "docs: fix http:/foo.example.com:8080/fred 
>  use." |  sed -e 's/\(.*\):.*/\1/'
> docs: fix http:/foo.example.com 
> 
> That won't match "docs:", nor any other valid I: word in any case where there 
> is an
> additional colon later in the subject line.  It will also allow false 
> positives like this
> subject:  "whanged on ip stuff: it was messed up".
> 
> Historically, these things have been keywords individually terminated by a 
> colon, as
> I gave in my example.  Once the collection of keywords is gathered, strip the 
> trailing
> colons for validity comparisons.
> 
> Just a thought.

Is this better?

https://gerrit.fd.io/r/20410


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#13403): https://lists.fd.io/g/vpp-dev/message/13403
Mute This Topic: https://lists.fd.io/mt/32096793/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] Commit Subjects

2019-06-17 Thread Jon Loeliger via Lists.Fd.Io 
On Mon, Jun 17, 2019 at 3:43 PM Damjan Marion  wrote:

>
> On 17 Jun 2019, at 22:41, Jon Loeliger  wrote:
>
> On Mon, Jun 17, 2019 at 3:33 PM Damjan Marion  wrote:
>
>>
>> I tried to be as much descriptive as possible in those messages, but
>> looks like I failed :(
>>
>
> Damjan,
>
> No problem.  I am working on some improvements.
>
> For example, fixing these problems:
>
> $ echo "Consolidate IPv6 link-local-address functions." |  sed -e
> 's/\(.*\):.*/\1/'
> Consolidate IPv6 link-local-address functions.
>
> $ echo "foo: bar: baz: Consolidate IPv6 link-local-address functions." |
>  sed -e 's/\(.*\):.*/\1/'
> foo: bar: baz
>
>
> Your commit message needs to be:
>
> foo bar baz: consolidate...
>

Damjan,

I think there will be unexpected complications with this approach.
Consider this:

$ echo "docs: fix http:/foo.example.com:8080/fred use." |  sed -e
's/\(.*\):.*/\1/'
docs: fix http:/foo.example.com

That won't match "docs:", nor any other valid I: word in any case where
there is an
additional colon later in the subject line.  It will also allow false
positives like this
subject:  "whanged on ip stuff: it was messed up".

Historically, these things have been keywords individually terminated by a
colon, as
I gave in my example.  Once the collection of keywords is gathered, strip
the trailing
colons for validity comparisons.

Just a thought.

jdl
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#13311): https://lists.fd.io/g/vpp-dev/message/13311
Mute This Topic: https://lists.fd.io/mt/32096793/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] Commit Subjects

2019-06-17 Thread Damjan Marion via Lists.Fd.Io 

> On 17 Jun 2019, at 22:41, Jon Loeliger  wrote:
> 
> On Mon, Jun 17, 2019 at 3:33 PM Damjan Marion  > wrote:
> 
> I tried to be as much descriptive as possible in those messages, but looks 
> like I failed :(
> 
> Damjan,
> 
> No problem.  I am working on some improvements.
> 
> For example, fixing these problems:
> 
> $ echo "Consolidate IPv6 link-local-address functions." |  sed -e 
> 's/\(.*\):.*/\1/'
> Consolidate IPv6 link-local-address functions.
>  
> $ echo "foo: bar: baz: Consolidate IPv6 link-local-address functions." |  sed 
> -e 's/\(.*\):.*/\1/'
> foo: bar: baz

Your commit message needs to be:

foo bar baz: consolidate...

with lowercase 'c'


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#13310): https://lists.fd.io/g/vpp-dev/message/13310
Mute This Topic: https://lists.fd.io/mt/32096793/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] Commit Subjects

2019-06-17 Thread Jon Loeliger via Lists.Fd.Io 
On Mon, Jun 17, 2019 at 3:33 PM Damjan Marion  wrote:

>
> I tried to be as much descriptive as possible in those messages, but looks
> like I failed :(
>

Damjan,

No problem.  I am working on some improvements.

For example, fixing these problems:

$ echo "Consolidate IPv6 link-local-address functions." |  sed -e
's/\(.*\):.*/\1/'
Consolidate IPv6 link-local-address functions.

$ echo "foo: bar: baz: Consolidate IPv6 link-local-address functions." |
 sed -e 's/\(.*\):.*/\1/'
foo: bar: baz

HTH,
jdl
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#13309): https://lists.fd.io/g/vpp-dev/message/13309
Mute This Topic: https://lists.fd.io/mt/32096793/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] Commit Subjects

2019-06-17 Thread Damjan Marion via Lists.Fd.Io 

I tried to be as much descriptive as possible in those messages, but looks like 
I failed :(

> On 17 Jun 2019, at 22:20, Florin Coras  wrote:
> 
> Hi Jon, 
> 
> Yup, it has to match a maintainer “I” entry and yes, that’s where the script 
> is. :-)
> 
> Florin
> 
>> On Jun 17, 2019, at 1:16 PM, Jon Loeliger via Lists.Fd.Io 
>> mailto:jdl=netgate@lists.fd.io>> wrote:
>> 
>> And now this: 
>> 
>> === ERROR ===
>> Unknown feature 'Consolidate' in commit 'Subject:' line.
>> Feature must exist in MAINTAINERS file. If this commit intruduces 
>> new feature, then this commit must add new entry into the 
>> MAINTAINERS file.
>> === ERROR ===
>> Does it just check the first word on the subject line regardless?
>> What else is being checked?  Poorly?
>> Does it _have_ to match a MAINTAINER I: word?
>> 
>> Where is this script?  Rhetorical.  It is here:
>> extras/scripts/check_commit_msg.sh
>> 
>> Now I at least know what I am up against.
>> 
>> jdl
>> 
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> 
>> View/Reply Online (#13306): https://lists.fd.io/g/vpp-dev/message/13306 
>> 
>> Mute This Topic: https://lists.fd.io/mt/32096793/675152 
>> 
>> Group Owner: vpp-dev+ow...@lists.fd.io 
>> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub 
>>   [fcoras.li...@gmail.com 
>> ]
>> -=-=-=-=-=-=-=-=-=-=-=-
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> 
> View/Reply Online (#13307): https://lists.fd.io/g/vpp-dev/message/13307
> Mute This Topic: https://lists.fd.io/mt/32096793/675642
> Group Owner: vpp-dev+ow...@lists.fd.io
> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [dmar...@me.com]
> -=-=-=-=-=-=-=-=-=-=-=-

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#13308): https://lists.fd.io/g/vpp-dev/message/13308
Mute This Topic: https://lists.fd.io/mt/32096793/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] Commit Subjects

2019-06-17 Thread Florin Coras 
Hi Jon, 

Yup, it has to match a maintainer “I” entry and yes, that’s where the script 
is. :-)

Florin

> On Jun 17, 2019, at 1:16 PM, Jon Loeliger via Lists.Fd.Io 
>  wrote:
> 
> And now this: 
> 
> === ERROR ===
> Unknown feature 'Consolidate' in commit 'Subject:' line.
> Feature must exist in MAINTAINERS file. If this commit intruduces 
> new feature, then this commit must add new entry into the 
> MAINTAINERS file.
> === ERROR ===
> Does it just check the first word on the subject line regardless?
> What else is being checked?  Poorly?
> Does it _have_ to match a MAINTAINER I: word?
> 
> Where is this script?  Rhetorical.  It is here:
> extras/scripts/check_commit_msg.sh
> 
> Now I at least know what I am up against.
> 
> jdl
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> 
> View/Reply Online (#13306): https://lists.fd.io/g/vpp-dev/message/13306
> Mute This Topic: https://lists.fd.io/mt/32096793/675152
> Group Owner: vpp-dev+ow...@lists.fd.io
> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [fcoras.li...@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#13307): https://lists.fd.io/g/vpp-dev/message/13307
Mute This Topic: https://lists.fd.io/mt/32096793/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] Commit Subjects

2019-06-17 Thread Jon Loeliger via Lists.Fd.Io 
And now this:

=== ERROR ===

Unknown feature 'Consolidate' in commit 'Subject:' line.
Feature must exist in MAINTAINERS file. If this commit intruduces
new feature, then this commit must add new entry into the
MAINTAINERS file.
=== ERROR ===

Does it just check the first word on the subject line regardless?
What else is being checked?  Poorly?
Does it _have_ to match a MAINTAINER I: word?

Where is this script?  Rhetorical.  It is here:
extras/scripts/check_commit_msg.sh

Now I at least know what I am up against.

jdl
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#13306): https://lists.fd.io/g/vpp-dev/message/13306
Mute This Topic: https://lists.fd.io/mt/32096793/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[vpp-dev] Commit Subjects

2019-06-17 Thread Jon Loeliger via Lists.Fd.Io 
Folks,

I received this during a build of a patch I submitted:

=== ERROR ===
Unknown feature 'IPv6' in commit 'Subject:' line.
Feature must exist in MAINTAINERS file. If this commit intruduces
new feature, then this commit must add new entry into the
MAINTAINERS file.
=== ERROR ===

Can we modify the scripts/check-something to verify this before
it is submitted?

Can we fix the spelling error in the message?

Thanks,
jdl
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#13301): https://lists.fd.io/g/vpp-dev/message/13301
Mute This Topic: https://lists.fd.io/mt/32096793/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-