Re: [vpp-dev] bug in api for tapv2

2018-10-17 Thread Marco Varlese 
Thank you!
On Wed, 2018-10-17 at 12:18 +, Michal Cmarada via Lists.Fd.Io wrote:
> Hi Marco,
>  
> Done: 
> https://gerrit.fd.io/r/#/c/15342/
>  
> Michal
>  
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> Michal Cmarada
> Engineer - Software
> mcmar...@cisco.com
> Tel:
> 
>  
>  
> 
> 
> 
> 
>  
> 
> 
> 
> 
> 
> 
> 
>  
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> Cisco Systems, Inc.
>  
>  
>  
> Slovakia
> cisco.com
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> Think before you print.
> 
> 
> 
> 
> This email may contain confidential and privileged material for the sole use
> of the intended recipient. Any review, use, distribution
>  or disclosure by others is strictly prohibited. If you are not the intended
> recipient (or authorized to receive for the recipient), please contact the
> sender by reply email and delete all copies of this message.
> Please
> 
> click here for Company Registration Information.
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
>  
> 
>  
> 
> 
> From: Marco Varlese  
> 
> Sent: Wednesday, October 17, 2018 2:16 PM
> 
> To: Michal Cmarada -X (mcmarada - PANTHEON TECHNOLOGIES at Cisco) <
> mcmar...@cisco.com>; vpp-dev@lists.fd.io
> 
> Subject: Re: [vpp-dev] bug in api for tapv2
> 
> 
>  
> 
> Hi Michal,
> 
> 
>  
> 
> 
> On Wed, 2018-10-17 at 11:49 +, Michal Cmarada via Lists.Fd.Io wrote:
> 
> > Hi VPP devs,
> >  
> > I found a bug in API for tapv2. I prepared a fix but I need someone to check
> > it.
> > 
> > 
> > gerrit patch: https://gerrit.fd.io/r/#/c/15341/
> 
> Yes, your fix makes sense to me.
> 
> 
> I am waiting for the Verified+1 to merge it.
> 
> 
>  
> 
> > 
> > also it will probably need a cherry-pick to stable 18.10
> 
> Yes, it will have to be cherry-picked to stable 18.10. Can you push a patch
> there too?
> 
> 
>  
> 
> >  
> >  
> > Thanks
> >  
> > Michal
> 
> Cheers,
> 
> 
> Marco
> 
> 
>  
> 
> >  
> >  
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > Michal Cmarada
> > Engineer - Software
> > mcmar...@cisco.com
> > Tel:
> > 
> >  
> >  
> > 
> > 
> > 
> > 
> >  
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> >  
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > Cisco Systems, Inc.
> >  
> >  
> >  
> > Slovakia
> > cisco.com
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > Think before you print.
> > 
> > 
> > 
> > 
> > This email may contain confidential and privileged material for the sole use
> > of the intended recipient. Any review, use, distribution
> >  or disclosure by others is strictly prohibited. If you are not the intended
> > recipient (or authorized to receive for the recipient), please contact the
> > sender by reply email and delete all copies of this message.
> > Please
> > 
> > click here for Company Registration Information.
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> >  
> >  
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> >  
> > View/Reply Online (#10854): https://lists.fd.io/g/vpp-dev/message/10854
> > Mute This Topic: https://lists.fd.io/mt/27379050/675056
> > Group Owner: vpp-dev+ow...@lists.fd.io
> > Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [mvarl...@suse.de]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >  
> 
> -- 
> 
> Marco V
> 
> 
>  
> 
> SUSE LINUX GmbH | GF: Felix Imendörffer, Jane Smithard, Graham Norton
> 
> HRB 21284 (AG Nürnberg) Maxfeldstr. 5, D-90409, Nürnberg
> 
> 
> 
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-Links: You receive all messages sent to this group.
> View/Reply Online (#10856): https://lists.fd.io/g/vpp-dev/message/10856Mute
> This Topic: https://lists.fd.io/mt/27379050/675056Group Owner: vpp-
> dev+ow...@lists.fd.ioUnsubscribe: https://lists.fd.io/g/vpp-dev/unsubb  [mvarl
> e...@suse.de]-=-=-=-=-=-=-=-=-=-=-=-
-- 
Marco V


SUSE LINUX GmbH | GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg) Maxfeldstr. 5, D-90409, Nürnberg
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#10857): https://lists.fd.io/g/vpp-dev/message/10857
Mute This Topic: https://lists.fd.io/mt/27379050/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] bug in api for tapv2

2018-10-17 Thread Michal Cmarada via Lists.Fd.Io 
Hi Marco,

Done: https://gerrit.fd.io/r/#/c/15342/

Michal

[https://www.cisco.com/c/dam/m/en_us/signaturetool/images/banners/standard/06_standard_graphic.png]




Michal Cmarada
Engineer - Software
mcmar...@cisco.com<mailto:mcmar...@cisco.com>
Tel:










Cisco Systems, Inc.



Slovakia
cisco.com



[http://www.cisco.com/assets/swa/img/thinkbeforeyouprint.gif]

Think before you print.

This email may contain confidential and privileged material for the sole use of 
the intended recipient. Any review, use, distribution or disclosure by others 
is strictly prohibited. If you are not the intended recipient (or authorized to 
receive for the recipient), please contact the sender by reply email and delete 
all copies of this message.
Please click 
here<http://www.cisco.com/c/en/us/about/legal/terms-sale-software-license-agreement/company-registration-information.html>
 for Company Registration Information.







From: Marco Varlese 
Sent: Wednesday, October 17, 2018 2:16 PM
To: Michal Cmarada -X (mcmarada - PANTHEON TECHNOLOGIES at Cisco) 
; vpp-dev@lists.fd.io
Subject: Re: [vpp-dev] bug in api for tapv2

Hi Michal,

On Wed, 2018-10-17 at 11:49 +, Michal Cmarada via Lists.Fd.Io wrote:
Hi VPP devs,

I found a bug in API for tapv2. I prepared a fix but I need someone to check it.
gerrit patch: https://gerrit.fd.io/r/#/c/15341/
Yes, your fix makes sense to me.
I am waiting for the Verified+1 to merge it.


also it will probably need a cherry-pick to stable 18.10
Yes, it will have to be cherry-picked to stable 18.10. Can you push a patch 
there too?



Thanks

Michal
Cheers,
Marco



[https://www.cisco.com/c/dam/m/en_us/signaturetool/images/banners/standard/06_standard_graphic.png]




Michal Cmarada
Engineer - Software
mcmar...@cisco.com<mailto:mcmar...@cisco.com>
Tel:










Cisco Systems, Inc.



Slovakia
cisco.com



[http://www.cisco.com/assets/swa/img/thinkbeforeyouprint.gif]

Think before you print.

This email may contain confidential and privileged material for the sole use of 
the intended recipient. Any review, use, distribution or disclosure by others 
is strictly prohibited. If you are not the intended recipient (or authorized to 
receive for the recipient), please contact the sender by reply email and delete 
all copies of this message.
Please click 
here<http://www.cisco.com/c/en/us/about/legal/terms-sale-software-license-agreement/company-registration-information.html>
 for Company Registration Information.








-=-=-=-=-=-=-=-=-=-=-=-

Links: You receive all messages sent to this group.



View/Reply Online (#10854): https://lists.fd.io/g/vpp-dev/message/10854

Mute This Topic: https://lists.fd.io/mt/27379050/675056

Group Owner: vpp-dev+ow...@lists.fd.io<mailto:vpp-dev+ow...@lists.fd.io>

Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  
[mvarl...@suse.de<mailto:mvarl...@suse.de>]

-=-=-=-=-=-=-=-=-=-=-=-



--
Marco V

SUSE LINUX GmbH | GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg) Maxfeldstr. 5, D-90409, Nürnberg
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#10856): https://lists.fd.io/g/vpp-dev/message/10856
Mute This Topic: https://lists.fd.io/mt/27379050/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] bug in api for tapv2

2018-10-17 Thread Marco Varlese 
Hi Michal,

On Wed, 2018-10-17 at 11:49 +, Michal Cmarada via Lists.Fd.Io wrote:
> 
> 
> Hi VPP devs,
> 
>  
> 
> I found a bug in API for tapv2. I prepared a fix but I need someone to check
> it.
> 
> 
> gerrit patch: https://gerrit.fd.io/r/#/c/15341/
> 
Yes, your fix makes sense to me.
I am waiting for the Verified+1 to merge it.



also it will probably need a cherry-pick to stable 18.10
Yes, it will have to be cherry-picked to stable 18.10. Can you push a patch
there too?

 
Thanks
 
Michal
Cheers,
Marco

 
Michal Cmarada
Engineer - Software
mcmar...@cisco.com
Tel:
 
 
 
 
Cisco Systems, Inc.
 
 
 
Slovakia
cisco.com
Think before you print.
This email may contain confidential and privileged material for the sole use of 
the intended recipient. Any review, use, distribution
 or disclosure by others is strictly prohibited. If you are not the intended 
recipient (or authorized to receive for the recipient), please contact the 
sender by reply email and delete all copies of this message.
Please

click here for Company Registration Information.
 
 



> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> 
> View/Reply Online (#10854): https://lists.fd.io/g/vpp-dev/message/10854
> Mute This Topic: https://lists.fd.io/mt/27379050/675056
> Group Owner: vpp-dev+ow...@lists.fd.io
> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [mvarl...@suse.de]
> -=-=-=-=-=-=-=-=-=-=-=-
> 
-- 
Marco V


SUSE LINUX GmbH | GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg) Maxfeldstr. 5, D-90409, Nürnberg
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#10855): https://lists.fd.io/g/vpp-dev/message/10855
Mute This Topic: https://lists.fd.io/mt/27379050/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[vpp-dev] bug in api for tapv2

2018-10-17 Thread Michal Cmarada via Lists.Fd.Io 
Hi VPP devs,

I found a bug in API for tapv2. I prepared a fix but I need someone to check it.
gerrit patch: https://gerrit.fd.io/r/#/c/15341/

also it will probably need a cherry-pick to stable 18.10

Thanks

Michal

[https://www.cisco.com/c/dam/m/en_us/signaturetool/images/banners/standard/06_standard_graphic.png]




Michal Cmarada
Engineer - Software
mcmar...@cisco.com
Tel:










Cisco Systems, Inc.



Slovakia
cisco.com



[http://www.cisco.com/assets/swa/img/thinkbeforeyouprint.gif]

Think before you print.

This email may contain confidential and privileged material for the sole use of 
the intended recipient. Any review, use, distribution or disclosure by others 
is strictly prohibited. If you are not the intended recipient (or authorized to 
receive for the recipient), please contact the sender by reply email and delete 
all copies of this message.
Please click 
here
 for Company Registration Information.







-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#10854): https://lists.fd.io/g/vpp-dev/message/10854
Mute This Topic: https://lists.fd.io/mt/27379050/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-