Re: [vpp-dev] minor doc change
Elias & Paul, It was only my opinion to move away from gerrit. No worries if folks like to use gerrit. It does make sense to remove the github repo if the repo does not get updated frequently (daily) and also does not contain up to data info about the repo. For a side note, all U.S. university research uses github, many open-source projects do, and many companies have there open source on github. I personally prefer using github. Thanks, Hemant -Original Message- From: vpp-dev@lists.fd.io On Behalf Of Elias Rudberg Sent: Sunday, November 29, 2020 2:13 PM To: pvi...@vinciconsulting.com; hem...@mnkcg.com Cc: vpp-dev@lists.fd.io Subject: Re: [vpp-dev] minor doc change Hi Hemant, > I agree with Elias. Long term, maybe use of gerrit is deprecated and > github is used. Perhaps I should clarify that I did not mean to recommend moving VPP to github. On the contrary, I think it is good that the VPP source code is managed independently from github and I hope it will stay that way. My point was just that in the current situation when there is a github mirror, it would be good to make that more clear to avoid confusion. Another way to avoid confusion would be to remove the code from github (that would be fine as I see it but of course there will be different opinions about that). > Github is free for public repos. That depends on what you mean by "free". It could be argued that there is a cost in terms of control over the project and being able to do what you want in the future. Moving something to github means partly giving up control. Best regards, Elias smime.p7s Description: S/MIME cryptographic signature -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#18194): https://lists.fd.io/g/vpp-dev/message/18194 Mute This Topic: https://lists.fd.io/mt/78559913/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [vpp-dev] minor doc change
Hi Hemant, > I agree with Elias. Long term, maybe use of gerrit > is deprecated and github is used. Perhaps I should clarify that I did not mean to recommend moving VPP to github. On the contrary, I think it is good that the VPP source code is managed independently from github and I hope it will stay that way. My point was just that in the current situation when there is a github mirror, it would be good to make that more clear to avoid confusion. Another way to avoid confusion would be to remove the code from github (that would be fine as I see it but of course there will be different opinions about that). > Github is free for public repos. That depends on what you mean by "free". It could be argued that there is a cost in terms of control over the project and being able to do what you want in the future. Moving something to github means partly giving up control. Best regards, Elias -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#18193): https://lists.fd.io/g/vpp-dev/message/18193 Mute This Topic: https://lists.fd.io/mt/78559913/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [vpp-dev] minor doc change
Hi Hermant, I had to go back and double check the thread. Elias said we should make it clear that it was a mirror, not that the use of Gerrit should be deprecated. I don't have the keys to the vpp github account, so I can't update the message. It's a good idea, though. +1 I would not support moving from Gerrit, it provides too much value. You can always point your upstream repo on your github fork to " https://gerrit.fd.io/r/vpp; if that helps any. Paul On Sun, Nov 29, 2020 at 12:07 PM wrote: > Another issue. The github vpp repo doesn't seem to be a mirror to me or > the > mirror is not updated frequently enough. During the past months, I was > writing a new VPP plugin. The code crashed outside of my plugin. After a > day > or two, I pulled a gerrit vpp repo and using my plugin, the code didn't > crash. > I aw significant differences between the github and gerrit repos at the > time. > > I agree with Elias. Long term, maybe use of gerrit is deprecated and > github > is used. Github is free for public repos. > > Hemant > > -Original Message- > From: vpp-dev@lists.fd.io On Behalf Of Elias Rudberg > Sent: Sunday, November 29, 2020 5:14 AM > To: pvi...@vinciconsulting.com; hem...@mnkcg.com > Cc: vpp-dev@lists.fd.io > Subject: Re: [vpp-dev] minor doc change > > I think it would be good if that could be clarified on the github page. > When people search for "vpp source code" or similar, I think they will > often > end up on the github page and it's not immediately obvious from there that > it's only a mirror. (People might get the wrong idea about some things, > for > example github shows a "contributors" list which I guess is not accurate > as it > only shows authors who happen to have github accounts that are linked to > gerrit in some way?) > > The github page says, under "About" to the right, "No description, > website, or > topics provided." So there is apparently a possibility to enter a > "description", perhaps that could be used to indicate that it is just a > mirror? > > Best regards, > Elias > > -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#18192): https://lists.fd.io/g/vpp-dev/message/18192 Mute This Topic: https://lists.fd.io/mt/78559913/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [vpp-dev] minor doc change
Another issue. The github vpp repo doesn't seem to be a mirror to me or the mirror is not updated frequently enough. During the past months, I was writing a new VPP plugin. The code crashed outside of my plugin. After a day or two, I pulled a gerrit vpp repo and using my plugin, the code didn't crash. I aw significant differences between the github and gerrit repos at the time. I agree with Elias. Long term, maybe use of gerrit is deprecated and github is used. Github is free for public repos. Hemant -Original Message- From: vpp-dev@lists.fd.io On Behalf Of Elias Rudberg Sent: Sunday, November 29, 2020 5:14 AM To: pvi...@vinciconsulting.com; hem...@mnkcg.com Cc: vpp-dev@lists.fd.io Subject: Re: [vpp-dev] minor doc change I think it would be good if that could be clarified on the github page. When people search for "vpp source code" or similar, I think they will often end up on the github page and it's not immediately obvious from there that it's only a mirror. (People might get the wrong idea about some things, for example github shows a "contributors" list which I guess is not accurate as it only shows authors who happen to have github accounts that are linked to gerrit in some way?) The github page says, under "About" to the right, "No description, website, or topics provided." So there is apparently a possibility to enter a "description", perhaps that could be used to indicate that it is just a mirror? Best regards, Elias smime.p7s Description: S/MIME cryptographic signature -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#18191): https://lists.fd.io/g/vpp-dev/message/18191 Mute This Topic: https://lists.fd.io/mt/78559913/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [vpp-dev] minor doc change
On Sat, 2020-11-28 at 13:18 -0500, Paul Vinciguerra wrote: > > We don't see pull requests. Github is just a mirror of the gerrit > repo. I think it would be good if that could be clarified on the github page. When people search for "vpp source code" or similar, I think they will often end up on the github page and it's not immediately obvious from there that it's only a mirror. (People might get the wrong idea about some things, for example github shows a "contributors" list which I guess is not accurate as it only shows authors who happen to have github accounts that are linked to gerrit in some way?) The github page says, under "About" to the right, "No description, website, or topics provided." So there is apparently a possibility to enter a "description", perhaps that could be used to indicate that it is just a mirror? Best regards, Elias -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#18190): https://lists.fd.io/g/vpp-dev/message/18190 Mute This Topic: https://lists.fd.io/mt/78559913/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [vpp-dev] minor doc change
Paul, Thanks for the links. I filed a new JIRA issue: https://jira.fd.io/browse/VPP-1951 I will look into gerrit repo to make the change. Hemant From: Paul Vinciguerra Sent: Saturday, November 28, 2020 1:19 PM To: hem...@mnkcg.com Cc: vpp-dev Subject: Re: [vpp-dev] minor doc change Hi Hermant, We don't see pull requests. Github is just a mirror of the gerrit repo. You can submit your change to the gerrit repo. See: [0] Bugs can be filed at [1] Paul [0] https://wiki.fd.io/view/VPP/Pulling,_Building,_Running,_Hacking_and_Pushing_VPP_Code#Pushing [1] https://jira.fd.io/projects/VPP/issues On Sat, Nov 28, 2020 at 12:58 PM mailto:hem...@mnkcg.com> > wrote: Paul, For all my work I use github. I used VPP github repo to make the doc change in a PR. See https://github.com/FDio/vpp/pull/32 If anyone can send me a link where bugs are filed against VPP gerrit repo, I can use the link to file issues. I haven’t used gerrit before but in future I can try and use it. Thanks, Hemant From: Paul Vinciguerra mailto:pvi...@vinciconsulting.com> > Sent: Friday, November 27, 2020 10:47 PM To: hem...@mnkcg.com <mailto:hem...@mnkcg.com> Cc: vpp-dev mailto:vpp-dev@lists.fd.io> > Subject: Re: [vpp-dev] minor doc change Hi Hermant. The document is in the sources here: docs/gettingstarted/developers/infrastructure.md The best way to get the docs updated is to submit a change. Paul On Fri, Nov 27, 2020 at 8:37 PM hemant via lists.fd.io <http://lists.fd.io> mailto:mnkcg@lists.fd.io> > wrote: At this link: https://my-vpp-docs.readthedocs.io/en/latest/gettingstarted/developers/infrastructure.html unformat_init_string() used two args but the latest VPP code uses three args. We should change the doc. Thanks, Hemant smime.p7s Description: S/MIME cryptographic signature -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#18187): https://lists.fd.io/g/vpp-dev/message/18187 Mute This Topic: https://lists.fd.io/mt/78559913/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [vpp-dev] minor doc change
Hi Hermant, We don't see pull requests. Github is just a mirror of the gerrit repo. You can submit your change to the gerrit repo. See: [0] Bugs can be filed at [1] Paul [0] https://wiki.fd.io/view/VPP/Pulling,_Building,_Running,_Hacking_and_Pushing_VPP_Code#Pushing [1] https://jira.fd.io/projects/VPP/issues On Sat, Nov 28, 2020 at 12:58 PM wrote: > Paul, > > > > For all my work I use github. I used VPP github repo to make the doc > change in a PR. See > > > > https://github.com/FDio/vpp/pull/32 > > > > If anyone can send me a link where bugs are filed against VPP gerrit repo, > I can use the link to file issues. I haven’t used gerrit before but in > future I can try and use it. > > > > Thanks, > > > > Hemant > > > > *From:* Paul Vinciguerra > *Sent:* Friday, November 27, 2020 10:47 PM > *To:* hem...@mnkcg.com > *Cc:* vpp-dev > *Subject:* Re: [vpp-dev] minor doc change > > > > Hi Hermant. > > > > The document is in the sources here: > > docs/gettingstarted/developers/infrastructure.md > > > > The best way to get the docs updated is to submit a change. > > > > Paul > > > > On Fri, Nov 27, 2020 at 8:37 PM hemant via lists.fd.io mnkcg@lists.fd.io> wrote: > > At this link: > > > > > https://my-vpp-docs.readthedocs.io/en/latest/gettingstarted/developers/infrastructure.html > > > > unformat_init_string() used two args but the latest VPP code uses three > args. We should change the doc. > > > > Thanks, > > > > Hemant > > > > > -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#18186): https://lists.fd.io/g/vpp-dev/message/18186 Mute This Topic: https://lists.fd.io/mt/78559913/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [vpp-dev] minor doc change
Paul, For all my work I use github. I used VPP github repo to make the doc change in a PR. See https://github.com/FDio/vpp/pull/32 If anyone can send me a link where bugs are filed against VPP gerrit repo, I can use the link to file issues. I haven’t used gerrit before but in future I can try and use it. Thanks, Hemant From: Paul Vinciguerra Sent: Friday, November 27, 2020 10:47 PM To: hem...@mnkcg.com Cc: vpp-dev Subject: Re: [vpp-dev] minor doc change Hi Hermant. The document is in the sources here: docs/gettingstarted/developers/infrastructure.md The best way to get the docs updated is to submit a change. Paul On Fri, Nov 27, 2020 at 8:37 PM hemant via lists.fd.io <http://lists.fd.io> mailto:mnkcg@lists.fd.io> > wrote: At this link: https://my-vpp-docs.readthedocs.io/en/latest/gettingstarted/developers/infrastructure.html unformat_init_string() used two args but the latest VPP code uses three args. We should change the doc. Thanks, Hemant smime.p7s Description: S/MIME cryptographic signature -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#18185): https://lists.fd.io/g/vpp-dev/message/18185 Mute This Topic: https://lists.fd.io/mt/78559913/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [vpp-dev] minor doc change
Hi Hermant. The document is in the sources here: docs/gettingstarted/developers/infrastructure.md The best way to get the docs updated is to submit a change. Paul On Fri, Nov 27, 2020 at 8:37 PM hemant via lists.fd.io wrote: > At this link: > > > > > https://my-vpp-docs.readthedocs.io/en/latest/gettingstarted/developers/infrastructure.html > > > > unformat_init_string() used two args but the latest VPP code uses three > args. We should change the doc. > > > > Thanks, > > > > Hemant > > > > -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#18184): https://lists.fd.io/g/vpp-dev/message/18184 Mute This Topic: https://lists.fd.io/mt/78559913/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[vpp-dev] minor doc change
At this link: https://my-vpp-docs.readthedocs.io/en/latest/gettingstarted/developers/infra structure.html unformat_init_string() used two args but the latest VPP code uses three args. We should change the doc. Thanks, Hemant smime.p7s Description: S/MIME cryptographic signature -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#18183): https://lists.fd.io/g/vpp-dev/message/18183 Mute This Topic: https://lists.fd.io/mt/78559913/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
