Re: [vpp-dev] Any tricks in IP reassembly ?

2018-12-13 Thread pvinci
Can you provide the code?  Personally, I would be interested in seeing your approach. -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#11594): https://lists.fd.io/g/vpp-dev/message/11594 Mute This Topic: https://lists.fd.io/mt/28718629/21656 Group

Re: [vpp-dev] Any tricks in IP reassembly ?

2018-12-13 Thread Klement Sekera via Lists.Fd.Io
The test framework spawns vpp with only one main thread and no workers. I had a patch which uses also worker threads but it never made it to git. It's grossly outdated by now. Anyhow, I don't think that's really possible with the current packet geneator implementation. Quoting

Re: [vpp-dev] Any tricks in IP reassembly ?

2018-12-12 Thread Ole Troan
should do that. Cheers, Ole > > mik...@yeah.net > > From: Klement Sekera > Date: 2018-12-11 20:39 > To: Mikado; vpp-dev > Subject: Re: [vpp-dev] Any tricks in IP reassembly ? > Hi Mikado, > > if the fragments get split between multiple workers, then eventually

Re: [vpp-dev] Any tricks in IP reassembly ?

2018-12-12 Thread pvinci
Hi Klement. Is there a way to write a test case that documents that behavior?  Does the test framework have the ability to split fragments across threads? -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#11583):

Re: [vpp-dev] Any tricks in IP reassembly ?

2018-12-12 Thread mik...@yeah.net
W...What??? So the only way to make ip reassembly working correctly is to keep one or more interfaces attached to a single worker thread? That does not sound efficient .. mik...@yeah.net From: Klement Sekera Date: 2018-12-11 20:39 To: Mikado; vpp-dev Subject: Re: [vpp-dev] Any tricks

Re: [vpp-dev] Any tricks in IP reassembly ?

2018-12-12 Thread Klement Sekera via Lists.Fd.Io
efficient .. > >-- > >mik...@yeah.net > >   > From: [1]Klement Sekera > Date: 2018-12-11 20:39 > To: [2]Mikado; [3]vpp-dev > Subject: Re: [vpp-dev] Any tri

Re: [vpp-dev] Any tricks in IP reassembly ?

2018-12-11 Thread Klement Sekera via Lists.Fd.Io
Hi Mikado, if the fragments get split between multiple workers, then eventually they'll get dropped after timing out ... Regards, Klement Quoting Mikado (2018-12-11 08:52:28) >Hi, > >   I have noticed that  “ip4-reassembly-feature” node  only >reassembles packets stored in the

[vpp-dev] Any tricks in IP reassembly ?

2018-12-11 Thread Mikado
Hi, I have noticed that “ip4-reassembly-feature” node only reassembles packets stored in the local pool of each thread. But it seems not right if a group of fragment packages is handled by different worker thread. So is there any tricks in VPP forcing the fragment packages in the