Re: [vpp-dev] Any tricks in IP reassembly ?
Can you provide the code? Personally, I would be interested in seeing your approach. -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#11594): https://lists.fd.io/g/vpp-dev/message/11594 Mute This Topic: https://lists.fd.io/mt/28718629/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [vpp-dev] Any tricks in IP reassembly ?
The test framework spawns vpp with only one main thread and no workers. I had a patch which uses also worker threads but it never made it to git. It's grossly outdated by now. Anyhow, I don't think that's really possible with the current packet geneator implementation. Quoting pvi...@vinciconsulting.com (2018-12-12 18:50:11) >Hi Klement. > >Is there a way to write a test case that documents that behavior? Does >the test framework have the ability to split fragments across threads? -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#11592): https://lists.fd.io/g/vpp-dev/message/11592 Mute This Topic: https://lists.fd.io/mt/28718629/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [vpp-dev] Any tricks in IP reassembly ?
> W...What??? So the only way to make ip reassembly working correctly is to > keep one or more interfaces attached to a single worker thread? > That does not sound efficient …… Or just ensure all parts of a fragment chain gets delivered to the same worker. Any good ECMP algorithm should do that. Cheers, Ole > > mik...@yeah.net > > From: Klement Sekera > Date: 2018-12-11 20:39 > To: Mikado; vpp-dev > Subject: Re: [vpp-dev] Any tricks in IP reassembly ? > Hi Mikado, > > if the fragments get split between multiple workers, then eventually > they'll get dropped after timing out ... > > Regards, > Klement > > Quoting Mikado (2018-12-11 08:52:28) > >Hi, > > > > I have noticed that “ip4-reassembly-feature” node only > >reassembles packets stored in the local pool of each thread. But it seems > >not right if a group of fragment packages is handled by different worker > >thread. So is there any tricks in VPP forcing the fragment packages in > >the same group dispatched to the same thread ? Or is it a bug ? > > > > > >Thanks in advance. > > > >Mikado > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > > View/Reply Online (#11581): https://lists.fd.io/g/vpp-dev/message/11581 > Mute This Topic: https://lists.fd.io/mt/28718629/675193 > Group Owner: vpp-dev+ow...@lists.fd.io > Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [otr...@employees.org] > -=-=-=-=-=-=-=-=-=-=-=- -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#11584): https://lists.fd.io/g/vpp-dev/message/11584 Mute This Topic: https://lists.fd.io/mt/28718629/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [vpp-dev] Any tricks in IP reassembly ?
Hi Klement. Is there a way to write a test case that documents that behavior? Does the test framework have the ability to split fragments across threads? -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#11583): https://lists.fd.io/g/vpp-dev/message/11583 Mute This Topic: https://lists.fd.io/mt/28718629/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [vpp-dev] Any tricks in IP reassembly ?
W...What??? So the only way to make ip reassembly working correctly is to keep one or more interfaces attached to a single worker thread? That does not sound efficient .. mik...@yeah.net From: Klement Sekera Date: 2018-12-11 20:39 To: Mikado; vpp-dev Subject: Re: [vpp-dev] Any tricks in IP reassembly ? Hi Mikado, if the fragments get split between multiple workers, then eventually they'll get dropped after timing out ... Regards, Klement Quoting Mikado (2018-12-11 08:52:28) >Hi, > > I have noticed that “ip4-reassembly-feature” node only >reassembles packets stored in the local pool of each thread. But it seems >not right if a group of fragment packages is handled by different worker >thread. So is there any tricks in VPP forcing the fragment packages in >the same group dispatched to the same thread ? Or is it a bug ? > > >Thanks in advance. > >Mikado -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#11581): https://lists.fd.io/g/vpp-dev/message/11581 Mute This Topic: https://lists.fd.io/mt/28718629/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [vpp-dev] Any tricks in IP reassembly ?
That's as it is now. A rework of the code is planned, no ETA yet... Quoting mik...@yeah.net (2018-12-12 02:05:40) >W...What??? So the only way to make ip reassembly working correctly is to >keep one or more interfaces attached to a single worker thread? >That does not sound efficient .. > >-- > >mik...@yeah.net > > > From: [1]Klement Sekera > Date: 2018-12-11 20:39 > To: [2]Mikado; [3]vpp-dev > Subject: Re: [vpp-dev] Any tricks in IP reassembly ? > Hi Mikado, > > if the fragments get split between multiple workers, then eventually > they'll get dropped after timing out ... > > Regards, > Klement > > Quoting Mikado (2018-12-11 08:52:28) > > Hi, > > > > I have noticed that “ip4-reassembly-feature” node only > > reassembles packets stored in the local pool of each thread. But it > seems > > not right if a group of fragment packages is handled by different > worker > > thread. So is there any tricks in VPP forcing the fragment > packages in > > the same group dispatched to the same thread ? Or is it a bug ? > > > > > > Thanks in advance. > > > > Mikado > > References > >Visible links >1. mailto:ksek...@cisco.com >2. mailto:mik...@yeah.net >3. mailto:vpp-dev@lists.fd.io -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#11576): https://lists.fd.io/g/vpp-dev/message/11576 Mute This Topic: https://lists.fd.io/mt/28718629/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [vpp-dev] Any tricks in IP reassembly ?
Hi Mikado, if the fragments get split between multiple workers, then eventually they'll get dropped after timing out ... Regards, Klement Quoting Mikado (2018-12-11 08:52:28) >Hi, > > I have noticed that “ip4-reassembly-feature” node only >reassembles packets stored in the local pool of each thread. But it seems >not right if a group of fragment packages is handled by different worker >thread. So is there any tricks in VPP forcing the fragment packages in >the same group dispatched to the same thread ? Or is it a bug ? > > >Thanks in advance. > >Mikado -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#11560): https://lists.fd.io/g/vpp-dev/message/11560 Mute This Topic: https://lists.fd.io/mt/28718629/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[vpp-dev] Any tricks in IP reassembly ?
Hi, I have noticed that “ip4-reassembly-feature” node only reassembles packets stored in the local pool of each thread. But it seems not right if a group of fragment packages is handled by different worker thread. So is there any tricks in VPP forcing the fragment packages in the same group dispatched to the same thread ? Or is it a bug ? Thanks in advance. Mikado-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#11559): https://lists.fd.io/g/vpp-dev/message/11559 Mute This Topic: https://lists.fd.io/mt/28718629/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
