Re: [vpp-dev] vpp checkstyle failures

2020-09-16 Thread Sergey Matov
I've just wanted to avoid the trick of fetching the counter's value and calling "set" with (value - 1). Extra decrementing method would not be harmful and can be used only when it's desired. On Tue, 15 Sep 2020 at 16:02, wrote: > Hi Sergey, > > > In a nutshell - yes, gauges are something I am

Re: [vpp-dev] vpp checkstyle failures

2020-09-15 Thread Ole Troan
Hi Sergey, > In a nutshell - yes, gauges are something I am also currently using to track > the number of entries in a bihash table(for example), however gauge update > will be done each time when the stats segment performs processing. Idea was > to track value more rapidly w/o increasing

Re: [vpp-dev] vpp checkstyle failures

2020-09-15 Thread Andrew Yourtchenko
Hi Sergey, The rationale behind this makes sense to me, though I still think it should be still a distinct new entity rather than “extending” the semantics of the existing one. We had about a year worth of rather disruptive injecting types in API so the users can distinguish a u32 IPv4

Re: [vpp-dev] vpp checkstyle failures

2020-09-15 Thread Sergey Matov
Hello Andrew. Thanks for quick response. In a nutshell - yes, gauges are something I am also currently using to track the number of entries in a bihash table(for example), however gauge update will be done each time when the stats segment performs processing. Idea was to track value more rapidly

Re: [vpp-dev] vpp checkstyle failures

2020-09-15 Thread Andrew Yourtchenko
Hi Sergey, have a look at 22963; the checkstyle job requires a particular version of checkstyle, it’s WIP in progress to update it, as well as to give us an option to selectively try out clang-format on some files. However; I think this functionality of this patch has more fundamental

[vpp-dev] vpp checkstyle failures

2020-09-15 Thread Sergey Matov
Greetings VPP community. Recently I've created a small patch for counter.h core file. For some reason several patchsets are failing with checkstyle issues. https://gerrit.fd.io/r/c/vpp/+/28843 Fixing of the change by indent causes the entire file to be reworked since the old file does not fit