WOOT !!
-Maciek
On 24 Oct 2016, at 22:01, Edward Warnicke
mailto:hagb...@gmail.com>> wrote:
3517 has been merged.
With Keith Wiles help, we've used:
https://gerrit.fd.io/r/#/c/3552/
To confirm that:
a) A Change Owner -2ed patch cannot be merged, even by a committer.
b) A new PatchSet does
3517 has been merged.
With Keith Wiles help, we've used:
https://gerrit.fd.io/r/#/c/3552/
To confirm that:
a) A Change Owner -2ed patch cannot be merged, even by a committer.
b) A new PatchSet does not clear the -2
Both of these are the expected behaviors, but its now been tested and
confirm
Keith,
If you could weigh in on the patch in gerrit:
https://gerrit.fd.io/r/#/c/3517/
Ed
On Sat, Oct 22, 2016 at 8:08 AM, Keith Burns wrote:
> Works for me.
>
>
> On Wed, Oct 19, 2016, 5:11 AM Damjan Marion (damarion)
> wrote:
>
>>
>> I think simply allowing “Change Owner” to do -2 on his ow
Works for me.
On Wed, Oct 19, 2016, 5:11 AM Damjan Marion (damarion)
wrote:
>
> I think simply allowing “Change Owner” to do -2 on his own change should
> address all issues here as only person who put -2 can remove it.
>
> (you remember that i had to ping you to remove -2 on one change as I was
OK... as a matter of personal opinion, I still favor simply making Drafts
public... that said, I do hear the sentiment in other directions, and the
useful pointer from Damjan about 'Change Owner'.
So... I've opened a gerrit:
https://gerrit.fd.io/r/#/c/3517/
Which would allow Change Owner (ie, th
+1
On 10/19/16 8:11 AM, Damjan Marion (damarion) wrote:
I think simply allowing “Change Owner” to do -2 on his own change
should address all issues here as only person who put -2 can remove it.
(you remember that i had to ping you to remove -2 on one change as I
was not able to merge it…)
6 20:33
To: Edward Warnicke mailto:hagb...@gmail.com>>; Maciek
Konstantynowicz (mkonstan) mailto:mkons...@cisco.com>>
Cc: csit-...@lists.fd.io<mailto:csit-...@lists.fd.io>; Damjan Marion (damarion)
mailto:damar...@cisco.com>>; vpp-dev
mailto:vpp-dev@lists.fd.io>>
Sub
+1
-Maciek
On 19 Oct 2016, at 13:11, Damjan Marion (damarion)
mailto:damar...@cisco.com>> wrote:
I think simply allowing “Change Owner” to do -2 on his own change should
address all issues here as only person who put -2 can remove it.
(you remember that i had to ping you to remove -2 on one
rnicke mailto:hagb...@gmail.com>>; Maciek
Konstantynowicz (mkonstan) mailto:mkons...@cisco.com>>
Cc: csit-...@lists.fd.io<mailto:csit-...@lists.fd.io>; Damjan Marion (damarion)
mailto:damar...@cisco.com>>; vpp-dev
mailto:vpp-dev@lists.fd.io>>
Subject: Re: [vpp-dev] [csit
I think simply allowing “Change Owner” to do -2 on his own change should
address all issues here as only person who put -2 can remove it.
(you remember that i had to ping you to remove -2 on one change as I was not
able to merge it…)
On 18 Oct 2016, at 20:32, Keith Burns
mailto:alaga...@gmail
Cc: csit-...@lists.fd.io<mailto:csit-...@lists.fd.io>; Damjan Marion (damarion)
mailto:damar...@cisco.com>>; vpp-dev
mailto:vpp-dev@lists.fd.io>>
Subject: Re: [vpp-dev] [csit-dev] DO_NOT_MERGE
But if the contributor -1 it then I'm ok putting -2 on it as a lock if I'
: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On
Behalf Of Keith Burns
Sent: 18. októbra 2016 20:33
To: Edward Warnicke ; Maciek Konstantynowicz (mkonstan)
Cc: csit-...@lists.fd.io; Damjan Marion (damarion) ;
vpp-dev
Subject: Re: [vpp-dev] [csit-dev] DO_NOT_MERGE
But if the
But if the contributor -1 it then I'm ok putting -2 on it as a lock if I'm
a committer on that project.
You can make drafts public but all that will do is force folks who like
that feature (private draft) to go to github where we don't get our
CSIT/verify jobs.
(Drafts are an easy way to check fo
I'm fine with -2, except for the problem that a contributor who is not a
committer cannot -2 their patch (only committers have -2 or +2).
Ed
On Tue, Oct 18, 2016 at 11:11 AM, Maciek Konstantynowicz (mkonstan) <
mkons...@cisco.com> wrote:
> +csit-dev
>
> And I asked for this merge :(
> Agree that
14 matches
Mail list logo
