Re: [W3af-develop] rewritten-urls branch

2011-12-27 Thread Andres Riancho
Taras, Merged into trunk and removed branch! :) Thank you so much for the great improvement! Regards, On Tue, Dec 27, 2011 at 5:33 AM, Taras wrote: > Andres, > > I have replaced direct setting of _mutant_dc with call of setMutantDc() for > mutantFileName and mutantUrlParts. Tests are also f

Re: [W3af-develop] rewritten-urls branch

2011-12-27 Thread Taras
Andres, I have replaced direct setting of _mutant_dc with call of setMutantDc() for mutantFileName and mutantUrlParts. Tests are also fixed. 26.12.2011 19:45, Andres Riancho пишет: > Let me know when that's done so I can merge, we can close the branch and > start with something else :) > El dic

Re: [W3af-develop] rewritten-urls branch

2011-12-26 Thread Andres Riancho
Let me know when that's done so I can merge, we can close the branch and start with something else :) El dic 26, 2011 11:56 a.m., "Taras" escribió: > Andres, > > On Fri, Dec 23, 2011 at 7:19 AM, Taras wrote: >> >>> Andres, >>> >>> currently only this comment is unresolved: >>> #APR: I woul

Re: [W3af-develop] rewritten-urls branch

2011-12-26 Thread Taras
Andres, > On Fri, Dec 23, 2011 at 7:19 AM, Taras wrote: >> Andres, >> >> currently only this comment is unresolved: >>> #APR: I would like to see more doctests that represent the real use >>> of this class. By that I mean that we should use >>> setModValue() in the doctest instead of "m._mutant_d

Re: [W3af-develop] rewritten-urls branch

2011-12-26 Thread Andres Riancho
Taras, On Fri, Dec 23, 2011 at 7:19 AM, Taras wrote: > Andres, > > currently only this comment is unresolved: >> #APR: I would like to see more doctests that represent the real use >> of this class. By that I mean that we should use >> setModValue() in the doctest instead of "m._mutant_dc = >> di

Re: [W3af-develop] rewritten-urls branch

2011-12-26 Thread Taras
Andres, ping :) > currently only this comment is unresolved: > > #APR: I would like to see more doctests that represent the real use > > of this class. By that I mean that we should use > > setModValue() in the doctest instead of "m._mutant_dc = > > divided_path". The ideal would be t

Re: [W3af-develop] rewritten-urls branch

2011-12-23 Thread Taras
Andres, currently only this comment is unresolved: > #APR: I would like to see more doctests that represent the real use > of this class. By that I mean that we should use > setModValue() in the doctest instead of "m._mutant_dc = > divided_path". The ideal would be to use it just like in fuzze

Re: [W3af-develop] rewritten-urls branch

2011-12-23 Thread Taras
Andres, >>> #APR: Do we use this? How? >>> +def dynamicURL( self ): >>> +''' >>> + >> Strange method and it is only found in base mutant class and mutantFileName. >> Let's remove it from these places? > > Let's remove it! I think we don't use it anywhere! Fixed! >>> #APR: Do we want t

Re: [W3af-develop] rewritten-urls branch

2011-12-23 Thread Achim Hoffmann
Am 23.12.2011 02:16, schrieb Andres Riancho: > Taras, > > On Wed, Dec 21, 2011 at 6:07 AM, Taras wrote: >>> #APR: Do we want to call _createUrlPartsMutants for all freq? Does it make >>> sense to fuzz the URL when >>> there are query string parameters? Hmmm... we should think about this. >> >>

Re: [W3af-develop] rewritten-urls branch

2011-12-22 Thread Andres Riancho
Taras, On Wed, Dec 21, 2011 at 6:07 AM, Taras wrote: > Andres, > > >>     I was reading through the whole rewritten-urls branch patch before >> I merged into the trunk and realized that there are still a couple of >> pending things and questions and we need to think about. Please read >> the line

Re: [W3af-develop] rewritten-urls branch

2011-12-21 Thread Taras
Andres, > I was reading through the whole rewritten-urls branch patch before > I merged into the trunk and realized that there are still a couple of > pending things and questions and we need to think about. Please read > the lines that start with "#APR" in the attached patch file. Thanks > a