Re: [waffle] [PATCH v2 2/4] waffle: add support for building Waffle using NaCl toolchain

2014-12-29 Thread Emil Velikov
On 29/12/14 07:47, Tapani Pälli wrote: > > > On 12/21/2014 03:53 PM, Emil Velikov wrote: >> On 17 December 2014 at 10:17, Tapani Pälli >> wrote: >>> Patch adds changes required to use NaCl compiler and libraries to >>> build Waffle. Build can be configured to use specific version of >>> the NaCl

Re: [waffle] [PATCH v2 2/4] waffle: add support for building Waffle using NaCl toolchain

2014-12-29 Thread Emil Velikov
On 22/12/14 22:28, Chad Versace wrote: > On 12/21/2014 07:53 AM, Emil Velikov wrote: >> On 17 December 2014 at 10:17, Tapani Pälli wrote: >>> Patch adds changes required to use NaCl compiler and libraries to >>> build Waffle. Build can be configured to use specific version of >>> the NaCl SDK, too

Re: [waffle] [PATCH 3/3] wgl: Verify the client area size matches the required size on window creation too.

2014-12-29 Thread Emil Velikov
On 29/12/14 16:22, Jose Fonseca wrote: > From: José Fonseca > > By default, Windows will limit windows too large to theu desktop size, > and windows too small to be big enough for the titlebar. Waffle's > windows don't get affected as their style is WS_POPUPWINDOW, which > doesn't include the WS

Re: [waffle] [PATCH 07/11] core: Add func wcore_attrib_list_copy()

2014-12-29 Thread Emil Velikov
On 23/12/14 01:02, Chad Versace wrote: > On 12/21/2014 09:00 AM, Emil Velikov wrote: >> On 16 December 2014 at 08:18, Chad Versace >> wrote: >>> This is useful for making a writable copy of a read-only attribute list. >>> >>> Signed-off-by: Chad Versace >>> --- >>> src/waffle/core/wcore_attrib_

Re: [waffle] [PATCH 00/11] Add new public func waffle_window_create2()

2014-12-29 Thread Emil Velikov
On 23/12/14 01:11, Chad Versace wrote: > On 12/21/2014 01:41 PM, Emil Velikov wrote: >> On 16 December 2014 at 08:18, Chad Versace >> wrote: >>> Today, waffle_window() has only two parameters: width and height. >>> >>> Frank Henigman wants to extend Waffle's GBM backend with the ability to >>> po

Re: [waffle] [PATCH 3/4] cmake: Add the installed package files to the registry on windows

2014-12-29 Thread Dylan Baker
On Monday, December 29, 2014 05:33:43 PM Jose Fonseca wrote: > On 29/12/14 17:07, Dylan Baker wrote: > > On Monday, December 29, 2014 11:35:20 AM Jose Fonseca wrote: > >> On 22/12/14 22:36, Dylan Baker wrote: > >>> This adds the locations of the package files to the registry on windows, > >>> which

[waffle] [Patch v3 3/3] cmake: remove FindWaffle.cmake

2014-12-29 Thread Dylan Baker
This is superseded by the WaffleConfig and WaffleConfigVersion cmake files. Signed-off-by: Dylan Baker Reviewed-by: Jordan Justen --- CMakeLists.txt | 10 ++ cmake/Modules/FindWaffle.cmake | 78 -- 2 files changed, 2 insertions(+), 86

[waffle] [Patch v3 1/3] cmake: fix version search

2014-12-29 Thread Dylan Baker
Currently the cmake file uses both WAFFLE_INCLUDE_DIR and WAFFLE_INCLUDE_DIRS, but only the DIRS version is actually defined. cmake doesn't complain about the undefined variable, instead it treats it as a blank string. This leads to the version never being checked. This patch replaces DIR with DIR

[waffle] Use cmake config files instead of find

2014-12-29 Thread Dylan Baker
This is the 3rd, and hopefully final, iteration of these patches. Changes from version 2: - rearrange the new code to be with the pkgconfig code in the cmake file - use CMAKE_BINARY_DIR - Drop patch 3 (use windows registry) I have tested this on linux with ninja and make backends with both in t

[waffle] [Patch v3 2/3] cmake: Add cmake PackageConfig files

2014-12-29 Thread Dylan Baker
This creates and installs a package version file and a package config file. These are used by find_package with the CONFIG option, and are roughly equivalent to pkgconfig, but is cmake specific rather than linux specific. v2: - Use configure_package_config_file() instead of config_file(), wh

Re: [waffle] [PATCH 3/4] cmake: Add the installed package files to the registry on windows

2014-12-29 Thread Jose Fonseca
On 29/12/14 17:07, Dylan Baker wrote: On Monday, December 29, 2014 11:35:20 AM Jose Fonseca wrote: On 22/12/14 22:36, Dylan Baker wrote: This adds the locations of the package files to the registry on windows, which should allow them to be auto detected by cmake on windows when linking against

Re: [waffle] [PATCH 3/4] cmake: Add the installed package files to the registry on windows

2014-12-29 Thread Dylan Baker
On Monday, December 29, 2014 11:35:20 AM Jose Fonseca wrote: > On 22/12/14 22:36, Dylan Baker wrote: > > This adds the locations of the package files to the registry on windows, > > which should allow them to be auto detected by cmake on windows when > > linking against waffle in other projects. >

[waffle] [PATCH 2/3] examples/gl_basic: Add option for window size.

2014-12-29 Thread Jose Fonseca
From: José Fonseca Useful to test huge/tiny windows. --- examples/gl_basic.c | 22 +- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/examples/gl_basic.c b/examples/gl_basic.c index fb62d52..69418c8 100644 --- a/examples/gl_basic.c +++ b/examples/gl_basic.c @@

[waffle] [PATCH 1/3] test/gl_basic_test: Address gcc format mismatch warning.

2014-12-29 Thread Jose Fonseca
From: José Fonseca --- tests/functional/gl_basic_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/functional/gl_basic_test.c b/tests/functional/gl_basic_test.c index 03692e0..0e932e3 100644 --- a/tests/functional/gl_basic_test.c +++ b/tests/functional/gl_basic_tes

[waffle] [PATCH 3/3] wgl: Verify the client area size matches the required size on window creation too.

2014-12-29 Thread Jose Fonseca
From: José Fonseca By default, Windows will limit windows too large to theu desktop size, and windows too small to be big enough for the titlebar. Waffle's windows don't get affected as their style is WS_POPUPWINDOW, which doesn't include the WS_CAPTION style. This change adds more assertion, j

Re: [waffle] [PATCH] wgl: Fix requirements for creation of ES2 context

2014-12-29 Thread Jose Fonseca
Sorry for the delay. I flagged this email, but then forgot about it, to only find it again now. Patch looks good and builds fine. Reviewed-by: Jose Fonseca Jose On 06/12/14 00:52, Chad Versace wrote: To create an ES2 context, Waffle required WGL_EXT_create_context_es2_profile. Fix Waffle t

Re: [waffle] [PATCH 3/4] cmake: Add the installed package files to the registry on windows

2014-12-29 Thread Jose Fonseca
On 22/12/14 22:36, Dylan Baker wrote: This adds the locations of the package files to the registry on windows, which should allow them to be auto detected by cmake on windows when linking against waffle in other projects. Signed-off-by: Dylan Baker --- This patch is completely untested (I don'

Re: [waffle] [PATCH v2 2/4] waffle: add support for building Waffle using NaCl toolchain

2014-12-29 Thread Tapani Pälli
On 12/29/2014 09:28 AM, Tapani Pälli wrote: On 12/23/2014 02:06 AM, Chad Versace wrote: On 12/17/2014 04:17 AM, Tapani Pälli wrote: Patch adds changes required to use NaCl compiler and libraries to build Waffle. Build can be configured to use specific version of the NaCl SDK, toolchain for t

Re: [waffle] [PATCH] waffle: make gl_basic to work with nacl

2014-12-29 Thread Tapani Pälli
On 12/23/2014 04:25 AM, Chad Versace wrote: On 12/21/2014 08:06 AM, Emil Velikov wrote: On 17 December 2014 at 13:12, Tapani Pälli wrote: Signed-off-by: Tapani Pälli --- .gitignore | 2 ++ examples/CMakeLists.txt | 30 ++ examples/gl_basic.c