Re: [waffle] [PULL] Remove libgbm/libGL linktime dependency

2014-11-12 Thread Chad Versace
On Thu 13 Nov 2014, Emil Velikov wrote: On 12/11/14 06:07, Chad Versace wrote: Emil, please collect my reviewed-bys onto your branch and look over the changes in my v2 of patch 4. If all looks good to you, let me know and I'll merge branch. Hi Chad, As mentioned, here is the annotated (plus

Re: [waffle] [RFC] wflinfo.c: add GLSL version information

2014-11-12 Thread Dylan Baker
On Wednesday, November 12, 2014 05:07:39 PM Jordan Justen wrote: > On 2014-11-12 16:20:59, Dylan Baker wrote: > > Signed-off-by: Dylan Baker > > --- > > > > This returns an error on GLES 1.x, which is expected. Should we do > > something to handle that differently or just return the > > WFLINFO_G

Re: [waffle] [RFC] wflinfo.c: add GLSL version information

2014-11-12 Thread Jordan Justen
On 2014-11-12 16:20:59, Dylan Baker wrote: > Signed-off-by: Dylan Baker > --- > > This returns an error on GLES 1.x, which is expected. Should we do > something to handle that differently or just return the > WFLINFO_GL_ERROR? We should avoid querying this value and attempting to print it if we

[waffle] [RFC] wflinfo.c: add GLSL version information

2014-11-12 Thread Dylan Baker
Signed-off-by: Dylan Baker --- This returns an error on GLES 1.x, which is expected. Should we do something to handle that differently or just return the WFLINFO_GL_ERROR? src/utils/wflinfo.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/utils/wflinfo.c b/src/utils/wflinfo.c ind

[waffle] [PULL] Remove libgbm/libGL linktime dependency

2014-11-12 Thread Emil Velikov
On 12/11/14 06:07, Chad Versace wrote: > Emil, please collect my reviewed-bys onto your branch and look over the > changes in my v2 of patch 4. If all looks good to you, let me know and > I'll merge branch. > Hi Chad, As mentioned, here is the annotated (plus patch 4 v2) of the series which remo

Re: [waffle] [PATCH] gbm: drop explicit linking against libgbm.so (v2)

2014-11-12 Thread Emil Velikov
On 12/11/14 20:43, Emil Velikov wrote: > On 12/11/14 06:03, Chad Versace wrote: >> From: Emil Velikov >> >> Use the function pointers stored in wgbm_platform, to communicate >> with the library. >> >> Signed-off-by: Emil Velikov >> Signed-off-by: Chad Versace >> --- >> >> v2(chadv): Fix numerous

Re: [waffle] [PATCH] gbm: drop explicit linking against libgbm.so (v2)

2014-11-12 Thread Emil Velikov
On 12/11/14 06:03, Chad Versace wrote: > From: Emil Velikov > > Use the function pointers stored in wgbm_platform, to communicate > with the library. > > Signed-off-by: Emil Velikov > Signed-off-by: Chad Versace > --- > > v2(chadv): Fix numerous upcast errors of form: > > src/waffle/gbm/

Re: [waffle] [PULL] WGL support

2014-11-12 Thread Chad Versace
On Wed 12 Nov 2014, Jose Fonseca wrote: Hi Emil, I went through the new patches and they look good AFAICT. Thanks for doing this. While going through "wgl: fully support ARB_create_context and EXT_create_context_es_profile." again I noticed a couple of issues with the usage of WGL_EXT_cr

Re: [waffle] [PULL] WGL support

2014-11-12 Thread Jose Fonseca
Hi Emil, I went through the new patches and they look good AFAICT. Thanks for doing this. While going through "wgl: fully support ARB_create_context and EXT_create_context_es_profile." again I noticed a couple of issues with the usage of WGL_EXT_create_context_es2_profile that I hadn't not