On Wed 22 Apr 2015, Frank Henigman wrote:
> Use the new WAFFLE_ENUM_LIST macro to implement waffle_enum_to_string()
> instead of specifying all the enums again.
> Now it will no longer be necessary to update waffle_enum_to_string()
> when adding an enum.
> Use bsearch() instead of a case statement,
On Thu 23 Apr 2015, Emil Velikov wrote:
> On 22 April 2015 at 19:03, Frank Henigman wrote:
> > Use the new WAFFLE_ENUM_LIST macro to implement waffle_enum_to_string()
> > instead of specifying all the enums again.
> > Now it will no longer be necessary to update waffle_enum_to_string()
> > when ad
On Thu 23 Apr 2015, Emil Velikov wrote:
> On 23 April 2015 at 02:07, Frank Henigman wrote:
> > On Wed, Apr 22, 2015 at 8:09 PM, Jordan Justen
> > wrote:
> >> On 2015-04-22 11:03:47, Frank Henigman wrote:
> >>> List all waffle_enum items in a big #define to avoid duplicating
> >>> the list when a
This exercises Frank's recent patch that added
the WAFFLE_WINDOW_FULLSCREEN attribute to waffle_window_create2().
Cc: Frank Henigman
Signed-off-by: Chad Versace
---
examples/gl_basic.c | 35 +--
1 file changed, 29 insertions(+), 6 deletions(-)
diff --
On Thu 23 Apr 2015, Emil Velikov wrote:
> On 22 April 2015 at 20:26, Chad Versace wrote:
> > On Fri 10 Apr 2015, Emil Velikov wrote:
> >> On 09/04/15 22:48, Chad Versace wrote:
> >> > On Mon 30 Mar 2015, Frank Henigman wrote:
>
> >> >> diff
On Thu 09 Apr 2015, Emil Velikov wrote:
> From: Bernhard Rosenkränzer
>
> Signed-off-by: Bernhard Rosenkränzer
> [Emil Velikov: Apply the workaround for kitkat and older]
> Signed-off-by: Emil Velikov
> ---
> Android.mk | 9 -
> 1 file changed, 8 insertions(+), 1 deletion(-)
Thanks. I
On Fri 10 Apr 2015, Emil Velikov wrote:
> On 09/04/15 22:48, Chad Versace wrote:
> > On Mon 30 Mar 2015, Frank Henigman wrote:
> >> You can now put WAFFLE_WINDOW_FULLSCREEN in the attribute list passed
> >> to waffle_window_create2() and get a full screen window
I HAVE NOT EVEN COMPILED MOST OF THESE
> - update wcore_enum_to_string()
> - update documentation
Reviewed-by: Chad Versace
I'll commit this to master today.
___
waffle mailing list
waffle@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/waffle
On Fri 10 Apr 2015, Jordan Justen wrote:
> On 2015-04-10 07:05:32, Frank Henigman wrote:
> > Sorry I let this thread get stale.
I apologise too for letting it go stale.
> > > On 02/20/2015 01:49 PM, Jordan Justen wrote:
> > >> My idea was just to define a one-time API that left presentation of
>
On Thu 16 Apr 2015, Frank Henigman wrote:
> On Thu, Apr 9, 2015 at 6:48 PM, Chad Versace wrote:
> > On Mon 30 Mar 2015, Frank Henigman wrote:
> >>
> >> You can now put WAFFLE_WINDOW_FULLSCREEN in the attribute list passed
> >> to waffle_window_create2() and get
her parts in waffle and
added a few missing pragma once guards.
Patch 6 is slightly on the bikeshed side, so I won't object it people
want to take it out the back and shoot it :-P
Emil, these cleanups look good to me. And I agree that bike-sheddy patch
6 does make the code a bit more read
Quoting Emil Velikov (2015-03-26 19:24:21)
> On 26 March 2015 at 14:50, Chad Versace wrote:
> > Quoting Emil Velikov (2015-03-25 07:30:00)
> >> Indeed you're bang on the spot. id_counter should be locked throughout
> >> a series of display_{connect, disconnect}, th
Quoting Jose Fonseca (2015-03-26 09:01:41)
> The approach we use to statically initialize critical sections on
> windows is unofficial. Read
> http://locklessinc.com/articles/pthreads_on_windows/ for the gritty details.
From the page:
#define PTHREAD_MUTEX_INITIALIZER {(void*)-1,-1,0,0,0,0}
Quoting Emil Velikov (2015-03-18 13:03:08)
> On 17 March 2015 at 19:54, Chad Versace wrote:
> > Hey Emil,
> >
> > The patches look good to me, though I haven't tested them yet.
> > I'm going to run the patches through a Piglit run and, if I
> > find no
ds_posix.c | 10 --
> 1 file changed, 4 insertions(+), 6 deletions(-)
Reviewed-by: Chad Versace
This patch looks safe to land before the others in the series, so I'll
go ahead and commit it.
___
waffle mailing list
waffle@lists.freedesk
Quoting Emil Velikov (2015-03-25 07:30:00)
> On 24 March 2015 at 17:37, Jose Fonseca wrote:
> > Is wcore_display_teardown called only once, or when destroying each display?
> >
> > If the latter, then it's not safe to call `mtx_destroy(&mutex)` on
> > `wcore_display_teardown`. Otherwise when wco
Thanks. I'll merge this to stable branches and master.
Quoting Frank Henigman (2015-03-23 18:34:44)
> Alpha planes are written and read, so we should ask for them in the config.
>
> Signed-off-by: Frank Henigman
> ---
> examples/gl_basic.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --g
Hey Emil,
The patches look good to me, though I haven't tested them yet.
I'm going to run the patches through a Piglit run and, if I
find no regressions, I'll push them.
___
waffle mailing list
waffle@lists.freedesktop.org
http://lists.freedesktop.org/ma
On 03/03/2015 08:30 AM, Emil Velikov wrote:
> On 26 February 2015 at 21:26, Chad Versace wrote:
>> On 02/23/2015 12:32 PM, Emil Velikov wrote:
>>> Hello list,
>>>
>>> Second to last part of removing all the window specific bits from
>>> link-time to
On 02/23/2015 12:32 PM, Emil Velikov wrote:
> Hello list,
>
> Second to last part of removing all the window specific bits from
> link-time to run-time (hail libdl).
>
> Note that the last patch looks a bit messy, mostly due to the wayland
> design approach to have a handful of functions define
By the way, I wrote a little Python script to ease the debugging
of GBM formats. You may find it useful too. Here's the example
usage:
$ gbm-format GBM_FORMAT_BGRA1010102
0x30334142
$ gbm-format 0x30334142
GBM_FORMAT_BGRA1010102
$ gbm-format B A 3 0
GBM_FORMAT_BGRA1010102
-8<- file: ~
On 02/24/2015 10:43 AM, Tom Stellard wrote:
> ---
>
> I think this is better than my original patch:
> http://lists.freedesktop.org/archives/waffle/2015-February/001070.html
>
> However, piglit tests still fail because the alpha channel is always 1.0.
> The gbm format being selected by eglGetConf
On 02/20/2015 01:49 PM, Jordan Justen wrote:
> On 2015-02-20 12:58:07, Chad Versace wrote:
>> On 02/17/2015 11:30 PM, Jordan Justen wrote:
>> For the sake of apps who want to dump the info to a log file or to
>> the console and get on
>> with their lives, I think the d
On 02/12/2015 12:06 AM, Tapani Pälli wrote:
>
>
> On 02/12/2015 03:47 AM, Chad Versace wrote:
>> On 02/09/2015 06:22 AM, Tapani Pälli wrote:
>>> +// Thread takes care that we do not issue another buffer
>>> +// swap before previous swap has completed.
>
On 02/17/2015 09:55 PM, Tapani wrote:
> On 02/18/2015 01:44 AM, Emil Velikov wrote:
>> On 16/02/15 06:49, Tapani Pälli wrote:
>>> Patch fills attributes table suitable for Pepper API from
>>> wcore_config_attrs passed by the application.
>>>
>>> v2:
On 02/17/2015 11:30 PM, Jordan Justen wrote:
> On 2015-02-10 12:09:05, Chad Versace wrote:
>>> On Sun, Feb 08, 2015 at 07:50:15PM -0500, Frank Henigman wrote:
>>>> I'd like to extend wflinfo so it can print platform-specific
>>>> information and eventuall
On 02/17/2015 03:31 PM, Emil Velikov wrote:
> On 17/02/15 19:34, Chad Versace wrote:
>> On 02/12/2015 05:56 AM, Emil Velikov wrote:
>>> Hello all,
>>>
>>> In case you've been wondering what happened with that here it goes:
>>>
>>> Curren
On 02/12/2015 05:56 AM, Emil Velikov wrote:
> Hello all,
>
> In case you've been wondering what happened with that here it goes:
>
> Currently the following libraries could be nuked
>
> NEEDED libwayland-client.so.0
> NEEDED libwayland-egl.so.1
> NEEDED
On 02/16/2015 02:41 PM, Emil Velikov wrote:
> Seems like I've used a bit too many tags, which caused some issues while
> generating the man/html page.
>
> Signed-off-by: Emil Velikov
> ---
> man/waffle_teardown.3.xml | 39 ++-
> 1 file changed, 18 insertions(+
On 02/14/2015 09:22 AM, Emil Velikov wrote:
> On 13 February 2015 at 02:22, Frank Henigman wrote:
>> On Thu, Feb 12, 2015 at 5:44 AM, Emil Velikov
>> wrote:
>>> On 12 February 2015 at 02:01, Chad Versace wrote:
>>>> On 02/10/2015 01:20 PM, Frank Henigman wr
On 02/11/2015 09:53 AM, Tom Stellard wrote:
> Using GBM_FORMAT_ABGR was causing the B and G components to
> be swapped for some piglit tests.
> ---
>
> I have no idea if this fix is correct, but based on an IRC discussion:
> http://people.freedesktop.org/~cbrill/dri-log/?channel=dri-devel&date
Frank, I see in your Github repo that you're working on support for
Chrome OS's null platform. I'm looking forward to it, because some
of us in Intel would like to use it too. Do you have an idea when
it will be ready for upstreaming?
signature.asc
Description: OpenPGP digital signature
On 02/10/2015 01:20 PM, Frank Henigman wrote:
> On Tue, Feb 10, 2015 at 4:08 PM, Frank Henigman wrote:
> Looks like Issue #3 is the format of the information. I thought it
> was given we should duplicate existing glxinfo/eglinfo/etc as closely
> as possible, in order to be a drop-in replacement,
On 02/09/2015 06:22 AM, Tapani Pälli wrote:
> Implementation for nacl is somewhat different as for other platforms,
> platform needs to ensure that the previous swap has finished before
> issuing GL commands or more swaps. This is done by introducing a worker
> thread that does buffer swaps from a
ementation for waffle_make_current
> nacl: add implementation for waffle_window_swap_buffers
> nacl: add implementation for waffle_dl_sym
Tapani,
This entire series, including v3 of the swap buffers patch, is
Reviewed-by: Chad Versace
I don't fully understand the NaCl APIs in the swap buffers patch
On 02/10/2015 01:08 PM, Frank Henigman wrote:
> On Tue, Feb 10, 2015 at 3:09 PM, Chad Versace wrote:
>> I see two significant design decisions that need to be made:
>>
>> Issue #1: Should Waffle provide a query mechanism for the native
>> platform info? Or should
On 02/03/2015 05:14 PM, Emil Velikov wrote:
> Hi Chad,
>
> Here is to another waffle API - waffle_teardown
> In summary:
> - It pairs up with waffle_init
> - Cleans up some memory "leaks"
> - Allows one to switch between platforms without the need to exit the
> program.
>
> Let me know if you
On 02/08/2015 04:50 PM, Frank Henigman wrote:
> I'd like to extend wflinfo so it can print platform-specific
> information and eventually be able to replace glxinfo, eglinfo and the
> like (I only know what's on linux). There would be a new flag to
> request the platform-specific output in additio
On 02/10/2015 10:31 AM, Dylan Baker wrote:
> I like this idea, it would be convenient for piglit to be able to assume
> waffle info can provide all of the information we currently call out to
> multiple binaries for.
Yes, Piglit wants this. I imagine more users will begin using it too.
> On Sun,
On 02/05/2015 04:45 AM, Tapani wrote:
> On 02/05/2015 09:47 AM, Tapani Pälli wrote:
>>
>> On 02/03/2015 10:07 PM, Chad Versace wrote:
>>> It seems that two solutions are available:
>>>
>>> S1. Provide waffle_set_swap_buffers_callback().
>&g
On 02/04/2015 05:13 AM, Emil Velikov wrote:
> On 4 February 2015 at 06:20, Tapani Pälli wrote:
>>
>>
>> On 02/03/2015 07:32 PM, Emil Velikov wrote:
>>>
>>> On 2 February 2015 at 13:08, Tapani Pälli wrote:
Patch introduces a new API that enables application to register
a callback to
On 02/05/2015 09:05 AM, Emil Velikov wrote:
> On 5 February 2015 at 13:12, Tapani wrote:
>> On 02/03/2015 07:09 PM, Emil Velikov wrote:
>>>
>>> On 23 January 2015 at 07:59, Tapani Pälli wrote:
> ...
+
+uint32_t len = strlen(src) + strlen(prefix);
>>>
>>> So the function name changes
On 02/03/2015 04:55 PM, Emil Velikov wrote:
> As requested, this is a resend of the two 3 patch series.
> I've added the r-b tags, and the patches are coming directly from
> $ git send-email -6
> so I hope they won't be messed up again.
>
> If they are, the series can be found in my github repo,
On 01/30/2015 02:33 AM, Tapani Pälli wrote:
> Hi;
>
> As a Finn I interpret silence as 'yes' :)
A safe assumption in many open source cultures :)
> So I started to hack on swap completion event support. I believe it
> can be useful for other backends also since then application can
> throttle re
On 01/22/2015 11:59 PM, Tapani Pälli wrote:
> Implementation for nacl is somewhat different as for other platforms,
> platform needs to ensure that the previous swap has finished before
> issuing another one. This is done by introducing a worker thread that
> does buffer swaps from a work queue.
>
On 01/22/2015 11:59 PM, Tapani Pälli wrote:
> Implementation for nacl is somewhat different as for other platforms,
> platform needs to ensure that the previous swap has finished before
> issuing another one. This is done by introducing a worker thread that
> does buffer swaps from a work queue.
>
On 02/03/2015 07:37 AM, Emil Velikov wrote:
> On 23 January 2015 at 07:59, Tapani Pälli wrote:
>> Patch creates and initializes pp::Graphics3D context for OpenGL ES 2.0.
>>
>> Signed-off-by: Tapani Pälli
>> ---
> [...]
>
>> @@ -37,6 +43,10 @@ nacl_container_dtor(waffle::nacl_container *nc)
>> {
I have to leave the office now. I'll finish reviewing the remaining patches in
the morning.
signature.asc
Description: OpenPGP digital signature
___
waffle mailing list
waffle@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/waffle
On 01/22/2015 11:59 PM, Tapani Pälli wrote:
> Signed-off-by: Tapani Pälli
> ---
> src/waffle/nacl/nacl_container.cpp | 17 +
> src/waffle/nacl/nacl_container.h | 1 +
> src/waffle/nacl/nacl_platform.c| 2 +-
> 3 files changed, 19 insertions(+), 1 deletion(-)
>
> diff --gi
On 01/22/2015 11:59 PM, Tapani Pälli wrote:
> Signed-off-by: Tapani Pälli
> ---
> src/waffle/nacl/nacl_container.cpp | 18 ++
> src/waffle/nacl/nacl_container.h | 1 +
> src/waffle/nacl/nacl_window.c | 7 ++-
> src/waffle/nacl/nacl_window.h | 1 +
> 4 files chan
On 01/22/2015 11:59 PM, Tapani Pälli wrote:
> Patch creates and initializes pp::Graphics3D context for OpenGL ES 2.0.
>
> Signed-off-by: Tapani Pälli
> ---
> src/waffle/nacl/nacl_container.cpp | 81
> ++
> src/waffle/nacl/nacl_container.h | 8
> src/w
On 01/22/2015 11:59 PM, Tapani Pälli wrote:
> Patch fills attributes table suitable for Pepper API from
> wcore_config_attrs passed by the application.
>
> Signed-off-by: Tapani Pälli
> ---
> src/waffle/nacl/nacl_config.c | 30 ++
> src/waffle/nacl/nacl_config.h | 2
On 01/22/2015 11:59 PM, Tapani Pälli wrote:
> Currently only OpenGL ES 2.0 is supported.
>
> Signed-off-by: Tapani Pälli
> ---
> src/waffle/nacl/nacl_display.c | 9 -
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/src/waffle/nacl/nacl_display.c b/src/waffle/nacl/nacl_
On 01/20/2015 10:56 PM, Tapani Pälli wrote:
> v2: fixes in cmake (Emil Velikov, Chad Versace)
>
> Changed also nmf file content and generation, moved
> nacl example content to separate output path.
>
> Signed-off-by: Tapani Pälli
> ---
> .gitignore
On 01/28/2015 04:08 AM, Emil Velikov wrote:
> The function declaration of droid_window_create did not match
> the function definition. Update the former.
This series is
Reviewed-by: Chad Versace
But, like your other Android series, all the emails are
base64 encoded. Could you resend thes
On 01/28/2015 04:08 AM, Emil Velikov wrote:
> The function declaration of droid_window_create did not match
> the function definition. Update the former.
This series is
Reviewed-by: Chad Versace
But, like your other Android series, all the emails are
base64 encoded. Could you resend thes
e -Wextra disabled ?
>
> Cheers,
> Emil
>
> P.S. That's enough waffle + android nit-picking for now. I'm going to
> head over to drm and mesa :-)
Emil, this series is
Reviewed-by: Chad Versace
But! git-am barfs on your patches. Every patch in the email is base64 enc
On 01/30/2015 03:07 AM, Jose Fonseca wrote:
> Workaround what seems to be a bug in MSVC parser for C99.
>
> http://lists.freedesktop.org/archives/waffle/2015-January/000975.html
Reviewed-by: Chad Versace
This will be on maint-1.5 and master later today.
signature.asc
Description
On 01/15/2015 07:21 AM, Emil Velikov wrote:
> Hello all,
>
> As mentioned a while back, here is the function waffle_teardown. Its purpose
> is to cleanup the global state (the api_platform variable and the respective
> platform private data).
>
> This makes valgrind a bit happier (-20k of still r
| 40 +++-
> 1 file changed, 19 insertions(+), 21 deletions(-)
LGTM
Reviewed-by: Chad Versace
This will land in maint-1.5 and master later today.
signature.asc
Description: OpenPGP digital signature
___
waffle mail
On 01/23/2015 08:37 AM, Emil Velikov wrote:
> On 23/01/15 01:43, Frank Henigman wrote:
>> wegl_platform_init() now returns false if dlopen or dlsym fails.
>>
>> Signed-off-by: Frank Henigman
> Reviewed-by: Emil Velikov
>
>> ---
>> Without this, if for some reason libEGL isn't loaded, wflinfo wil
On 01/21/2015 06:27 AM, Emil Velikov wrote:
> On 4 January 2015 at 22:02, Chad Versace wrote:
> I've just send a couple of updates to get things working for WGL/MSVC.
> With those applied on top of your waffle_window_create2 branch (top
> commit 1b9a56659c7021265a468f1b238b45
On 01/21/2015 06:12 AM, Emil Velikov wrote:
> On 4 January 2015 at 22:03, Chad Versace wrote:
>> Tested on GLX, X11/EGL, Wayland, and GBM.
>>
>> Signed-off-by: Chad Versace
>> ---
>> examples/gl_basic.c | 10 --
>> 1 file changed, 8 insertion
On 01/21/2015 06:06 AM, Emil Velikov wrote:
> On 4 January 2015 at 22:03, Chad Versace wrote:
>> Define the function below. All act on size_t inputs.
>> wcore_add_size
>> wcore_iadd_size : in-place addition
>> wcore_mul_size
>> wcore_im
le.cmake
This bug only affects other projects that use CMake and used FindWaffle.cmake.
See bug [https://github.com/waffle-gl/waffle/issues/27].
Changes since 1.5.0
---
Chad Versace (3):
doc: Add release notes for Waffle 1.5.1
doc: Add release notes for Waffle 1.4.
/issues/27].
Changes since 1.4.3
---
Chad Versace (2):
doc: Add release notes for Waffle 1.4.4
waffle: Bump version to 1.4.4
Dylan Baker (2):
cmake: Add cmake PackageConfig files
cmake: fix version search
Jordan Justen (4):
debian: Add WaffleConfig*.cmake to libwa
On 01/15/2015 04:35 AM, Emil Velikov wrote:
> Hi Chad,
> Almost forgot about the way we handle the exported/public symbols in MSVC.
> Can you squash the following into this patch please.
Yes, I'll squash it.
> diff --git a/src/waffle/waffle.def.in b/src/waffle/waffle.def.in
> index db8464f..ca30
On 01/15/2015 04:40 AM, Emil Velikov wrote:
> On 4 January 2015 at 22:02, Chad Versace wrote:
>> The current wcore_attrib_list functions work on int32_t attribute lists.
>> A future commit will add variants that work on intptr_t attribute lists.
>> To prevent code duplicat
On 01/15/2015 04:29 AM, Emil Velikov wrote:
> On 4 January 2015 at 22:02, Chad Versace wrote:
>> This macro annotates symbols as deprecated in Waffle 1.6. The compiler
>> emits deprecation warnings only if the user enables the feature macro
>> for the Waffle 1.6 API.
>
On 01/15/2015 05:31 AM, Emil Velikov wrote:
> On 15 January 2015 at 15:21, Emil Velikov wrote:
>> Hello all,
>>
>> As mentioned a while back, here is the function waffle_teardown. Its purpose
>> is to cleanup the global state (the api_platform variable and the respective
>> platform private data).
On 01/15/2015 07:21 AM, Emil Velikov wrote:
> Drop ~20k and ~10k of still reachable memory "leaks", for the glx and x11_egl
> platforms respectively.
>
> Signed-off-by: Emil Velikov
> ---
> src/utils/wflinfo.c | 6 +-
> 1 file changed, 5 insertions(+), 1
; definitely lost: 87 bytes in 5 blocks
> still reachable: 23,451 bytes in 55 blocks
>
> Signed-off-by: Emil Velikov
> ---
> examples/gl_basic.c | 6 +-
> examples/simple-x11-egl.c | 5 +
> 2 files changed, 10 insertions(+), 1 deletion(-)
Looks good. Patch 2 is
t an error here rather
than
succeed? Either behavior makes sense, though, so I'm not suggesting you change
it.
> +
> +ok &= api_platform->vtbl->destroy(api_platform);
> +if (!ok)
> + return false;
Now I see why you document in the man page that,
On 01/04/2015 11:36 PM, Tapani Pälli wrote:
> Hello;
>
> Here is v3 of nacl support patches with many changes and fixes here
> and there! Thanks for Emil and Chad for review, I think it looks a lot
> cleaner now.
>
> In case you want to try on Chrome, I also put 'demo' of gl_basic here:
>
> http
The maint-1.5 branch has acquired a few fixes. And Dylan (CC'd) would like to
use the
Waffle's new CMake package files. So I think it's time for new maintenance
releases.
I plan on releasing Waffle 1.5.1 and 1.4.4 on Wednesday unless someone objects.
The unreleased changes on the maint-1.5 bran
Tested on GLX, X11/EGL, Wayland, and GBM.
Signed-off-by: Chad Versace
---
examples/gl_basic.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/examples/gl_basic.c b/examples/gl_basic.c
index 69418c8..6f57799 100644
--- a/examples/gl_basic.c
+++ b/examples
This function converts an int32_t attribute list to an intptr_t
attribute list. It will be needed in the future when updating
waffle_config_choose() to accept an intptr_t attribute list.
Signed-off-by: Chad Versace
---
src/waffle/core/wcore_attrib_list.c | 48
intptr_t
variants of the wcore_attrib_list functions.
This patch makes room for the new intptr_t wcore_attrib_list functions
by renaming the old ones.
Signed-off-by: Chad Versace
---
src/waffle/api/waffle_attrib_list.c | 8 +-
src/waffle/core/wcore_attrib_list.c | 10
The prototype differed between the public header and file
waffle_window.c.
This is solely a cosmetic change, because 'int' and 'int32_t' are the
same on all platforms supported by Waffle.
Signed-off-by: Chad Versace
---
src/waffle/api/waffle_window.c | 2 +-
1 file change
This is useful for removing attributes as they are parsed.
Signed-off-by: Chad Versace
---
src/waffle/core/wcore_attrib_list.c | 40 +
src/waffle/core/wcore_attrib_list.h | 6 ++
2 files changed, 46 insertions(+)
diff --git a/src/waffle/core
This prepares for adding waffle_window_create2() to Waffle's public API,
which will have an attrib_list parameter.
No attributes are supported yet. Therefore this patch validates, at the
top of each ${PLATFORM}_window_create(), that the attrib_list is empty.
Signed-off-by: Chad Versace
--
Tested on GLX, X11/EGL, and Wayland.
Signed-off-by: Chad Versace
---
tests/functional/gl_basic_test.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/tests/functional/gl_basic_test.c b/tests/functional/gl_basic_test.c
index 0e932e3..19b0dac 100644
--- a/tests
Define the function below. All act on size_t inputs.
wcore_add_size
wcore_iadd_size : in-place addition
wcore_mul_size
wcore_imul_size : in-place multiplication
Future patches will use the functions to safely calculate the 'size'
value given to malloc.
Signed-off-by: Ch
intptr_t
variants of the wcore_attrib_list functions.
Signed-off-by: Chad Versace
---
src/waffle/core/wcore_attrib_list.c | 6 ++
src/waffle/core/wcore_attrib_list.h | 23 +++
2 files changed, 29 insertions(+)
v2:
- Remove duplicate code by defining functions with
This little helper function emits WAFFLE_ERROR_BAD_ATTRIBUTE with
a default error message.
Signed-off-by: Chad Versace
---
src/waffle/core/wcore_error.c | 8
src/waffle/core/wcore_error.h | 4
2 files changed, 12 insertions(+)
diff --git a/src/waffle/core/wcore_error.c b/src
ction waffle_window_create2() is conceptually equivalent to
the original waffle_window_create() with the addition of an attrib_list
parameter. The only supported attributes are currently
WAFFLE_WINDOW_WIDTH and WAFFLE_WINDOW_HEIGHT.
See the manpage changes for more details.
Signed-off-by: Chad Versace
--
Fix signature to match that of waffle_window_create(). The types of
parameters 'width' and 'height' didn't match the public header.
As a consequence, also fix the signature of
${PLATFORM}_window_create() for all platforms.
Signed-off-by: Chad Versace
---
src/waffle/and
,
WCORE_ATTRIB_LIST_COMMON_FUNCS, which will also be used to define the
upcoming intptr_t functions.
Signed-off-by: Chad Versace
---
src/waffle/core/wcore_attrib_list.c | 152 +++-
1 file changed, 82 insertions(+), 70 deletions(-)
diff --git a/src/waffle/core/wcore_attrib_list.c
b/src/waffle
rdiff_t to int32_t in wcore_attrib_list_length
just looked wrong. A cast to size_t makes more sense.
As precedent, strlen() also returns size_t.
Signed-off-by: Chad Versace
---
src/waffle/core/wcore_attrib_list.c | 4 ++--
src/waffle/core/wcore_attrib_list.h | 3 ++-
2 files changed, 4 insert
This is useful for making a writable copy of a read-only attribute list.
Signed-off-by: Chad Versace
---
src/waffle/core/wcore_attrib_list.c | 37 +
src/waffle/core/wcore_attrib_list.h | 3 +++
2 files changed, 40 insertions(+)
v2:
- Correctly handle
I'm deprecating the waffle_attrib_list functionss because I don't want
to maintain two variants (int32_t and intptr_t) of each function. They
offer little utility to users, so I see little benefit in trying
maintain both variants.
Signed-off-by: Chad Versace
---
include/waffle/waf
igman]
- Be smarter about arithmetic overflows when allocating memory.
- Handle malloc failure. [emil]
- Fix some #include placements. [emil]
Chad Versace (17):
include: Define macro WAFFLE_DEPRECATED_1_06
include: Deprecate waffle_attrib_list funcs
core: Rename functions s/wc
This macro annotates symbols as deprecated in Waffle 1.6. The compiler
emits deprecation warnings only if the user enables the feature macro
for the Waffle 1.6 API.
Signed-off-by: Chad Versace
---
include/waffle/waffle.h | 12
1 file changed, 12 insertions(+)
diff --git a/include
On 12/23/2014 04:22 PM, Frank Henigman wrote:
> On Mon, Dec 22, 2014 at 8:11 PM, Chad Versace wrote:
>> On 12/21/2014 01:41 PM, Emil Velikov wrote:
>>> On 16 December 2014 at 08:18, Chad Versace
>>> wrote:
>>>> Today, waffle_window() has only two parame
On 12/23/2014 04:24 PM, Frank Henigman wrote:
> On Tue, Dec 16, 2014 at 3:18 AM, Chad Versace
> wrote:
>> Today, waffle_window() has only two parameters: width and height.
>>
>> Frank Henigman wants to extend Waffle's GBM backend with the ability to
>>
On 12/23/2014 04:23 PM, Frank Henigman wrote:
> On Tue, Dec 16, 2014 at 3:18 AM, Chad Versace
> wrote:
>> When designing the original Waffle 1.0 API, I made a mistake when
>> I chose to declare attribute lists as arrays of int32_t. Instead, they
>> should have been arrays
On 12/29/2014 03:35 AM, Jose Fonseca wrote:
> FWIW, IMO the best way of finding things with CMake on Windows is using the
> `-C` cmake option.
>
> For example, this is part of my MSVC Cmake cache:
>
> $ cat msvc32/Cache.cmake
> set (CMAKE_ASM_MASM_COMPILER "${CMAKE_CURRENT_LIST_DIR}/masm/ml.exe
Series is
Reviewed-by: Chad Versace
I'll commit these to the master and maint-1.5 branches today.
signature.asc
Description: OpenPGP digital signature
___
waffle mailing list
waffle@lists.freedesktop.org
http://lists.freedesktop.org/ma
On 12/29/2014 12:00 AM, Tapani Pälli wrote:
>
>
> On 12/23/2014 04:25 AM, Chad Versace wrote:
>> On 12/21/2014 08:06 AM, Emil Velikov wrote:
>>> On 17 December 2014 at 13:12, Tapani Pälli wrote:
>>>> Signed-off-by: Tapani Pälli
>>>> ---
>&g
On 12/28/2014 11:47 PM, Tapani Pälli wrote:
>
>
> On 12/21/2014 03:53 PM, Emil Velikov wrote:
>> On 17 December 2014 at 10:17, Tapani Pälli wrote:
>>> +if(NOT EXISTS ${CMAKE_TOOLCHAIN_FILE})
>>> +message(FATAL_ERROR "Toolchain for Nacl not found. This must
>>> be "
>>> +
101 - 200 of 511 matches
Mail list logo
