Re: [Warzone-dev] g++ fixes again

2007-05-23 Thread Christian Ohm
On Wednesday, 23 May 2007 at 22:46, Giel van Schijndel wrote: > Christian Ohm schreef: > > Some g++ fixes again. "new" is a reserved keyword, a few casts, and I've > > moved OggVorbisDecoderState into oggvorbis.h, there was a linker error > > when it was typedeffed to void in some cases. Don't know

Re: [Warzone-dev] g++ fixes again

2007-05-23 Thread Christian Ohm
On Wednesday, 23 May 2007 at 22:42, Per Inge Mathisen wrote: > On 5/23/07, Christian Ohm <[EMAIL PROTECTED]> wrote: > > Some g++ fixes again. > > Most of these are good, but do we need "fixes" of this kind?: > > - buffer = malloc(bufferSize + sizeof(soundDataBuffer)); > + buffer = (so

Re: [Warzone-dev] g++ fixes again

2007-05-23 Thread Giel van Schijndel
[EMAIL PROTECTED] schreef: > On Wed, 23 May 2007 17:12:02 -0400 Per Inge Mathisen > <[EMAIL PROTECTED]> wrote: > >> On 5/23/07, Dennis Schridde <[EMAIL PROTECTED]> wrote: >> Most of these are good, but do we need "fixes" of this kind?: - buffer = malloc(bufferSize + si

Re: [Warzone-dev] g++ fixes again

2007-05-23 Thread vs2k5
On Wed, 23 May 2007 17:12:02 -0400 Per Inge Mathisen <[EMAIL PROTECTED]> wrote: >On 5/23/07, Dennis Schridde <[EMAIL PROTECTED]> wrote: >> > Most of these are good, but do we need "fixes" of this kind?: >> > >> > - buffer = malloc(bufferSize + sizeof(soundDataBuffer)); >> > + buffer =

Re: [Warzone-dev] g++ fixes again

2007-05-23 Thread Per Inge Mathisen
On 5/23/07, Dennis Schridde <[EMAIL PROTECTED]> wrote: > > Most of these are good, but do we need "fixes" of this kind?: > > > > - buffer = malloc(bufferSize + sizeof(soundDataBuffer)); > > + buffer = (soundDataBuffer*) malloc(bufferSize + > > sizeof(soundDataBuffer)); ... > Question:

Re: [Warzone-dev] g++ fixes again

2007-05-23 Thread Giel van Schijndel
Giel van Schijndel schreef: > Christian Ohm schreef: > >> Some g++ fixes again. "new" is a reserved keyword, a few casts, and I've >> moved OggVorbisDecoderState into oggvorbis.h, there was a linker error >> when it was typedeffed to void in some cases. Don't know why it was done >> that way, st

Re: [Warzone-dev] g++ fixes again

2007-05-23 Thread Dennis Schridde
Am Mittwoch, 23. Mai 2007 schrieb Per Inge Mathisen: > On 5/23/07, Christian Ohm <[EMAIL PROTECTED]> wrote: > > Some g++ fixes again. > > Most of these are good, but do we need "fixes" of this kind?: > > - buffer = malloc(bufferSize + sizeof(soundDataBuffer)); > + buffer = (soundDataBuf

Re: [Warzone-dev] g++ fixes again

2007-05-23 Thread Giel van Schijndel
Christian Ohm schreef: > Some g++ fixes again. "new" is a reserved keyword, a few casts, and I've > moved OggVorbisDecoderState into oggvorbis.h, there was a linker error > when it was typedeffed to void in some cases. Don't know why it was done > that way, still works for me now. I've removed an #

Re: [Warzone-dev] g++ fixes again

2007-05-23 Thread Per Inge Mathisen
On 5/23/07, Christian Ohm <[EMAIL PROTECTED]> wrote: > Some g++ fixes again. Most of these are good, but do we need "fixes" of this kind?: - buffer = malloc(bufferSize + sizeof(soundDataBuffer)); + buffer = (soundDataBuffer*) malloc(bufferSize + sizeof(soundDataBuffer)); Please just

[Warzone-dev] g++ fixes again

2007-05-23 Thread Christian Ohm
Some g++ fixes again. "new" is a reserved keyword, a few casts, and I've moved OggVorbisDecoderState into oggvorbis.h, there was a linker error when it was typedeffed to void in some cases. Don't know why it was done that way, still works for me now. I've removed an #ifdef WZ_NOOGG, but ./configur

Re: [Warzone-dev] code formatting

2007-05-23 Thread Christian Vest Hansen
You can use tabs: http://www.codeandcoffee.com/2007/05/18/use-tabs-not-spaces/ Or you can use spaces: http://www.iovene.com/tabs-vs-spaces-the-end-of-the-debate/ But consistency matters more than either. 2007/5/22, Belhorma Bendebiche <[EMAIL PROTECTED]>: > What do you mean by lining stuff out?