[Warzone-dev] [bug #9329] segfault, hashtabl.c

2007-06-13 Thread Jose Ivey
URL: Summary: segfault, hashtabl.c Project: Warzone Resurrection Project Submitted by: urbanvoyeur Submitted on: Thursday 06/14/2007 at 01:52 Category: None Severity: 3 - Normal

Re: [Warzone-dev] Patch for tex.c

2007-06-13 Thread vs2k5
On Wed, 13 Jun 2007 17:31:17 -0400 Dennis Schridde <[EMAIL PROTECTED]> wrote: >Am Mittwoch, 13. Juni 2007 schrieb [EMAIL PROTECTED]: >> The game crash on that line, free(image->bmp). >> Since it set to NULL after 1st free call, we can then assume >that >> image pointer is wrong/corrupted. >> So t

Re: [Warzone-dev] Memory design problems.

2007-06-13 Thread Giel van Schijndel
Dennis Schridde schreef: > Am Mittwoch, 13. Juni 2007 schrieb [EMAIL PROTECTED]: > >> Another option is use heap again. >> > The magic question is: > How is that going to improve the situation? > > There must have been some special assumption on Pumpkins heap implementation > which magical

Re: [Warzone-dev] Memory design problems.

2007-06-13 Thread Dennis Schridde
Am Mittwoch, 13. Juni 2007 schrieb [EMAIL PROTECTED]: > On Wed, 13 Jun 2007 14:16:26 -0400 Dennis Schridde > > <[EMAIL PROTECTED]> wrote: > >Am Mittwoch, 13. Juni 2007 schrieb [EMAIL PROTECTED]: > >> On Mon, 11 Jun 2007 16:45:58 -0400 Dennis Schridde > >> > >> >Valgrind should help... Will try on t

Re: [Warzone-dev] Patch for tex.c

2007-06-13 Thread Dennis Schridde
Am Mittwoch, 13. Juni 2007 schrieb [EMAIL PROTECTED]: > On Wed, 13 Jun 2007 16:54:33 -0400 Giel van Schijndel > > <[EMAIL PROTECTED]> wrote: > >Dennis Schridde schreef: > >>> Index: tex.c > > > >=== > > > >>> --- tex.c (revision 1494)

Re: [Warzone-dev] Memory design problems.

2007-06-13 Thread vs2k5
On Wed, 13 Jun 2007 14:16:26 -0400 Dennis Schridde <[EMAIL PROTECTED]> wrote: >Am Mittwoch, 13. Juni 2007 schrieb [EMAIL PROTECTED]: >> On Mon, 11 Jun 2007 16:45:58 -0400 Dennis Schridde >> >Valgrind should help... Will try on the weekend. >> > >> >You apparently dove deep into the code and found

Re: [Warzone-dev] Patch for tex.c

2007-06-13 Thread vs2k5
On Wed, 13 Jun 2007 16:54:33 -0400 Giel van Schijndel <[EMAIL PROTECTED]> wrote: >Dennis Schridde schreef: >>> Index: tex.c >>> >=== > >>> --- tex.c (revision 1494) >>> +++ tex.c (working copy) >>> @@ -264,7 +264,7 @@ >>> >>> vo

Re: [Warzone-dev] Memory design problems.

2007-06-13 Thread Giel van Schijndel
Dennis Schridde schreef: > - Refcounting is probably even better. > I like reference counting, in fact it is to my opinion both the safest and most efficient solution of all. However, I do think that unlike C++, which provides constructors and destructors, reference counting will not be easy to

Re: [Warzone-dev] Patch for tex.c

2007-06-13 Thread Giel van Schijndel
Dennis Schridde schreef: > Am Mittwoch, 13. Juni 2007 schrieb [EMAIL PROTECTED]: > >> I no could tell where original function came from. It was add to >> tex.c from ??? >> It crash for me with free memory already free. >> So this fix it. >> >> Also, I find that lots physfs routines that use cop

Re: [Warzone-dev] Patch for tex.c

2007-06-13 Thread Dennis Schridde
Am Mittwoch, 13. Juni 2007 schrieb [EMAIL PROTECTED]: > I no could tell where original function came from. It was add to > tex.c from ??? > It crash for me with free memory already free. > So this fix it. > > Also, I find that lots physfs routines that use copy, use uninit > variables, but no seem

Re: [Warzone-dev] Memory design problems.

2007-06-13 Thread Per Inge Mathisen
On 6/13/07, Dennis Schridde <[EMAIL PROTECTED]> wrote: > - Dead-lists (prune-lists, as they are called in WZ according to Per) No, that's what I called them, because that is what I named a somewhat similar system that I made once. It is called "list of destroyed objects" or similar in Warzone. Ju

Re: [Warzone-dev] Memory design problems.

2007-06-13 Thread Dennis Schridde
Am Mittwoch, 13. Juni 2007 schrieb [EMAIL PROTECTED]: > On Mon, 11 Jun 2007 16:45:58 -0400 Dennis Schridde > >Valgrind should help... Will try on the weekend. > > > >You apparently dove deep into the code and found several places > >where > >unitialised memory comes from or pointers are not set to

Re: [Warzone-dev] Patch for tex.c

2007-06-13 Thread Giel van Schijndel
[EMAIL PROTECTED] schreef: > I no could tell where original function came from. It was add to > tex.c from ??? > It crash for me with free memory already free. > So this fix it. > > Index: tex.c > === > --- tex.c (revision 1494)