Re: [Warzone-dev] g++ fixes again

2007-05-25 Thread Per Inge Mathisen
On 5/25/07, Dennis Schridde [EMAIL PROTECTED] wrote: Am Freitag, 25. Mai 2007 schrieb Giel van Schijndel: Patch is attached for review. I haven't looked into a typedef solution to eliminate the struct keyword yet, so if you happen to know one right away, please tell me. Sorry forgot

Re: [Warzone-dev] g++ fixes again

2007-05-25 Thread Giel van Schijndel
Per Inge Mathisen schreef: On 5/25/07, Dennis Schridde [EMAIL PROTECTED] wrote: Am Freitag, 25. Mai 2007 schrieb Giel van Schijndel: Patch is attached for review. I haven't looked into a typedef solution to eliminate the struct keyword yet, so if you happen to know one right away,

Re: [Warzone-dev] g++ fixes again

2007-05-25 Thread Per Inge Mathisen
On 5/25/07, Giel van Schijndel [EMAIL PROTECTED] wrote: Can I interpret this as that you actually prefer to see the struct keyword in declarations ? Yes. - Per ___ Warzone-dev mailing list Warzone-dev@gna.org

Re: [Warzone-dev] g++ fixes again

2007-05-24 Thread Giel van Schijndel
Christian Ohm schreef: On Wednesday, 23 May 2007 at 22:46, Giel van Schijndel wrote: Christian Ohm schreef: Some g++ fixes again. new is a reserved keyword, a few casts, and I've moved OggVorbisDecoderState into oggvorbis.h, there was a linker error when it was typedeffed to void in

Re: [Warzone-dev] g++ fixes again

2007-05-23 Thread Per Inge Mathisen
On 5/23/07, Christian Ohm [EMAIL PROTECTED] wrote: Some g++ fixes again. Most of these are good, but do we need fixes of this kind?: - buffer = malloc(bufferSize + sizeof(soundDataBuffer)); + buffer = (soundDataBuffer*) malloc(bufferSize + sizeof(soundDataBuffer)); Please just use

Re: [Warzone-dev] g++ fixes again

2007-05-23 Thread Giel van Schijndel
Christian Ohm schreef: Some g++ fixes again. new is a reserved keyword, a few casts, and I've moved OggVorbisDecoderState into oggvorbis.h, there was a linker error when it was typedeffed to void in some cases. Don't know why it was done that way, still works for me now. I've removed an #ifdef

Re: [Warzone-dev] g++ fixes again

2007-05-23 Thread Dennis Schridde
Am Mittwoch, 23. Mai 2007 schrieb Per Inge Mathisen: On 5/23/07, Christian Ohm [EMAIL PROTECTED] wrote: Some g++ fixes again. Most of these are good, but do we need fixes of this kind?: - buffer = malloc(bufferSize + sizeof(soundDataBuffer)); + buffer = (soundDataBuffer*)

Re: [Warzone-dev] g++ fixes again

2007-05-23 Thread Giel van Schijndel
Giel van Schijndel schreef: Christian Ohm schreef: Some g++ fixes again. new is a reserved keyword, a few casts, and I've moved OggVorbisDecoderState into oggvorbis.h, there was a linker error when it was typedeffed to void in some cases. Don't know why it was done that way, still works

Re: [Warzone-dev] g++ fixes again

2007-05-23 Thread vs2k5
On Wed, 23 May 2007 17:12:02 -0400 Per Inge Mathisen [EMAIL PROTECTED] wrote: On 5/23/07, Dennis Schridde [EMAIL PROTECTED] wrote: Most of these are good, but do we need fixes of this kind?: - buffer = malloc(bufferSize + sizeof(soundDataBuffer)); + buffer = (soundDataBuffer*)

Re: [Warzone-dev] g++ fixes again

2007-05-23 Thread Giel van Schijndel
[EMAIL PROTECTED] schreef: On Wed, 23 May 2007 17:12:02 -0400 Per Inge Mathisen [EMAIL PROTECTED] wrote: On 5/23/07, Dennis Schridde [EMAIL PROTECTED] wrote: Most of these are good, but do we need fixes of this kind?: - buffer = malloc(bufferSize + sizeof(soundDataBuffer));

Re: [Warzone-dev] g++ fixes again

2007-05-23 Thread Christian Ohm
On Wednesday, 23 May 2007 at 22:42, Per Inge Mathisen wrote: On 5/23/07, Christian Ohm [EMAIL PROTECTED] wrote: Some g++ fixes again. Most of these are good, but do we need fixes of this kind?: - buffer = malloc(bufferSize + sizeof(soundDataBuffer)); + buffer =

Re: [Warzone-dev] g++ fixes again

2007-05-23 Thread Christian Ohm
On Wednesday, 23 May 2007 at 22:46, Giel van Schijndel wrote: Christian Ohm schreef: Some g++ fixes again. new is a reserved keyword, a few casts, and I've moved OggVorbisDecoderState into oggvorbis.h, there was a linker error when it was typedeffed to void in some cases. Don't know why it