Re: [Warzone-dev] XDR method considered harmful...

2007-07-18 Thread Freddie Witherden
I am not sure if this made its way to the mailing lists (sorry for posting it again if it has): On 18 Jul 2007, at 13:02, Per Inge Mathisen wrote: I was just working on something else, when it struck me how easily the XDR way of boundling read and write methods would break the code. Compare

Re: [Warzone-dev] Fwd: [patch] to allow 8bit text chars

2007-07-18 Thread Giel van Schijndel
Martin Koller schreef: On Wednesday 18 July 2007, Dennis Schridde wrote: The *xxx* names are just some strings which should never appear in the game, as they represent something special. So I don't think they should be translated, esp. since it could be hard with the abbreviations they

Re: [Warzone-dev] Fwd: [patch] to allow 8bit text chars

2007-07-18 Thread Dennis Schridde
Am Mittwoch, 18. Juli 2007 18:49:46 schrieb Giel van Schijndel: Martin Koller schreef: On Wednesday 18 July 2007, Dennis Schridde wrote: The *xxx* names are just some strings which should never appear in the game, as they represent something special. So I don't think they should be

Re: [Warzone-dev] Question about datatype

2007-07-18 Thread Martin Koller
On Tuesday 17 July 2007, Per Inge Mathisen wrote: On 7/17/07, Martin Koller [EMAIL PROTECTED] wrote: What about the follwing patch ? Just a quick glance at src/multibot.c tells me you missed cases. That will break multiplayer games badly, so it is important you catch them all. Do I see

Re: [Warzone-dev] Question about datatype

2007-07-18 Thread Per Inge Mathisen
On 7/18/07, Martin Koller [EMAIL PROTECTED] wrote: Do I see this correct, that NetAdd(m,4,psDroid-x); NetAdd(m,6,psDroid-y); adds the value psDroid-x/y at byte position 4/6 ? So that means x/y must be 2 bytes to make it work ? Yes. If so ... what a code .. :-( Indeed. It is on

Re: [Warzone-dev] Question about datatype

2007-07-18 Thread Martin Koller
On Wednesday 18 July 2007, Martin Koller wrote: It should better use a size counter and sizeof() instead. What do you think about the following approach: A new NETadd macro simply counts on its own what is given to its NETMSG. So e.g. sendHappyVtol() would change from: NETMSG m;

[Warzone-dev] going a bit to C++ ?

2007-07-18 Thread Martin Koller
Hi all, is there any interest in allowing to compile wz with a C++ compiler and allowing future additions to use C++ ? I made a simple check by compiling wz with g++ to see what happens. There are only about 250 errors, which are mainly invalid datatype conversions (e.g. not casting the

[Warzone-dev] [bug #9535] Assertion in proj_SendProjectile() after killing a droid

2007-07-18 Thread Roman
URL: http://gna.org/bugs/?9535 Summary: Assertion in proj_SendProjectile() after killing a droid Project: Warzone Resurrection Project Submitted by: troman Submitted on: Wednesday 07/18/2007 at 19:13 Category: None

Re: [Warzone-dev] going a bit to C++ ?

2007-07-18 Thread Per Inge Mathisen
On 7/18/07, Martin Koller [EMAIL PROTECTED] wrote: is there any interest in allowing to compile wz with a C++ compiler If you look at the coding style document (in the wiki), you'll see we require that patches remain C++ compatible. and allowing future additions to use C++ ? Not unless

Re: [Warzone-dev] going a bit to C++ ?

2007-07-18 Thread Martin Koller
On Wednesday 18 July 2007, Per Inge Mathisen wrote: On 7/18/07, Martin Koller [EMAIL PROTECTED] wrote: is there any interest in allowing to compile wz with a C++ compiler If you look at the coding style document (in the wiki), you'll see we require that patches remain C++ compatible.

Re: [Warzone-dev] going a bit to C++ ?

2007-07-18 Thread Freddie Witherden
On 18 Jul 2007, at 22:15, Martin Koller wrote: IMHO those things should be corrected even for plain C compilation, as it's kind of ugly and might hide bugs. No, you should not cast the value returned from malloc in C... you should not in the meaning of in C it is not needed or this

Re: [Warzone-dev] [Warzone-commits] r2130 - in /branches/2.0/debian: control rules

2007-07-18 Thread Angus Lees
On 7/17/07, Dennis Schridde [EMAIL PROTECTED] wrote: Author: devurandom Date: Tue Jul 17 22:42:52 2007 New Revision: 2130 URL: http://svn.gna.org/viewcvs/warzone?rev=2130view=rev Log: Port changes made in r2032 and r2033 by Angus Lees from tags/2.0.7 NOTE: In case tags/ has to be modified, it