Re: [Warzone-dev] [Warzone-commits] r5232 - /tags/2.1_beta3/src/droid.c

2008-06-10 Thread Per Inge Mathisen
On Tue, Jun 10, 2008 at 12:23 AM, Dennis Schridde [EMAIL PROTECTED] wrote: We are: - Defining DEBUG on debug builds and not otherwise. - Defining NDEBUG to shutup asserts. It also seems inconsistent to sometimes decide depending on DEBUG and sometimes depending on NDEBUG, for the same case

Re: [Warzone-dev] [Warzone-commits] r5232 - /tags/2.1_beta3/src/droid.c

2008-06-10 Thread Dennis Schridde
Am Dienstag, 10. Juni 2008 08:09:19 schrieb Per Inge Mathisen: On Tue, Jun 10, 2008 at 12:23 AM, Dennis Schridde [EMAIL PROTECTED] wrote: We are: - Defining DEBUG on debug builds and not otherwise. - Defining NDEBUG to shutup asserts. It also seems inconsistent to sometimes decide

Re: [Warzone-dev] [Warzone-commits] r5232 - /tags/2.1_beta3/src/droid.c

2008-06-10 Thread Freddie Witherden
Hi all, A non-debug build *should* #define NDEBUG (to shut up the ASSERTs among others). Hence I think the better fix would be to #define NDEBUG in the XCode project when producing a non-debug build. #ifndef DEBUG seems more than sufficient. More consistent too. Inconsistent

Re: [Warzone-dev] [Warzone-commits] r5232 - /tags/2.1_beta3/src/droid.c

2008-06-09 Thread Giel van Schijndel
Freddie Witherden schreef: Author: evilguru Date: Sat Jun 7 23:07:33 2008 New Revision: 5232 URL: http://svn.gna.org/viewcvs/warzone?rev=5232view=rev Log: Fix non-debug compilation on OS X A non-debug build *should* #define NDEBUG (to shut up the ASSERTs among others). Hence I think the

Re: [Warzone-dev] [Warzone-commits] r5232 - /tags/2.1_beta3/src/droid.c

2008-06-09 Thread Dennis Schridde
Am Montag, 9. Juni 2008 22:53:48 schrieb Giel van Schijndel: Freddie Witherden schreef: Author: evilguru Date: Sat Jun 7 23:07:33 2008 New Revision: 5232 URL: http://svn.gna.org/viewcvs/warzone?rev=5232view=rev Log: Fix non-debug compilation on OS X A non-debug build *should*