Re: [Warzone-dev] Just a few comments about a few commits
On Saturday, 25 July 2009 at 23:11, bugs buggy wrote:
Revision: 7842
http://warzone2100.svn.sourceforge.net/warzone2100/?rev=7842view=rev
Author: zarelsl
Date: 2009-07-13 21:10:49 + (Mon, 13 Jul 2009)
2.2: Fix possible buffer overflow in missionFlyTransportersIn and
getLandingX/Y.
How does this fix anything?
These should be asserts (so we can find the real cause), and this code
fragment in getLandingX() and getLandingY() is just wrong:
if ((unsigned int) iPlayer 8)
{
iPlayer = 8;
}
You can't make that assumption, and you are possibly introducing more
bugs with that.
That was a reaction to gcc reporting a warning (that stops compilation with
-Werror) array subscript is above array bounds when optimizing. Actually
retrying now (with r7842 reverted) I get:
mission.c: In function ‘saveMissionData’:
mission.c:3291: error: array subscript is above array bounds
mission.c:3291: error: array subscript is above array bounds
So gcc tries to inline getLandingX in saveMissionData - if I use
static LANDING_ZONE sLandingZone[MAX_NOGO_AREAS+1];
instead of
static LANDING_ZONE sLandingZone[MAX_NOGO_AREAS];
the warning disappears. So somewhere we get a possible 9 for the player number
there...
Revision: 7887
http://warzone2100.svn.sourceforge.net/warzone2100/?rev=7887view=rev
Author: zarelsl
Date: 2009-07-19 22:26:54 + (Sun, 19 Jul 2009)
2.2: Stop rotation when Continue is pressed after winning a
multiplayer/skirmish game.
IIRC, the whole reason behind this, was so you can't 'continue' the
game as normal, ie, it is mainly to fire the fireworks, to show you,
you won, or lost. This could introduce more bugs, since your screwing
with the original design, and you haven't modified any of the scripts
for the win/loss stuff.
Which means, that in the least, I would add a info(Game has ended),
or perhaps a addDumpInfo(Game has ended), so we can weed out crash
reports when people continue after a win/loss.
The dumpinfo sounds good, and a warning in the release notes perhaps.
Revision: 7891
http://warzone2100.svn.sourceforge.net/warzone2100/?rev=7891view=rev
Author: zarelsl
Date: 2009-07-22 22:12:41 + (Wed, 22 Jul 2009)
Index terrain textures (~68 MB - ~22 MB); idea suggested by i-NoD.
... I thought any big data changes should be brought to the attention
of the ML for comments. True, in this case, since most everyone is
away, it wouldn't have made a difference, but it would have been nice.
I also don't think this was required per se, perhaps when we would
have branched 2.3...
I haven't compared screenshots yet, but I think the new textures look
different.
___
Warzone-dev mailing list
Warzone-dev@gna.org
https://mail.gna.org/listinfo/warzone-dev
Re: [Warzone-dev] Just a few comments about a few commits
Am Sonntag, 26. Juli 2009 05:11:55 schrieb bugs buggy: Revision: 7891 http://warzone2100.svn.sourceforge.net/warzone2100/?rev=7891view=rev Author: zarelsl Date: 2009-07-22 22:12:41 + (Wed, 22 Jul 2009) Index terrain textures (~68 MB - ~22 MB); idea suggested by i-NoD. ... I thought any big data changes should be brought to the attention of the ML for comments. True, in this case, since most everyone is away, it wouldn't have made a difference, Who is away? Speaking at least for me: I am still watching, even if you do not see much of me. --devu ___ Warzone-dev mailing list Warzone-dev@gna.org https://mail.gna.org/listinfo/warzone-dev
Re: [Warzone-dev] Just a few comments about a few commits
On 7/26/09, Dennis Schridde devurxx...@gmx.net wrote: Am Sonntag, 26. Juli 2009 05:11:55 schrieb bugs buggy: Revision: 7891 http://warzone2100.svn.sourceforge.net/warzone2100/?rev=7891view=rev Author: zarelsl Date: 2009-07-22 22:12:41 + (Wed, 22 Jul 2009) Index terrain textures (~68 MB - ~22 MB); idea suggested by i-NoD. ... I thought any big data changes should be brought to the attention of the ML for comments. True, in this case, since most everyone is away, it wouldn't have made a difference, Who is away? Speaking at least for me: I am still watching, even if you do not see much of me. The better question is, who isn't away? AFAIK, only Per Zarel Cybersphinx (Christian) are fairly active looking at the commit list this past month. ___ Warzone-dev mailing list Warzone-dev@gna.org https://mail.gna.org/listinfo/warzone-dev
Re: [Warzone-dev] Just a few comments about a few commits
On Sat, Jul 25, 2009 at 10:11 PM, bugs buggybuginato...@gmail.com wrote:
Revision: 7842
http://warzone2100.svn.sourceforge.net/warzone2100/?rev=7842view=rev
Author: zarelsl
Date: 2009-07-13 21:10:49 + (Mon, 13 Jul 2009)
2.2: Fix possible buffer overflow in missionFlyTransportersIn and
getLandingX/Y.
How does this fix anything?
These should be asserts (so we can find the real cause), and this code
fragment in getLandingX() and getLandingY() is just wrong:
if ((unsigned int) iPlayer 8)
{
iPlayer = 8;
}
You can't make that assumption, and you are possibly introducing more
bugs with that.
I discussed this with cybersphinx before committing, and we've
discussed on IRC again why it's a perfectly valid assumption to make.
I'll go update the numbers to use the #defined ones, okay? =/
Revision: 7887
http://warzone2100.svn.sourceforge.net/warzone2100/?rev=7887view=rev
Author: zarelsl
Date: 2009-07-19 22:26:54 + (Sun, 19 Jul 2009)
2.2: Stop rotation when Continue is pressed after winning a
multiplayer/skirmish game.
IIRC, the whole reason behind this, was so you can't 'continue' the
game as normal, ie, it is mainly to fire the fireworks, to show you,
you won, or lost. This could introduce more bugs, since your screwing
with the original design, and you haven't modified any of the scripts
for the win/loss stuff.
Which means, that in the least, I would add a info(Game has ended),
or perhaps a addDumpInfo(Game has ended), so we can weed out crash
reports when people continue after a win/loss.
Sure, go ahead and do that, or I will at some point.
Seriously, I would've modified the scripts for win/loss stuff, but
they don't make any sense at all. Where does a loss disconnect a
player? I still can't find that code. Please _please_ point me to it;
I've been asking for months.
Revision: 7891
http://warzone2100.svn.sourceforge.net/warzone2100/?rev=7891view=rev
Author: zarelsl
Date: 2009-07-22 22:12:41 + (Wed, 22 Jul 2009)
Index terrain textures (~68 MB - ~22 MB); idea suggested by i-NoD.
... I thought any big data changes should be brought to the attention
of the ML for comments. True, in this case, since most everyone is
away, it wouldn't have made a difference, but it would have been nice.
I also don't think this was required per se, perhaps when we would
have branched 2.3...
Erm, I never heard this. Why? I mean, it's not exactly a controversial change.
-Zarel
___
Warzone-dev mailing list
Warzone-dev@gna.org
https://mail.gna.org/listinfo/warzone-dev
Re: [Warzone-dev] Just a few comments about a few commits
Am Sonntag, 26. Juli 2009 20:05:20 schrieb bugs buggy: On 7/26/09, Dennis Schridde devurxx...@gmx.net wrote: Am Sonntag, 26. Juli 2009 05:11:55 schrieb bugs buggy: Revision: 7891 http://warzone2100.svn.sourceforge.net/warzone2100/?rev=7891view=rev Author: zarelsl Date: 2009-07-22 22:12:41 + (Wed, 22 Jul 2009) Index terrain textures (~68 MB - ~22 MB); idea suggested by i-NoD. ... I thought any big data changes should be brought to the attention of the ML for comments. True, in this case, since most everyone is away, it wouldn't have made a difference, Who is away? Speaking at least for me: I am still watching, even if you do not see much of me. The better question is, who isn't away? AFAIK, only Per Zarel Cybersphinx (Christian) are fairly active looking at the commit list this past month. True. I am just actively looking at the commit list. ;) ___ Warzone-dev mailing list Warzone-dev@gna.org https://mail.gna.org/listinfo/warzone-dev
[Warzone-dev] Just a few comments about a few commits
Revision: 7842
http://warzone2100.svn.sourceforge.net/warzone2100/?rev=7842view=rev
Author: zarelsl
Date: 2009-07-13 21:10:49 + (Mon, 13 Jul 2009)
2.2: Fix possible buffer overflow in missionFlyTransportersIn and
getLandingX/Y.
How does this fix anything?
These should be asserts (so we can find the real cause), and this code
fragment in getLandingX() and getLandingY() is just wrong:
if ((unsigned int) iPlayer 8)
{
iPlayer = 8;
}
You can't make that assumption, and you are possibly introducing more
bugs with that.
Revision: 7887
http://warzone2100.svn.sourceforge.net/warzone2100/?rev=7887view=rev
Author: zarelsl
Date: 2009-07-19 22:26:54 + (Sun, 19 Jul 2009)
2.2: Stop rotation when Continue is pressed after winning a
multiplayer/skirmish game.
IIRC, the whole reason behind this, was so you can't 'continue' the
game as normal, ie, it is mainly to fire the fireworks, to show you,
you won, or lost. This could introduce more bugs, since your screwing
with the original design, and you haven't modified any of the scripts
for the win/loss stuff.
Which means, that in the least, I would add a info(Game has ended),
or perhaps a addDumpInfo(Game has ended), so we can weed out crash
reports when people continue after a win/loss.
Revision: 7891
http://warzone2100.svn.sourceforge.net/warzone2100/?rev=7891view=rev
Author: zarelsl
Date: 2009-07-22 22:12:41 + (Wed, 22 Jul 2009)
Index terrain textures (~68 MB - ~22 MB); idea suggested by i-NoD.
... I thought any big data changes should be brought to the attention
of the ML for comments. True, in this case, since most everyone is
away, it wouldn't have made a difference, but it would have been nice.
I also don't think this was required per se, perhaps when we would
have branched 2.3...
This is just the commits that caught my attention so far...
___
Warzone-dev mailing list
Warzone-dev@gna.org
https://mail.gna.org/listinfo/warzone-dev
