[Warzone-dev] Commit policies

2008-06-16 Thread Per Inge Mathisen
Hello all, We need to implement some stricter commit policies and focus more on quality control and avoiding patch conflicts. Here is what I would like to see: 1) Every patch goes into the patch tracker. Give a quick run down of what it does and what it changes. 2) After a patch has been put in

Re: [Warzone-dev] Commit policies

2008-06-16 Thread Dennis Luxen
Hello, > We need to implement some stricter commit policies and focus more on > quality control and avoiding patch conflicts. Although, I have contributed only once until now, I do see these problems as well. > Here is what I would like to see: > 1) Every patch goes into the patch tracker. Giv

Re: [Warzone-dev] Commit policies

2008-06-16 Thread Giel van Schijndel
Per Inge Mathisen schreef: Here is what I would like to see: 1) Every patch goes into the patch tracker. Give a quick run down of what it does and what it changes. 2) After a patch has been put into the patch tracker, give this list 48 hours to comment on it. Exception for patches that *only* f

Re: [Warzone-dev] Commit policies

2008-06-16 Thread Per Inge Mathisen
On Mon, Jun 16, 2008 at 9:21 PM, Giel van Schijndel <[EMAIL PROTECTED]> wrote: > Per Inge Mathisen schreef: >> >> Here is what I would like to see: >> 1) Every patch goes into the patch tracker. Give a quick run down of >> what it does and what it changes. >> 2) After a patch has been put into th

Re: [Warzone-dev] Commit policies

2008-06-16 Thread Giel van Schijndel
Per Inge Mathisen schreef: On Mon, Jun 16, 2008 at 9:21 PM, Giel van Schijndel <[EMAIL PROTECTED]> wrote: Per Inge Mathisen schreef: Here is what I would like to see: 1) Every patch goes into the patch tracker. Give a quick run down of what it does and what it changes. 2) After a patc

[Warzone-dev] Commit guidelines

2008-06-16 Thread Per Inge Mathisen
After some discussion, I would like to soften the suggestion a bit: Commit guidelines: 1) All larger patches should go into the patch tracker. Give people time to comment on it. Add yourself to the cc: list of patches you are interested in. 2) Try to break up larger changes into smaller patches wh

[Warzone-dev] patch #969: Rewritten minimap code, ready for testing

2008-06-16 Thread Per Inge Mathisen
I would like someone to take a look at patch #969: Rewritten minimap code. It changes the familiar radar window quite a bit. Instead of zoom and pan, the window always contains the entire map, and you can enlarge or shrink the radar window using the scroll wheel when the cursor is over the radar wi

Re: [Warzone-dev] Commit guidelines

2008-06-16 Thread Giel van Schijndel
Per Inge Mathisen schreef: After some discussion, I would like to soften the suggestion a bit: Commit guidelines: 1) All larger patches should go into the patch tracker. Give people time to comment on it. Add yourself to the cc: list of patches you are interested in. 2) Try to break up larger ch

Re: [Warzone-dev] Music

2008-06-16 Thread Angus Lees
On Sun, Jun 15, 2008 at 12:17 PM, Per Inge Mathisen <[EMAIL PROTECTED]> wrote: > I would like to commit the original game music to the repository under > base/music. I ripped it directly from the game CDs, using normal ogg > compression. Any objections? > > The music playing patch that is attached

Re: [Warzone-dev] Commit policies

2008-06-16 Thread Dennis Schridde
Am Montag, 16. Juni 2008 21:47:16 schrieb Giel van Schijndel: > Per Inge Mathisen schreef: > > On Mon, Jun 16, 2008 at 9:21 PM, Giel van Schijndel <[EMAIL PROTECTED]> > > wrote: > >> Per Inge Mathisen schreef: > >>> Here is what I would like to see: > >>> 1) Every patch goes into the patch tracke

Re: [Warzone-dev] Commit guidelines

2008-06-16 Thread Dennis Schridde
Am Montag, 16. Juni 2008 23:25:54 schrieb Giel van Schijndel: > Per Inge Mathisen schreef: > > After some discussion, I would like to soften the suggestion a bit: > > > > Commit guidelines: > > 1) All larger patches should go into the patch tracker. Give people > > time to comment on it. Add yourse

Re: [Warzone-dev] patch #969: Rewritten minimap code, ready for testing

2008-06-16 Thread Dennis Schridde
Am Montag, 16. Juni 2008 23:16:30 schrieb Per Inge Mathisen: > I would like someone to take a look at patch #969: Rewritten minimap > code. It changes the familiar radar window quite a bit. Instead of > zoom and pan, the window always contains the entire map, and you can > enlarge or shrink the rad

Re: [Warzone-dev] Commit guidelines

2008-06-16 Thread bugs buggy
On 6/16/08, Per Inge Mathisen <[EMAIL PROTECTED]> wrote: > After some discussion, I would like to soften the suggestion a bit: > > Commit guidelines: > 1) All larger patches should go into the patch tracker. Give people > time to comment on it. Add yourself to the cc: list of patches you are >

Re: [Warzone-dev] Music

2008-06-16 Thread Per Inge Mathisen
On Tue, Jun 17, 2008 at 12:17 AM, Angus Lees <[EMAIL PROTECTED]> wrote: > Can we keep the original files losslessly compressed (using something like > flac, perhaps) for posterity? or are the flac files still too large to put > through our repository? I do not think they are too large, as long as

Re: [Warzone-dev] patch #969: Rewritten minimap code, ready for testing

2008-06-16 Thread Per Inge Mathisen
On Tue, Jun 17, 2008 at 12:43 AM, Dennis Schridde <[EMAIL PROTECTED]> wrote: > So you cannot zoom into just a part of the map anymore? Correct. > Is there the possibility for a split mode? > Like having the minimap as it is now, and when pressing ..."m"... it brings up > a fullscreen (or rather:

Re: [Warzone-dev] Commit guidelines

2008-06-16 Thread Per Inge Mathisen
On Tue, Jun 17, 2008 at 6:57 AM, bugs buggy <[EMAIL PROTECTED]> wrote: > I would also like to add, *test* your patch, and if you can't, then > please let others know. Yes, good point. More testing before commits are made would be very welcome. I play a bit with rush2, load a savegame, try to play