Re: It is time for wave

2012-01-18 Thread Vicente J. Ruiz Jurado
The client deltas not expressed against server bug, but maybe both are related because I don't get a No conversations since a long time ago.

Re: FundWIAB.com main page patch

2012-01-18 Thread Christian Grobmeier
Hello Kirill, first feedback from the incubator is positiv. One suggestion has come up from Bertrand Delacretaz so far which I would like to recommend to you: I agree, just one minor thing, they say we will commit all patches into the main tree but it's the Wave PMC who's in control of

Re: FundWIAB.com main page patch

2012-01-18 Thread Yuri Z
please submit your patch for index page for review On Jan 18, 2012 4:36 PM, Kirill Kostyuchenko kisel2...@gmail.com wrote: Hello Christian and Upayavira! I added, that Apache Wave is a trademark of the ASF, but it's not listed as a trademark here http://www.apache.org/foundation/marks/list/

Re: Wave with HTTPS?

2012-01-18 Thread Vicente J. Ruiz Jurado
El 18/01/12 00:20, Ali Lown escribió: I had a go at setting it up and yes this method of adjusting jetty seems to work fine. Over the next couple of days I will have a go at writing a patch so that we can choose between ssl (and normal) listeners, keystore location and password all from the

Re: FundWIAB.com main page patch

2012-01-18 Thread Kirill Kostyuchenko
Please inform, how I can get svn of index.html to create patch? When I try to send the patch created with diff againist downloaded index I got 'Unable to parse diff revision header '2012-01-17 23:20:22.906139482 +0600'. ? 2012/1/18 Yuri Z vega...@gmail.com The patches are usually reviewed at

Re: WiaB client code usage in the wild (a.k.a Undercurrent in Blogger)

2012-01-18 Thread Yuri Z
Hi Patrick. First of all - congrats on the Blogger improvement - it's really great to see how GWave advancements slowly make it into mainstream. Regarding your suggestion - can you maybe describe what the the possible of the proposed change? Generally - removing dependencies - sounds great. Also,

Re: Wiki - Wave Store TODO's

2012-01-18 Thread Michael MacFadden
Doing so now. On Jan 17, 2012, at 1:55 PM, Yuri Z wrote: Good, it means you are in good shape to review my patch :) https://reviews.apache.org/r/3508/ On Tue, Jan 17, 2012 at 11:36 PM, Michael MacFadden michael.macfad...@gmail.com wrote: I recently, just went through most of the OT,

Re: Review Request: Decouple the search implementation from the waves persistence logic.

2012-01-18 Thread Michael MacFadden
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3508/#review4437 --- I went through the files in order of the diffs. It wasn't until I

Re: Review Request: WAVE-298: Wave doesn't compile: error: no suitable method found for thenReturn(StringTokenizer)

2012-01-18 Thread Yuri Zelikov
On 2011-11-26 10:12:55, Yuri Zelikov wrote: Thanks for contributing to the Apache Wave project. Besides minor comments this patch LGTM. I will address the comments by myself and commit if it's OK with you. Antonio Bello wrote: Yeah sure - thanks for fixing my code. I think I

Re: Review Request: Sets the current wave title also as the browser window title

2012-01-18 Thread Michael MacFadden
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3530/#review4442 --- Looks pretty good. My only large comment was in regards to extending

Re: Review Request: Sets the current wave title also as the browser window title

2012-01-18 Thread Daniel Danilatos
You can also try Range range = TitleHelper.findImplicitTitle(rootDoc); return DocHelper.getText(rootDoc, range.getStart(), range.getEnd()); Normally there won't be a title unless something is calling TitleHelper.maybeFindAndSetImplicitTitle on the document? Dan On Thu, Jan 19, 2012 at 7:42 AM,

Re: Review Request: Sets the current wave title also as the browser window title

2012-01-18 Thread Yuri Zelikov
On 2012-01-18 20:42:51, Michael MacFadden wrote: src/org/waveprotocol/wave/client/wavepanel/WavePanel.java, line 52 https://reviews.apache.org/r/3530/diff/1/?file=69700#file69700line52 I noticed that this method was added to this listener interface. However, every class that