Review Request: Import GWave waves to Wiab.

2012-01-20 Thread Andrew Kaplanov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3564/ --- Review request for wave and Yuri Zelikov. Summary --- Exports waves from

Re: Review Request: Import GWave waves to Wiab.

2012-01-20 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3564/#review4490 --- Hi Andrew Thanks for the effort. It seems like your patch includes

ICLA (was: Re: Review Request: Import GWave waves to Wiab.)

2012-01-20 Thread Christian Grobmeier
Hey folks, please don't forget, if you provide so huge patches at the one from Andrew below to sign an ICLA (Contributor License Agreement). The ASF desires that all contributors of ideas, code, or documentation to the Apache projects complete, sign, and submit (via postal mail, fax or email) an

Re: ICLA (was: Re: Review Request: Import GWave waves to Wiab.)

2012-01-20 Thread Yuri Z
Probably it would be great if other active contributors that didn't submitted the ICLA would do do it now. On Fri, Jan 20, 2012 at 5:08 PM, Christian Grobmeier grobme...@gmail.comwrote: Hey folks, please don't forget, if you provide so huge patches at the one from Andrew below to sign an

Re: ICLA (was: Re: Review Request: Import GWave waves to Wiab.)

2012-01-20 Thread Christian Grobmeier
On Fri, Jan 20, 2012 at 4:20 PM, Yuri Z vega...@gmail.com wrote: Probably it would be great if other active contributors that didn't submitted the ICLA would do do it now. +1 On Fri, Jan 20, 2012 at 5:08 PM, Christian Grobmeier grobme...@gmail.comwrote: Hey folks, please don't forget,

Re: ICLA (was: Re: Review Request: Import GWave waves to Wiab.)

2012-01-20 Thread Michael MacFadden
I agree, this is also part of the path for new contributors to become committers. ~Michael On Jan 20, 2012, at 7:20 AM, Yuri Z wrote: Probably it would be great if other active contributors that didn't submitted the ICLA would do do it now. On Fri, Jan 20, 2012 at 5:08 PM, Christian

Re: Review Request: Sets the current wave title also as the browser window title

2012-01-20 Thread Yuri Zelikov
On 2012-01-18 20:42:51, Michael MacFadden wrote: src/org/waveprotocol/wave/client/doodad/title/TitleAnnotationHandler.java, line 50 https://reviews.apache.org/r/3530/diff/1/?file=69698#file69698line50 This was made public. But I don't see that it us used anywhere outside of