----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3564/#review4490 -----------------------------------------------------------
Hi Andrew Thanks for the effort. It seems like your patch includes project related files. Can you please remove them. I suggest that you would import the WIAB project into Eclipse and then add the additional files into the WIAB project. Also, WIAB already have almost all jars that you want to add in the /third_party folder, please make sure you use the existing third party libraries instead oaf adding all the required dependencies again. Another point is that All newly created class should include the header with Apache License (please take a look at any java class in the WIAB source for example) Regarding the java format style - WIAB uses two space indentation and each line length is limited by 100 characters. Please make sure there are no double empty lines or trailing white spaces. If you have more questions - please send me email or even we can talk via Skype or GTalk. - Yuri On 2012-01-20 13:48:50, Andrew Kaplanov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3564/ > ----------------------------------------------------------- > > (Updated 2012-01-20 13:48:50) > > > Review request for wave and Yuri Zelikov. > > > Summary > ------- > > Exports waves from GWave to files, and imports them to Wiab by two command > line utilities. > The implementation is very raw, due to time constraints. > Import accesses special service on the Wiab. > Authorization on import service are not implemented now. > To access GWave was used Walkaround with GAE libraries. > Later, when GWave stop, this module can be used to export/import waves of > Wiab. > Then Walkaround and GAE libraries may be excluded from the distribution. > Imports of attachments not yet implemented. > Also, there is no generation of wave Id's for import into a non-empty store, > and from different domains. > Instructions for use enclosed in the file README. > GIT repository https://github.com/jorkey/WaveImport. > > > Diffs > ----- > > ./import/ant/org-netbeans-modules-java-j2seproject-copylibstask.jar UNKNOWN > ./import/build.xml PRE-CREATION > ./import/nbproject/build-impl.xml PRE-CREATION > ./import/README PRE-CREATION > ./import/nbproject/configs/import.properties PRE-CREATION > ./import/nbproject/genfiles.properties PRE-CREATION > ./import/nbproject/private/config.properties PRE-CREATION > ./import/nbproject/private/configs/export.properties PRE-CREATION > ./import/nbproject/private/configs/import.properties PRE-CREATION > ./import/nbproject/private/private.properties PRE-CREATION > ./import/nbproject/private/private.xml PRE-CREATION > ./import/nbproject/project.properties PRE-CREATION > ./import/nbproject/project.xml PRE-CREATION > ./import/run-build PRE-CREATION > ./import/run-export PRE-CREATION > ./import/run-import PRE-CREATION > ./import/src/waveimport/RobotApi.java PRE-CREATION > ./import/src/waveimport/WaveExport.java PRE-CREATION > ./import/src/waveimport/WaveImport.java PRE-CREATION > ./import/third_party/libs/appengine-api-stubs.jar UNKNOWN > ./import/third_party/libs/appengine-api.jar UNKNOWN > ./import/third_party/libs/appengine-local-runtime.jar UNKNOWN > ./import/third_party/libs/commons-cli-1.2.jar UNKNOWN > ./import/third_party/libs/commons-codec-1.5.jar UNKNOWN > ./import/third_party/libs/communication.jar UNKNOWN > ./import/third_party/libs/google-api-client-1.5.0-beta.jar UNKNOWN > ./import/third_party/libs/google-http-client-1.5.0-beta.jar UNKNOWN > ./import/third_party/libs/google-http-client-extensions-1.5.0-beta.jar > UNKNOWN > ./import/third_party/libs/google-oauth-client-1.5.0-beta.jar UNKNOWN > ./import/third_party/libs/gson-1.7.1.jar UNKNOWN > ./import/third_party/libs/guava-10.0.1.jar UNKNOWN > ./import/third_party/libs/guice-3.0.jar UNKNOWN > ./import/third_party/libs/guice-assistedinject-3.0.jar UNKNOWN > ./import/third_party/libs/guice-servlet-3.0.jar UNKNOWN > ./import/third_party/libs/gxp-0.2.4-beta.jar UNKNOWN > ./import/third_party/libs/jackson-core-asl-1.6.7.jar UNKNOWN > ./import/third_party/libs/javax.inject.jar UNKNOWN > ./import/third_party/libs/jsr305.jar UNKNOWN > ./import/third_party/libs/junit-4.10.jar UNKNOWN > ./import/third_party/libs/model.jar UNKNOWN > ./import/third_party/libs/oauth-common-src.jar UNKNOWN > ./import/third_party/libs/oauth-common.jar UNKNOWN > ./import/third_party/libs/oauth-consumer-src.jar UNKNOWN > ./import/third_party/libs/oauth-consumer.jar UNKNOWN > ./import/third_party/libs/oauth-provider-src.jar UNKNOWN > ./import/third_party/libs/oauth-provider.jar UNKNOWN > ./import/third_party/libs/protobuf.jar UNKNOWN > ./import/third_party/libs/servlet-api-3.0.jar UNKNOWN > ./import/third_party/libs/wave-api-0.3.jar UNKNOWN > ./import/third_party/src/com/google/walkaround/proto/Diff.java PRE-CREATION > ./import/third_party/src/com/google/walkaround/proto/Extensions.java > PRE-CREATION > ./import/third_party/src/com/google/walkaround/proto/GoogleImport.java > PRE-CREATION > ./import/third_party/src/com/google/walkaround/proto/Proto.java > PRE-CREATION > ./import/third_party/src/com/google/walkaround/proto/RobotSearchDigest.java > PRE-CREATION > > ./import/third_party/src/com/google/walkaround/proto/RobotSearchDigestUtil.java > PRE-CREATION > ./import/third_party/src/com/google/walkaround/proto/Walkaround.java > PRE-CREATION > > ./import/third_party/src/com/google/walkaround/proto/gson/RobotSearchDigestGsonImpl.java > PRE-CREATION > > ./import/third_party/src/com/google/walkaround/proto/impl/RobotSearchDigestImpl.java > PRE-CREATION > > ./import/third_party/src/com/google/walkaround/util/server/MonitoringVars.java > PRE-CREATION > ./import/third_party/src/com/google/walkaround/util/server/RetryHelper.java > PRE-CREATION > ./import/third_party/src/com/google/walkaround/util/server/Util.java > PRE-CREATION > > ./import/third_party/src/com/google/walkaround/util/server/flags/FlagDeclaration.java > PRE-CREATION > > ./import/third_party/src/com/google/walkaround/util/server/flags/FlagFormatException.java > PRE-CREATION > > ./import/third_party/src/com/google/walkaround/util/server/flags/JsonFlags.java > PRE-CREATION > > ./import/third_party/src/com/google/walkaround/wave/server/DatastoreProvider.java > PRE-CREATION > ./import/third_party/src/com/google/walkaround/wave/server/Flag.java > PRE-CREATION > > ./import/third_party/src/com/google/walkaround/wave/server/FlagConfiguration.java > PRE-CREATION > ./import/third_party/src/com/google/walkaround/wave/server/FlagName.java > PRE-CREATION > ./import/third_party/src/com/google/walkaround/wave/server/StoreType.java > PRE-CREATION > > ./import/third_party/src/com/google/walkaround/wave/server/auth/NeedNewOAuthTokenException.java > PRE-CREATION > > ./import/third_party/src/com/google/walkaround/wave/server/auth/OAuthCredentials.java > PRE-CREATION > > ./import/third_party/src/com/google/walkaround/wave/server/auth/OAuthRequestHelper.java > PRE-CREATION > > ./import/third_party/src/com/google/walkaround/wave/server/auth/OAuthedFetchService.java > PRE-CREATION > > ./import/third_party/src/com/google/walkaround/wave/server/auth/StableUserId.java > PRE-CREATION > > ./import/third_party/src/com/google/walkaround/wave/server/auth/UserContext.java > PRE-CREATION > ./src/org/waveprotocol/box/server/ServerMain.java 1233819 > > Diff: https://reviews.apache.org/r/3564/diff > > > Testing > ------- > > > Thanks, > > Andrew > >
