Re: Questions about implementing 'linky' WAVE-275

2012-02-01 Thread Thomas Wrobel
Ah, this comes down to my ignorance of how the wave client works currently - but it sounds like EditorUpdateEvent is the core problem here. Can it not be modified to also return what key was last pressed? Or maybe the link checking can go within this event and the event itself modified? (links

Re: Questions about implementing 'linky' WAVE-275

2012-02-01 Thread Daniel Danilatos
The trouble is, as you've discovered, doing too much work on each event can really slow down the responsiveness. This is why EditorUpdateEvent is batched and rate limited by design, to prevent people from writing code that makes typing really unresponsive. Internally, the editor gets every key

Re: Questions about implementing 'linky' WAVE-275

2012-02-01 Thread Thomas Wrobel
I think your way is better in that case. I was just trying to think of the most simple method. I guess you could adapt the EditorUpdateEvent to accept a listener for a specific set of letters and it only fires the specified commands if it sees that sequence. But I guess this is generic as it

Re: Questions about implementing 'linky' WAVE-275

2012-01-31 Thread Ali Lown
On 9 December 2011 00:09, Yuri Z vega...@gmail.com wrote: I don't think that Linky should be implemented as robot/robot agent. I guess you can just register listener on update events and then insert the link annotation whenever text in the edited blip looks like a URL. I have now closed the

Re: Questions about implementing 'linky' WAVE-275

2012-01-31 Thread Thomas Wrobel
I guess because robots then increase bandwidth(as the server needs to send back the update befor you see it change). Probably would look more laggy. Id steer well clear of client side Regexs for something continuously checked like this. Why not just remember the last few letters typed? If its

Re: Questions about implementing 'linky' WAVE-275

2012-01-31 Thread Ali Lown
Id steer well clear of client side Regexs for something continuously checked like this. I did precisely because I knew it would only end badly. Why not just remember the last few letters typed? If only that sort of information was available. The API for this sort of thing is the

Re: Questions about implementing 'linky' WAVE-275

2012-01-31 Thread Daniel Danilatos
An idea to solve the speed problem: There is no API for this currently, but it would be fairly straight forward to listen to the operation stream coming out of the document, which would give you precise, fine-grained knowledge of where changes are occurring and what they are. The only issue here

Re: Questions about implementing 'linky' WAVE-275

2011-12-15 Thread Ali Lown
I don't seem to be able to do this. (Well I can't see any way to assign myself to a task?) A look through the documentation suggests I might need to be granted the Assign Issue/Assignable User permission be granted for the wave project first. On 9 December 2011 01:42, Thomas Wrobel

Re: Questions about implementing 'linky' WAVE-275

2011-12-15 Thread Yuri Z
Michael, can you please add Ali to Wave Jira? On Thu, Dec 15, 2011 at 11:14 PM, Ali Lown a...@lown.me.uk wrote: I don't seem to be able to do this. (Well I can't see any way to assign myself to a task?) A look through the documentation suggests I might need to be granted the Assign

Re: Questions about implementing 'linky' WAVE-275

2011-12-15 Thread Michael MacFadden
Should be done within the hour. Michael S. MacFadden Director of Research and Development SOLUTE Consulting 4250 Pacific Highway, Suite 211 San Diego, CA 92110 Office: (619) 758-9900 macfadden.mich...@solute.us www.solute.us CONFIDENTIALITY NOTICE: This e-mail and any attachments are

Re: Questions about implementing 'linky' WAVE-275

2011-12-15 Thread Michael MacFadden
Ali, You should be all set. On Dec 15, 2011, at 1:51 PM, Yuri Z wrote: Michael, can you please add Ali to Wave Jira? On Thu, Dec 15, 2011 at 11:14 PM, Ali Lown a...@lown.me.uk wrote: I don't seem to be able to do this. (Well I can't see any way to assign myself to a task?) A look through

Re: Questions about implementing 'linky' WAVE-275

2011-12-14 Thread Daniel Danilatos
Yup. And using EditorUpdateEvent is the right way to go (it's not to do with agents, as it's client-side). Dan On Fri, Dec 9, 2011 at 11:09 AM, Yuri Z vega...@gmail.com wrote: No, AFAIK the code is legacy from Google Wave. I don't think that Linky should be implemented as robot/robot agent. I

Re: Questions about implementing 'linky' WAVE-275

2011-12-14 Thread Ali Lown
Ok. Been away for a few days, but I will get some more time to look at it tonight. So far I have hooked in a class to the EditorUpdateEvent (following the style setout in WaveTitleHandler). Now I just need to parse the document for links. On Dec 15, 2011 6:43 AM, Daniel Danilatos

Questions about implementing 'linky' WAVE-275

2011-12-08 Thread Ali Lown
There seem to be a few references to 'linky' distributed through the code (in doodad/Link and doodad/Suggestion) does this mean someone else is already implementing this? The diagram on the old FAQ [0] suggests that linky was implemented as an agent. Does this mean that it should be implement as

Re: Questions about implementing 'linky' WAVE-275

2011-12-08 Thread Yuri Z
No, AFAIK the code is legacy from Google Wave. I don't think that Linky should be implemented as robot/robot agent. I guess you can just register listener on update events and then insert the link annotation whenever text in the edited blip looks like a URL. So your suggestions sound right to me.

Re: Questions about implementing 'linky' WAVE-275

2011-12-08 Thread Thomas Wrobel
If you tackle this, remember to assign yourself to; https://issues.apache.org/jira/browse/WAVE-275 :) ~~ Reviews of anything, by anyone; www.rateoholic.co.uk Please try out my new site and give feedback :) On 9 December 2011 01:09, Yuri Z vega...@gmail.com wrote: No, AFAIK the code is