[Wayland-bugs] [Bug 102649] Mouse taps (?) detected while typing

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=102649

--- Comment #48 from Rimas Kudelis  ---
Sorry, I didn't notice your previous message in my inbox.
I shall try 1.10 and see how it goes, but I can't commit to a particular
deadline with a response.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 102649] Mouse taps (?) detected while typing

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=102649

--- Comment #47 from Peter Hutterer  ---
ping?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105222] RFE: keyboard debouncing

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105222

Peter Hutterer  changed:

   What|Removed |Added

 Resolution|WONTFIX |---
 Status|RESOLVED|REOPENED

--- Comment #9 from Peter Hutterer  ---
thanks for the fix, it does show the problem a bit better. Main question now is
of course: can you make this trigger for normal sequences? e.g. hitting
backspace multiple times, typing mm or ll or any of the common sequences that
would cause a user to type fast enough? This is quite important to gauge
whether we'll have regressions.

What's the minimum debounce time you can get away with? I can get 23ms
press->release time but 38ms is the lowest for release->press. Together they
are still way above the 30ms that we have in that script measuring between
press and press. So I think the debounce may actually be viable after all.

Given the experience we had with wireless mice in the button debouncing code,
this should only be enabled for internal (serial bus?) keyboards. Probably only
on specific models known to have broken hardware.

> would you accept a patch to add keyboard debouncing along these lines?

I'll be honest, I'm not enthusiastic about it but depending how complex it is
and how well it fixes the issue, maybe. This is still a hardware bug and having
to work around this in software (and keeping that behaviour for the next
decade) doesn't exactly fill me with joy...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 103572] Libinput: 1.9+: Apple Magic Trackpad stutters, is unresponsive

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=103572

Peter Hutterer  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #39 from Peter Hutterer  ---
pushed, thanks. please re-open if the 60/40 is too high and we need to reduce
it further.

commit f47eb2d796ef459c52394681083d0110d56b4ce3
Author: Mario Di Raimondo <>
Date:   Thu Mar 1 11:52:35 2018 +0100

Fix Apple Magic Trackpad sensitivity

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105306] Make touchpad hysteresis omnidirectional

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105306

Peter Hutterer  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO
 CC||hi-an...@yandex.ru

--- Comment #5 from Peter Hutterer  ---
Konstantin, can you test attachment 137744 please to make sure it fixes or at
least doesn't introduce any other bugs? If not, then I'll push this asap.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105306] Make touchpad hysteresis omnidirectional

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105306

--- Comment #4 from Daniel van Vugt  ---
I ran it but found the picture confusing at first. Now I understand it is
distorted by the input data being square, and the result is good. Maybe a less
confusing plot might be to only plot a circle of input points.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105306] Make touchpad hysteresis omnidirectional

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105306

--- Comment #3 from Peter Hutterer  ---
Created attachment 137746
  --> https://bugs.freedesktop.org/attachment.cgi?id=137746=edit
hysteresis.gnuplot

For archiving purposes: a gnuplot script to visualize the output from
attachment 137745

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105306] Make touchpad hysteresis omnidirectional

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105306

--- Comment #2 from Peter Hutterer  ---
Created attachment 137745
  --> https://bugs.freedesktop.org/attachment.cgi?id=137745=edit
hysteresis-test.c

For archiving purposes: a little c program that outputs the two different
approaches, the one from here and the one from Bug 105018#c12

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105306] Make touchpad hysteresis omnidirectional

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105306

Peter Hutterer  changed:

   What|Removed |Added

 Blocks||104828


Referenced Bugs:

https://bugs.freedesktop.org/show_bug.cgi?id=104828
[Bug 104828] Wobbly AlpsPS/2 ALPS DualPoint TouchPad
-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 104828] Wobbly AlpsPS/2 ALPS DualPoint TouchPad

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=104828

Peter Hutterer  changed:

   What|Removed |Added

 Depends on||105306

--- Comment #37 from Peter Hutterer  ---
FTR the fix for bug 105306 should improve the behaviour even further


Referenced Bugs:

https://bugs.freedesktop.org/show_bug.cgi?id=105306
[Bug 105306] Make touchpad hysteresis omnidirectional
-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105306] Make touchpad hysteresis omnidirectional

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105306

Peter Hutterer  changed:

   What|Removed |Added

 Attachment #137715|0   |1
is obsolete||

--- Comment #1 from Peter Hutterer  ---
Created attachment 137744
  --> https://bugs.freedesktop.org/attachment.cgi?id=137744=edit
0001-Introduce-omnidirectional-elliptical-hysteresis.patch

rebased on master (400aadd5), typo fix in commit msg. no other changes

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 104828] Wobbly AlpsPS/2 ALPS DualPoint TouchPad

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=104828

Peter Hutterer  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEEDINFO|RESOLVED

--- Comment #36 from Peter Hutterer  ---
commit 400aadd53ac00ca773533d14e231ba192f4141a9
Author: Konstantin Kharlamov <...>
Date:   Wed Feb 21 20:16:41 2018 +0300

touchpad: add wobbling detection


I've pushed the patches for the wobble detection now, leaving out the patches
that use the fuzz until we're sure about what to do with Bug 105303

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 786693] wayland: fix fontconfig monitoring

[gtk+]

https://bugzilla.gnome.org/show_bug.cgi?id=786693

--- Comment #13 from Martin Blanchard  ---
(In reply to Bastien Nocera from comment #11)
> (In reply to Martin Blanchard from comment #9)
> > (In reply to Bastien Nocera from comment #8)
> > > It also looks easy enough to extend and add support for the 2 other
> > > GtkSettings if you're interested.
> > 
> > Hummm, isn't 'gtk-enable-animations' already implemented as a gsetting?
> 
> Yes, incorrectly so in the Wayland backend. In the X11 backend, animations
> are force-disabled if the GSettings is false, then controlled by
> gnome-settings-daemon, which will disable them if a software renderer is
> used, or an external VNC client is connected.

That makes sense. Shouldn't that be handled in a separate bug though?

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 786693] wayland: fix fontconfig monitoring

[gtk+]

https://bugzilla.gnome.org/show_bug.cgi?id=786693

Martin Blanchard  changed:

   What|Removed |Added

 Attachment #369118|needs-work  |none
 status||
 Attachment #369118|0   |1
is obsolete||

--- Comment #12 from Martin Blanchard  ---
Created attachment 369162
  --> https://bugzilla.gnome.org/attachment.cgi?id=369162=edit
'gtk-fontconfig-timestamp' and 'gtk-modules' for Wayland

Fifth version: Keep dbus connection's cancellable alive all along
GdkWaylandScreen's lifetime.

(In reply to Bastien Nocera from comment #10)
> @@ +929,3 @@
> +  g_clear_object (_wayland->dbus_cancellable);
> 
> No, don't do this, keep it around.
> Instead, you'll want to cancel it it in dispose().

Ok.

> @@ +955,3 @@
> +}
> +
> +  g_variant_unref (value);
> 
> g_variant_unref() doesn't like being passed NULL.

Ouch...

> @@ +963,3 @@
> +{
> +  modules = g_variant_get_string (value, );
> +  screen_wayland->dbus_settings.modules = g_strndup (modules, length);
> 
> You're leaking the old value of dbus_settings.modules.
> 
> Seeing as the string will be nul-terminated, free the old string, and use
> g_variant_dup_string() to assign the new value.

Well, I'm expecting this to be called only once, at object's initialisation
time. Are there any case where this would be called again for the same
GdkWaylandScreen instance? Anyway, string gets freed now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 103572] Libinput: 1.9+: Apple Magic Trackpad stutters, is unresponsive

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=103572

Mario  changed:

   What|Removed |Added

 Attachment #137637|0   |1
is obsolete||
 Attachment #137686|0   |1
is obsolete||

--- Comment #38 from Mario  ---
Created attachment 137716
  --> https://bugs.freedesktop.org/attachment.cgi?id=137716=edit
a signoff version of the previous patch with 60:40 thresholds

I hope it is in the proper format. Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 786693] wayland: fix fontconfig monitoring

[gtk+]

https://bugzilla.gnome.org/show_bug.cgi?id=786693

--- Comment #11 from Bastien Nocera  ---
(In reply to Martin Blanchard from comment #9)
> (In reply to Bastien Nocera from comment #8)
> > It also looks easy enough to extend and add support for the 2 other
> > GtkSettings if you're interested.
> 
> Hummm, isn't 'gtk-enable-animations' already implemented as a gsetting?

Yes, incorrectly so in the Wayland backend. In the X11 backend, animations are
force-disabled if the GSettings is false, then controlled by
gnome-settings-daemon, which will disable them if a software renderer is used,
or an external VNC client is connected.

> > ::: gdk/wayland/gdkscreen-wayland.c
> > @@ +70,3 @@
> > Why use a struct here, and not directly a timestamp? The struct will be
> > initialised to 0 when it's instantiated.
> 
> I've kept the struct so that dbus settings are grouped, that make it clear
> that they'll be handle together.

That's fine. If a GTK+ reviewer doesn't like it, we can unbundle it.

> > @@ +713,3 @@
> > Why the guard here? Wouldn't you want to return the "0" instead of an error
> > here?
> 
> You're right, the distinction between a somehow fake initial value and 0 is
> of little interest here.

Well, 0 is a valid value. This will break if somebody rewinds their clock back
to the 1970, but the value itself is of little interest, we could use an always
incrementing serial, but a timestamp will likely make races and debugging
easier.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 786693] wayland: fix fontconfig monitoring

[gtk+]

https://bugzilla.gnome.org/show_bug.cgi?id=786693

Bastien Nocera  changed:

   What|Removed |Added

 Attachment #369118|none|needs-work
 status||

--- Comment #10 from Bastien Nocera  ---
Review of attachment 369118:

Looks good otherwise.

::: gdk/wayland/gdkscreen-wayland.c
@@ +929,3 @@
+  proxy = g_dbus_proxy_new_for_bus_finish (result, NULL);
+
+  g_clear_object (_wayland->dbus_cancellable);

No, don't do this, keep it around.

Instead, you'll want to cancel it it in dispose().

@@ +955,3 @@
+}
+
+  g_variant_unref (value);

g_variant_unref() doesn't like being passed NULL.

@@ +963,3 @@
+{
+  modules = g_variant_get_string (value, );
+  screen_wayland->dbus_settings.modules = g_strndup (modules, length);

You're leaking the old value of dbus_settings.modules.

Seeing as the string will be nul-terminated, free the old string, and use
g_variant_dup_string() to assign the new value.

@@ +966,3 @@
+}
+
+  g_variant_unref (value);

Ditto.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105108] Lenovo Yoga 11S touchpad is jittery

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105108

--- Comment #22 from Daniel van Vugt  ---
See bug 105306.

It's a separate bug because that enhancement alone doesn't fix the other bugs
already open. However once combined with:
 - smaller margins (fuzz); and
 - hysteresis always on
then I think we will have a complete fix for this bug and others.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105306] Make touchpad hysteresis omnidirectional

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105306

Daniel van Vugt  changed:

   What|Removed |Added

   Priority|medium  |high
   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105306] Make touchpad hysteresis omnidirectional

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105306

Bug ID: 105306
   Summary: Make touchpad hysteresis omnidirectional
   Product: Wayland
   Version: unspecified
  Hardware: Other
OS: All
Status: NEW
  Severity: normal
  Priority: medium
 Component: libinput
  Assignee: wayland-bugs@lists.freedesktop.org
  Reporter: daniel.van.v...@canonical.com

Created attachment 137715
  --> https://bugs.freedesktop.org/attachment.cgi?id=137715=edit
elliptical-hysteresis-v1.patch

Make touchpad hysteresis omnidirectional.

This is to solve annoyances in the current algorithm observed as:
 * Moving a finger in small circles moves the cursor in squares.
 * Moving a finger in a curve snaps the cursor to vertical or horizontal lines
only.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs