https://bugzilla.gnome.org/show_bug.cgi?id=786693
Bastien Nocera <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #369118|none |needs-work
status| |
--- Comment #10 from Bastien Nocera <[email protected]> ---
Review of attachment 369118:
Looks good otherwise.
::: gdk/wayland/gdkscreen-wayland.c
@@ +929,3 @@
+ proxy = g_dbus_proxy_new_for_bus_finish (result, NULL);
+
+ g_clear_object (&screen_wayland->dbus_cancellable);
No, don't do this, keep it around.
Instead, you'll want to cancel it it in dispose().
@@ +955,3 @@
+ }
+
+ g_variant_unref (value);
g_variant_unref() doesn't like being passed NULL.
@@ +963,3 @@
+ {
+ modules = g_variant_get_string (value, &length);
+ screen_wayland->dbus_settings.modules = g_strndup (modules, length);
You're leaking the old value of dbus_settings.modules.
Seeing as the string will be nul-terminated, free the old string, and use
g_variant_dup_string() to assign the new value.
@@ +966,3 @@
+ }
+
+ g_variant_unref (value);
Ditto.
--
You are receiving this mail because:
You are on the CC list for the bug._______________________________________________
wayland-bugs mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs
