[Wayland-bugs] [Bug 105963] Lenovo P50 - Slow fine touchpad movement makes it jump (bug 2)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105963

--- Comment #4 from Tim Richardson  ---
OK, it was in the wrong place. After copying the correct quirk rules file to
the Ubuntu location, and rebooting the quirk is active. It definitely has an
effect, I'm not sure it is a good effect but I can play now.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105963] Lenovo P50 - Slow fine touchpad movement makes it jump (bug 2)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105963

--- Comment #3 from Tim Richardson  ---
I have a system file in /lib/udev/hwdb.d which is out of date. It has not P50
rule

the ninja install is updating /usr/lib/udev/hwdb.d
this has the P50 rule but it looks like it is not being used

is it in the wrong place?

http://manpages.ubuntu.com/manpages/xenial/man7/udev.7.html

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105963] Lenovo P50 - Slow fine touchpad movement makes it jump (bug 2)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105963

--- Comment #1 from Tim Richardson  ---
in 

tp_need_motion_history_reset(struct tp_dispatch *tp)

I added this 



static inline bool
tp_need_motion_history_reset(struct tp_dispatch *tp)
{
bool rc = false;
evdev_log_debug(tp->device, "Checking for consecutive non-motion
events\n");
}





but I am not getting any such log messages at all.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105963] Lenovo P50 - Slow fine touchpad movement makes it jump (bug 2)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105963

Bug ID: 105963
   Summary: Lenovo P50 - Slow fine touchpad movement makes it jump
(bug 2)
   Product: Wayland
   Version: unspecified
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: NEW
  Severity: normal
  Priority: medium
 Component: libinput
  Assignee: wayland-bugs@lists.freedesktop.org
  Reporter: t...@tim-richardson.net

as requested https://bugs.freedesktop.org/show_bug.cgi?id=105022#c40 
making a new bug report, following on from that comment:

Tim:
can we move this to a separate bug please? This one is too noisy to still
figure out what's going on. As a general tip - when you're working on libinput,
put printfs in everywhere and run either sudo ./build/libinput-debug-events
(commandline) or sudo ./build/libinput-debug-gui (a GUI). No need to install
and restart X just for basic testing.

If even the above makes no difference, it's likely that the model flag is never
applied, put a printf in for that in evdev.c. 

> I plan to understand the acceleration logic and change it somehow, so that 
> there must be a certain number of events before acceleration is applied, 
> similar to the idea in the code above.


That's an interesting idea. We previously had code that we required N events
for the pointer to start moving, but that didn't work well, too laggy. But not
having acceleration for the first N events could work (N <=2, I suspect...)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 102375] kernel: T460s disabled touchpad conflicts with trackpoint

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=102375

Peter Hutterer  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 103606] Is there any way to disable palm detection?

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=103606

--- Comment #14 from Peter Hutterer  ---
ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 101139] Acceleration still too fast with slow and slow-medium finger movements

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=101139

--- Comment #44 from Peter Hutterer  ---
Created attachment 138716
  --> https://bugs.freedesktop.org/attachment.cgi?id=138716=edit
synaptics-libinput-comparison.svg

Please keep this bug on-topic, the hysteresis issues are not for this bug.

Attaching my best efforts to compare synaptics and libinput for archival
purposes. The libinput curve is printed directly with the ptraccel-debug tool
(this is git master without the patches above). For the synaptics curve, I
created a uinput device that moves a touch from left to right at decreasing
time intervals and eventually gets to the maximum speeds shown. The various
values were printed as YAML to the xorg.log and extracted from there with
custom python scripts.

Since the server uses device coordinates everywhere, I divided the velocity for
synaptics values by the resolution I used in the uinput device. This should
give us mm.

The curves shown in the diagram are:
"synaptics" - the accelfct as returned from SynapticsAccelerationProfile for a
given speed. Notice how the curve isn't too dissimilar to the libinput curve in
shape, albeit the libinput curve includes the final accel factor.
"mult" - the multiplier used in the server's acceleratePointerPredictable(),
after taking constant deceleration and the synaptics acceleration factor into
account. This mult factor is then applied to the input deltas (these are in
device coordinates) and the closest match to the 'accel factor' that libinput
uses (but see below).
"libinput" - libinput accel factor applied to a delta at any given speed.

Constant deceleration in synaptics is 1/2.5 (0.4), and quite similar to the
MAGIC we use in libinput (0.37). That latter one was found by trial and error
but having those two similar indicates this is a good value.

I haven't even tried to change synaptics acceleration options, this makes it
even harder...

To the best of my knowledge, the curves are correct. But honestly, this is all
so convoluted that it's hard to be sure. And note that after applying the
acceleration factor, the device coordinates are scaled into screen coordinates
which depends on the screen resolution. IOW, different results for larger
screens (or screens with different aspect ratios). And for all I know, this may
change the curve significantly but this is even harder to test because the
rescaling will clip at screen edges and my testing approach hit those very
quickly.

Also, neither libinput nor synaptics are that simple, there is some analysis of
previous events to adjust the acceleration curve (e.g. on directional changes).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105022] Lenovo P50 - Slow fine touchpad movement makes it jump

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105022

--- Comment #40 from Peter Hutterer  ---
Krasi:
I've reverted the patch upstream, (commit e8cb7e4) Unsure how it can affect
scrolling but at this point I'm so out of time for everything that I'll need
your/someone's help debugging this any further, sorry.



Tim:
can we move this to a separate bug please? This one is too noisy to still
figure out what's going on. As a general tip - when you're working on libinput,
put printfs in everywhere and run either sudo ./build/libinput-debug-events
(commandline) or sudo ./build/libinput-debug-gui (a GUI). No need to install
and restart X just for basic testing.

If even the above makes no difference, it's likely that the model flag is never
applied, put a printf in for that in evdev.c. 

> I plan to understand the acceleration logic and change it somehow, so that 
> there must be a certain number of events before acceleration is applied, 
> similar to the idea in the code above.

That's an interesting idea. We previously had code that we required N events
for the pointer to start moving, but that didn't work well, too laggy. But not
having acceleration for the first N events could work (N <=2, I suspect...)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 793462] gnome-terminal doesn't properly adjust back to HiDPI

[gtk+]

https://bugzilla.gnome.org/show_bug.cgi?id=793462

Christian Persch  changed:

   What|Removed |Added

 CC||r...@robster.org.uk,
   ||wayland-bugs@lists.freedesk
   ||top.org
  Component|general |Backend: Wayland
Version|3.26.x  |3.22.x
   Assignee|gnome-terminal-maint@gnome. |gtk-b...@gtk.org
   |bugs|
Product|gnome-terminal  |gtk+
 QA Contact|gnome-terminal-maint@gnome. |gtk-b...@gtk.org
   |bugs|

--- Comment #4 from Christian Persch  ---
-> gtk+

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 789788] Sometimes drop down opens behind shell top panel under Wayland

[gtk+]

https://bugzilla.gnome.org/show_bug.cgi?id=789788

--- Comment #5 from Strangiato  ---
install amount of gtk or shell themes enough to create a long drop down in
Tweaks.
Start Gnome Wayland session
open Tweaks and maximize it window, open gtk/shell theme drop down
The problem shown in my screenshot happens when I open the drop down for the
first time.

Note that in my screenshot I use a transparent shell theme named
"VimixLight-Laptop".

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 789788] Sometimes drop down opens behind shell top panel under Wayland

[gtk+]

https://bugzilla.gnome.org/show_bug.cgi?id=789788

--- Comment #4 from Jonas Ådahl  ---
I can't reproduce this bug, using the same menu as in the screen shot. Can you
describe when you see it?

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 770784] Wayland: Looong popup windows from combobox misplaced

[gtk+]

https://bugzilla.gnome.org/show_bug.cgi?id=770784

Jonas Ådahl  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW
 CC||jad...@gmail.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105022] Lenovo P50 - Slow fine touchpad movement makes it jump

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105022

--- Comment #39 from Tim Richardson  ---
Peter, thanks for your code. It's very easy to build, very easy to understand. 

I made this change, but it makes no difference

diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c
index 99cbcc56..6e75322d 100644
--- a/src/evdev-mt-touchpad.c
+++ b/src/evdev-mt-touchpad.c
@@ -1411,7 +1411,7 @@ tp_need_motion_history_reset(struct tp_dispatch *tp)
 */
if (tp->device->model_flags & EVDEV_MODEL_LENOVO_T450_TOUCHPAD) {
if (tp->queued & TOUCHPAD_EVENT_MOTION) {
-   if (tp->quirks.nonmotion_event_count > 10) {
+   if (tp->quirks.nonmotion_event_count > 0) {
tp->queued &= ~TOUCHPAD_EVENT_MOTION;
rc = true;
}


That large jump in cursor movement is really a problem. It is not ignored, even
by the code above (which was applied when I took that recording, and I both
updated and rebooted). 

It is treated as a rapid movement and accelerated. The only way I can get a
good touchpad experience is an acceleration factor < -0.7

I plan to understand the acceleration logic and change it somehow, so that
there must be a certain number of events before acceleration is applied,
similar to the idea in the code above.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105022] Lenovo P50 - Slow fine touchpad movement makes it jump

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105022

--- Comment #38 from Krasi  ---
It affected all scrolling. After reverting the patch it all went back to
normal.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 102649] Mouse taps (?) detected while typing

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=102649

--- Comment #57 from Peter Hutterer  ---
Grab libinput git master, build it and run libinput record against your
touchpad and the keyboard (it can record two devices at the same time). See:
https://wayland.freedesktop.org/libinput/doc/latest/tools.html#libinput-record

You don't actually have to install libinput from git to run the tool. This
should show the race conditions (if any).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105939] libinput install phase failure

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105939

--- Comment #6 from huaicheng  ---
I see. Thank you for the help!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105939] libinput install phase failure

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105939

Peter Hutterer  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |NOTOURBUG

--- Comment #5 from Peter Hutterer  ---
ok, there's something wrong with restorecon on your system. not sure what
exactly it is, but it ls shows the file but both meson and this script fail to
restore it (independently), the issue with outside our influence, sorry.

If it ends up being a libinput bug please re-open but if restorecon doesn't
find a file that's clearly there, something else is the matter.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs