Re: [PATCH weston] xdg-shell: Make stable

2014-08-28 Thread Pekka Paalanen
On Wed, 27 Aug 2014 11:37:13 -0700 Jason Ekstrand ja...@jlekstrand.net wrote: On Wed, Aug 27, 2014 at 1:52 AM, Giulio Camuffo giuliocamu...@gmail.com wrote: 2014-08-27 11:38 GMT+03:00 Pekka Paalanen ppaala...@gmail.com: On Wed, 27 Aug 2014 11:03:04 +0300 Giulio Camuffo

Re: [PATCH weston 1/3] compositor: add weston_client_start()

2014-08-28 Thread Pekka Paalanen
On Wed, 27 Aug 2014 11:31:18 -0500 Derek Foreman der...@osg.samsung.com wrote: On 27/08/14 05:41 AM, Pekka Paalanen wrote: From: Pekka Paalanen pekka.paala...@collabora.co.uk weston_client_start() is a new wrapper around weston_client_launch(), that does the process tracking on its own,

Re: [PATCH weston 2/3] shell: fix race on desktop-shell exit

2014-08-28 Thread Pekka Paalanen
On Wed, 27 Aug 2014 13:16:56 -0500 Derek Foreman der...@osg.samsung.com wrote: On 27/08/14 05:41 AM, Pekka Paalanen wrote: From: Pekka Paalanen pekka.paala...@collabora.co.uk The desktop shell plugin registers both a wl_client destroy signal listener, and a sigchld handler, when

[PATCH weston] shell: quit weston, if weston-desktop-shell dies early

2014-08-28 Thread Pekka Paalanen
From: Pekka Paalanen pekka.paala...@collabora.co.uk If weston-desktop-shell dies soon after launch, or maybe cannot be executed at all, let weston exit rather than letting the user stare at a black screen. But, do not exit weston, if weston-desktop-shell dies later, as the user may already have

Re: [PATCH weston v3] compositor: add a way to change the keyboard locks

2014-08-28 Thread Pekka Paalanen
On Fri, 22 Aug 2014 13:22:27 +0300 Giulio Camuffo giuliocamu...@gmail.com wrote: This adds a function weston_keyboard_set_locks() which can be used to change the state of the num lock and the caps locks, changing the leds too. Only the evdev and libinput backends supports this, since it

Re: [PATCH weston v2] compositor: add an option to set the default numlock value

2014-08-28 Thread Pekka Paalanen
On Fri, 22 Aug 2014 11:48:59 +0300 Giulio Camuffo giuliocamu...@gmail.com wrote: Add a new numlock-on option in the [keyboard] section of weston.ini which, if set to true, is used to enable the numlock of the keyboards attached at startup. --- man/weston.ini.man | 6 ++

Re: Use xdg-shell in tests

2014-08-28 Thread Pekka Paalanen
On Wed, 16 Jul 2014 15:52:27 +0200 Marek Chalupa mchqwe...@gmail.com wrote: Hi, in this series of patches I added support for xdg-shell/surface to the test-suite. The thing that led me to this is captured in the last patch, that is that maximizing and fullscreening didn't work as

[PATCH 2/2] client: wake up sleeping threads on all return paths from read_events

2014-08-28 Thread Marek Chalupa
In the first place, create a function display_wakeup_threads that contains always-repeated pattern: broadcast + increase serial. Replace the pattern with this function and call this function also on return from read_events when wl_connection_read fails with EAGAIN (this solves the bug from the

[PATCH 1/2] tests: add new threading test

2014-08-28 Thread Marek Chalupa
This test creates three threads (and main one) and in each does preapare_read and read_events. This is normal workflow, but since we have no data on socket, the read_events will return with EAGAIN. On this path we do not wake up threads and this test blocks until timeout. Signed-off-by: Marek

Re: Use xdg-shell in tests

2014-08-28 Thread Marek Chalupa
Hi, On 28 August 2014 11:30, Pekka Paalanen ppaala...@gmail.com wrote: On Wed, 16 Jul 2014 15:52:27 +0200 Marek Chalupa mchqwe...@gmail.com wrote: Hi, in this series of patches I added support for xdg-shell/surface to the test-suite. The thing that led me to this is captured in

Re: [PATCH] client: clarify wl_display_prepare_read() semantics

2014-08-28 Thread Pekka Paalanen
On Mon, 4 Aug 2014 11:30:46 +0200 Marek Chalupa mchqwe...@gmail.com wrote: From the doc comment I get the feeling, that after successfull call to wl_display_prepare_read(), the thread gains exclusive access to the fd. That is not true. It only ensures that _one_ of the threads, that called

Re: [PATCH weston] multi-resource: remove an unnecessary call of wl_display_get_fd()

2014-08-28 Thread Pekka Paalanen
On Thu, 28 Aug 2014 18:35:27 +0900 Ryo Munakata ryomnk...@gmail.com wrote: Signed-off-by: Ryo Munakata ryomnk...@gmail.com --- clients/multi-resource.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/clients/multi-resource.c b/clients/multi-resource.c index c4a0c18..0dc2c74 100644

Re: [PATCH 2/2] client: wake up sleeping threads on all return paths from read_events

2014-08-28 Thread Marek Chalupa
Hmm, thinking about that... Maybe this is not the right solution. Programmer should probably do something like: do { ret = wl_display_read_events(display); } while (ret == 0 errno == EAGAIN); to be sure he read the events (or got an error). This patch would force him to re-run

Re: [PATCH weston 08/10] weston-test: fix build when mesa egl extensions are not defined

2014-08-28 Thread Pekka Paalanen
On Mon, 25 Aug 2014 20:56:50 +0200 raw...@gmail.com wrote: From: Arnaud Vrac av...@freebox.fr --- tests/weston-test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/weston-test.c b/tests/weston-test.c index f1e45c1..5c6fd47 100644 --- a/tests/weston-test.c +++

Re: [PATCH weston 09/10] keyboard: do not crash if no input panel is available

2014-08-28 Thread Pekka Paalanen
On Mon, 25 Aug 2014 20:56:51 +0200 raw...@gmail.com wrote: From: Arnaud Vrac av...@freebox.fr --- clients/keyboard.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/clients/keyboard.c b/clients/keyboard.c index 7c11cec..750f58e 100644 --- a/clients/keyboard.c +++

Re: [PATCH weston 10/10] pixman-renderer: free shadow buffer on renderer destruction

2014-08-28 Thread Pekka Paalanen
On Mon, 25 Aug 2014 20:56:52 +0200 raw...@gmail.com wrote: From: Arnaud Vrac av...@freebox.fr --- src/pixman-renderer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/pixman-renderer.c b/src/pixman-renderer.c index a816d02..4fdcb05 100644 --- a/src/pixman-renderer.c +++

Re: [PATCH weston v3] compositor: add a way to change the keyboard locks

2014-08-28 Thread Pekka Paalanen
On Thu, 28 Aug 2014 12:12:59 +0300 Pekka Paalanen ppaala...@gmail.com wrote: On Fri, 22 Aug 2014 13:22:27 +0300 Giulio Camuffo giuliocamu...@gmail.com wrote: This adds a function weston_keyboard_set_locks() which can be used to change the state of the num lock and the caps locks, changing

[PATCH weston] Add font entry to shell section for title fonts

2014-08-28 Thread Ryo Munakata
cairo-util has used sans font family for title fonts so far. But sans doesn't support non-ascii characters. So now let users choose a font family for titles. The entry name is generic, 'font' so that other places where draw texts can use this entry too. Signed-off-by: Ryo Munakata

Re: [PATCH libinput 01/11] test: add helpers to wait for specific events

2014-08-28 Thread Hans de Goede
Hi, On 08/27/2014 06:31 AM, Peter Hutterer wrote: litest_wait_for_event() returns if any event is available. litest_wait_for_event_of_type(... type, type, type, -1) returns if any of the given event types is availble. All other events are discarded. Signed-off-by: Peter Hutterer

Re: [PATCH libinput 02/11] test: add a generic single-touch device

2014-08-28 Thread Hans de Goede
Hi, On 08/27/2014 06:31 AM, Peter Hutterer wrote: With a non-zero absmin for both axes and different ranges for x/y, just to detect those errors. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Looks good: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans ---

Re: [PATCH libinput 03/11] udev: use evdev_device_calibrate() instead of manually writing the matrix

2014-08-28 Thread Hans de Goede
Hi, On 08/27/2014 06:31 AM, Peter Hutterer wrote: We have a wrapper, use it. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Looks good: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/udev-seat.c | 27 ++- 1 file changed, 14

Re: [PATCH libinput 04/11] evdev: constify evdev_device_calibrate

2014-08-28 Thread Hans de Goede
Hi, On 08/27/2014 06:31 AM, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Looks good: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/evdev.c | 3 ++- src/evdev.h | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff

Re: [PATCH libinput 05/11] evdev: apply calibration to multitouch values as well

2014-08-28 Thread Hans de Goede
Hi, On 08/27/2014 06:31 AM, Peter Hutterer wrote: We apply calibration to single-touch and absolute devices, but we might as well do so for multitouch events. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev.c | 31 +++ 1 file changed, 19

Re: [PATCH libinput 06/11] util: add a couple of 3x3 matrix helper functions

2014-08-28 Thread Hans de Goede
Hi, On 08/27/2014 06:31 AM, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/libinput-util.h | 100 test/misc.c | 78 2 files changed, 178

Re: [PATCH libinput 08/11] udev: drop WL_CALIBRATION, replace with LIBINPUT_CALIBRATION_MATRIX

2014-08-28 Thread Hans de Goede
Hi, On 08/27/2014 06:31 AM, Peter Hutterer wrote: WL_CALIBRATION is a weston-specific property that required the translation component of the matrix to be in pixels. libinput can't provide calibration based on unknown outputs, so drop support for this property. The basic functionality is

Re: [PATCH libinput 09/11] test: add tests for touch calibration

2014-08-28 Thread Hans de Goede
Hi, On 08/27/2014 06:31 AM, Peter Hutterer wrote: Basic tests for rotation, translation and scaling events. Note that tests need to be added separately for single-touch and touch devices, this is a restriction of the litest framework. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net

Re: [PATCH libinput 10/11] Change calibration into a configuration option

2014-08-28 Thread Hans de Goede
Hi, On 08/27/2014 06:31 AM, Peter Hutterer wrote: New configuration API: libinput_device_config_calibration_has_matrix() libinput_device_config_calibration_set_matrix() libinput_device_config_calibration_get_matrix()

Re: [PATCH libinput 11/11] evdev: load the LIBINPUT_CALIBRATION_MATRIX as default matrix

2014-08-28 Thread Hans de Goede
Hi, On 08/27/2014 06:31 AM, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Looks good: Reviewed-by: Hans de Goede hdego...@redhat.com --- See patch 08/11, not sure we really want that configuration back-channel. I think it is useful to have. Regards, Hans

Re: [PATCH libinput 08/11] udev: drop WL_CALIBRATION, replace with LIBINPUT_CALIBRATION_MATRIX

2014-08-28 Thread Hans de Goede
Hi, On 08/28/2014 03:12 PM, Hans de Goede wrote: Hi, On 08/27/2014 06:31 AM, Peter Hutterer wrote: WL_CALIBRATION is a weston-specific property that required the translation component of the matrix to be in pixels. libinput can't provide calibration based on unknown outputs, so drop

Re: [PATCH] client: clarify wl_display_prepare_read() semantics

2014-08-28 Thread Marek Chalupa
On 28 August 2014 12:02, Pekka Paalanen ppaala...@gmail.com wrote: On Mon, 4 Aug 2014 11:30:46 +0200 Marek Chalupa mchqwe...@gmail.com wrote: From the doc comment I get the feeling, that after successfull call to wl_display_prepare_read(), the thread gains exclusive access to the fd.

Re: [PATCH] client: clarify wl_display_prepare_read() semantics

2014-08-28 Thread Pekka Paalanen
On Thu, 28 Aug 2014 15:59:37 +0200 Marek Chalupa mchqwe...@gmail.com wrote: On 28 August 2014 12:02, Pekka Paalanen ppaala...@gmail.com wrote: On Mon, 4 Aug 2014 11:30:46 +0200 Marek Chalupa mchqwe...@gmail.com wrote: From the doc comment I get the feeling, that after successfull

Re: [PATCH] client: clarify wl_display_prepare_read() semantics

2014-08-28 Thread Marek Chalupa
On 28 August 2014 17:52, Pekka Paalanen ppaala...@gmail.com wrote: On Thu, 28 Aug 2014 15:59:37 +0200 Marek Chalupa mchqwe...@gmail.com wrote: On 28 August 2014 12:02, Pekka Paalanen ppaala...@gmail.com wrote: On Mon, 4 Aug 2014 11:30:46 +0200 Marek Chalupa mchqwe...@gmail.com

[PATCH 1/2 weston v4] compositor: add a way to change the keyboard locks

2014-08-28 Thread Giulio Camuffo
This adds a function weston_keyboard_set_locks() which can be used to change the state of the num lock and the caps locks, changing the leds too. Only the evdev and libinput backends supports this, since it doesn't make sense for embedded sessions. --- src/compositor.h | 12

[PATCH 2/2 weston v2] compositor: add an option to set the default numlock value

2014-08-28 Thread Giulio Camuffo
Add a new numlock-on option in the [keyboard] section of weston.ini which, if set to true, is used to enable the numlock of the keyboards attached at startup. --- man/weston.ini.man | 6 ++ src/compositor.c | 13 + 2 files changed, 19 insertions(+) diff --git

Re: [PATCH weston] shell: quit weston, if weston-desktop-shell dies early

2014-08-28 Thread Jason Ekstrand
Really, do we need a whole 30 seconds? You can easily do enough interaction to crash something in 30 seconds. Other than that, this looks fine. Reviewed-by: Jason Ekstrand jason.ekstr...@intel.com On Thu, Aug 28, 2014 at 1:48 AM, Pekka Paalanen ppaala...@gmail.com wrote: From: Pekka Paalanen

Re: [PATCH weston] xdg-shell: Make stable

2014-08-28 Thread Jason Ekstrand
Jasper, I looked through your xdg-shell-rewrite branch and, other than some things that need better docs/rewording, I think it looks OK. In particular, I think we're probably OK removing set_unstable_version in 1.6. Things that need attention (some of this may be a repeat of what Pekka said): -

Re: [PATCH libinput 05/11] evdev: apply calibration to multitouch values as well

2014-08-28 Thread Peter Hutterer
On Thu, Aug 28, 2014 at 03:02:33PM +0200, Hans de Goede wrote: Hi, On 08/27/2014 06:31 AM, Peter Hutterer wrote: We apply calibration to single-touch and absolute devices, but we might as well do so for multitouch events. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net ---

Re: [PATCH libinput 06/11] util: add a couple of 3x3 matrix helper functions

2014-08-28 Thread Peter Hutterer
On Thu, Aug 28, 2014 at 03:04:30PM +0200, Hans de Goede wrote: Hi, On 08/27/2014 06:31 AM, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/libinput-util.h | 100 test/misc.c | 78

Re: [PATCH libinput 07/11] evdev: switch to a normalized transformation matrix

2014-08-28 Thread Peter Hutterer
On Thu, Aug 28, 2014 at 03:07:26PM +0200, Hans de Goede wrote: Hi, On 08/27/2014 06:31 AM, Peter Hutterer wrote: The big change here is the requirement to have the translation component in a device-normalized coordinate space. Without that, we cannot reliably rotate as the