Re: [PATCH v2] doc: Add config check for doxygen 1.6.0+.

2014-12-08 Thread Pekka Paalanen
On Fri, 05 Dec 2014 07:39:04 -0800 Jon A. Cruz j...@osg.samsung.com wrote: On 12/05/2014 07:09 AM, Pekka Paalanen wrote: Hi, looking at doc/doxygen/wayland.doxygen.in it says # Doxyfile 1.7.6.1 Do we know this works with Doxygen 1.6 or should we require 1.7? Not that it

Re: [PATCH libinput] Drop LIBINPUT_TABLET_AXIS_CNT from the public API

2014-12-08 Thread Hans de Goede
Hi, On 08-12-14 04:52, Peter Hutterer wrote: Avoid mismatches in what the caller expects vs what libinput actually provides when building against newer/older versions of libinput. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Looks good: Reviewed-by: Hans de Goede

Re: [PATCH 1/4] doc: use markdown tildes for code blocks

2014-12-08 Thread Peter Hutterer
On Fri, Dec 05, 2014 at 12:53:28PM -0800, Bill Spitzak wrote: On 12/05/2014 06:44 AM, Pekka Paalanen wrote: do you have any suggestions on how to get rid of the asterisks in front of code examples? All I can say is that this appears to be a Doxygen bug, and it depends both on the version

Re: [PATCH 1/4] doc: use markdown tildes for code blocks

2014-12-08 Thread Pekka Paalanen
On Fri, 05 Dec 2014 12:53:28 -0800 Bill Spitzak spit...@gmail.com wrote: On 12/05/2014 06:44 AM, Pekka Paalanen wrote: do you have any suggestions on how to get rid of the asterisks in front of code examples? All I can say is that this appears to be a Doxygen bug, and it depends both

[PATCH libinput v2 2/2] touchpad: Use remove callback to unlink event listener and stop timers

2014-12-08 Thread Hans de Goede
We use 2 mechanisms to unregister the trackpoint event listener depending on device removal order. 1) We have a device_removed callback, if the trackpoint gets removed before the touchpad, this gets called, sees the device being removed is the trackpoint and unregisters the listener 2) If the

[PATCH libinput v2 1/2] evdev: Add a remove callback to the evdev_dispatch_interface

2014-12-08 Thread Hans de Goede
Some dispatchers may want to do some cleanup at remove time, rather then at destroy time. Signed-off-by: Hans de Goede hdego...@redhat.com --- src/evdev-mt-touchpad.c | 1 + src/evdev.c | 4 src/evdev.h | 3 +++ 3 files changed, 8 insertions(+) diff --git

Re: [PATCH 1/1] weston-launch: alter tty command line parameter semantics

2014-12-08 Thread Daniel Stone
Hi, On Wednesday, October 2, 2013, Alex DAMIAN alexandru.dam...@intel.com wrote: Current behaviour of the tty parameter is to take effect only if there is a new user starting up. Since it is useful to start weston-launch with a command line specified tty, I'm changing the semantics of the

[PATCH] evdev: Remove double-semicolon

2014-12-08 Thread Hans de Goede
From: Carlos Garnacho carl...@gnome.org Signed-off-by: Carlos Garnacho carl...@gnome.org --- src/evdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/evdev.c b/src/evdev.c index 4490562..c8ca384 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -2032,7 +2032,7 @@

Re: [PATCH 1/1] weston-launch: alter tty command line parameter semantics

2014-12-08 Thread Damian, Alexandru
What annoyed me was weston silently ignoring the tty argument in certain conditions (you have to specify a new user argument while being root). I reasoned that user access to the tty should be set up by the kernel policies, and we should not enforce the policy at weston level. If the system is

Where should project Weston go?

2014-12-08 Thread Pekka Paalanen
Dear Wayland community, I would like to start a discussion on what Weston really is, and where it should go, if only to confirm that our concensus still holds. I feel the need for it, because I personally find it sometimes hard to judge whether a big new feature is a good idea or out of scope.

Re: [PATCH] evdev: Remove double-semicolon

2014-12-08 Thread Peter Hutterer
On Mon, Dec 08, 2014 at 10:46:54AM +0100, Hans de Goede wrote: From: Carlos Garnacho carl...@gnome.org Signed-off-by: Carlos Garnacho carl...@gnome.org pushed, thanks. fwiw, you can push patches like this directly to the repo, I don't think they'll trigger big discussions on design :)

Re: [PATCH weston v2 2/2] compositor: Implement JSON-timeline logging

2014-12-08 Thread Pekka Paalanen
On Thu, 4 Dec 2014 13:23:57 +0200 Pekka Paalanen ppaala...@gmail.com wrote: On Tue, 02 Dec 2014 12:12:28 -0800 Bill Spitzak spit...@gmail.com wrote: On 12/02/2014 05:45 AM, Pekka Paalanen wrote: From: Pekka Paalanen pekka.paala...@collabora.co.uk + if (!s-get_label ||

Re: [PATCH weston 14/17] Introduce pointer locking and confinement protocol

2014-12-08 Thread Jonas Ådahl
On Tue, Dec 02, 2014 at 02:39:21PM -0800, Bill Spitzak wrote: On 12/02/2014 05:49 AM, Jonas Ådahl wrote: +request name=lock_pointer + description summary=lock pointer to a position +The lock_pointer request lets the client disable absolute pointer +movements,

[PATCH wayland-web] Adding notes regarding Arch Linux dependencies for DocBook.

2014-12-08 Thread Jon A. Cruz
Adding simple notes on DocBook dependencies needed when building on Arch Linux. Without these being present the documentation build will attempt network access and fail outright or warn and then not produce correct results when no Internet access is present. Fixes:

[PATCH weston v2 6/7] text: Don't crash if a seat has no keyboard

2014-12-08 Thread Derek Foreman
A keyboard might not be present in a seat, so check that before dereferencing keyboard related pointers. Also, use the keyboard pointer we set to shorten the code a little bit. Signed-off-by: Derek Foreman der...@osg.samsung.com --- Made the check similar to the dereference. src/text-backend.c

[PATCH libinput 2/3] Implement support for pen barrel rotation

2014-12-08 Thread Jason Gerecke
Some Wacom tablets can report the rotation of the pen about its barrel in the ABS_Z axis. Report this via LIBINPUT_TABLET_AXIS_TWIST. Signed-off-by: Jason Gerecke killert...@gmail.com Acked-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-tablet.c | 6 ++ src/evdev-tablet.h | 6

[PATCH libinput 1/3] Deduplicate and rename normalization functionality

2014-12-08 Thread Jason Gerecke
Changes the names to reflect the functionality, not the use case. Also defines one in terms of the other so that we aren't repeating ourselves. Signed-off-by: Jason Gerecke killert...@gmail.com Acked-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-tablet.c | 15 ++- 1 file

[PATCH libinput 3/3] Add tests for pen rotation

2014-12-08 Thread Jason Gerecke
Signed-off-by: Jason Gerecke killert...@gmail.com Acked-by: Peter Hutterer peter.hutte...@who-t.net --- test/litest-wacom-intuos-tablet.c | 3 +++ test/tablet.c | 41 +-- 2 files changed, 42 insertions(+), 2 deletions(-) diff --git

Re: [RFC PATCH libinput 1/2] Add a string-based input API

2014-12-08 Thread Bill Spitzak
Shouldn't this use the same api as the input methods, since it is in fact an input method? On 12/07/2014 10:05 PM, Peter Hutterer wrote: Some devices don't rely on keycodes + xkb layout but rather send a specific keysym (or multiple) in response to physical button presses. This is the case for

Re: [PATCH 1/4] doc: use markdown tildes for code blocks

2014-12-08 Thread Bill Spitzak
However I think the decision was to only require Doxygen 1.6 and therefore the tildes don't work, and you must use \code. Is this correct? This is what is currently in git head. On 12/08/2014 01:35 AM, Pekka Paalanen wrote: On Fri, 05 Dec 2014 12:53:28 -0800 Bill Spitzak spit...@gmail.com

Re: [PATCH weston 14/17] Introduce pointer locking and confinement protocol

2014-12-08 Thread Bill Spitzak
On 12/08/2014 06:07 AM, Jonas Ådahl wrote: On Tue, Dec 02, 2014 at 02:39:21PM -0800, Bill Spitzak wrote: - Does this need some id of the triggering event? Mostly to determine if the surface had the pointer focus at the time the request was made. It does not, and the lock is postponed until

Re: [PATCH libinput 1/3] Deduplicate and rename normalization functionality

2014-12-08 Thread Bill Spitzak
On 12/08/2014 09:59 AM, Jason Gerecke wrote: +normalize_double_ended(const struct input_absinfo * absinfo) { + /* Map from (0, 1) to the (-1, 1) range */ I think you mean Map from (min, max) to the (-1, 1) range ___ wayland-devel mailing list

Re: [PATCH libinput 2/3] Implement support for pen barrel rotation

2014-12-08 Thread Bill Spitzak
Why not call it Z instead of TWIST? I'm pretty certain that is a common term for this movement, and that twist is a rather strange term (roll is used more). And Z has the advantage that it also implies that counter-clockwise is positive. On 12/08/2014 09:59 AM, Jason Gerecke wrote: ---

Re: [PATCH libinput 2/3] Implement support for pen barrel rotation

2014-12-08 Thread Jon A. Cruz
On 12/08/2014 12:13 PM, Bill Spitzak wrote: Why not call it Z instead of TWIST? I'm pretty certain that is a common term for this movement, and that twist is a rather strange term (roll is used more). And Z has the advantage that it also implies that counter-clockwise is positive. In that

Re: [PATCH libinput 2/3] Implement support for pen barrel rotation

2014-12-08 Thread Peter Hutterer
On Mon, Dec 08, 2014 at 12:13:17PM -0800, Bill Spitzak wrote: Why not call it Z instead of TWIST? I'm pretty certain that is a common term for this movement, and that twist is a rather strange term (roll is used more). And Z has the advantage that it also implies that counter-clockwise is

Re: Where should project Weston go?

2014-12-08 Thread Bryce Harrington
On Mon, Dec 08, 2014 at 02:01:32PM +0200, Pekka Paalanen wrote: Dear Wayland community, I would like to start a discussion on what Weston really is, and where it should go, if only to confirm that our concensus still holds. Thanks for opening discussion on this. I suspect a lot of us have

Re: [PATCH libinput v2 1/2] evdev: Add a remove callback to the evdev_dispatch_interface

2014-12-08 Thread Peter Hutterer
On Mon, Dec 08, 2014 at 10:46:43AM +0100, Hans de Goede wrote: Some dispatchers may want to do some cleanup at remove time, rather then at destroy time. Signed-off-by: Hans de Goede hdego...@redhat.com --- src/evdev-mt-touchpad.c | 1 + src/evdev.c | 4 src/evdev.h

Re: [PATCH libinput v2 2/2] touchpad: Use remove callback to unlink event listener and stop timers

2014-12-08 Thread Peter Hutterer
On Mon, Dec 08, 2014 at 10:46:44AM +0100, Hans de Goede wrote: We use 2 mechanisms to unregister the trackpoint event listener depending on device removal order. 1) We have a device_removed callback, if the trackpoint gets removed before the touchpad, this gets called, sees the device being

Re: [PATCH libinput 2/3] Implement support for pen barrel rotation

2014-12-08 Thread Bill Spitzak
You are right that the fact that it is along the pen is not obvious from Z. However this is actually true of X and Y (one of them could be the angle in the plane defined by the other tilt). Roll probably is good, but it still seems to me that Z is more common, also it looks like the evdev

RE: [PATCH 2/2] ivi-shell: Say something when configuration is missing

2014-12-08 Thread Tanibata, Nobuhiko (ADITJ/SWG)
How about adding more info like following to clearly say which shell output this log? weston_log(ivi-shell: No ivi-module set in weston.conf\n); BR, Nobuhiko Tanibata -Original Message- From: wayland-devel [mailto:wayland-devel-boun...@lists.freedesktop.org] On Behalf Of Ond?ej

[PATCH] doc: Label Client/Server library as Appendex B.

2014-12-08 Thread Bryce Harrington
The table of contents is out of order: .. Chapter 4. Wayland Protocol and Model of Operation Appendix A. Wayland Protocol Specification Chapter 5. Wayland Library The protocol specification docs and the wayland library docs both are generated documentation from source code as opposed

Re: [RFC PATCH libinput 1/2] Add a string-based input API

2014-12-08 Thread Peter Hutterer
On Mon, Dec 08, 2014 at 11:03:58AM -0800, Bill Spitzak wrote: Shouldn't this use the same api as the input methods, since it is in fact an input method? please explain On 12/07/2014 10:05 PM, Peter Hutterer wrote: Some devices don't rely on keycodes + xkb layout but rather send a specific

Re: [PATCH] doc: Label Client/Server library as Appendex B.

2014-12-08 Thread Bill Spitzak
I made the same change in the patches I submitted, and also split the client and server into different Appendicies. On 12/08/2014 06:26 PM, Bryce Harrington wrote: The table of contents is out of order: .. Chapter 4. Wayland Protocol and Model of Operation Appendix A. Wayland

RE: Where should project Weston go?

2014-12-08 Thread Tanibata, Nobuhiko (ADITJ/SWG)
-Original Message- From: wayland-devel [mailto:wayland-devel-boun...@lists.freedesktop.org] On Behalf Of Pekka Paalanen Sent: Monday, December 08, 2014 9:02 PM To: wayland-devel@lists.freedesktop.org Subject: Where should project Weston go? Dear Wayland community, I would

Re: [PATCH] doc: Label Client/Server library as Appendex B.

2014-12-08 Thread Bryce Harrington
On Mon, Dec 08, 2014 at 06:43:14PM -0800, Bill Spitzak wrote: I made the same change in the patches I submitted, and also split the client and server into different Appendicies. Ah, sorry, didn't see that. On 12/08/2014 06:26 PM, Bryce Harrington wrote: The table of contents is out of

Re: [PATCH] doc: Label Client/Server library as Appendex B.

2014-12-08 Thread Peter Hutterer
On Mon, Dec 08, 2014 at 06:26:11PM -0800, Bryce Harrington wrote: The table of contents is out of order: .. Chapter 4. Wayland Protocol and Model of Operation Appendix A. Wayland Protocol Specification Chapter 5. Wayland Library The protocol specification docs and the wayland

Re: [RFC PATCH libinput 1/2] Add a string-based input API

2014-12-08 Thread Bill Spitzak
On 12/08/2014 06:37 PM, Peter Hutterer wrote: On Mon, Dec 08, 2014 at 11:03:58AM -0800, Bill Spitzak wrote: Shouldn't this use the same api as the input methods, since it is in fact an input method? please explain Never mind, I think this is not talking about text input, but about using

Re: [RFC PATCH libinput 1/2] Add a string-based input API

2014-12-08 Thread Peter Hutterer
On Mon, Dec 08, 2014 at 06:49:37PM -0800, Bill Spitzak wrote: On 12/08/2014 06:37 PM, Peter Hutterer wrote: On Mon, Dec 08, 2014 at 11:03:58AM -0800, Bill Spitzak wrote: Shouldn't this use the same api as the input methods, since it is in fact an input method? please explain Never

Re: [RFC PATCH libinput 1/2] Add a string-based input API

2014-12-08 Thread Bill Spitzak
On 12/08/2014 06:59 PM, Peter Hutterer wrote: On Mon, Dec 08, 2014 at 06:49:37PM -0800, Bill Spitzak wrote: On 12/08/2014 06:37 PM, Peter Hutterer wrote: On Mon, Dec 08, 2014 at 11:03:58AM -0800, Bill Spitzak wrote: Shouldn't this use the same api as the input methods, since it is in fact

Re: [PATCH libinput 2/3] Implement support for pen barrel rotation

2014-12-08 Thread Jason Gerecke
My primary complaint is that X and Y are both translational axes, and by analogy Z should be as well. Using it as the name for a rotational axis just muddies things, especially when we already have DISTANCE. My second complaint is the same as Peter's: it should be clear that is axis is in the