[PATCH libinput] touchpad: only use the last two coordinates for delta calculation

Taking the last 4 points means factoring in a coordinate that may be more than 40ms in the past - or even more when the finger moves slowly and we don't get events for a while. This makes the pointer more sluggish and slower to catch up with what the finger is actually doing. We already have the

[PATCH libinput 3/4] test: allow the first event to be a short one during scroll tests

The hysteresis cuts the first pointer motion by the hysteresis margin. On some touchpads this causes the tests to fail when the motion history length is reduced (future patch). Allow the first event to be smaller than the expected minimum. This doesn't trigger in current tests because the

[PATCH libinput 2/4] test: fix edge-scroll no-motion test

The test is supposed to make sure no motion event is sent and that scrolling continues once leaving the edge. It does so by moving down the edge, into the touchpad, then down further. The move from the edge into the touchpad had a vertical component to it though and could cause the scroll minimum

[PATCH libinput 1/4] test: start with the first offset when moving touches

This doesn't have an effect in our current tests because the touchpad always needs 4 motion events to get moving. But for the future, it simplifies the case of "i want to move between x1/y1 and x2/y2", because it fills in only the events in between rather than re-using the touch down coordinates

[PATCH libinput 4/4] evdev: simplify hysteresis code and document it

center + diff is the input coordinate. Simplify the code so it's clear what we're returning. And document the function to explain what it does. Signed-off-by: Peter Hutterer --- src/evdev.h | 38 +++--- 1 file changed, 35 insertions(+),

Re: [RFC v2 wayland-protocols] tablet: define our own enum for tablet tool buttons

On Mon, Nov 21, 2016 at 12:42:36PM +, Daniel Stone wrote: > Hi, > > On 20 November 2016 at 05:14, Peter Hutterer wrote: > > Rather than relying on input-event-codes, define our own enum that is > > tailored > > towards the tablet interface. > > > > Signed-off-by:

Re: [weston 1/2] linux-dmabuf: implement immediate dmabuf import

Hi Varad, On 11 November 2016 at 11:40, Varad Gautam wrote: > handle create_immed() dmabuf import requests and support > zwp_linux_dmabuf_v1_interface version 2. Same caveat about holding off on merging applies, but these two patches are: Reviewed-by: Daniel Stone

[PATCH weston v3 1/2] editor: Use parse_options() from shared for command line options

Also add a basic --help option Signed-off-by: Bryce Harrington --- clients/editor.c | 80 1 file changed, 58 insertions(+), 22 deletions(-) diff --git a/clients/editor.c b/clients/editor.c index 30bf555..b8fc63a

Re: [PATCH weston v2 1/2] editor: Use parse_options() from shared for command line options

On Mon, Nov 21, 2016 at 09:08:38PM +0100, Silvan Jegen wrote: > Hi > > > int > > main(int argc, char *argv[]) > > { > > struct editor editor; > > int i; > > This is still unused (as pointed out by Daniel) and should be removed. Oh, thanks, missed that. Bryce > Cheers, > > Silvan >

[PATCH weston v3 2/2] editor: Load a file if specified on command line

Add support for basic text file loading, to facilitate more expansive testing of its UTF-8 text editing support. Signed-off-by: Bryce Harrington --- clients/editor.c | 67 +++- 1 file changed, 62 insertions(+), 5

Re: [wayland-protocols] linux-dmabuf: add immediate dmabuf import path

Hi Varad, On 11 November 2016 at 11:40, Varad Gautam wrote: > provide a mechanism that allows clients to import the added dmabufs > and immediately receive the newly created wl_buffer handle. this is > useful to clients that are sure of their import request succeeding, >

Re: [PATCH weston] simple-egl: Do not set EGL up until XDG setup is complete

Well, I agree this fix would allow non-compliant implementations to keep misusing wl_surface.commit, and that could potentially remove any motivation to find an appropriate resolution for the bug below. I'm fine with deferring this patch, but I still think applications should not start setting

Re: [PATCH wayland v2] util: Clarify documentation of wl_dispatcher_func_t

Hi, On 21 November 2016 at 20:59, Yong Bakos wrote: > On Nov 21, 2016, at 9:14 AM, Daniel Stone wrote: >> I think removing the final word 'the dispatcher-specific >> implementation data' is a loss of precision/accuracy. If you don't >> mind

Re: [PATCH wayland v2] util: Clarify documentation of wl_dispatcher_func_t

Hi Daniel, > On Nov 21, 2016, at 9:14 AM, Daniel Stone wrote: > > Hi Yong, > > On 21 November 2016 at 13:44, Yong Bakos wrote: >> - * A dispatcher takes five arguments: The first is the dispatcher-specific >> - * implementation data associated

Re: [PATCH weston 9/9] clients/simple-dmabuf-drm: use tiled frame data with modifiers

Hi, On 17 November 2016 at 11:56, Varad Gautam wrote: > fill the dmabuf with valid DRM_FORMAT_NV12 + > DRM_FORMAT_MOD_SAMSUNG_64_32_TILE frame data before importing to display > a non-gibberish pattern when importing with modifiers. Just squash this into the previous

Re: [PATCH weston 8/9] clients/simple-dmabuf-drm: add valid frame data to use with modifiers

On 17 November 2016 at 11:56, Varad Gautam wrote: > From: Varad Gautam > > raw SMPTE color bar pattern in drm_fourcc.h format DRM_FORMAT_NV12 with > modifier DRM_FORMAT_MOD_SAMSUNG_64_32_TILE to be imported as a dmabuf. > > Signed-off-by: Varad

Re: [PATCH weston 7/9] clients/simple-dmabuf-drm: import with dmabuf modifiers

Hi Varad, On 17 November 2016 at 11:56, Varad Gautam wrote: > From: Varad Gautam > > mesa's freedreno driver supports importing dmabufs with format > DRM_FORMAT_NV12 and DRM_FORMAT_MOD_SAMSUNG_64_32_TILE modifier. > demonstrate weston modifier

Re: [PATCH weston 6/9] clients/simple-dmabuf-drm: add freedreno support alongside intel

Hi Varad, On 17 November 2016 at 11:56, Varad Gautam wrote: > diff --git a/configure.ac b/configure.ac > index d084d32..b959637 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -392,12 +392,21 @@ AC_ARG_ENABLE(simple-dmabuf-drm-client, >

Re: [PATCH weston 5/9] clients/simple-dmabuf-intel: rename to simple-dmabuf-drm

Hi Varad, On 17 November 2016 at 11:55, Varad Gautam wrote: > From: Varad Gautam > > this will allow adding other drm backends later. It's still not a particularly pretty client, but no worse than what came before. Reviewed-by: Daniel Stone

Re: [PATCH weston 4/9] gl-renderer: allow importing fourth dmabuf plane

Hi Varad, On 17 November 2016 at 11:55, Varad Gautam wrote: > @@ -1621,6 +1621,21 @@ import_simple_dmabuf(struct gl_renderer *gr, > } > } > > + if (gr->has_dmabuf_import_modifiers) { > + if (attributes->n_planes > 3) { > +

Re: [PATCH weston 3/9] gl-renderer: allow importing dmabufs with format modifiers

Hi Varad, On 17 November 2016 at 11:55, Varad Gautam wrote: > attribs[atti++] = EGL_NONE; > @@ -1924,9 +1941,10 @@ gl_renderer_import_dmabuf(struct weston_compositor *ec, > assert(gr->has_dmabuf_import); > > for (i = 0; i <

Re: [PATCH weston 2/9] linux-dmabuf: advertise supported formats and modifiers

Hi Varad, On 17 November 2016 at 11:55, Varad Gautam wrote: > implement 'format' and 'modifier' events to communicate available > formats and modifiers to the client and support zwp_linux_dmabuf_v1 > interface version 3. When this lands, this will need a wayland-protocols

Re: [PATCH weston 1/9] gl-renderer: support format and modifier queries

Hi Varad, On 17 November 2016 at 11:55, Varad Gautam wrote: > @@ -1847,6 +1851,69 @@ import_dmabuf(struct gl_renderer *gr, > } > > static bool > +gl_renderer_query_dmabuf_formats(struct weston_compositor *wc, > + int **formats, int

Re: [PATCH weston 1/9] gl-renderer: support format and modifier queries

On 21 November 2016 at 20:07, Daniel Stone wrote: > On 17 November 2016 at 11:55, Varad Gautam wrote: >> +static bool >> +gl_renderer_query_dmabuf_modifiers(struct weston_compositor *wc, int format, >> + uint64_t

Re: [PATCH weston v2 1/2] editor: Use parse_options() from shared for command line options

Hi One comment below. On Mon, Nov 21, 2016 at 10:34:33AM -0800, Bryce Harrington wrote: > Also add a basic --help option > > Signed-off-by: Bryce Harrington > --- > clients/editor.c | 78 > +--- > 1 file changed, 57

Re: [wayland-protocols v3] linux-dmabuf: advertise format modifiers with modifier event

Hi Varad, On 21 November 2016 at 10:17, Varad Gautam wrote: > advertise the supported fourcc format modifiers along with supported > formats to the client. > > bump zwp_linux_dmabuf_v1, zwp_linux_buffer_params_v1 interface > versions to 3. Reviewed-by: Daniel Stone

Re: [wayland-protocols v2] linux-dmabuf: clarify format event description

Hi Varad, On 21 November 2016 at 10:17, Varad Gautam wrote: > clearly state the request name in format event to avoid abmiguous > interpretation between 'zwp_linux_buffer_params_v1::create' and > 'zwp_linux_dmabuf_v1::create_params' requests. Sorry, I forgot to note that

Re: [PATCH weston v3] libweston: Position layers in an absolute way

Hi Quentin, On 11 July 2016 at 10:29, Quentin Glidic wrote: > Currently, layers’ order depends on the module loading order and it does > not survive runtime modifications (like shell locking/unlocking). > With this patch, modules can safely add their own layer at

Re: [PATCH weston 6/8] compositor-drm: Make some functions take a weston_output directly

Hi Emmanuel, On 2 May 2016 at 22:40, Emmanuel Gil Peyrot wrote: > Makes it clearer that they don’t use any field specific to drm_output, > and reduce the amount of churn from the following commits. I forgot to mention that I think patches 5 and 6 from this look

Re: [PATCH weston 7/8] compositor-drm: Implement clone mode, refactor output into logical ones

Hi Emmanuel, On 2 May 2016 at 22:40, Emmanuel Gil Peyrot wrote: > Introduces a “same-as” configuration option for each output, which > bypasses the rest of the output configuration (mode, scale, transform > and seat) and instead makes it a clone of the specified

Re: [PATCH weston] gl: Don't declare variables in for loop

Hi, On 21 November 2016 at 19:05, Bryce Harrington wrote: > On Mon, Nov 21, 2016 at 06:06:23PM +, Daniel Stone wrote: >> On 21 November 2016 at 18:02, Bryce Harrington wrote: >> > libweston/gl-renderer.c:2862:2: error: ‘for’ loop initial

Re: [PATCH weston] gl: Don't declare variables in for loop

On Mon, Nov 21, 2016 at 06:06:23PM +, Daniel Stone wrote: > Hi, > > On 21 November 2016 at 18:02, Bryce Harrington wrote: > > Fixes compilation error introduced by 43cea54c: > > > > libweston/gl-renderer.c:2862:2: error: ‘for’ loop initial declarations > > are only

[PATCH weston v2 2/2] editor: Load a file if specified on command line

Add support for basic text file loading, to facilitate more expansive testing of its UTF-8 text editing support. Signed-off-by: Bryce Harrington --- clients/editor.c | 68 +++- 1 file changed, 63 insertions(+), 5

[PATCH weston v2 1/2] editor: Use parse_options() from shared for command line options

Also add a basic --help option Signed-off-by: Bryce Harrington --- clients/editor.c | 78 +--- 1 file changed, 57 insertions(+), 21 deletions(-) diff --git a/clients/editor.c b/clients/editor.c index 30bf555..33b43d2

Re: [PATCH weston 3/3] editor: Load a file if specified on command line

On Mon, Nov 21, 2016 at 12:55:14PM +, Daniel Stone wrote: > Hi Bryce, > > On 20 November 2016 at 22:00, Bryce Harrington wrote: > > Add support for basic text file loading, to facilitate more expansive > > testing of its UTF-8 text editing support. > > Honestly, I

Re: [PATCH] Introduce keyboard grabbing protocol

Hi, On 30 August 2016 at 14:05, Olivier Fourdan wrote: >> Xwayland should probably use a private protocol, like EGL, ideally >> completely hidden and pid-restricted. > > That's the point, I initially thought of a private protocol, but then > realized it could be useful

Re: [PATCH weston] libweston: Add move (without scale) animation

Hi, On 10 August 2016 at 14:53, Quentin Glidic wrote: > From: Quentin Glidic > > Signed-off-by: Quentin Glidic > --- > libweston/animation.c | 35 +-- >

Re: [PATCH weston] gl: Don't declare variables in for loop

Hi, On 21 November 2016 at 18:02, Bryce Harrington wrote: > Fixes compilation error introduced by 43cea54c: > > libweston/gl-renderer.c:2862:2: error: ‘for’ loop initial declarations > are only allowed in C99 mode > for (unsigned i = 0; i <

Re: [PATCH weston v2] compositor-wayland: Port to xdg-shell-v6

Hi, On 21 November 2016 at 18:01, Armin Krezović wrote: > On 21.11.2016 18:42, Armin Krezović wrote: >> v2: >> >> - Keep wl_shell code around until xdg_shell is declared stable. >> >> Signed-off-by: Armin Krezović > > I hereby agree that the

[PATCH weston] gl: Don't declare variables in for loop

Fixes compilation error introduced by 43cea54c: libweston/gl-renderer.c:2862:2: error: ‘for’ loop initial declarations are only allowed in C99 mode for (unsigned i = 0; i < ARRAY_LENGTH(swap_damage_ext_to_entrypoint); i++) { ^ Signed-off-by: Bryce Harrington

Re: [PATCH weston v2] compositor-wayland: Port to xdg-shell-v6

On 21.11.2016 18:42, Armin Krezović wrote: > v2: > > - Keep wl_shell code around until xdg_shell is declared stable. > > Signed-off-by: Armin Krezović I hereby agree that the following changes can be merged as part of this patch:

Re: [weston] linux-dmabuf: align DMABUF exposed formats with EGL supported formats

Hi Vincent, On 7 October 2016 at 16:08, Vincent Abriou wrote: > @@ -72,6 +72,9 @@ install-libweston_moduleLTLIBRARIES > install-moduleLTLIBRARIES: install-libLTLIBR > lib_LTLIBRARIES = libweston-@LIBWESTON_MAJOR@.la > libweston_@LIBWESTON_MAJOR@_la_CPPFLAGS =

[PATCH weston v2] compositor-wayland: Port to xdg-shell-v6

v2: - Keep wl_shell code around until xdg_shell is declared stable. Signed-off-by: Armin Krezović --- Makefile.am| 8 ++- libweston/compositor-wayland.c | 146 + 2 files changed, 139 insertions(+), 15

Re: [PATCH wayland 1/4] wayland-util: do not export the wl_map_* API

Hi Emil, On 30 August 2016 at 18:24, Emil Velikov wrote: > From: Emil Velikov > > Use only internally and explicitly marked as such with commit > cf04b0a18f2 ("Move private definitions and prototypes to new > zwayland-private.h") > >

Re: [PATCH wayland v2] util: Clarify documentation of wl_dispatcher_func_t

Hi Yong, On 21 November 2016 at 13:44, Yong Bakos wrote: > - * A dispatcher takes five arguments: The first is the dispatcher-specific > - * implementation data associated with the target object. The second is the > - * object on which the callback is being invoked

Re: [PATCH weston 09/10] compositor-wayland: Port to xdg-shell-v6

On 21.11.2016 17:37, Daniel Stone wrote: > Hi Armin, > > On 9 October 2016 at 16:30, Armin Krezović wrote: >> Signed-off-by: Armin Krezović > > Could you please spin another version which doesn't jettison wl_shell > support? I know it's lame,

Re: [PATCH weston v2 1/2] config-parser: add support for more color formats

Hi Eric, On 26 October 2016 at 23:53, Eric Engestrom wrote: > Supported colour formats are: > - (0x)(AA)RRGGBB > - #RGB(A) > - #RRGGBB(AA) If I'm honest, I don't entirely see the value in these. Accepting 12345678 as well as 0x12345678 implies, to me at least, that the former

Re: [PATCH weston 1/2] compositor-x11: Move vfunc setting from set_size to enable

Hi Armin, On 28 October 2016 at 23:26, Armin Krezović wrote: > Signed-off-by: Armin Krezović I've pushed this one, but need to think some more about the resizing. Cheers, Daniel ___ wayland-devel

Re: [PATCH weston 08/10] compositor-wayland: Destroy shm buffers on output disable

Hi, On 9 October 2016 at 16:30, Armin Krezović wrote: > Signed-off-by: Armin Krezović Meanwhile, I've reviewed and pushed the series up to this point. Thanks! To ssh://git.freedesktop.org/git/wayland/weston e31d95f..2e66252 upstream ->

Re: [PATCH weston 10/10] compositor-wayland: Simplify fullscreening for sprawl use case

Hi Armin, On 9 October 2016 at 16:30, Armin Krezović wrote: > wayland_output_set_fullscreen() already takes care of > everything and xdg_shell doesn't use any present methods > so a single call to wayland_output_set_fullscreen() is > sufficient. Ha, clever. I kind of

Re: [PATCH weston 09/10] compositor-wayland: Port to xdg-shell-v6

Hi Armin, On 9 October 2016 at 16:30, Armin Krezović wrote: > Signed-off-by: Armin Krezović Could you please spin another version which doesn't jettison wl_shell support? I know it's lame, but it's the only thing which is actually stable

Re: [PATCH weston v3] build: add -uninstalled.pc.in files for libweston and libweston-desktop

Hey Derek, Reynaldo, On 7 September 2016 at 18:58, Derek Foreman wrote: > diff --git a/libweston-desktop/libweston-desktop-uninstalled.pc.in > b/libweston-desktop/libweston-desktop-uninstalled.pc.in > new file mode 100644 > index 000..04af505 > --- /dev/null > +++

Re: [PATCH] weston-editor: Free preferred_language in text_entry_destroy

Hi, On 17 November 2016 at 23:01, Bryce Harrington wrote: > On Thu, Nov 17, 2016 at 09:43:06PM +0100, Silvan Jegen wrote: >> Signed-off-by: Silvan Jegen > > Yep, the value is set via a strdup in main(), so needs free'd. > > Reviewed-by: Bryce Harrington

Re: [PATCH weston v2 5/8] clients/window: use weston_platform_destroy_egl_surface wrapper

Hi Emil, On 18 November 2016 at 19:12, Emil Velikov wrote: > From: Emil Velikov > > v2: Use correct (destroy) API (Dan) All merged with review now, thanks! To ssh://git.freedesktop.org/git/wayland/weston 43cea54..5e60408 upstream ->

Re: [PATCH weston v5 31/42] compositor-drm: Introduce drm_plane_state structure

Hi Daniel Below are two remarks regarding (m/z/c)alloc. By the way, as a general remark (and maybe a personal opinion) zalloc(x) is a bit more readable than calloc(1,x) On 11/16/2016 03:25 PM, Daniel Stone wrote: > Track dynamic plane state (CRTC, FB, position) in separate structures, >

Re: [PATCH wayland] doc: start documenting Xwayland

On Mon, 21 Nov 2016 14:31:43 +0200 Pekka Paalanen wrote: > From: Pekka Paalanen > > This is a rough intro to what Xwayland is and does, with just one > implementation detail so far (Window identification). > > I paid no attention to

Re: [PATCH weston v5 30/42] compositor-drm: Introduce drm_output_state structure

Hi Daniel On 11/16/2016 03:25 PM, Daniel Stone wrote: > Currently this doesn't actually really do anything, but will be used in > the future to track the state for both modeset and repaint requests. > Completion of the request gives us a single request-completion path for > both pageflip and

Re: [PATCH wayland] util: Clarify documentation of wl_dispatcher_func_t

Verified that the intent of the return type of wl_dispatcher_func_t is for an error code. I'm including a response from J Ekstrand, author of wl_dispatcher_func_t inline below, for the record. > On Nov 17, 2016, at 8:28 AM, Yong Bakos wrote: > > On Nov 17, 2016, at 8:23

Re: [PATCH] server: Fix crash when accessing client which is already freed

Hi Pekka, On 21 November 2016 at 13:30, Pekka Paalanen wrote: > On Mon, 21 Nov 2016 12:19:43 + Daniel Stone wrote: >> I'm would suggest we document that invoking wl_display_flush_clients() / >> wl_connection_flush() from a request handler may cause

[PATCH wayland v2] util: Clarify documentation of wl_dispatcher_func_t

From: Yong Bakos Adjust the brief, clarify the behavior and arguments, correct a grammar error, document the parameters, and document the return type. Signed-off-by: Yong Bakos Reviewed-by: Bryce Harrington --- v2:

Re: [PATCH wayland] util: Clarify documentation of wl_dispatcher_func_t

Please disregard, need to annotate the v2. Apologies for the noise. y > On Nov 21, 2016, at 5:40 AM, Yong Bakos wrote: > > From: Yong Bakos > > Adjust the brief, clarify the behavior and arguments, correct a grammar > error, document the

Re: [PATCH weston v5 21/42] compositor-drm: Return FB directly from render

Hi Daniel, On 11/16/2016 03:25 PM, Daniel Stone wrote: > Instead of setting state members directly in the drm_output_render > functions (to paint using Pixman or GL), just return a drm_fb, and let > the core function place it in state. > > Signed-off-by: Daniel Stone > >

[PATCH wayland] util: Clarify documentation of wl_dispatcher_func_t

From: Yong Bakos Adjust the brief, clarify the behavior and arguments, correct a grammar error, document the parameters, and document the return type. Signed-off-by: Yong Bakos Reviewed-by: Bryce Harrington ---

Re: [PATCH] server: Fix crash when accessing client which is already freed

On Mon, 21 Nov 2016 12:19:43 + Daniel Stone wrote: > Hi Hyun Kook, > > On 23 September 2016 at 00:40, Hyun Kook Khang > wrote: > > > in wl_client_connection_data(), > > there is no guarantee that client would never be destroyed in the process

Re: [PATCH weston 3/3] editor: Load a file if specified on command line

Hi Bryce, On 20 November 2016 at 22:00, Bryce Harrington wrote: > Add support for basic text file loading, to facilitate more expansive > testing of its UTF-8 text editing support. Honestly, I question the value of turning the editor into something 'real': as soon as

Re: [RFC v2 wayland-protocols] tablet: define our own enum for tablet tool buttons

Hi, On 20 November 2016 at 05:14, Peter Hutterer wrote: > Rather than relying on input-event-codes, define our own enum that is tailored > towards the tablet interface. > > Signed-off-by: Peter Hutterer > --- > Because it's usually easier to

[PATCH wayland] doc: start documenting Xwayland

From: Pekka Paalanen This is a rough intro to what Xwayland is and does, with just one implementation detail so far (Window identification). I paid no attention to formatting details, those can be polished in follow-ups. I just want the prose out. I also just

Re: [PATCH] server: Fix crash when accessing client which is already freed

Hi Hyun Kook, On 23 September 2016 at 00:40, Hyun Kook Khang wrote: > in wl_client_connection_data(), > there is no guarantee that client would never be destroyed in the process > of handling the pending input. > > For example, > 1. It comes to

Re: [PATCH] xdg-shell: clarify popup constrain's slide mechanism

On Mon, Nov 21, 2016 at 06:36:49AM -0500, Mike Blumenkrantz wrote: > On Fri, 18 Nov 2016 09:28:56 +0800 > Jonas Ådahl wrote: > > > On Wed, Nov 16, 2016 at 10:23:59AM -0500, Mike Blumenkrantz wrote: > > > some restrictions must be placed on this or else it becomes legal for > >

Re: [PATCH] xdg-shell: clarify popup constrain's slide mechanism

On Fri, 18 Nov 2016 09:28:56 +0800 Jonas Ådahl wrote: > On Wed, Nov 16, 2016 at 10:23:59AM -0500, Mike Blumenkrantz wrote: > > some restrictions must be placed on this or else it becomes legal for > > the compositor to place popups in unexpected locations when sliding > > is

Re: [PATCH wayland] protocol: indentation fixes

Hi Bryce, On 18 November 2016 at 00:42, Bryce Harrington wrote: > The patch isn't applying as of change 66a26aeb (remove inconsistent line > breaks), but in generating a whitespace patch myself using emacs with > the Wayland style rules, I am getting a similar looking set

Re: [PATCH wayland] protocol: indentation fixes

Hi Peter, On 10 November 2016 at 05:02, Peter Hutterer wrote: > 8 spaces changed to one tab Can't say I'm a massive fan of it personally, but that ship's already sailed, so have applied this; well, manually reconstructed with sed and taken your commit message / etc.

Re: [RFC wayland 0/1] tests: Test wl_argument_from_va_list

Hi Yong, On 13 November 2016 at 19:14, Yong Bakos wrote: > My ongoing routine of documenting objects and checking for related test > coverage > has recently led me to notice that wl_argument_from_va_list does not have a > specific test in connection-test.c. The 1/1 patch

Re: [PATCH] wayland-client: Require base 10 for WAYLAND_SOCKET, explicitly

Hi, On 9 July 2016 at 02:36, Yong Bakos wrote: > On Jul 8, 2016, at 4:42 PM, Bryce Harrington wrote: >> The third arg to strtol() specifies the base to assume for the number. >> When 0 is passed, as is currently done in wayland-client.c,

Re: [PATCH weston 2/2] simple-egl: add support for EGL_KHR_swap_buffers_with_damage

Hi Emil, On 3 November 2016 at 22:38, Emil Velikov wrote: > @@ -191,14 +205,21 @@ init_egl(struct display *display, struct window *window) > display->swap_buffers_with_damage = NULL; > extensions = eglQueryString(display->egl.dpy, EGL_EXTENSIONS); >

Re: [PATCH wayland] util: Document wl_log_func_t

Hi Yong, On 20 November 2016 at 16:59, Yong Bakos wrote: > +/** > + * Log function type alias > + * > + * The C implementation of the Wayland protocol abstracts the details of > + * logging. Users may customize the logging behavior, with a function > conforming > + * to

Re: [PATCH weston] drm: don't put too big surfaces in the cursor plane

Hi Giulio, On 21 November 2016 at 11:23, Giulio Camuffo wrote: > When using output scaling a client surface's wicth and height can be > smaller than the cursor plane's size, even if its buffer is actually > bigger. So check the buffer size rather than the surface size.

Re: [PATCH wayland-web v2] qt5: fixed bug tracker link

> On 21 nov. 2016, at 11:55, Daniel Stone wrote: > > Hi, > > On 9 October 2016 at 21:04, Samuel Gaist wrote: >>> On 31 août 2016, at 17:13, Yong Bakos wrote: >>> On Aug 30, 2016, at 11:50 PM, Samuel Gaist

[PATCH weston] drm: don't put too big surfaces in the cursor plane

When using output scaling a client surface's wicth and height can be smaller than the cursor plane's size, even if its buffer is actually bigger. So check the buffer size rather than the surface size. --- libweston/compositor-drm.c | 17 + 1 file changed, 9 insertions(+), 8

Re: [PATCH wayland-protocols 1/1] (multiple): Remove inconsistent line breaks

Hi Yong, On 31 October 2016 at 13:43, Yong Bakos wrote: > From: Yong Bakos > > Enum entries and message arguments are sometimes preceded by a blank line, but > often aren't. > > Standardize the format of the protocol specification by removing

Re: [PATCH wayland-web v2] qt5: fixed bug tracker link

> On 21 nov. 2016, at 12:11, Daniel Stone wrote: > > Hi Samuel, > > On 21 November 2016 at 11:08, Samuel Gaist wrote: >>> On 21 nov. 2016, at 11:55, Daniel Stone wrote: >>> Very much overlooked indeed; sorry for the delay.

Re: [PATCH wayland 2/2] build: Fix scanner path in uninstalled pkg-config file

Hi, On 30 August 2016 at 01:29, Bryce Harrington wrote: > On Fri, Aug 26, 2016 at 04:04:03PM -0500, Derek Foreman wrote: >> this was generating a pkg-config file that said wayland-scanner was >> wayland/src/wayland-scanner when it's actually wayland/wayland-scanner >> >>

Re: [PATCH wayland-web v2] qt5: fixed bug tracker link

Hi Samuel, On 21 November 2016 at 11:08, Samuel Gaist wrote: >> On 21 nov. 2016, at 11:55, Daniel Stone wrote: >> Very much overlooked indeed; sorry for the delay. Pushed now. > > Thank you very much ! > > Can you also take a look at: > >

Re: [PATCH wayland] util: Improve documentation of wl_iterator_result

Hi Yong, On 20 November 2016 at 17:26, Yong Bakos wrote: > Use declarative voice, remove the unnecessary doxygen \enum tag, and add > two see-also's. This keeps the output the same but makes the comment > voice consistent, a little more readable, and refers to documented

Re: [PATCH v2 wayland] protocol: spell out that we're using linux/input-event-codes.h button codes

Hi Peter, On 18 November 2016 at 02:35, Peter Hutterer wrote: > Because we already rely on it in the callers anyway. This is a retrofit, which > is not ideal but I'm not sure any compositor out there uses anything else. > Might as well define it. Thanks for this. To

Re: [PATCH weston 2/2] Makefile.am: Link modules to libweston.la

On Monday 2016-11-21 12:00, Daniel Stone wrote: >On 18 August 2016 at 10:15, Quentin Glidic > wrote: >> @@ -116,7 +116,9 @@ libweston_@LIBWESTON_MAJOR@_la_SOURCES = >>\ >> lib_LTLIBRARIES += libweston-desktop-@LIBWESTON_MAJOR@.la >>

Re: [PATCH weston 1/2] libweston: Move text_backend_* to weston.h

Hi, On 18 August 2016 at 12:28, Quentin Glidic wrote: > I forgot to explain it, but these are actually defined in Weston, not > libweston, so any libweston user trying to use them will fail. Right you are: To ssh://git.freedesktop.org/git/wayland/weston

Re: [PATCH weston 2/2] Makefile.am: Link modules to libweston.la

Hi Quentin, On 18 August 2016 at 10:15, Quentin Glidic wrote: > @@ -116,7 +116,9 @@ libweston_@LIBWESTON_MAJOR@_la_SOURCES = > \ > lib_LTLIBRARIES += libweston-desktop-@LIBWESTON_MAJOR@.la > libweston_desktop_@LIBWESTON_MAJOR@_la_CPPFLAGS =

Re: [PATCH wayland-web v2] qt5: fixed bug tracker link

Hi, On 9 October 2016 at 21:04, Samuel Gaist wrote: >> On 31 août 2016, at 17:13, Yong Bakos wrote: >> On Aug 30, 2016, at 11:50 PM, Samuel Gaist wrote: >>> No being used to the by email patch workflow, should I send

Re: [PATCH wayland-web] Drop the ubuntu 12.04 build directions.

Hi, On 16 September 2016 at 22:29, Bryce Harrington wrote: > It is unlikely anyone still needs directions on how to install on this > old distro -- Ubuntu 12.04 is scheduled to hit end-of-life this April. > > Further, no developers (to my knowledge) still test on 12.04, so

[wayland-protocols v3] linux-dmabuf: advertise format modifiers with modifier event

From: Varad Gautam advertise the supported fourcc format modifiers along with supported formats to the client. bump zwp_linux_dmabuf_v1, zwp_linux_buffer_params_v1 interface versions to 3. v2: specify request name in event description for clarity (Yong Bakos) v3:

[wayland-protocols v2] linux-dmabuf: clarify format event description

From: Varad Gautam clearly state the request name in format event to avoid abmiguous interpretation between 'zwp_linux_buffer_params_v1::create' and 'zwp_linux_dmabuf_v1::create_params' requests. v2: grammar fixup (Yong Bakos) Suggested-by: Yong Bakos

Re: [PATCH wayland-protocols] input-method: Cleanup some grammar

Hi Bryce, On 17 September 2016 at 05:37, Bryce Harrington wrote: > > > - Set the styling information on composing text. The style is applied > for > - length in bytes from index relative to the beginning of > - the composing text (as byte

Re: [PATCH wayland] cursor: Remove "weston" from anonymous shm filenames

On 27 July 2016 at 17:06, Derek Foreman wrote: > This mildly confused me during some debugging, so I guess it wouldn't > hurt to make the filename more indicative of where it was actually > created. > > Signed-off-by: Derek Foreman Heh. Branding!

Re: [PATCH weston] Ignore the OSC code for desktop notifications

Hi Dima, On 4 November 2016 at 06:46, Dima Ryazanov wrote: > In Fedora, bash is configured to display a desktop notification when a command > finishes (and the terminal is not focused). weston-terminal complains about > it; > let's silence it. I have no clue about terminal

Re: [PATCH weston] simple-egl: Do not set EGL up until XDG setup is complete

Hi Miguel, On 15 November 2016 at 04:49, Miguel A. Vico wrote: > There is nothing that prohibits the underlying EGL_PLATFORM_WAYLAND > implementation to attach a buffer or commit surfaces right after the > Wayland EGLSurface has been created. > > Since XDG Shell v6 imposes

Re: [PATCH weston] libweston: remove unused function declaration of weston_compositor_top

Hi, On 18 November 2016 at 12:17, Ryo Munakata wrote: > Signed-off-by: Ryo Munakata Pushed with review, thanks! To ssh://git.freedesktop.org/git/wayland/weston 97863d6..08f09e2 upstream -> master Cheers, Daniel

Re: [PATCH weston v2] xwayland: Fix X11 lock file size confusion

Hi, On 17 November 2016 at 14:41, Pekka Paalanen wrote: > On Thu, 17 Nov 2016 12:17:59 + > Daniel Stone wrote: >> @@ -148,13 +148,19 @@ bind_to_unix_socket(int display) >> static int >> create_lockfile(int display, char *lockfile,

Re: [PATCH weston] clients/simple-shm: remove unreachable function call

Hi Munakata-san, On 18 November 2016 at 12:17, Ryo Munakata wrote: > window->wait_for_configure should be false after dispatching more than once. > Therefore this redraw() will never be called. > > Signed-off-by: Ryo Munakata > --- >