Re: Discrepancies in object IDs printed by $WAYLAND_DEBUG output

On 2021-08-25 3:08 p.m., Hoosier, Matt wrote: I observe that the IDs used to denote some wl_buffer protocol objects created by a server-side factory in the $WAYLAND_DEBUG trace, differ between the moment they're first announced in the callback event and the later use-sites when the objects are

Re: Stepping down as release manager

On Mon, 8 Apr 2019 at 05:54, Daniel Stone wrote: > > Hi, > > On Mon, 8 Apr 2019 at 11:02, Pekka Paalanen wrote: > > On Fri, 05 Apr 2019 18:01:45 + Simon Ser wrote: > > > Regarding the need for a new release manager for Wayland, I'd like to > > > step in and volunteer for this role. I'm

Stepping down as release manager

Hi everyone, I no longer have as much time to dedicate to this as I used to, so I think it would be best if someone else could take over managing the releases for Weston and Wayland. Thanks for the opportunity to help out, Derek ___ wayland-devel

[ANNOUNCE] weston 6.0.0

Weston 6.0 is released with only a trivial build change since RC2. Derek Foreman (1): configure.ac/meson.build: bump version to 6.0.0 for the official release Marius Vlad (1): autotools: Fix tags/cscope targets with autools git tag: 6.0.0 https://wayland.freedesktop.org/releases

[ANNOUNCE] wayland 1.17.0

Wayland 1.17 is released, with no changes (except the version) since RC1. Derek Foreman (1): configure.ac: bump to version 1.17.0 for the official release git tag: 1.17.0 https://wayland.freedesktop.org/releases/wayland-1.17.0.tar.xz MD5: d91f970aea11fd549eae023d06f91af3 wayland-1.17.0

[ANNOUNCE] weston 5.0.94

This is the RC2 release for weston 6.0. There's a fix for a bug in the meson build. Since the plan is to drop meson shortly after 6.0 is released, it's critical that autotools and meson both build properly, so an RC2 is in order. Perhaps a full release next Wednesday. Changelog follows: Derek

[ANNOUNCE] wayland 1.16.93

This is the first release candidate for the upcoming 1.17 release. Sorry I missed the intended release date yesterday, the following releases will be pushed back a day as well. Changelog follows: Chris Billington (1): wayland-util.h: add forward declaration for wl_object Derek Foreman (1

[ANNOUNCE] weston 5.0.93

This is the first release candidate for the upcoming 6.0 release. Sorry I missed the intended release date yesterday, the following releases will be pushed back a day as well. Changelog follows: Derek Foreman (1): configure.ac: bump version to 5.0.93 for the RC1 release Philipp Zabel (2

Re: EXT: Re: [PATCH wayland v2] contributing: use Gitlab merge request workflow

On Wed, 6 Mar 2019 at 04:49, Ray, Ian (GE Healthcare) wrote: > > > > > On 6 Mar 2019, at 11.28, Pekka Paalanen wrote: > > > > Going once, going twice... > > > > Any objections? More acks? Acked-by: Derek Foreman Personally, I really see no harm in push

[ANNOUNCE] wayland 1.16.92

This is the beta for the upcoming 1.17 release. Changelog: Derek Foreman (1): configure.ac: bump to version 1.16.92 for the beta release Leonid Bobrov via wayland-devel (1): tests: fix main symbol duplication Simon Ser (1): protocol: warn clients about some wl_output

[ANNOUNCE] weston 5.0.92

missing newline to debug print Derek Foreman (1): configure.ac: bump to version 5.0.92 for the beta release Emmanuel Gil Peyrot (1): Fix typos all around (thanks codespell!) Philipp Zabel (1): compositor-drm: fix gbm_bo_get_handle_for_plane error handling git tag: 5.0.92 https

Re: [ANNOUNCE] weston 5.0.91

wrote: > Hi, > > FYI, The links at the end all give 404. Releases page is missing alpha > version entry as well. > > On 2/19/19 10:15 PM, Derek Foreman wrote: > > This is the alpha release for weston 6.0. A lot has happened for this > > release, some big items to note

[ANNOUNCE] weston 5.0.91

capability Derek Foreman (2): configure.ac: Reopen master for regular development configure.ac: bump to version 5.0.91 for the alpha release Dima Ryazanov (4): Don't look for weston.ini in the current working directory Revert "Fix a crash when unlocking or unconf

[ANNOUNCE] wayland 1.16.91

tests: Use volatile pointer for NULL dereference tests: Overly elaborate compiler warning workaround tests: Remove memory leak checking infrastructure Derek Foreman (3): configure.ac: Reopen master for regular development protocol: Bump seat to version 7 and require keymaps

Weston/wayland release schedule

Hello, Thanks everyone for the flurry of activity reviewing and landing important patches for the release! In agreement with Daniel's suggestion to freeze and release today, I'm going to start rolling the alpha shortly. Here's the final release schedule: Alpha: today, February 19th Beta: March

Re: Upcoming release

On 1/30/19 6:58 AM, Alexandros Frantzis wrote: > On Fri, Jan 25, 2019 at 10:05:47AM -0600, Derek Foreman wrote: >> On 1/18/19 4:20 PM, Derek Foreman wrote: >>> Hi all, >>> >>> It's been quite some time since our last weston release, and there's >>> bee

Re: Upcoming release

On 1/30/19 6:19 AM, Pekka Paalanen wrote: > On Mon, 28 Jan 2019 12:13:12 +0200 > Pekka Paalanen wrote: > >> On Fri, 25 Jan 2019 10:05:47 -0600 >> Derek Foreman wrote: >> >>> On 1/18/19 4:20 PM, Derek Foreman wrote: >>>> Hi all, >>>>

Re: Upcoming release

On 1/18/19 4:20 PM, Derek Foreman wrote: > Hi all, > > It's been quite some time since our last weston release, and there's > been some discussion of getting the next one out in the January to March > timeframe (this would be the last release to have an autotools build, btw). &

Upcoming release

Hi all, It's been quite some time since our last weston release, and there's been some discussion of getting the next one out in the January to March timeframe (this would be the last release to have an autotools build, btw). Does anyone have objections to an early February freeze and a March

Re: [PATCH wayland] protocol: Bump seat to version 7 and require keymaps be private

On 11/2/18 6:15 AM, Pekka Paalanen wrote: > On Thu, 1 Nov 2018 11:15:46 -0500 > Derek Foreman wrote: > >> Weston commit 76829fc4eaea329d2a525c3978271e13bd76c078 (and similar >> commits for other compositors) protects the compositor's keyboard >> mapping from c

Re: [PATCH v2] protocol: prefer wl_surface.damage_buffer

On 11/5/18 1:44 PM, Derek Foreman wrote: > On 11/5/18 7:57 AM, Simon Ser wrote: >> This commit makes wl_surface.damage_buffer preferred over wl_surface.damage. >> wl_surface.damage can be implemented in a non-optimal way by the compositor >> (e.g. by always damaging the whole

Re: [PATCH] wayland-server: update the client fd when it failed to flush with EAGAIN

On 11/22/18 11:08 PM, Jeonghyun Kang wrote: > When a wayland compositor gets an EAGAIN error whenever > sending or receiving event(s) to a client in the > wl_closure_send() or the wl_closure_queue(), the error > variable of the wl_client for the client will be set to > true and the client is going

Re: [PATCH wayland-protocols v3] Add alpha-compositing protocol

This looks nice to me, and I have need of something like this. A couple of comments below. On 11/14/18 7:00 PM, Scott Anderson wrote: > This protocol specifies a set of interfaces used to control the alpha > compositing and blending of surface contents, based on the Chromium > Wayland protocol

Re: [PATCH] protocol: deprecate wl_surface.damage

On 11/5/18 7:43 AM, Simon Ser wrote: > On Monday, November 5, 2018 11:07 AM, Pekka Paalanen > wrote: >> How about writing what Derek said: that the old damage request may be >> unoptimal rather than deprecated. >> >> I don't like "deprecated" because to me it implies that this request >> will be

Re: [PATCH v2] protocol: prefer wl_surface.damage_buffer

hers in the repo, and 8 spaces are compressed into a single tab. Otherwise, this is: Reviewed-by: Derek Foreman > --- > protocol/wayland.xml | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/protocol/wayland.xml b/protocol/wayland.xml > index 141038b..df2

Re: [PATCH] protocol: deprecate wl_surface.damage

IMHO this is a win. Reviewed-by: Derek Foreman I think we can follow it up by removing surface damage in surface co-ordinates from weston clients - if we don't want people using it, we shouldn't be giving then good examples of how. I also think it's reasonable for compositor writers to take

Re: [PATCH wayland] protocol: Bump seat to version 7 and require keymaps be private

rek > 2018-11-01 (木) の 11:15 -0500 に Derek Foreman さんは書きました: >> Weston commit 76829fc4eaea329d2a525c3978271e13bd76c078 (and similar >> commits for other compositors) protects the compositor's keyboard >> mapping from client damage by duplicating the keymap for every >>

[PATCH wayland] protocol: Bump seat to version 7 and require keymaps be private

or a similar facility, it should still protect itself with copied keymaps, but clients must always assume shared mapping of a keymap will fail. Signed-off-by: Derek Foreman --- protocol/wayland.xml | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/protocol/wayland.xml b

Re: [PATCH v2] server: add wl_signal_emit_safe

On 2018-08-08 07:00 AM, Simon Ser wrote: > This new function allows listeners to remove themselves or any > other listener when called. This version only works if listeners > are properly removed before they are free'd. > > wl_signal_emit tries to be safe but it fails: it works fine if a >

[ANNOUNCE] weston 5.0.0

with another preference, please speak up! Derek Foreman (1): configure.ac: bump to version 5.0.0 for the official release Stefan Agner (1): compositor-drm: add DPI connector type git tag 5.0.0 https://wayland.freedesktop.org/releases/weston-5.0.0.tar.xz MD5

[ANNOUNCE] wayland 1.16.0

changes occur. At this point I don't see a need to schedule a next wayland release, but if one hasn't occurred when we near the time weston's ready for its next major release, we can look at what's landed and decide if there's a need. If that's a bad idea, please speak up! Derek Foreman (1

Re: [PATCH weston 2/2] input: Update to-be-restored focus when unfocused

k upstream, except I set up > an entire qemu image using NixOS to test this, and that seems a little > heavyweight. I can't think of an easier way to test drm-backend stuff > though... Would still be interesting to take a look at, I think. Thanks, Derek > Jamey

Re: [PATCH weston 2/2] input: Update to-be-restored focus when unfocused

On 2018-08-16 02:33 AM, Quentin Glidic wrote: > On 8/16/18 5:24 AM, Peter Hutterer wrote: >> On Fri, Aug 10, 2018 at 12:55:42PM -0500, Derek Foreman wrote: >>> On 2018-08-02 03:32 AM, Quentin Glidic wrote: >>>> On 8/2/18 10:29 AM, Quentin Glidic wrote: >>>>

[ANNOUNCE] weston 4.0.94

Hello, The RC2 release candidate for weston 5.0 is now available. We've gone to RC2 here as well, as a patch has landed to fix a bug allowing clients to corrupt the compositor's keyboard mapping. Derek Foreman (3): input: add weston_keyboard_send_keymap helper function input: Send

[ANNOUNCE] wayland 1.15.94

Hello, The RC2 release candidate for wayland 1.16 is now available. We've had to go to RC2 as this release contains a bug fix for a pointer overflow condition. Some discussion at: https://gitlab.freedesktop.org/wayland/wayland/issues/50 Derek Foreman (1): configure.ac: bump to version

Re: [PATCH 3/3] connection: Prevent pointer overflow from large lengths.

, 7 insertions(+), 5 deletions(-) > > Hi, > > this looks correct to me and should address Jann's concerns too. I also > checked that (end - p) cannot become negative. > > Reviewed-by: Pekka Paalanen Also Reviewed-by: Derek Foreman I'll land this and the 2nd patch in the seri

Re: [PATCH 2/3] connection: Prevent integer overflow in DIV_ROUNDUP.

)) / a); >> +} > > The above has a few style issues: > - div_roundup should start on a new line as it is a function now > - use /* */ comment style > - use tabs for indent > - missing Signed-off-by > > But aside from those, this patch is: > > Reviewed-by: Pekka P

[ANNOUNCE] weston 4.0.93

Hello, The RC1 release candidate for weston 5.0 is now available. Daniel Stone (3): doc: Update CONTRIBUTING for Weston README: Move to Markdown, rewrite introduction doc: Use GitLab MRs for patches, not the list Derek Foreman (1): configure.ac: bump to version 4.0.93

[ANNOUNCE] wayland-1.15.93

Hello, The RC1 release candidate for wayland 1.16 is now available. Daniel Stone (1): contributing: Weston now uses GitLab MRs Derek Foreman (1): configure.ac: bump to version 1.15.93 for the RC1 release git tag: 1.15.93 https://wayland.freedesktop.org/releases/wayland-1.15.93

Re: [PATCH weston 2/2] input: Update to-be-restored focus when unfocused

On 2018-08-02 03:32 AM, Quentin Glidic wrote: > On 8/2/18 10:29 AM, Quentin Glidic wrote: >> From: Quentin Glidic >> >> If we start a special (grabbing) client when Weston is unfocused, it >> would lose focus when coming back to Weston. >> >> A first attempt to fix this was

[ANNOUNCE] weston 4.0.92

Hello, Here is the beta release for weston 5.0. Daniel Stone (3): compositor-drm: Remove unnecessary libdrm defines compositor-drm: Don't test render-only atomic configuration compositor-drm: Remove addfb warning for user buffers Derek Foreman (1): configure.ac: bump

[ANNOUNCE] wayland 1.15.92

Hello, Here is the beta for the 1.16 release. Daniel Stone (3): build: Remove execinfo.h check build: Remove support for non-pkg-config Expat spec: Delete old unused directory Derek Foreman (2): wayland-server: Finally remove deprecated struct wl_buffer definition

Re: [PATCH] compositor-drm: Remove addfb warning for user buffers

Failing AddFB from user-supplied buffers though, is not an error. The > user can't necessarily allocate suitable buffers, nor does it have to. > Don't spam the log with warnings when we fail on user buffers. > > Signed-off-by: Daniel Stone > Reported-by: Pekka Paalanen Reviewed-

Re: [PATCH] compositor-drm: Don't test render-only atomic configuration

t; > Signed-off-by: Daniel Stone This looks right to me, and is apparently quite important as it fixes VT switching. I'm not really well versed enough in this code to give a solid RB, but I'm going to land it shortly with Acked-by: Derek Foreman > --- > libweston/compositor-drm.c

Re: [PATCH wayland 1/2] spec: Delete old unused directory

On 2018-07-22 04:17 AM, Daniel Stone wrote: > The protocol spec used to live here, but it's now part of the regular > doc build. The PNG files are created as part of the doc build. Delete > the pre-generated versions. > > Signed-off-by: Daniel Stone Nice find. Reviewed-by

Re: [PATCH] compositor-drm: Remove unnecessary libdrm defines

IDTH and HEIGHT were added in libdrm 2.4.68 > (cc9a53f076d4). Thank you for making this so trivial to review! :) > Remove these four fallback definitions. > > Signed-off-by: Daniel Stone Reviewed-by: Derek Foreman > --- > libweston/compositor-drm.c | 16 > 1 file

Re: [PATCH wayland 2/2] build: Remove support for non-pkg-config Expat

352cfc8f59a7, in September 2007. > > Drop build support for versions of Expat which do not ship a > pkg-config file. > > Signed-off-by: Daniel Stone Looks good to me Reviewed-by: Derek Foreman > --- > configure.ac | 11 +-- > 1 file changed, 1 insertion(+), 10 deletions

Re: [PATCH wayland 1/2] build: Remove execinfo.h check

wayland libraries") with no obvious use or reasoning. 5cfdbe3d299 just moved it, it was added in commit bc3e020475 It appears to have been accidentally included there, as it doesn't look relevant to the bug ticket referenced in the commit. > Remove the no-op check. > > Signed-off-by: Daniel Sto

Re: [RFC wayland] wayland-server: Finally remove deprecated struct wl_buffer definition

On 2018-07-14 09:46 AM, Daniel Stone wrote: > Hey Derek, > On Fri, 16 Feb 2018 at 16:55, Derek Foreman wrote: >> commit d94a8722cb29d8b897672be66ff3c9ff79eab6fe >> warned this was coming, back in 2013. >> >> I've seen libraries that have wayland client and server

Re: [RFC weston] clients: Don't attach a buffer if mouse cursor surface is unchanged

On 2018-07-22 05:55 AM, Daniel Stone wrote: > Hey Derek, > > On Thu, 22 Feb 2018 at 22:16, Derek Foreman wrote: >> Keep track of what cusor image buffer is attached to the cursor >> surface and avoid re-attaching it if we don't have to. >> >> This isn't just an

[ANNOUNCE] wayland 1.15.91

for the download URLs to work for both of these releases. Full change history: Daniel Stone (2): Add .gitlab-ci.yml doc: Update URLs for GitLab transition Derek Foreman (4): configure.ac: Reopen master for regular development tests: Test for use after free in resource destruction

[ANNOUNCE] weston 4.0.91

r: fix compilation against FreeRDP 2.0.0 rc2 Derek Foreman (3): configure.ac: Reopen master for regular development configure.ac: Bump libweston version to match weston version configure.ac: bump to version 4.0.91 for the alpha release Dima Ryazanov (1): Fix a crash when unl

Re: [PATCH wayland 1/4] contributing: how to read the review rules

> > Series is: > Reviewed-by: Daniel Stone Agreed. Reviewed-by: Derek Foreman I'll land the series right before I do the release today. Thanks, Derek > Cheers, > Daniel > ___ > wayland-devel mailing list > wayland-devel@li

Re: Upcoming release reminder

On 2018-07-03 04:33 PM, Derek Foreman wrote: > Hi all, > > Just a quick reminder that we're due for alpha shortly, with the > following intended release schedule: I'd like to push this back to Friday, it looks like some atomic patches are just about ready to land, and it seems a sh

Upcoming release reminder

Hi all, Just a quick reminder that we're due for alpha shortly, with the following intended release schedule: Alpha - July 10th Beta - July 24th RC1 - August 7th First possible release August 14th. Thanks, Derek ___ wayland-devel mailing list

Re: [PATCH wayland 0/2] Document review and commit access requirements

elines will not be perfect from the start. They should we honed > over time. > > > Thanks, > pq > > > Pekka Paalanen (2): > contributing: add review guidelines > contributing: commit rights Really like these, and both are: Reviewed-by: Derek For

Re: Release schedule

On 2018-06-14 02:08 AM, Pekka Paalanen wrote: > On Wed, 13 Jun 2018 21:05:03 -0400 > ferreiradaselva wrote: > >> Any chance of the XDG decoration protocol being part of this release plan? > > Hi, > > wayland-protocols is not part of this release plan. It is much more > free to release at

Re: Release schedule

On 2018-06-08 03:21 AM, Pekka Paalanen wrote: > On Thu, 7 Jun 2018 15:45:00 -0500 > Derek Foreman wrote: > >> On 2018-06-04 07:14 AM, Daniel Stone wrote: >>> Hi Pekka, >>> >>> On 4 June 2018 at 12:29, Pekka Paalanen wrote: >>>> On S

Re: Release schedule

On 2018-06-04 07:14 AM, Daniel Stone wrote: > Hi Pekka, > > On 4 June 2018 at 12:29, Pekka Paalanen wrote: >> On Sun, 3 Jun 2018 10:52:49 +0100 >> Daniel Stone wrote: >>> On 1 June 2018 at 17:52, Derek Foreman wrote: >>> Maybe? There's certainly a t

Release schedule

Hi all, Our last release for wayland and weston was April 9th, and there has been some talk on IRC about release schedules, so maybe it's time to start planning for the next one. Previously it looks like we've been on a 6 month cycle with releases in February and August. Following that duration

Re: [PATCH wayland] wayland-server: Properly handle EAGAIN from wl_connection_read()

On 2018-04-19 09:18 AM, Derek Foreman wrote: > On 2018-04-19 09:01 AM, Derek Foreman wrote: >> From: Dipen Somani <dipen.som...@samsung.com> >> >> commit 3cddb3c692acd3536a7cc8542a29f0cc3c0ac3d6 casted len to an >> unsigned value to compare to sizeof results. How

Re: [PATCH v2 0/3] Deal with destroy signal use after free issues

I've pushed this series now. Thanks, Derek On 2018-04-16 03:00 PM, Derek Foreman wrote: > Now that the release is out, I'd like to dig back into this mess. > This is a round up of some patches that were on list shortly before > the release to deal with a problem where many existing l

Re: [PATCH v2 0/3] Deal with destroy signal use after free issues

ovide the > testcase that shows an issue. > Since it's originally authored by me, I guess my R-B would be weird there :) I didn't put my R-B on it because I made a (mostly cosmetic) change to it, and wasn't sure if that was ok. Thanks, Derek > Cheers, > ongy > > On 2018/Apri

[PATCH v2 3/3] tests: Add free-without-remove test

From: Markus Ongyerth <w...@ongy.net> [Derek Foreman <der...@osg.samsung.com> moved this into resources-test] --- I moved this behind Markus' back, so let's not go landing it if he's not ok with that change. I think it's a great illustration of the problem and would like to see it

[PATCH v2 2/3] server: Add special case destroy signal emitter

destroy emit, and put it in a list all its own. This way whether the listener is removed or not has no impact on the following emits. Signed-off-by: Derek Foreman <der...@osg.samsung.com> --- Changes since v1: In v1 I went through some ugly steps to ensure wl_priv_signal_get() worked. It

[PATCH v2 0/3] Deal with destroy signal use after free issues

- this is an attempt to "fix" the problem, by making the destroy signal emit operate without ever touching potentially free()d elements again. Markus' test that would fail without patch 2/3, as it catches the free() without removal case we've all come to know any love. Derek Foreman (2): tests: Te

Re: EXT: [PATCH weston v6 00/73] Head-based output configuration API a.k.a clone mode infrastructure

Patches 25-30 clean up libweston after the frontend migration. >>> >>> Patches 18-30 : Reviewed-by Ian Ray <ian@ge.com> >>> >>> >>>>> >>>>> - Patches 31-38 migrate all the backends to the head-based API. At this >>>

[ANNOUNCE] wayland 1.15.0

-egl: Make symbol test fail on failure wayland-egl: Ignore underscored symbols in ABI check Derek Foreman (28): protocol: Suggest get_registry not be called frequently connection: close_fds() should only remove fds it closed from the buffer client: Simplify some logic in q

[ANNOUNCE] weston 4.0.0

compositor-drm: Remove no_addfb2 handling compositor-wayland: Ignore pointer enter on destroyed surface terminal: Fix unintended fallthrough to cursor restore David Fort (2): Fix API troubles with FreeRDP 2.0 v2 rdp compositor: add a man page and add links to that page Derek

Re: [PATCH] terminal: Fix unintended fallthrough to cursor restore

obviously correct to me Reviewed-by: Derek Foreman <der...@osg.samsung.com> And pushed. Thanks, Derek > > Signed-off-by: Daniel Stone <dani...@collabora.com> > --- > clients/terminal.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/clients/terminal.c

[ANNOUNCE] weston 3.0.93

also been removed until the next release when there's more time to review the fixes. If all goes well we're looking at an April 9th release date. Derek Foreman (4): xwm: Fix two more icon related memory leaks Revert "xwm: do not include shadow in input region" Partia

[ANNOUNCE] wayland 1.14.93

This is the RC1 for the wayland 1.15 release. If all goes well, the next release will be on Monday April 9th. This release fixes make check under platforms (such as ARM) where our ABI check test was broken. Daniel Stone (1): wayland-egl: Ignore underscored symbols in ABI check Derek

Re: [PATCH wayland 2/2] .gitignore: add wayland-egl-abi-check

On 2018-03-20 06:10 AM, Emil Velikov wrote: > From: Emil Velikov <emil.veli...@collabora.com> > > Instruct git go ignore the file, in case we've done an in-tree build. > > Cc: Derek Foreman <der...@osg.samsung.com> > Signed-off-by: Emil Velikov <emil.veli...@

[PATCH v2 weston] Partially revert "xwm: Add icon support to the frame" and friends

can lead to very strange rendering. At window close time the wrong sized icon appears above the window during fade out. This patch reverts the mostly solid bits and keeps the unfinished bits behind in favor of a simpler revert than removing the whole thing. Signed-off-by: Derek Foreman <

Re: [PATCH weston] Revert "xwm: Add icon support to the frame" and friends

On 2018-03-29 09:10 AM, Derek Foreman wrote: > On 2018-03-29 08:59 AM, Derek Foreman wrote: >> This reverts commit bef761796c2ada6344d227142af4a0f40b9760dd. >> This (partially) reverts commit 4d1cd36c9ea041688f92cd8981e43b5fe3b52409. >> - the frame_destroy in weston_wm_win

Re: [PATCH weston] Revert "xwm: Add icon support to the frame" and friends

On 2018-03-29 08:59 AM, Derek Foreman wrote: > This reverts commit bef761796c2ada6344d227142af4a0f40b9760dd. > This (partially) reverts commit 4d1cd36c9ea041688f92cd8981e43b5fe3b52409. > - the frame_destroy in weston_wm_window_destroy() remains > This re

[PATCH weston] Revert "xwm: Add icon support to the frame" and friends

changes and review cycles. Reverting this all for now for the upcoming release. Signed-off-by: Derek Foreman <der...@osg.samsung.com> --- clients/window.c | 4 +- libweston/compositor-wayland.c | 2 +- shared/cairo-util.h| 6 +-- shared/frame.c

Re: [PATCH v5 weston] xwm: Choose icon closest to target size

500 > Derek Foreman <der...@osg.samsung.com> wrote: > >> Xwayland clients can offer multiple icon sizes in no particular order. >> Previously xwm was selecting the first one unconditionally. This patch >> selects the icon that matches the size closest to the target

Re: [PATCH v2] xwm: Update input region on resize

On 2018-03-28 12:55 AM, Ray, Ian (GE Healthcare) wrote: > On 27/03/2018, 21.50, "wayland-devel on behalf of Derek Foreman" > <wayland-devel-boun...@lists.freedesktop.org on behalf of > der...@osg.samsung.com> wrote: >> >> Hey everyone, >> >>

Re: [PATCH weston] xwm: Fix two more icon related memory leaks

On 2018-03-28 08:56 AM, Pekka Paalanen wrote: > On Tue, 27 Mar 2018 11:09:32 -0500 > Derek Foreman <der...@osg.samsung.com> wrote: > >> Hopefully sort the last leaks introduced in commit 6b58ea8c >> >> The window could be destroyed before it had a frame but

Re: [PATCH v2] xwm: Update input region on resize

an xwayland client doesn't update input region) If there are no fixes forthcoming I'd like to revert commit 332d1892bbb before RC1 (which is still scheduled for release on Monday, April 2). Thanks, Derek On 2018-03-19 03:20 PM, Scott Moreau wrote: > > > On Mon, Mar 19, 2018 at 1:13

[PATCH v5 weston] xwm: Choose icon closest to target size

Xwayland clients can offer multiple icon sizes in no particular order. Previously xwm was selecting the first one unconditionally. This patch selects the icon that matches the size closest to the target size. The target size is hard coded to 16 since there is only one theme and the data used to

[PATCH weston] xwm: Fix two more icon related memory leaks

leak was Reported-by: Scott Moreau <ore...@gmail.com> Signed-off-by: Derek Foreman <der...@osg.samsung.com> --- xwayland/window-manager.c | 5 + 1 file changed, 5 insertions(+) diff --git a/xwayland/window-manager.c b/xwayland/window-manager.c index dad117fa..7b98e140 100644 --

Re: [PATCH v3] xwm: Fix memory leak

On 2018-03-26 08:36 AM, Pekka Paalanen wrote: > On Fri, 23 Mar 2018 15:07:07 -0500 > Derek Foreman <der...@osg.samsung.com> wrote: > >> On 2018-03-23 02:41 PM, Scott Moreau wrote: >>> A memory leak introduced by 6b58ea8c led to me finding a bigger leak, >>>

Re: [PATCH v4 2/2] xwm: Scale icon if size is not the target size

double width, double height) Still have some whitespace issues here. Otherwise, this is Reviewed-by: Derek Foreman <der...@osg.samsung.com> Does this + your leak fix close all known bugs in the icon code? Thanks, Derek > +{ > + cairo_surface_t

Re: [PATCH v4 1/2] xwm: Choose icon closest to target size

coded to 16 since there is only one theme and the > data used to create the theme is hard coded. LGTM, Reviewed-by: Derek Foreman <der...@osg.samsung.com> > --- > > Changed in v2: > > - Fix typo setting width to height > > Changed in v3: > > - Move checks

Re: [PATCH v3] xwm: Fix memory leak

troy handler for it broken. Here we fix this by calling > frame_destroy() when the window is destroyed and free the reply in > the icon_surface destroy handler. Reviewed-by: Derek Foreman <der...@osg.samsung.com> Though, I guess this should probably be split into two, in case the icon stuff n

Re: [PATCH v2] xwm: Fix memory leak

/* Bail out in case anything wrong happened during surface creation. */ > if (cairo_surface_status(new_surface) != CAIRO_STATUS_SUCCESS) { > cairo_surface_destroy(new_surface); > + free(reply); > return; &

Re: [PATCH 2/2 v2] xwm: Scale icon if size is not the target size

On 2018-03-22 01:04 AM, Scott Moreau wrote: > This scales the icon cairo surface for the titlebar if it isn't the > target size. > > shared/cairo-util: Add surface resizing function to be used for this > case and other potential cases. > --- > > Changed in v2: > > - Rebase to [PATCH 1/1 v3]

Re: [PATCH v3] xwm: Choose icon closest to target size

Thanks for this. This particular feature is getting on my nerves because it seemed like a simple thing and has result in a lot of breakage. Would like to see it repaired or removed by late next week. This seems to be a good step towards repair, comments inline below. On 2018-03-22 12:47 AM,

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

On 2018-03-20 10:02 AM, Emil Velikov wrote: > On 20 March 2018 at 14:50, Derek Foreman <der...@osg.samsung.com> wrote: >> On 2018-03-20 07:11 AM, Daniel Stone wrote: >>> On 20 March 2018 at 11:55, Emil Velikov <emil.l.veli...@gmail.com> wrote: >>>> On

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

have no-one > notice that in review. I think that's a reasonable tradeoff. I'm inclined to agree with Daniel here. Someone managing to sneak a WL_EXPORT on a symbol starting with a _ past review seems reasonably unlikely. And after reading this

[ANNOUNCE] weston 3.0.92

compositor-wayland: Ignore pointer enter on destroyed surface Derek Foreman (2): libweston-desktop/xdg-shell-v6: Fix crash when surface has buffer at creation configure.ac: bump to version 3.0.92 for the beta release Dima Ryazanov (2): weston: Add a help string for --xwayland Fix

[ANNOUNCE] wayland 1.14.92

This is the beta for the wayland 1.15 release. Daniel Stone (2): wayland-egl: Pass nm path to check script wayland-egl: Make symbol test fail on failure Derek Foreman (3): client: Don't inappropriatly close fds for zombie objects walyand-client: Fix trivial build break

Re: [PATCH weston v4 4/4] simple-dmabuf-drm: support etnaviv drm as well

mabuf client]) have_simple_dmabuf_drm_client=yes, + [have_etnaviv=no]) why the have_etnaviv=no here when the rest are all [true]? With that explained, this is Reviewed-by: Derek Foreman <der...@osg.samsung.com> But I'm about to start the release process for the beta, so I think this wil

Re: [PATCH weston v4 2/4] simple-dmabuf-drm: use large enough buffer (freedreno)

On 2018-03-19 12:23 PM, Eric Engestrom wrote: On Monday, 2018-03-19 17:45:19 +0100, Guido Günther wrote: Use stride instead of width for buffer calculation. Signed-off-by: Guido Günther --- clients/simple-dmabuf-drm.c | 6 -- 1 file changed, 4 insertions(+), 2

Re: [PATCH v2] xwm: Update input region on resize

On 2018-03-16 06:42 PM, Scott Moreau wrote: Hi Pekka, On Fri, Mar 16, 2018 at 9:20 AM, Pekka Paalanen > wrote: On Tue, 13 Mar 2018 21:22:04 -0600 Scott Moreau > wrote: > Commit 332d1892

Re: [PATCH weston v4 1/4] simple-dmabuf-drm: Always define ALIGN

On 2018-03-19 11:45 AM, Guido Günther wrote: Other backends might want to use it. Signed-off-by: Guido Günther <a...@sigxcpu.org> Reviewed-by: Derek Foreman <der...@osg.samsung.com> (and pushed) Thanks, Derek --- clients/simple-dmabuf-drm.c | 2 +- 1 file changed, 1 ins

Re: [PATCH wayland] wayland-egl: Make symbol test fail on failure

On 2018-03-19 11:20 AM, Eric Engestrom wrote: On Monday, 2018-03-19 16:10:57 +, Daniel Stone wrote: Hi, On 19 March 2018 at 16:08, Eric Engestrom wrote: On Monday, 2018-03-19 15:13:14 +, Daniel Stone wrote: +if ! test -f "$LIB"; then + echo "Test

Re: [PATCH weston] libweston-desktop/xdg-shell-v6: Fix crash when surface has buffer at creation

On 2018-03-13 01:18 PM, Quentin Glidic wrote: On 3/13/18 5:34 PM, Derek Foreman wrote: When a surface has a buffer at creation time we send an error, which results in a disconnection and all resources being destroyed. Since we send that error and return before performing the configure_list

  1   2   3   4   5   6   7   8   9   10   >