Re: [PATCH] xdg-shell: Align surface life-time rules with that of wl_shell

2014-07-21 Thread Jasper St. Pierre
Note that I fixed GTK+ to always create a new wl_surface and never reuse it. I don't think it makes any sense to keep the wl_surface around in the background. I certainly don't think it ever makes sense to destroy the xdg_surface and then make it into an xdg_popup or similar. The semantics of

Re: Fwd: [PATCH weston] xdg-shell: Make stable

2014-07-18 Thread Jasper St. Pierre
The lack of an unset_minimized feature is very intentional. The *goal*, it sounds like, is to present the window immediately again, but an unset_minimized won't do that. What if the window is on a different workspace, or has been simply stacked behind another set of windows? unset_minimized won't

Re: [PATCH wayland 3/6] server: Split out code to initialize the socket address for a display name

2014-07-18 Thread Jasper St. Pierre
Does the off-by-one matter? I don't think bind actually cares. On Fri, Jul 18, 2014 at 4:13 AM, Marek Chalupa mchqwe...@gmail.com wrote: On 17 July 2014 19:54, Jasper St. Pierre jstpie...@mecheye.net wrote: We'll use this to autodetect a good socket to open on. --- src/wayland-server.c

Re: Fwd: [PATCH weston] xdg-shell: Make stable

2014-07-18 Thread Jasper St. Pierre
On Fri, Jul 18, 2014 at 2:26 PM, Bill Spitzak spit...@gmail.com wrote: On 07/18/2014 09:55 AM, Jason Ekstrand wrote: I really like Jasper's present request solution to this problem. (It could probably also be called attention). If kwin wants to implement that as move to the appropriate

Re: libinput returns multiple keyboards that do not generate events

2014-07-17 Thread Jasper St. Pierre
Why do you need to know which one is the real keyboard? Just listen to events from all of them. On my laptop, I also have six keyboards. They are: Power Button Video Bus Sleep Button Integrated Camera AT Translated Set 2 keyboard (this is the actual keyboard keyboard)

Re: libinput returns multiple keyboards that do not generate events

2014-07-17 Thread Jasper St. Pierre
...@gmail.com wrote: 2014-07-17 14:20 GMT+02:00 Jasper St. Pierre jstpie...@mecheye.net: Why do you need to know which one is the real keyboard? Just listen to events from all of them. On my laptop, I also have six keyboards. They are: Power Button Video Bus Sleep Button

Re: libinput returns multiple keyboards that do not generate events

2014-07-17 Thread Jasper St. Pierre
I don't see a benefit for running directly on a Linux console. I don't have any examples of using udev on me at the moment, but Weston should have a few. On Thu, Jul 17, 2014 at 8:43 AM, Stefanos A. stapos...@gmail.com wrote: 2014-07-17 14:39 GMT+02:00 Jasper St. Pierre jstpie...@mecheye.net

[PATCH wayland 5/6] server: Save the display name in the wl_socket

2014-07-17 Thread Jasper St. Pierre
This allows us to return the display name to the client in a new API. --- src/wayland-server.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/wayland-server.c b/src/wayland-server.c index 5c0e84f..55b3e25 100644 --- a/src/wayland-server.c +++ b/src/wayland-server.c @@ -63,6 +63,7 @@

[PATCH wayland 0/6] Introduce API to automatically find a good default display

2014-07-17 Thread Jasper St. Pierre
This patch series introduces a new API to find an open Wayland display so that compositors don't need to reimplement all this code. This way, the code searching for an appropriate socket can be shared between all compositors. Jasper St. Pierre (6): server: Clean up socket destruction server

[PATCH wayland 4/6] server: Make get_socket_lock operate directly on the socket's lock_fd

2014-07-17 Thread Jasper St. Pierre
--- src/wayland-server.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/wayland-server.c b/src/wayland-server.c index 3350751..5c0e84f 100644 --- a/src/wayland-server.c +++ b/src/wayland-server.c @@ -1021,27 +1021,27 @@ socket_data(int fd,

[PATCH wayland 3/6] server: Split out code to initialize the socket address for a display name

2014-07-17 Thread Jasper St. Pierre
We'll use this to autodetect a good socket to open on. --- src/wayland-server.c | 41 ++--- 1 file changed, 26 insertions(+), 15 deletions(-) diff --git a/src/wayland-server.c b/src/wayland-server.c index d919eb2..3350751 100644 --- a/src/wayland-server.c +++

[PATCH wayland 1/6] server: Clean up socket destruction

2014-07-17 Thread Jasper St. Pierre
The code here is wrong, leaky, and inconsistent. We don't free, unlink or clean up things when we should in every error path. Centralize the data destruction so it's easier to keep track of and easier to bug fix. --- src/wayland-server.c | 49 - 1

[PATCH wayland 6/6] server: Add a simple API to find a good default display

2014-07-17 Thread Jasper St. Pierre
This allows compositors to easily select a good display to listen on. --- src/wayland-server.c | 97 ++-- src/wayland-server.h | 1 + 2 files changed, 73 insertions(+), 25 deletions(-) diff --git a/src/wayland-server.c b/src/wayland-server.c index

[PATCH wayland 2/6] server: Create the socket FD after taking the lock

2014-07-17 Thread Jasper St. Pierre
We're going to split out the lock-taking to another function so we can repetitively try locks. --- src/wayland-server.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/wayland-server.c b/src/wayland-server.c index 3e0fb25..d919eb2 100644 ---

[PATCH weston] compositor: Use libwayland to find a good default display for us

2014-07-17 Thread Jasper St. Pierre
--- src/compositor.c | 67 1 file changed, 38 insertions(+), 29 deletions(-) diff --git a/src/compositor.c b/src/compositor.c index 17fce8d..5eb8ac8 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -4153,7 +4153,7 @@ int main(int

[PATCH weston] xdg-shell: Make stable

2014-07-17 Thread Jasper St. Pierre
We've gone through enough churn of xdg-shell that we're now feeling confident enough to commit to this much. Let's do it. The major version number is bumped to 2 because unfortunately we need to remove the use_unstable_version API. --- clients/simple-damage.c | 9 +-- clients/simple-egl.c

Re: New guy

2014-07-15 Thread Jasper St. Pierre
On Tue, Jul 15, 2014 at 7:48 AM, Magnus Hoff maghoff+wayl...@gmail.com wrote: Hi :) I'm Magnus, and I'd like to help. I'm not scared of working with low-level stuff in C :) My experience is more with C++, so I will need some getting used to C idioms. I have successfully installed and run

Re: Sending keyboard events?

2014-07-07 Thread Jasper St. Pierre
It is not possible to send keyboard events to arbitrary other windows or clients. You have no knowledge that these clients or windows actually exist, even. On Mon, Jul 7, 2014 at 4:44 PM, Pouar thepo...@gmail.com wrote: On 07/07/2014 03:33 PM, Pouar wrote: On X I have a program that maps

Re: Sending keyboard events?

2014-07-07 Thread Jasper St. Pierre
Yes, it's builtin to the compositor. On Mon, Jul 7, 2014 at 5:31 PM, Pouar thepo...@gmail.com wrote: On 07/07/2014 03:49 PM, Jasper St. Pierre wrote: It is not possible to send keyboard events to arbitrary other windows or clients. You have no knowledge that these clients or windows

Re: x11/GLX/GL on top of wayland

2014-07-04 Thread Jasper St. Pierre
Xwayland has DRI3/Present support, which means that any app that uses DRI3 will work fine under it. Right now, this is the Intel driver, with support for the other FOSS drivers coming soon. Otherwise, we fall back to non-hardware-accelerated codepaths. It won't break, but it will mean that you

Re: x11/GLX/GL on top of wayland

2014-07-04 Thread Jasper St. Pierre
Wayland compositor using the secret wl_drm interface. I'm told that the nouveau and radeon drivers now have support for DRI3 as of last week. On Fri, Jul 4, 2014 at 10:17 AM, Sylvain BERTRAND sylw...@legeek.net wrote: On Fri, Jul 04, 2014 at 09:48:20AM -0400, Jasper St. Pierre wrote

Re: Global shortkeys and keyboard focus

2014-07-04 Thread Jasper St. Pierre
I think the user should be in control here. I have a custom setup just because it's something I did 10 years ago and it's engrained into my muscle memory. Ctrl+Shift+X is pause/play music Ctrl+Shift+C is play music (which also means rewinding the current track to the beginning) Ctrl+Shift+D is

Re: X and wayland api

2014-07-02 Thread Jasper St. Pierre
Wayland is not a 1:1 mapping of the X APIs. We can't send you such a list, because the programming models are different. On Wed, Jul 2, 2014 at 6:57 AM, Pooja Thakoor pooja.thakoo...@gmail.com wrote: I want to shift from X to Wayland programming. Can someone provide me with the wayland api

Re: Wayland program

2014-07-02 Thread Jasper St. Pierre
Have you looked at the simple-shm Wayland example? This shows a very simple Wayland program. http://cgit.freedesktop.org/wayland/weston/tree/clients/simple-shm.c If you have questions about it, we can explain them. On Wed, Jul 2, 2014 at 6:58 AM, Pooja Thakoor pooja.thakoo...@gmail.com wrote:

Re: wl_tablet specification draft

2014-07-01 Thread Jasper St. Pierre
A blink in the highlighting? On Tue, Jul 1, 2014 at 3:32 PM, Bill Spitzak spit...@gmail.com wrote: On 06/30/2014 09:50 PM, Peter Hutterer wrote: Yes this makes sense. Sorry I was confusing it with the X implementation where the Enter event replaced a Move event. it does? it's actually

Re: Window placement

2014-07-01 Thread Jasper St. Pierre
No, you don't. You cannot possibly reuse the saved settings on different OSes with different output layouts. On Windows, there's a taskbar at the bottom (yes, it's technically configurable, I know). On OS X, there's a menu bar at the top. You have no idea what windows are around you and where

Re: Window placement

2014-07-01 Thread Jasper St. Pierre
On Tue, Jul 1, 2014 at 4:05 PM, Bill Spitzak spit...@gmail.com wrote: On 07/01/2014 12:57 PM, Jasper St. Pierre wrote: No, you don't. You cannot possibly reuse the saved settings on different OSes with different output layouts. You are wrong. We use it all the time. These systems

Re: Window placement

2014-06-29 Thread Jasper St. Pierre
On Sun, Jun 29, 2014 at 12:21 PM, Fabrice Rey faboune...@gmail.com wrote: By the application and the compositor they're designed for having a specific extension that they use to negotiate the position. The compositor may allow this extension only to known applications it launches. Or maybe

Re: Window placement

2014-06-29 Thread Jasper St. Pierre
, and the compositor will hand you back an adapted rectangle clipped to the coordinates of the screen, allowing you to figure out where the screen edges are with a single round-trip. 2014-06-29 18:26 GMT+02:00 Jasper St. Pierre jstpie...@mecheye.net: On Sun, Jun 29, 2014 at 12:21 PM, Fabrice Rey faboune

Re: [PATCH] Use pixman_region32_clear instead of our own empty_region

2014-06-26 Thread Jasper St. Pierre
Looks good. Reviewed-by: Jasper St. Pierre jstpie...@mecheye.net On Thu, Jun 26, 2014 at 2:16 PM, Jason Ekstrand ja...@jlekstrand.net wrote: This requires pixman 0.25.2 --- clients/nested.c | 9 + configure.ac | 2 +- src/compositor.c | 15 --- src/data

Re: [ANNOUNCE] libinput 0.4.0

2014-06-25 Thread Jasper St. Pierre
On Wed, Jun 25, 2014 at 2:59 AM, Lyude thatsly...@gmail.com wrote: On Tue, 2014-06-24 at 23:40 -0700, Andrea Giammarchi wrote: Yeah Peter, I know how to apply a patch and no, I don't have any of them in my inbox, that's why I've asked what was wrong in my process ... right now I'm on Gmail

Re: [PATCH weston] shell: fix segfault in fullscreen binding

2014-06-25 Thread Jasper St. Pierre
Well, I removed recommended_output in that patch, because it became unnecessary. The set to NULL makes no sense to me either. You should just be able to do a one-line patch: +shsurf-fullscreen_output = shsurf-output; I don't see any need for anything more fancy. I'd also add a comment along

Re: [PATCH weston 0/2] Unify the commit logic

2014-06-20 Thread Jasper St. Pierre
Does this fix any bugs that you know of, or is it just a code cleanup? Just curious, I'm not insinuating anything. On Fri, Jun 20, 2014 at 8:25 PM, Jason Ekstrand ja...@jlekstrand.net wrote: This little two-patch series unifies all of the surface commit logic in one place. Previously the

Re: Weston multitouch support?

2014-06-09 Thread Jasper St. Pierre
Have you looked at the wl_touch protocol in the core interface at all? That provides multiple raw touchpoints which seems to be what you're after. I don't know if qtwaylandcompositor supports it yet, but Weston and gnome do. On Jun 9, 2014 4:24 AM, Shawn Rutledge shawn.t.rutle...@gmail.com wrote:

Re: [PATCH libinput] Add our own version of linux/input.h

2014-06-03 Thread Jasper St. Pierre
I think it should be #include linux/input.h at the very least. a_header_file.h has always meant system library to me. On Tue, Jun 3, 2014 at 5:34 AM, Peter Hutterer peter.hutte...@who-t.net wrote: On 3/06/2014 17:06 , Thiago Macieira wrote: Em ter 03 jun 2014, às 16:56:35, Peter Hutterer

Re: [PATCH libinput] Add our own version of linux/input.h

2014-06-03 Thread Jasper St. Pierre
Just have people shoot an email saying hey, we'd like to add a constant for this. Talking to each other is really all we need to do, no need to make it any more formal. On Tue, Jun 3, 2014 at 11:17 AM, Thiago Macieira thi...@kde.org wrote: Em ter 03 jun 2014, às 19:32:06, Peter Hutterer

Re: [PATCH libinput 03/10] touchpad: hook up to the tapping configuration

2014-06-03 Thread Jasper St. Pierre
On Tue, Jun 3, 2014 at 4:42 PM, Jonas Ådahl jad...@gmail.com wrote: On Tue, Jun 03, 2014 at 03:34:56PM +1000, Peter Hutterer wrote: Now that we have run-time changes of the tap.enabled state move the check to the IDLE state only. Otherwise the tap machine may hang if tapping is disabled

Re: Simple SHM Wayland Client

2014-05-30 Thread Jasper St. Pierre
In order for something to show up, you need to put it in a desktop surface. The existing one is wl_shell_surface, but xdg_surface will replace it eventually. Look at a version of simple-shm.c from 1.4 ( http://cgit.freedesktop.org/wayland/weston/tree/clients/simple-shm.c?h=1.4 ) for info on how to

Re: query fullscreen size to pass that value in callback calling glviewport.

2014-05-30 Thread Jasper St. Pierre
or callback. Is their no way to know updated size or resolution. On Tue, May 27, 2014 at 8:14 PM, Jasper St. Pierre jstpie...@mecheye.net wrote: The window size comes in the configure event, which is similar to X11's ConfigureNotify. See: http://cgit.freedesktop.org/wayland/weston/tree/clients

Re: Simple SHM Wayland Client

2014-05-30 Thread Jasper St. Pierre
On Fri, May 30, 2014 at 10:48 PM, Philip Rushik prus...@gmail.com wrote: great, thank you. That seems like what I was missing. Though I haven't had the time to try it out yet. What is the reason for switching from wl_shell to xdg_shell? Will xdg_shell become part of libwayland-client or will

Re: query fullscreen size to pass that value in callback calling glviewport.

2014-05-27 Thread Jasper St. Pierre
The window size comes in the configure event, which is similar to X11's ConfigureNotify. See: http://cgit.freedesktop.org/wayland/weston/tree/clients/simple-egl.c#n269 If you're still using wl_shell_surface, then see:

Re: libepoxy configure problem

2014-05-27 Thread Jasper St. Pierre
mesa installs these headers: http://cgit.freedesktop.org/mesa/mesa/tree/include/EGL/eglplatform.h On Tue, May 27, 2014 at 2:46 PM, Bill Spitzak spit...@gmail.com wrote: On 05/24/2014 12:45 AM, Pekka Paalanen wrote: - No idea why you needed the CPPFLAGS for libepoxy, I certainly didn't

Re: [PATCH libinput 0/24] Tablet support

2014-05-23 Thread Jasper St. Pierre
On Fri, May 23, 2014 at 2:19 AM, Peter Hutterer peter.hutte...@who-t.netwrote: On Fri, May 23, 2014 at 01:40:49AM +0200, Carlos Garnacho wrote: Hi, First of all, I'm sorry I dropped the ball this long. It's great to see you've been doing some progress. On jue, 2014-05-22 at 01:17

Re: [PATCH] protocol: remove redundant 'the' in description

2014-05-23 Thread Jasper St. Pierre
On Fri, May 23, 2014 at 2:49 AM, Pekka Paalanen ppaala...@gmail.com wrote: On Fri, 23 May 2014 07:26:56 +0200 Silvan Jegen s.je...@gmail.com wrote: Signed-off-by: Silvan Jegen s.je...@gmail.com --- protocol/wayland.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

Re: [PATCH libinput 5/6] touchpad: Don't allow diagonal scrolling

2014-05-23 Thread Jasper St. Pierre
Any reason you switched the order of these two if statements around? On Fri, May 23, 2014 at 10:06 AM, Hans de Goede hdego...@redhat.com wrote: We pin scrolling to the initial direction, so a 2 finger scroll starting in the vertical direction, will from then on only generate vertical scroll

Re: [PATCH wayland-web] Added depencies and bug fixes to build instructions

2014-05-22 Thread Jasper St. Pierre
It's # yum install 'pkgconfig(foo)'; not # yum install 'pkg-config(foo)' The inconsistent hyphenation is annoying. On Thu, May 22, 2014 at 6:15 AM, Peter Hutterer peter.hutte...@who-t.netwrote: On Thu, May 22, 2014 at 09:14:30AM +0200, Thierry Reding wrote: On Thu, May 22, 2014 at

Re: [PATCH wayland-web] Added depencies and bug fixes to build instructions

2014-05-20 Thread Jasper St. Pierre
On Tue, May 20, 2014 at 2:55 AM, Pekka Paalanen ppaala...@gmail.com wrote: On Mon, 19 May 2014 20:31:28 -0700 Bill Spitzak spit...@gmail.com wrote: On 05/19/2014 12:39 AM, Pekka Paalanen wrote: On Fri, 16 May 2014 13:43:50 -0700 spit...@gmail.com wrote: From: spitzak

[PATCH 1/2] fullscreen: Remove our own focused state tracking

2014-05-12 Thread Jasper St. Pierre
This is decided by xdg-shell now. --- clients/fullscreen.c | 21 +++-- 1 file changed, 3 insertions(+), 18 deletions(-) diff --git a/clients/fullscreen.c b/clients/fullscreen.c index fa8028a..789d243 100644 --- a/clients/fullscreen.c +++ b/clients/fullscreen.c @@ -50,7 +50,7 @@

[PATCH 2/2] fullscreen: Remove dirty sizing trick

2014-05-12 Thread Jasper St. Pierre
xdg-shell mandates that the FULLSCREEN state means that we must match the size that we were configured to, at least by default. Other states or protocol extensions might relax this requirement, but at least for now implement the behavior specified in the protocol documentation. ---

[PATCH] xdg-shell: Rename set_transient_for to set_parent

2014-05-12 Thread Jasper St. Pierre
It's a confusing name that comes from the ICCCM. The ICCCM is best forgotten about. With the addition of the potential new transient role meaning a parent-relative toplevel like a long-lived popup, used for e.g. tooltips, the set_transient_for name will become even more confusing. ---

Re: weston logind and display managers

2014-05-10 Thread Jasper St. Pierre
On Sat, May 10, 2014 at 3:44 AM, Pier Luigi pierluigi.fior...@gmail.comwrote: 2014-05-09 2:34 GMT+02:00 nerdopolis bluescreen_aven...@verizon.net: On Wednesday, May 07, 2014 10:18:00 PM Pier Luigi wrote: Hi, I'm porting sddm (QtQuick based display manager) to Wayland, it's still work

Re: Bug 78372 - create multiple windows with offset

2014-05-08 Thread Jasper St. Pierre
What should happen if the user unplugs monitors, or adds an additional one, or repositions them? What should be restored where? On Wed, May 7, 2014 at 4:10 PM, Bill Spitzak spit...@gmail.com wrote: Good to see there is an actual bug on this, but I need to ask for our exact case: Our app can

Re: [PATCH wayland 2/3] server: Split out code to open sockets for a specific display name

2014-05-08 Thread Jasper St. Pierre
On Wed, May 7, 2014 at 9:24 PM, Jason Ekstrand ja...@jlekstrand.net wrote: Comments below, --Jason Ekstrand On Wed, May 7, 2014 at 9:25 AM, Jasper St. Pierre jstpie...@mecheye.netwrote: We'll use this to autodetect a good socket to open on. --- src/wayland-server.c | 40

Re: Bug 78372 - create multiple windows with offset

2014-05-08 Thread Jasper St. Pierre
I don't know how you can have been on the Wayland mailing list for this long and not grasp core Wayland protocol concepts. Clients cannot get global surface positions, and it's been that way since day 1 six years ago. I also have never seen a patch or a line of code from you, ever. It's

Re: Bug 78372 - create multiple windows with offset

2014-05-08 Thread Jasper St. Pierre
On Thu, May 8, 2014 at 4:13 PM, Bill Spitzak spit...@gmail.com wrote: On 05/08/2014 11:31 AM, Jasper St. Pierre wrote: I don't know how you can have been on the Wayland mailing list for this long and not grasp core Wayland protocol concepts. Clients cannot get global surface positions

[PATCH wayland 0/3] Automatically find a good WAYLAND_SOCKET for compositors

2014-05-07 Thread Jasper St. Pierre
it. Jasper St. Pierre (3): server: Create the socket FD after taking the lock server: Split out code to open sockets for a specific name server: Find an open wayland-* socket by default src/wayland-server.c | 77 1 file changed, 54 insertions

[PATCH wayland 3/3] server: Find an open wayland-* socket by default

2014-05-07 Thread Jasper St. Pierre
Rather than just trying wayland-0 and bailing out if it's in use. --- src/wayland-server.c | 29 ++--- 1 file changed, 26 insertions(+), 3 deletions(-) diff --git a/src/wayland-server.c b/src/wayland-server.c index 3390171..ba13168 100644 --- a/src/wayland-server.c +++

[PATCH wayland 1/3] server: Create the socket FD after taking the lock

2014-05-07 Thread Jasper St. Pierre
This removes a small cleanup path. --- src/wayland-server.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/wayland-server.c b/src/wayland-server.c index e850d48..d299000 100644 --- a/src/wayland-server.c +++ b/src/wayland-server.c @@ -1061,12 +1061,6 @@

[PATCH wayland 2/3] server: Split out code to open sockets for a specific name

2014-05-07 Thread Jasper St. Pierre
We'll use this to autodetect a good socket to open on. --- src/wayland-server.c | 40 +--- 1 file changed, 25 insertions(+), 15 deletions(-) diff --git a/src/wayland-server.c b/src/wayland-server.c index d299000..3390171 100644 --- a/src/wayland-server.c +++

[PATCH 1/2] compositor: Add a comment around the WAYLAND_DISPLAY envvar setting

2014-05-07 Thread Jasper St. Pierre
This took me a few minutes to figure out, so document it for the next person who stumbles in here. --- src/compositor.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/compositor.c b/src/compositor.c index 3d65e4c..120818f 100644 --- a/src/compositor.c +++

Re: [PATCH wayland 0/3] Automatically find a good WAYLAND_SOCKET for compositors

2014-05-07 Thread Jasper St. Pierre
Of course I mean WAYLAND_DISPLAY, not WAYLAND_SOCKET. Whoops. On Wed, May 7, 2014 at 9:05 AM, Jasper St. Pierre jstpie...@mecheye.netwrote: This patch series implements a better fallback than a hardcoded wayland-0 when a server socket has already been taken. This way, the code for searching

Re: [PATCH weston 1/3] shell: Fix artifacts caused by workspace change animation

2014-05-07 Thread Jasper St. Pierre
Hm, it seems to me that hiding a layer should cause all the regions it occupied to be marked as needing repaint. Fixing the scene graph is better than a one-off at the end of an animation. On Wed, May 7, 2014 at 4:57 AM, Ander Conselvan de Oliveira conselv...@gmail.com wrote: From: Ander

Re: [PATCH weston 3/3] shell: Fix crash when restoring focus state during workspace change

2014-05-07 Thread Jasper St. Pierre
Yep, looks good. On Wed, May 7, 2014 at 4:57 AM, Ander Conselvan de Oliveira conselv...@gmail.com wrote: From: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com The check to avoid calling weston_keyboard_set_focus() for a seat that didn't have a keyboard in

Re: [PATCH weston 2/3] simple-touch: Handle multiple seats properly

2014-05-07 Thread Jasper St. Pierre
I was wondering why you didn't move the pointer / keyboard fields to the seat, before noticing that they were unused. It might make sense to have a prereq patch that removes those unused fields. This patch looks good, though. On Wed, May 7, 2014 at 4:57 AM, Ander Conselvan de Oliveira

Re: Bug 78372 - create multiple windows with offset

2014-05-07 Thread Jasper St. Pierre
The rationale explained in the bug by Pekka and Emilio sounds OK to me. Explaining a bit more about your use case with your data visualization app might be helpful. What kinds of systems do you want your app to be run on? Generic desktop systems? If so, then you can't guarantee anything about

Re: [PATCH weston 2/3] compositor-wayland: assign the correct mode

2014-05-07 Thread Jasper St. Pierre
I love the simple typos like this. LGTM. On Tue, May 6, 2014 at 5:50 PM, U. Artie Eoff ullysses.a.e...@intel.comwrote: Signed-off-by: U. Artie Eoff ullysses.a.e...@intel.com --- src/compositor-wayland.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH weston] simple-touch: Handle multiple seats

2014-05-07 Thread Jasper St. Pierre
Looks mostly the same as Ander's patch here: http://lists.freedesktop.org/archives/wayland-devel/2014-May/014658.html Same review applies :) On Wed, May 7, 2014 at 10:00 AM, Neil Roberts n...@linux.intel.com wrote: Previously simple-touch would only handle one seat. If there were multiple

[PATCH wayland 0/3] Add API to automatically select a display name

2014-05-07 Thread Jasper St. Pierre
v2 of my patch series. v1 was broken because I didn't test it properly. This one should actually work. First patch also had a resource leak fixed. Second patch is the same. Third patch takes a new approach. Jasper St. Pierre (3): server: Create the socket FD after taking the lock server

[PATCH wayland 2/3] server: Split out code to open sockets for a specific display name

2014-05-07 Thread Jasper St. Pierre
We'll use this to autodetect a good socket to open on. --- src/wayland-server.c | 40 +--- 1 file changed, 25 insertions(+), 15 deletions(-) diff --git a/src/wayland-server.c b/src/wayland-server.c index d0fd280..6bc8dc3 100644 --- a/src/wayland-server.c +++

[PATCH wayland 1/3] server: Create the socket FD after taking the lock

2014-05-07 Thread Jasper St. Pierre
--- src/wayland-server.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/src/wayland-server.c b/src/wayland-server.c index e850d48..d0fd280 100644 --- a/src/wayland-server.c +++ b/src/wayland-server.c @@ -1061,12 +1061,6 @@ wl_display_add_socket(struct

[PATCH wayland 3/3] server: Add a simple API to find a good default display

2014-05-07 Thread Jasper St. Pierre
This allows compositors to easily select a good display to listen on. --- src/wayland-server.c | 23 +++ src/wayland-server.h | 2 ++ 2 files changed, 25 insertions(+) diff --git a/src/wayland-server.c b/src/wayland-server.c index 6bc8dc3..5624199 100644 ---

[PATCH] compositor: Use libwayland to find a good default display for us

2014-05-07 Thread Jasper St. Pierre
--- src/compositor.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/compositor.c b/src/compositor.c index 3d65e4c..1906441 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -4150,7 +4150,7 @@ int main(int argc, char *argv[]) char *server_socket = NULL,

Re: [PATCH weston] window.c: Set the input region of the tooltip to empty

2014-05-07 Thread Jasper St. Pierre
Events aren't delivered to surfaces. They're delivered to clients. On Wed, May 7, 2014 at 2:02 PM, Bill Spitzak spit...@gmail.com wrote: On 05/07/2014 01:47 AM, Pekka Paalanen wrote: It is for normal windows like registered with xdg_shell where sub-surfaces are not suitable for tooltips. A

Re: [PATCH wayland 3/3] server: Add a simple API to find a good default display

2014-05-07 Thread Jasper St. Pierre
On Wed, May 7, 2014 at 9:31 PM, Jason Ekstrand ja...@jlekstrand.net wrote: On Wed, May 7, 2014 at 9:25 AM, Jasper St. Pierre jstpie...@mecheye.netwrote: This allows compositors to easily select a good display to listen on. --- src/wayland-server.c | 23 +++ src

Re: Thoughts on getting surfaces to appear on the right output

2014-05-06 Thread Jasper St. Pierre
We solved this under X11 with the startup-notification protocol. Ryan Lortie has been looking at making a DBus-only startup-notification for other platforms like Wayland. Since there's an intersection here, I'm going to CC Ryan and have him provide his thoughts on this, so we don't have duplicate

Re: [PATCH 6/6] window: Add a simple getenv to force SHM rendering

2014-04-29 Thread Jasper St. Pierre
On Mon, Apr 28, 2014 at 11:19 AM, Jasper St. Pierre jstpie...@mecheye.netwrote: --- clients/window.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/clients/window.c b/clients/window.c index d822af7..3897440 100644 --- a/clients/window.c +++ b/clients/window.c

Re: [PATCH 6/6] window: Add a simple getenv to force SHM rendering

2014-04-29 Thread Jasper St. Pierre
...@gmail.com wrote: On Mon, 28 Apr 2014 11:19:32 -0400 Jasper St. Pierre jstpie...@mecheye.net wrote: --- clients/window.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/clients/window.c b/clients/window.c index d822af7..3897440 100644 --- a/clients

[PATCH 5/6] window: Clean up buffer type choosing

2014-04-28 Thread Jasper St. Pierre
Extracting it to a function makes this cleaner and more understandable. --- clients/window.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/clients/window.c b/clients/window.c index e2f7010..d822af7 100644 --- a/clients/window.c +++ b/clients/window.c @@

[PATCH 4/6] cairo-util: Don't show a resize cursor on edges when we're maximized

2014-04-28 Thread Jasper St. Pierre
This is substantially confusing to users, namely me. --- shared/cairo-util.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/shared/cairo-util.c b/shared/cairo-util.c index a1568ff..a77d0b6 100644 --- a/shared/cairo-util.c +++ b/shared/cairo-util.c @@ -487,11

[PATCH 2/6] compositor: Remove the edges parameter from send_configure

2014-04-28 Thread Jasper St. Pierre
send_configure was originally modelled after wl_shell_surface::send_configure, which takes these arguments. However, the X WM and xdg_surface::configure variants don't use these arguments. We already store the resize edges for a surface while it's being resized, so just use the saved state in the

[PATCH 6/6] window: Add a simple getenv to force SHM rendering

2014-04-28 Thread Jasper St. Pierre
--- clients/window.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/clients/window.c b/clients/window.c index d822af7..3897440 100644 --- a/clients/window.c +++ b/clients/window.c @@ -4338,11 +4338,11 @@ surface_create(struct window *window) return surface; }

[PATCH 3/6] cairo-util: Kill a duplicate test

2014-04-28 Thread Jasper St. Pierre
If !(x margin), then clearly margin = x. No need to test for it again. --- shared/cairo-util.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/shared/cairo-util.c b/shared/cairo-util.c index 3948572..a1568ff 100644 --- a/shared/cairo-util.c +++ b/shared/cairo-util.c @@

[PATCH 1/6] compositor: Fix the documentation for surface-configure

2014-04-28 Thread Jasper St. Pierre
It's called on commit, not on attach. Additionally, correct the interface name to be wl_surface, not surface. --- src/compositor.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/compositor.h b/src/compositor.h index 03d8992..c913f54 100644 --- a/src/compositor.h +++

Re: Deep Color support

2014-04-26 Thread Jasper St. Pierre
Outside of an X11 environment, the only standard is EGL, with a Wayland backend for Wayland apps, or a GBM backend for native modesetting. I don't know whether the Intel drivers have support for 64-bit textures on either of these backends. Writing a little test app is probably the easiest way to

Re: [PATCH weston] Simply the matrix calculation for zooming

2014-04-25 Thread Jasper St. Pierre
I fully support any patch that removes the phrase modelview. On Fri, Apr 25, 2014 at 5:07 PM, Kristian Høgsberg hoegsb...@gmail.comwrote: On Fri, Apr 25, 2014 at 01:19:37PM +0100, Neil Roberts wrote: In order to apply the zoom transformation to the output matrix, Weston was doing the

Re: xserver git version?

2014-04-22 Thread Jasper St. Pierre
It looks OK, but the upstream is at https://github.com/anholt/libepoxy On Tue, Apr 22, 2014 at 10:54 PM, Bill Spitzak spit...@gmail.com wrote: On 04/22/2014 05:34 PM, Peter Hutterer wrote: Config with --enable-xwayland is not working however: checking whether to build XWin DDX... no

Re: cannot create opengl by dynamically loading wayland symbols from library

2014-04-16 Thread Jasper St. Pierre
On Wed, Apr 16, 2014 at 2:27 PM, Pekka Paalanen ppaala...@gmail.com wrote: Hi, I'm moving this conversation to where it belongs. On Wed, 16 Apr 2014 11:25:26 + bugzilla-dae...@freedesktop.org wrote: https://bugs.freedesktop.org/show_bug.cgi?id=77521 Priority: medium

Re: Question about multi-display on wayland protocol

2014-04-14 Thread Jasper St. Pierre
I'd imagine this is something like _NET_WM_FULLSCREEN_MONITORS, which allows an application to full-screen across multiple outputs. This is a use case xdg-shell doesn't handle right now. I don't know of anything but games that would like to use such a feature, though. On Mon, Apr 14, 2014 at

Re: How can I start wayland at boot?

2014-04-13 Thread Jasper St. Pierre
Recent gdm has support for Wayland sessions. You'll have to write the session file yourself if you want to launch weston, though. Something like this should work. # mkdir -p /usr/share/wayland-sessions/ # echo EOF [Desktop Entry] Name=Weston Exec=weston-launch -- weston Type=Application EOF

Re: [PATCH weston 2/2] Reset the keyboard focus on all seats when the compositor is locked

2014-04-09 Thread Jasper St. Pierre
Why is this necessary? Won't events never be delivered while locked anyway? On Apr 9, 2014 8:36 AM, Neil Roberts n...@linux.intel.com wrote: Before commit 2f5faff7f9142 when the compositor is locked it would reset the keyboard focus on all of the seats as part of pushing the focus_state. This

Re: [RFC libwayland] Track protocol object versions inside wl_proxy.

2014-04-02 Thread Jasper St. Pierre
Does this help clean up client code? Can you give an example of how a client would use this? On Wed, Apr 2, 2014 at 10:48 AM, Jason Ekstrand ja...@jlekstrand.netwrote: It's worth noting that there is one small backwards-compatability issue here. Namely, if the client is built against

Re: weston: weston randr protocol for testing and configuration

2014-03-27 Thread Jasper St. Pierre
I don't think the user really knows what refresh is either. I'm actually curious: is there a reason to ever expose different modes to the user that have the same width/height but different timings? What's the rationale for choosing one instead of the other? I know nothing about display panels,

Re: weston: weston randr protocol for testing and configuration

2014-03-27 Thread Jasper St. Pierre
not offer the user a broken mode in the first place, but I don't want to get a scolding from Adam Jackson, so I'll shut up. On Thu, Mar 27, 2014 at 9:05 AM, Pekka Paalanen ppaala...@gmail.com wrote: On Thu, 27 Mar 2014 08:31:34 -0400 Jasper St. Pierre jstpie...@mecheye.net wrote: I don't think

Re: weston: weston randr protocol for testing and configuration

2014-03-26 Thread Jasper St. Pierre
Yes. I'd say that realistically, you should never have more than one client trying to set the mode at once. If you somehow do, your machine is already messing up in some way. No need to design for a broken edge case in the protocol. Relying on message ordering is fine. We, of course, still want a

Re: [PATCH] xdg-shell: rename the xdg_surface.delete event to close.

2014-03-24 Thread Jasper St. Pierre
Yeah, this is fine with me. Reviewed-by: Jasper St. Pierre jstpie...@mecheye.net On Mon, Mar 24, 2014 at 8:13 AM, Giulio Camuffo giuliocamu...@gmail.comwrote: 'close' is more consistent with the purpose of the event than 'delete', and it is also c++ friendly, since 'delete' is a keyword

Re: [RFC PATCH libinput] udev: add libinput_udev_rescan_devices()

2014-03-20 Thread Jasper St. Pierre
So you're saying that every time we're suspended, we simply throw out the entire context and drop all the devices on the floor, as if you just unplugged all of them? I suppose I just never thought of that. On first though, I don't see anything wrong with that. If that's what we should do, should

Re: Is Wayland without X11 matured

2014-03-19 Thread Jasper St. Pierre
For very simple use cases, it's fairly mature. You can use it on embedded systems quite well. For complex desktops, it's not quite. There's a lot of protocols that are traditionally in something like the ICCCM or EWMH that we have to reinvent on Wayland. We're working on them all the time, so

Re: [PATCH] protocol: replace the usage of selection with clipboard

2014-03-13 Thread Jasper St. Pierre
On Thu, Mar 13, 2014 at 3:12 PM, Bill Spitzak spit...@gmail.com wrote: John Kåre Alsaker wrote: On Wed, Mar 12, 2014 at 7:32 PM, Bill Spitzak spit...@gmail.com wrote: Isn't Wayland differentiating between the selection and the clipboard? It is not doing that at the moment. Only explicit

Re: [PATCH 1/6] Add weston randr protocol

2014-03-09 Thread Jasper St. Pierre
There's two different things here. There's the protocol and the UI. (By UI I also mean a command-line tool like /usr/bin/xrandr, I just mean the way the user does a mode-set). I think to build a good UI, we need a list of available modes that the user can choose from. Having a tool where the user

Re: [PATCH 1/6] Add weston randr protocol

2014-03-04 Thread Jasper St. Pierre
So, before we go further on this, I need to ask three basic questions: what are the goals of this interface? Who is supposed to use this interface? Why would they use this interface? On Tue, Mar 4, 2014 at 9:07 PM, Wang, Quanxian quanxian.w...@intel.comwrote: Hi, All With the first version

<    1   2   3   4   >