Re: Proposal to add 'raise' and 'lower' to xdg-shell in wayland-protocols

On Wed, Nov 30, 2016 at 12:04:33PM -0500, Adam Goode wrote: > Hi, > > See https://bugzilla.redhat.com/show_bug.cgi?id=1349225 and > https://bugzilla.gnome.org/show_bug.cgi?id=767967 > > When using Client Side Decorations, toolkits cannot bind raise or lower to > user actions. This binding is

Re: [PATCH] xdg-shell: clarify popup constrain's slide mechanism

On Mon, Nov 21, 2016 at 06:36:49AM -0500, Mike Blumenkrantz wrote: > On Fri, 18 Nov 2016 09:28:56 +0800 > Jonas Ådahl <jad...@gmail.com> wrote: > > > On Wed, Nov 16, 2016 at 10:23:59AM -0500, Mike Blumenkrantz wrote: > > > some restrictions must be placed on

Re: [PATCH wayland] protocol: spell out that we're using linux/input-event-codes.h key codes

On Fri, Nov 18, 2016 at 12:25:21PM +1000, Peter Hutterer wrote: > On Thu, Nov 17, 2016 at 10:42:41AM +0800, Jonas Ådahl wrote: > > On Wed, Nov 16, 2016 at 04:00:23PM +, Daniel Stone wrote: > > > Hi, > > > > > > On 15 November 2016 at 09:42, Jonas Ådahl <

Re: [PATCH v2 wayland] protocol: spell out that we're using linux/input-event-codes.h button codes

er <peter.hutte...@who-t.net> Reviewed-by: Jonas Ådahl <jad...@gmail.com> > --- > This is the button bit only which I think we agreed on so far. I'll do the > key codes in a separate patch. > > protocol/wayland.xml | 8 > 1 file changed, 8 insertions(+) >

Re: [PATCH] xdg-shell: clarify popup constrain's slide mechanism

On Wed, Nov 16, 2016 at 10:23:59AM -0500, Mike Blumenkrantz wrote: > some restrictions must be placed on this or else it becomes legal for > the compositor to place popups in unexpected locations when sliding > is allowed > > Signed-off-by: Mike Blumenkrantz > --- >

Re: [PATCH wayland] protocol: spell out that we're using linux/input-event-codes.h key codes

On Wed, Nov 16, 2016 at 04:00:23PM +, Daniel Stone wrote: > Hi, > > On 15 November 2016 at 09:42, Jonas Ådahl <jad...@gmail.com> wrote: > > On Thu, Nov 10, 2016 at 10:22:41AM +, Daniel Stone wrote: > >> But this I'd prefer to drop. We need to describe the

Re: [PATCH wayland] protocol: spell out that we're using linux/input-event-codes.h key codes

On Thu, Nov 10, 2016 at 10:22:41AM +, Daniel Stone wrote: > Hi, > > On 10 November 2016 at 05:19, Peter Hutterer wrote: > > A side-note here: my first version sent to Jonas privately had a reserved > > range for any key with the highest bit set. The idea here was to

Re: Shell surface positioning

On Wed, Nov 09, 2016 at 10:30:45AM +0100, Jan Synacek wrote: > Hello, > > I'm playing around with libwayland-client, implementing a simple > application. I made the middle mouse button move the "window" using > wl_shell_surface_move() when the button is pressed, which works. What > I don't

Re: Implementing show_window_menu in Weston

On Wed, Nov 09, 2016 at 03:21:30PM -0800, Dima Ryazanov wrote: > Hi, > > I'd like to take a shot at implementing window menus (from xdg-shell) in > Weston - but I don't have a good understanding of how the compositor, > shell, etc. interact, so wanted to ask about it first. > > Looks like the

Re: [PATCH] xdg-shell: validate positioner object

; parent_geometry.y), > + frame_width(menu->frame), > frame_height(menu->frame)); nit: line break after , Otherwise looks good, and is Reviewed-by: Jonas Ådahl <jad...@gmail.com> Jonas > window->xdg_popup = >

Re: [PATCH weston v2] libweston-desktop/xdg_shell_v6: Raise errors on not-yet-possible requests

rdemff7.net> 1 and v2 of 2 are Reviewed-by: Jonas Ådahl <jad...@gmail.com> > --- > Sorry for the noise, last minute rename. > > libweston-desktop/xdg-shell-v6.c | 21 + > 1 file changed, 21 insertions(+) > > diff --git a/libweston-desktop/xdg

Re: [PATCH weston 2/2] libweston-desktop: fix unsetting fullscreen/maximize with wl_shell

On Sun, Sep 04, 2016 at 06:50:47PM +0300, Giulio Camuffo wrote: > --- > libweston-desktop/wl-shell.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/libweston-desktop/wl-shell.c b/libweston-desktop/wl-shell.c > index 74ce473..7172449 100644 > ---

Re: [PATCH weston 1/2] compositor: set the opaque region for some views with transform

On Sun, Sep 04, 2016 at 06:50:46PM +0300, Giulio Camuffo wrote: > If the transform on a view is only a translation we can trivially > set the opaque region for it so to optimize the rendering. Makes sense. Reviewed-by: Jonas Ådahl <jad...@gmail.com> > --- > libwesto

Re: [PATCH weston v3 3/3] libweston-desktop/xdg_shell_v5: Add surface as needed

+...@sardemff7.net> On all three: Reviewed-by: Jonas Ådahl <jad...@gmail.com> but I have one minor nit/suggestion. Feel free to ignore and no need to resend for just that. > --- > v2: Nothing > v3: Fixed "if" style > > libweston-desktop/xdg-shell-v5.c | 42

Re: [PATCH] Introduce keyboard grabbing protocol

On Tue, Aug 30, 2016 at 03:39:08PM +0200, Giulio Camuffo wrote: > 2016-08-30 15:22 GMT+02:00 Jonas Ådahl <jad...@gmail.com>: > > On Tue, Aug 30, 2016 at 02:12:29PM +0200, Giulio Camuffo wrote: > >> 2016-08-30 13:58 GMT+02:00 Olivier Fourdan <ofour...@redhat.com>: >

Re: [PATCH] Introduce keyboard grabbing protocol

On Tue, Aug 30, 2016 at 02:12:29PM +0200, Giulio Camuffo wrote: > 2016-08-30 13:58 GMT+02:00 Olivier Fourdan : > > Hi Giulio, > > > >> i have a couple of comments below > > > > Thanks a lot for your quick reply! > > > >> 2016-08-30 11:54 GMT+02:00 Olivier Fourdan

Re: [PATCH wayland-protocols 3/3] text-input: Correct grammar

On Mon, Aug 29, 2016 at 05:31:22PM -0700, Bryce Harrington wrote: > On Fri, Aug 19, 2016 at 11:05:28AM -0700, Yong Bakos wrote: > > From: Yong Bakos > > > > Signed-off-by: Yong Bakos > > Reviewed-by: Bryce Harrington

Re: [PATCH wayland-protocols] xdg-shell: Correct grammar

On Mon, Aug 29, 2016 at 05:33:56PM -0700, Bryce Harrington wrote: > On Fri, Aug 19, 2016 at 09:47:39AM -0700, Yong Bakos wrote: > > From: Yong Bakos > > > > Adjust minor grammar issues, for clarity. > > > > This patch cherry-picks some relevant changes from an earlier

Re: [PATCH wayland-protocols v2] buildsystem: add -uninstalled.pc pkg-config file

On Mon, Aug 29, 2016 at 05:10:17PM -0700, Bryce Harrington wrote: > On Mon, Aug 29, 2016 at 02:25:46PM -0500, Derek Foreman wrote: > > From: "Reynaldo H. Verdejo Pinochet" > > > > For building against an uninstalled wayland-protocols tree > > > > Signed-off-by:

Re: [PATCH weston 1/2] desktop-shell: Unset fullscreen/maximized state on commit

On Tue, Aug 16, 2016 at 02:30:06PM +0200, Quentin Glidic wrote: > From: Quentin Glidic > > Maybe libweston-desktop should prevent the committed callback to be "Maybe" doesn't seem like something to have in a commit message :P The reason we need it in shell_surface

Re: [PATCH wayland-web] Mention GammaRay in the tools page

On Thu, Aug 18, 2016 at 11:02:29AM +0300, Pekka Paalanen wrote: > On Thu, 18 Aug 2016 09:45:30 +0200 > Giulio Camuffo <giuliocamu...@gmail.com> wrote: > > > 2016-08-17 23:23 GMT+02:00 <dar...@chaosreigns.com>: > > > On 08/17, Jonas Ådahl wrote: > &g

Re: [PATCH wayland-web] Mention GammaRay in the tools page

On Wed, Aug 17, 2016 at 11:48:03AM +0300, Pekka Paalanen wrote: > On Wed, 17 Aug 2016 10:33:19 +0200 > Giulio Camuffo wrote: > > > --- > > extras.html | 13 + > > gammaray.png | Bin 0 -> 563838 bytes > > 2 files changed, 13 insertions(+) > > create mode

Re: [PATCH weston 2/2] libweston-desktop/xwayland: Actually destroy the view

On Tue, Aug 16, 2016 at 10:55:44AM +0200, Quentin Glidic wrote: > From: Quentin Glidic > > Signed-off-by: Quentin Glidic 1-2 are also Rb me. Jonas > --- > libweston-desktop/xwayland.c | 7 +-- > 1 file changed, 5 insertions(+),

Re: [PATCH weston] desktop-shell: Properly destroy the weston_desktop_view

On Tue, Aug 16, 2016 at 10:28:21AM +0200, Quentin Glidic wrote: > From: Quentin Glidic <sardemff7+...@sardemff7.net> > > Signed-off-by: Quentin Glidic <sardemff7+...@sardemff7.net> As discussed, API naming can be improved, but lets do that in the follow up. This is Reviewed

Re: [PATCH 1/3 v4] wayland-server: Add API to control globals visibility

which wl_global would > be listed to clients. > > Compositors can use this mechanism to hide their own private interfaces > that regular clients should not use. > > Signed-off-by: Olivier Fourdan <ofour...@redhat.com> Reviewed-by: Jonas Ådahl <jad...@gmail.com> &g

Re: [PATCH wayland] scanner: Correct doxygen group name for *_add_listener

On Tue, Jul 26, 2016 at 04:09:48PM -0500, Yong Bakos wrote: > From: Yong Bakos > > From: Bill Spitzak Should the patch author be Yong or Bill here? If a patch was authored by multiple parties the common way so far has been to put all those authors

Re: [PATCH weston] weston-editor: Close the data source after sending

On Sat, Jul 09, 2016 at 12:08:53PM -0700, Yong Bakos wrote: > On Jul 7, 2016, at 8:52 AM, Derek Foreman wrote: > > > > We're leaking the fd when sending cut'n'paste. Failure to close can also > > makes the other end unhappy because it doesn't know the paste is finished.

Re: [PATCH weston v2 4/4] configure.ac: check weston vs. libweston versions

nly pre-release versions the weston and libweston > may differ > > - when they differ, libweston version must be exactly (weston.major+1).0.0 > > - otherwise, the versions must be exactly the same. > > Cc: Jonas Ådahl <jad...@gmail.com> > Cc: Quentin Glidic <sar

Re: [PATCH weston v2 2/4] README: updates on libweston versioning

rom weston > version and how to use pkg-config properly. > > Signed-off-by: Pekka Paalanen <pekka.paala...@collabora.co.uk> Reviewed-by: Jonas Ådahl <jad...@gmail.com> > --- > README | 51 --- > 1 file changed, 36 in

Re: [PATCH weston 0/6] Switch client to xdg_shell unstable v6

These have now landed: 003da88..6ccd286 master -> master Jonas On Fri, Aug 12, 2016 at 11:40:00AM +0800, Jonas Ådahl wrote: > Hi, > > With a xdg_shell unstable v6 release around the corner, and a > libweston-desktop > about to land with a xdg_shell unstable v6 implement

Re: [PATCH weston 2/2] libweston-desktop: Drop (wrongly named) new_buffer in committed

On Mon, Aug 15, 2016 at 01:51:42PM +0200, Quentin Glidic wrote: > From: Quentin Glidic > > Instead we store the buffer move and just use it when the signal is > fired. As a side note, as was discussed on IRC earlier; eventually we should probably rename the recently

[PATCH] Makefile.am: Include files built for libweston-desktop in BUILT_SOURCES

Without this make distcheck fails. Also remove redundant nodist sources from desktop-shell source list. Signed-off-by: Jonas Ådahl <jad...@gmail.com> --- Makefile.am | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile.am b/Makefile.am index 47fc643..92009d6

Re: [PATCH weston 2/2] README: updates on libweston versioning

On Wed, Aug 10, 2016 at 03:01:13PM +0300, Pekka Paalanen wrote: > From: Pekka Paalanen > > WE have agreed to use the major as the ABI-version, so talk about major Typo? Or do you emphasize WE? :P > to avoid confusion. > > Remove unncessary or incorrect wording

Re: [PATCH weston 1/2] releasing: how to handle libweston

rsion, leading up to 2.1.0. > > Signed-off-by: Pekka Paalanen <pekka.paala...@collabora.co.uk> I tried to go through the various scenarious and apply the rules added below and it seems to hold up. Some things could be made more obvious, but maybe not in the text below. For example,

[ANNOUNCE] wayland-protocols 1.7

in future releases. Here is the shortlog: Jonas Ådahl (13): xdg-shell: Bump unstable version to 6 xdg-shell: Remove the old unstable version enum and request xdg-shell: Turn xdg_surface into a generic base interface xdg-shell: Put xdg_shell events after requests

Re: [PATCH wayland-protocols 3/4 v2] xdg-shell: Add resize_x/y constrain adjustment to positioner

On Fri, Aug 12, 2016 at 12:19:20PM -0700, Bryce Harrington wrote: > On Fri, Aug 12, 2016 at 12:44:49PM +0800, Jonas Ådahl wrote: > > On Thu, Aug 11, 2016 at 09:35:57PM -0700, Bryce Harrington wrote: > > > On Fri, Aug 12, 2016 at 11:56:13AM +0800, Jonas Ådahl wrote: > >

Re: [PATCH weston 0/6] libweston-desktop, finally

On Fri, Aug 12, 2016 at 10:41:31AM +0200, Quentin Glidic wrote: > From: Quentin Glidic > > Hi everyone, > > Here is the final shape of my libweston-desktop series. > A lot of things happened on Phabricator[1], and this is the result. > > Thanks to Jonas for the

Re: [PATCH weston 3/6] clients/simple-shm: Port to xdg_shell unstable v6

On Fri, Aug 12, 2016 at 11:27:11AM +0200, Quentin Glidic wrote: > On 12/08/2016 05:40, Jonas Ådahl wrote: > > Signed-off-by: Jonas Ådahl <jad...@gmail.com> > > One concern (in two places) below. > > > > --- > > Makefile.am

[PATCH weston v2] clients/simple-shm: Port to xdg_shell unstable v6

Signed-off-by: Jonas Ådahl <jad...@gmail.com> Acked-by: Bryce Harrington <br...@osg.samsung.com> Acked-by: Pekka Paalanen <pekka.paala...@collabora.co.uk> --- > … here. You trigger a redraw (chain) if configure was received, but in this > case, the redraw is already trigg

Re: [PATCH weston 1/6] toytoolkit: Port to xdg_shell unstable v6

On Fri, Aug 12, 2016 at 11:16:22AM +0200, Quentin Glidic wrote: > On 12/08/2016 05:40, Jonas Ådahl wrote: > > Signed-off-by: Jonas Ådahl <jad...@gmail.com> > > --- > > Makefile.am | 10 ++- > > clients/window.c | 268 > > +

Re: [PATCH wayland-protocols v2] Introduce xdg-foreign protocol

On Sun, Aug 07, 2016 at 08:14:32AM -0500, Derek Foreman wrote: > On 05/08/16 10:52 AM, Jonas Ådahl wrote: > > On Fri, Aug 05, 2016 at 07:45:50AM -0500, Derek Foreman wrote: > >> On 27/07/16 02:54 AM, Jonas Ådahl wrote: > >>> xdg-foreign is a protocol meant to e

Re: [PATCH wayland-protocols v4] Add screensaver idle inhibitor protocol

As one probably already noticed, this was pushed earlier and was included in wayland-protocols 1.6. Jonas On Thu, Jul 14, 2016 at 06:35:31PM -0700, Bryce Harrington wrote: > This interface allows disabling of screensaver/screenblanking on a > per-surface basis. As long as the surface remains

Re: [PATCH wayland-protocols 1/4 v5] xdg-shell: Introduce xdg_positioner

On Thu, Aug 11, 2016 at 09:36:42PM -0700, Bryce Harrington wrote: > On Fri, Aug 12, 2016 at 12:33:42PM +0800, Jonas Ådahl wrote: > > On Thu, Aug 11, 2016 at 09:08:15PM -0700, Bryce Harrington wrote: > > > On Fri, Aug 12, 2016 at 11:51:38AM +0800, Jonas Ådahl wrote: > >

Re: [PATCH wayland-protocols 3/4 v2] xdg-shell: Add resize_x/y constrain adjustment to positioner

On Thu, Aug 11, 2016 at 09:35:57PM -0700, Bryce Harrington wrote: > On Fri, Aug 12, 2016 at 11:56:13AM +0800, Jonas Ådahl wrote: > > On Thu, Aug 11, 2016 at 08:49:01PM -0700, Bryce Harrington wrote: > > > On Fri, Jul 29, 2016 at 12:04:55PM +0800, Jonas Ådahl wrote: > > >

Re: [PATCH wayland-protocols 1/4 v5] xdg-shell: Introduce xdg_positioner

On Thu, Aug 11, 2016 at 09:08:15PM -0700, Bryce Harrington wrote: > On Fri, Aug 12, 2016 at 11:51:38AM +0800, Jonas Ådahl wrote: > > On Thu, Aug 11, 2016 at 08:39:08PM -0700, Bryce Harrington wrote: > > > On Fri, Jul 29, 2016 at 12:04:53PM +0800, Jonas Ådahl wrote: >

Re: [PATCH wayland-protocols 3/4 v2] xdg-shell: Add resize_x/y constrain adjustment to positioner

On Thu, Aug 11, 2016 at 08:49:01PM -0700, Bryce Harrington wrote: > On Fri, Jul 29, 2016 at 12:04:55PM +0800, Jonas Ådahl wrote: > > In order to get feedback of available space where a client can create > > its popup, let it create requset that its popup rectangle being re

Re: [PATCH wayland-protocols 1/4 v5] xdg-shell: Introduce xdg_positioner

On Thu, Aug 11, 2016 at 08:39:08PM -0700, Bryce Harrington wrote: > On Fri, Jul 29, 2016 at 12:04:53PM +0800, Jonas Ådahl wrote: > > xdg_positioner is a method for declarative positioning of child surfaces > > (currently only xdg_popup surfaces). A client creates a description of a

[PATCH weston 6/6] clients/simple-dmabuf-v4l: Port to xdg_shell unstable v6

Signed-off-by: Jonas Ådahl <jad...@gmail.com> --- Makefile.am | 6 +-- clients/simple-dmabuf-v4l.c | 96 ++--- 2 files changed, 66 insertions(+), 36 deletions(-) diff --git a/Makefile.am b/Makefile.am index 7fdca41..00fc0ff

[PATCH weston 5/6] clients/simple-dmabuf-intel: Port to xdg_shell unstable v6

Signed-off-by: Jonas Ådahl <jad...@gmail.com> --- Makefile.am | 4 +- clients/simple-dmabuf-intel.c | 94 +-- 2 files changed, 65 insertions(+), 33 deletions(-) diff --git a/Makefile.am b/Makefile.am index d0693c5..7fdca41

[PATCH weston 2/6] clients/simple-egl: Port to xdg_shell unstable v6

Signed-off-by: Jonas Ådahl <jad...@gmail.com> --- Makefile.am | 4 +- clients/simple-egl.c | 106 +++ 2 files changed, 66 insertions(+), 44 deletions(-) diff --git a/Makefile.am b/Makefile.am index 3a42a93..dcd0a25

[PATCH weston 0/6] Switch client to xdg_shell unstable v6

for every toplevel surface, there is also the 'perfect first frame' semantics adaptation meaning clients need to wait for the first zxdg_surface_v6.configure event before attaching its first buffer. Jonas Jonas Ådahl (6): toytoolkit: Port to xdg_shell unstable v6 clients/simple-egl: Port

[PATCH weston 4/6] clients/simple-damage: Port to xdg_shell unstable v6

Signed-off-by: Jonas Ådahl <jad...@gmail.com> --- Makefile.am | 4 +-- clients/simple-damage.c | 92 - 2 files changed, 63 insertions(+), 33 deletions(-) diff --git a/Makefile.am b/Makefile.am index eb093b8..d0693c5

[PATCH weston 1/6] toytoolkit: Port to xdg_shell unstable v6

Signed-off-by: Jonas Ådahl <jad...@gmail.com> --- Makefile.am | 10 ++- clients/window.c | 268 --- 2 files changed, 184 insertions(+), 94 deletions(-) diff --git a/Makefile.am b/Makefile.am index 47fc643..3a42a93 100644 --- a/Makef

[PATCH weston 3/6] clients/simple-shm: Port to xdg_shell unstable v6

Signed-off-by: Jonas Ådahl <jad...@gmail.com> --- Makefile.am | 4 +-- clients/simple-shm.c | 93 2 files changed, 60 insertions(+), 37 deletions(-) diff --git a/Makefile.am b/Makefile.am index dcd0a25..eb093b8

[ANNOUNCE] wayland-protocols 1.6

) See each protocols XML file for details. Here is the shortlog: Bryce Harrington (1): Add screensaver idle inhibitor protocol Jonas Ådahl (2): Introduce xdg-foreign protocol configure.ac: Bump version to 1.6 git tag: 1.6 http://wayland.freedesktop.org/releases/wayland-protocols

Re: [PATCH wayland-protocols 1/4 v5] xdg-shell: Introduce xdg_positioner

rather than later. If anyone have any objections, please raise them as soon as possible. If anyone want to give their RB, please do so as well, and I'll add them before landing wip/xdg-shell-unstable-v6 on master. Jonas On Fri, Jul 29, 2016 at 12:04:53PM +0800, Jonas Ådahl wrote

Re: [PATCH wayland-protocols v4] Add screensaver idle inhibitor protocol

the surface is visible on. > > To uninhibit, simply destroy the inhibitor object. > > Signed-off-by: Bryce Harrington <br...@bryceharrington.org> Looks good to me, and I agree that not overspecifying and bringing up subsurfaces makes it clear enough how it is supposed to work.

Re: [PATCH wayland v4 3/3] Add API to install protocol loggers on the server wl_display

use it > can be enabled at run time and allows to show the log e.g. in a UI view. > A test is added for the new functionality. > > Signed-off-by: Giulio Camuffo <giulio.camu...@kdab.com> With one documentation nit below, this is Reviewed-by: Jonas Ådahl <jad...@gmail.com

Re: [PATCH weston v2 5/6] Add API to retrieve and iterate over the resources list of a client

On Tue, Aug 09, 2016 at 11:51:18AM +0200, Giulio Camuffo wrote: > 2016-08-09 10:17 GMT+02:00 Jonas Ådahl <jad...@gmail.com>: > > On Tue, Jul 05, 2016 at 09:51:10AM +0200, Giulio Camuffo wrote: > >> To complement on the new resource created signal, this allows to > &

Re: [PATCH weston v2 6/6] Add API to install protocol loggers on the server wl_display

On Tue, Jul 05, 2016 at 09:51:11AM +0200, Giulio Camuffo wrote: > The new wl_display_add_protocol_logger allows to set a function as > a logger, which will get called when a new request is received or an > event is sent. > This is akin to setting WAYLAND_DEBUG=1, but more powerful because it > can

Re: [PATCH weston v2 5/6] Add API to retrieve and iterate over the resources list of a client

like that forcing people to write more readable code, it's almost pointless. With that said, the code looks correct to me, and with a couple of comments inline, this is: Reviewed-by: Jonas Ådahl <jad...@gmail.com> > --- > > v2: - don't cast the function pointer, but make it a two step

Re: [PATCH weston v2 4/6] Add a resource creation signal

t i think > that resources are really client specific objects, so it makes sense > to use the wl_client as the context. > > Signed-off-by: Giulio Camuffo <giulio.camu...@kdab.com> Looks good to me. Reviewed-by: Jonas Ådahl <jad...@gmail.com> > --- > > v2: expand a bit the

Re: [PATCH weston v2 2/6] Add API to retrieve the interface name of a wl_resource

On Tue, Jul 05, 2016 at 09:51:07AM +0200, Giulio Camuffo wrote: > Signed-off-by: Giulio Camuffo <giulio.camu...@kdab.com> Reviewed-by: Jonas Ådahl <jad...@gmail.com> > --- > > v2: - return the interface name instead of the interface struct > > src/wayland-server

Re: [PATCH weston v2 3/6] Add API to get the list of connected clients

.com> One comment below; either way this is: Reviewed-by: Jonas Ådahl <jad...@gmail.com> > --- > > v2: expand a bit the documentation and the commit message > > src/wayland-server-core.h | 14 + > src/wayland-server.c | 54 &

Re: [PATCH weston v2 1/6] server: add listener API for new clients

a.paala...@collabora.co.uk> Looks fine to me, except for one issue inlined. With that fixed this is Reviewed-by: Jonas Ådahl <jad...@gmail.com> > --- > > v2: - added a test > - some more documentation > > Makefile.am | 5 ++- > src/wayland-server

Re: [PATCH 3/3 v3] tests: Add a test for global filter

On Mon, Aug 08, 2016 at 10:10:52AM +0200, Olivier Fourdan wrote: > Test if the global filter is effectively filtering out the global when > the filter returns false. > > Signed-off-by: Olivier Fourdan <ofour...@redhat.com> 1-3 looks good to me and are Reviewed-by: Jonas Ådahl

Re: [PATCH wayland-protocols v2] Introduce xdg-foreign protocol

On Fri, Aug 05, 2016 at 07:45:50AM -0500, Derek Foreman wrote: > On 27/07/16 02:54 AM, Jonas Ådahl wrote: > > xdg-foreign is a protocol meant to enable setting up inter surface > > relationships across clients. Potential use cases are out-of-process > > dialogs, such a

Re: [PATCH v2] wayland-server: Add API to control globals visibility

On Mon, Aug 01, 2016 at 03:22:59PM +0200, Olivier Fourdan wrote: > Add a new API to let compositor decide whether or not a wl_global > should be advertised to the clients via wl_registry_bind() or > display_get_registry() > > By using its own filter, the compositor can decide which wl_global

Re: [PATCH wayland-protocols 3/4 v2] xdg-shell: Add resize_x/y constrain adjustment to positioner

On Fri, Jul 29, 2016 at 10:58:47AM +0200, Quentin Glidic wrote: > On 29/07/2016 06:04, Jonas Ådahl wrote: > > In order to get feedback of available space where a client can create > > its popup, let it create requset that its popup rectangle being resized > > would it not fi

[PATCH wayland-protocols 4/4] xdg-shell: Drop desktop environment specific state allocations

their private configure events a latched state tied to xdg_surface.configure. Signed-off-by: Jonas Ådahl <jad...@gmail.com> --- unstable/xdg-shell/xdg-shell-unstable-v6.xml | 12 1 file changed, 12 deletions(-) diff --git a/unstable/xdg-shell/xdg-shell-unstable-v6.xml b/unstable/xdg

[PATCH wayland-protocols 3/4 v2] xdg-shell: Add resize_x/y constrain adjustment to positioner

to the xdg_popup.configure event. The existing constrain adjustment actions take precedence, and resizing will only be triggered if all other adjustments requested didn't manage to make the popup rectangle fully visible. Signed-off-by: Jonas Ådahl <jad...@gmail.com> Acked-by: Quentin Glidic <sardemff7+...@

[PATCH wayland-protocols 1/4 v5] xdg-shell: Introduce xdg_positioner

surface should be positioned in relation to the parent surface. Signed-off-by: Jonas Ådahl <jad...@gmail.com> Signed-off-by: Mike Blumenkrantz <zm...@samsung.com> Acked-by: Yong Bakos <yba...@humanoriented.com> Acked-by: Quentin Glidic <sardemff7+...@sardemff7.net> --- Chang

[PATCH wayland-protocols 2/4 v2] xdg-shell: Clarify focus semantics for popup grabs

focus. This patch doesn't really change any semantics but rather clarifies what was ambiguous before. Signed-off-by: Jonas Ådahl <jad...@gmail.com> --- Changes since v1: - Added back the "This is done so that ..." sentence. unstable/xdg-shell/xdg-shell-unstable-v6.xml | 8

Re: [PATCH wayland-protocols v4 1/7] xdg-shell: Turn xdg_surface into a generic base interface

+0800, Jonas Ådahl wrote: > Split out toplevel window like requests and events into a new interface > called xdg_toplevel, and turn xdg_surface into a generic base interface > which others extends. > > xdg_popup is changed to extend the xdg_surface. > > The configure event in xdg

[PATCH wayland-protocols v2] Introduce xdg-foreign protocol

a client to export a surface, creating a handle for the exported surface. The handle, in form of a unique string, may be shared in some way with other clients (for example the provider of the file dialog) which can then import the exported surface. Signed-off-by: Jonas Ådahl <jad...@gmail.

Re: [PATCH wayland-protocols 2/3] xdg-shell: Clarify focus semantics for popup grabs

On Wed, Jul 20, 2016 at 11:07:50AM -0700, Yong Bakos wrote: > Hi Jonas, > > > On Jul 15, 2016, at 2:37 AM, Jonas Ådahl <jad...@gmail.com> wrote: > > > > Make it clearer what the focus semantics are during a popup grab. In > > short, when a grabbing popup is ma

Re: [PATCH wayland-protocols v4 7/7] xdg-shell: Introduce xdg_positioner

> > I /think/ this can be landed as-is, especially since we've got a branch > for this, but I have some comments inline below before I R'b. > > > > On Jun 23, 2016, at 11:47 PM, Jonas Ådahl <jad...@gmail.com> wrote: > > > > xdg_positioner is a method for dec

[ANNOUNCE] wayland-protocols 1.5

is the shortlog: Bryce Harrington (1): Fix grammar for 'an X*' Carlos Garnacho (1): tablet: Add pad support to the tablet protocol Jonas Ådahl (1): configure.ac: Bump version to 1.5 Peter Hutterer (3): tablet: add v2 of the tablet protocol tablet: change all degree values

Re: [PATCH wayland-protocols] xdg-shell: Introduce xdg_toplevel capabilities

On Wed, Jul 20, 2016 at 11:12:03AM +0200, Quentin Glidic wrote: > On 15/07/2016 13:00, Jonas Ådahl wrote: > > The xdg_toplevel capabilities are meant to let the compositor know what > > configurations a client can be configured to. This is meant to make it > > possible to

Re: [PATCH wayland-protocols] Introduce xdg-foreign protocol

On Wed, Jul 20, 2016 at 12:04:04PM -0700, Yong Bakos wrote: > Hi Jonas, > > > On Jul 13, 2016, at 12:58 AM, Jonas Ådahl <jad...@gmail.com> wrote: > > > > xdg-foreign is a protocol meant to enable setting up inter surface > > relationships across clients. Po

Re: [PATCH wayland-protocols v5 1/4] tablet: add v2 of the tablet protocol

All 4 patches merged, with the typo mentioned by Peter and wording change suggested by Jason, as well as with Bryce and my RBs: 2009a70..24eb670 master -> master Will let it brew over the night a and make release hopefully tomorrow. Jonas On Mon, Jul 11, 2016 at 05:13:33PM +0200, Carlos

Re: [RFC PATCH wayland] wayland-server: Add API to control globals visibility

On Wed, Jul 06, 2016 at 03:45:00PM +0200, Olivier Fourdan wrote: > Add a new API to let compositor decide whether or not a wl_global > should be advertised to the clients via wl_registry_bind() or > display_get_registry() > > By using its own filter, the compositor can decide which wl_global

[PATCH wayland-protocols] xdg-shell: Introduce xdg_toplevel capabilities

to dimension in the xdg_toplevel.configure event. This makes it possible to create non-resizable surfaces as well as surfaces with only a certain aspect ratio allowed, by making them un-fullscreen:able and un-maximize:able. Signed-off-by: Jonas Ådahl <jad...@gmail.com> --- This is an alter

[PATCH wayland-protocols 3/3] xdg-shell: Add resize_x/y constrain adjustment to positioner

to the xdg_popup.configure event. The existing constrain adjustment actions take precedence, and resizing will only be triggered if all other adjustments requested didn't manage to make the popup rectangle fully visible. Signed-off-by: Jonas Ådahl <jad...@gmail.com> --- unstable/xdg-shell/xdg-shell-unstable-

[PATCH wayland-protocols 2/3] xdg-shell: Clarify focus semantics for popup grabs

focus. This patch doesn't really change any semantics but rather clarifies what was ambiguous before. Signed-off-by: Jonas Ådahl <jad...@gmail.com> --- unstable/xdg-shell/xdg-shell-unstable-v6.xml | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/unstable/xdg-shell/xdg

[PATCH wayland-protocols 1/3] xdg-shell: Don't require the client to obay configure sizes

that will not be able to resize to a certain size, or deal with it in some way, such as adding padding or scaling. Signed-off-by: Jonas Ådahl <jad...@gmail.com> --- unstable/xdg-shell/xdg-shell-unstable-v6.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/unstable/xdg-shell/xdg

[PATCH wayland-protocols] Introduce xdg-foreign protocol

a client to export a surface, creating a handle for the exported surface. The handle, in form of a unique string, may be shared in some way with other clients (for example the provider of the file dialog) which can then import the exported surface. Signed-off-by: Jonas Ådahl <jad...@gmail.com> -

Re: [PATCH RFC] Add tiled states per edge

On Fri, Jul 08, 2016 at 11:58:13AM +0200, Quentin Glidic wrote: > Hi all, > > I will try to summarize all the discussion about tiling that this thread has > generated, and if all goes fine, we will see that we mostly all agree with > each other. > > First, definitions: > > Stacking/Floating:

Re: [PATCH wayland-protocols v7] text: Create second version of text input protocol

On Wed, Jul 06, 2016 at 12:26:28AM +0200, Jan Arne Petersen wrote: > On Thu, Jun 9, 2016 at 1:01 PM Carlos Garnacho wrote: > > Hi Carlos, > > Thanks for the feedback. > > > > > Chiming in, and kinda late at that... hopefully we'll get this moving :). > > I do not think we

Re: [PATCH libinput 1/2] test: create a lock file to avoid parallel udev reloads during device add

if (stat(LITEST_UDEV_LOCKFILE, ) != -1) { > + if (st.st_mtime < now - 10) { I suppose making sure the test case runs fine when changing between summer time/not summer time is unimportant enoug

Re: [PATCH wayland-web 1/1] html: Remove trailing whitespace

On Thu, Jun 30, 2016 at 03:38:44PM -0700, Yong Bakos wrote: > On Jun 30, 2016, at 3:12 AM, Pekka Paalanen wrote: > > > > On Tue, 28 Jun 2016 08:52:33 -0500 > > Yong Bakos wrote: > > > >> From: Yong Bakos > >> > >> The

Re: [PATCH v4 wayland-protocols 4/4] tablet: Add pad support to the tablet protocol

On Thu, Jun 30, 2016 at 01:10:33PM +0200, Carlos Garnacho wrote: > Hi!, > > On Thu, Jun 30, 2016 at 6:27 AM, Jonas Ådahl <jad...@gmail.com> wrote: > > On Tue, Jun 28, 2016 at 11:21:50PM +0200, Carlos Garnacho wrote: > >> The pad's interface is similar to the tool i

Re: [PATCH v4 wayland-protocols 4/4] tablet: Add pad support to the tablet protocol

On Tue, Jun 28, 2016 at 11:21:50PM +0200, Carlos Garnacho wrote: > The pad's interface is similar to the tool interface, a client is notified of > the pad after the tablet_added event. > > The pad has three functionalities: buttons, rings and strips. > Buttons are fairly straightforward, rings

Re: Free software license of weston1.9

On Thu, Jun 30, 2016 at 04:43:29AM +0200, Armin Krezović wrote: > On 30.06.2016 04:19, 袁嘉伟 wrote: > > Hi, All: > > > > > > Who does know that the free software license of weston 1.9 is GPL or > > LGPL? > > Thanks. > > > > Best regards, > > Anthenony > > > > > > > >

[PATCH wayland-protocols v4 7/7] xdg-shell: Introduce xdg_positioner

surface should be positioned in relation to the parent surface. Signed-off-by: Jonas Ådahl <jad...@gmail.com> Signed-off-by: Mike Blumenkrantz <zm...@samsung.com> Acked-by: Yong Bakos <yba...@humanoriented.com> --- Changes since v3: - Allow combining slide_x/y and flip_x/y enums

[PATCH wayland-protocols v4 1/7] xdg-shell: Turn xdg_surface into a generic base interface

xdg_surface based extensions are meant to also extend xdg_surface.configure for relevant window type dependend state synchronization. Signed-off-by: Jonas Ådahl <jad...@gmail.com> Signed-off-by: Mike Blumenkrantz <zm...@samsung.com> Reviewed-by: Yong Bakos <yba...@humanoriented.co

[PATCH wayland-protocols v4 4/7] xdg-shell: Improve error enum formatting some

The long lines stood out, break them by putting the summary on its own line. Signed-off-by: Jonas Ådahl <jad...@gmail.com> Reviewed-by: Yong Bakos <yba...@humanoriented.com> Reviewed-by: Mike Blumenkrantz <zm...@osg.samsung.com> Reviewed-by: Benoit Gschwind <gschw...@gnu-log

[PATCH wayland-protocols v4 3/7] xdg-shell: Add error codes for invalid surface state

Signed-off-by: Jonas Ådahl <jad...@gmail.com> Reviewed-by: Mike Blumenkrantz <zm...@osg.samsung.com> Reviewed-by: Yong Bakos <yba...@humanoriented.com> --- No changes since v3. unstable/xdg-shell/xdg-shell-unstable-v6.xml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/

[PATCH wayland-protocols v4 5/7] xdg-shell: Make get_popup take a xdg_surface instead of wl_surface

The reason for using wl_surface before was that xdg_popup and xdg_surface (now xdg_toplevel) had no common interface other than wl_surface, but since xdg_surface is now the base interface, lets use that. Signed-off-by: Jonas Ådahl <jad...@gmail.com> Reviewed-by: Mike Blumenkran

Re: [PATCH wayland-protocols v3 7/7] xdg-shell: Introduce xdg_positioner

On Tue, Jun 14, 2016 at 01:01:15PM -0400, Jonas Ådahl wrote: > On Thu, Jun 09, 2016 at 12:05:28AM +0200, Benoit Gschwind wrote: > > Hello Jonas, > > > > The proposal of xdg_positioner is a good idea. I still need to review > > your proposal deeper, but at the moment I h

<    1   2   3   4   5   6   7   8   9   10   >