Re: [PATCH weston v2 2/3] compositor-drm: Add scanout support for linux_dmabuf buffers

2016-10-06 Thread Esaki Tomohito
Hi, Fabien Thanks for your reviewing. On 2016/10/05 0:45, Fabien DESSENNE wrote: > On 09/30/2016 11:28 AM, Tomohito Esaki wrote: >> +width = dmabuf->attributes.width; >> +height = dmabuf->attributes.height; >> +if (backend->min_width > width || >> +width > backend->max_width

Re: [PATCH weston v2 2/3] compositor-drm: Add scanout support for linux_dmabuf buffers

2016-10-06 Thread Esaki Tomohito
Hi, Derek Thanks for your reviewing and testing. On 2016/10/04 3:20, Derek Foreman wrote: > If I mess up redraw() to call exit(1); after drawing 100 frames I get > the same weston crash with intel_do_flush_locked failed. > > I don't have a lot of time to dig into this right now - can you test an

Re: [PATCH weston v2 2/3] compositor-drm: Add scanout support for linux_dmabuf buffers

2016-10-04 Thread Fabien DESSENNE
Hi Thank you for the patch. Please, find some minor comments below. On 09/30/2016 11:28 AM, Tomohito Esaki wrote: > This implementations bypasses gbm and passes the dmabuf handles directly > to libdrm for composition. Maybe you can split the patch in two parts: - one part dealing with

Re: [PATCH weston v2 2/3] compositor-drm: Add scanout support for linux_dmabuf buffers

2016-10-03 Thread Derek Foreman
On 30/09/16 04:28 AM, Tomohito Esaki wrote: This implementations bypasses gbm and passes the dmabuf handles directly to libdrm for composition. Signed-off-by: Tomohito Esaki Very cool work! Acked-by: Derek Foreman I don't see anything here that Eric

Re: [PATCH weston v2 2/3] compositor-drm: Add scanout support for linux_dmabuf buffers

2016-09-30 Thread Eric Engestrom
On Fri, Sep 30, 2016 at 06:28:52PM +0900, Tomohito Esaki wrote: > This implementations bypasses gbm and passes the dmabuf handles directly > to libdrm for composition. > > Signed-off-by: Tomohito Esaki > --- > libweston/compositor-drm.c | 125 >

[PATCH weston v2 2/3] compositor-drm: Add scanout support for linux_dmabuf buffers

2016-09-30 Thread Tomohito Esaki
This implementations bypasses gbm and passes the dmabuf handles directly to libdrm for composition. Signed-off-by: Tomohito Esaki --- libweston/compositor-drm.c | 125 ++--- 1 file changed, 107 insertions(+), 18 deletions(-) diff --git