Hi, Fabien Thanks for your reviewing.
On 2016/10/05 0:45, Fabien DESSENNE wrote: > On 09/30/2016 11:28 AM, Tomohito Esaki wrote: >> + width = dmabuf->attributes.width; >> + height = dmabuf->attributes.height; >> + if (backend->min_width > width || >> + width > backend->max_width || >> + backend->min_height > height || >> + height > backend->max_height) >> + return NULL; > Just like in drm_fb_get_from_bo(), add an error log "bo geometry out of > bounds" I removed this logging in v2 because of the possibility of flooding the compoitor log, as Pekka pointed out (see below). Pekka wrote below for v1: On 2016/06/15 17:20, Pekka Paalanen wrote: > > Is there a possibility that if this triggers, it will trigger every > frame and flood the compositor log? > > If yes, I'd just remove this logging. The rest below are fine by me, > since those should not be failing, right? (https://lists.freedesktop.org/archives/wayland-devel/2016-June/029466.html) Otherwise I will update patches as you suggested. Best regards. -- -------------------------- IGEL Co., Ltd. Tomohito Esaki e...@igel.co.jp _______________________________________________ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel
