Re: [PATCH weston v2 3/3] compositor-drm: Support linux_dmabuf output for sprite planes without gbm

2017-09-27 Thread Esaki Tomohito
Hello Daniel-san On 2017/09/27 2:09, Daniel Stone wrote: > Hello Esaki-san, > > On 1 November 2016 at 19:09, Daniel Stone wrote: >>> @@ -1101,15 +1096,9 @@ drm_output_prepare_overlay_view(struct drm_output >>> *output, >>> if (!found) >>> return NULL; >>> >>> - if

Re: [PATCH weston v2 3/3] compositor-drm: Support linux_dmabuf output for sprite planes without gbm

2017-09-26 Thread Daniel Stone
Hello Esaki-san, On 1 November 2016 at 19:09, Daniel Stone wrote: >> @@ -1101,15 +1096,9 @@ drm_output_prepare_overlay_view(struct drm_output >> *output, >> if (!found) >> return NULL; >> >> - if ((dmabuf = linux_dmabuf_buffer_get(buffer_resource))) { >> + if

Re: [PATCH weston v2 3/3] compositor-drm: Support linux_dmabuf output for sprite planes without gbm

2016-11-02 Thread Esaki Tomohito
Dear Daniel, On 2016/11/02 4:09, Daniel Stone wrote: > This includes the small changes I mentioned to patch 1/3: please let > me know if this change is OK with you. I think the series which is in > there is pretty good to review already, but needs a tiny bit more > testing. This is what I am curre

Re: [PATCH weston v2 3/3] compositor-drm: Support linux_dmabuf output for sprite planes without gbm

2016-11-01 Thread Daniel Stone
Dear Esaki-san, On 30 September 2016 at 10:28, Tomohito Esaki wrote: > Multiplanar formats are supported by using drmModeAddFB2 and bypassing > gbm. If drmModeAddFB2 isn't available, the existing gbm bo import path > is used and multiplanar formats are unsupported. Thanks very much for these fou

Re: [PATCH weston v2 3/3] compositor-drm: Support linux_dmabuf output for sprite planes without gbm

2016-10-10 Thread Fabien DESSENNE
Hi, Please find below a comment. Fabien On 09/30/2016 11:28 AM, Tomohito Esaki wrote: > Multiplanar formats are supported by using drmModeAddFB2 and bypassing > gbm. If drmModeAddFB2 isn't available, the existing gbm bo import path > is used and multiplanar formats are unsupported. > > Signed

Re: [PATCH weston v2 3/3] compositor-drm: Support linux_dmabuf output for sprite planes without gbm

2016-10-04 Thread Pekka Paalanen
On Mon, 3 Oct 2016 15:53:20 +0100 Daniel Stone wrote: > Hi, > > On 3 October 2016 at 15:01, Derek Foreman wrote: > > My fingers are crossed - I see this (both atomic mode setting, and the > > ability to put dmabuf buffers into planes) as incredibly important work > > too. > > Yes - I think

Re: [PATCH weston v2 3/3] compositor-drm: Support linux_dmabuf output for sprite planes without gbm

2016-10-03 Thread Daniel Stone
Hi, On 3 October 2016 at 15:01, Derek Foreman wrote: > On 03/10/16 06:03 AM, Fabien DESSENNE wrote: >> I do not know all the history of Weston, and I am not aware of all the >> reasons that made the sprites "broken". I have always been told that it >> was not a good idea to enable sprites because

Re: [PATCH weston v2 3/3] compositor-drm: Support linux_dmabuf output for sprite planes without gbm

2016-10-03 Thread Derek Foreman
On 03/10/16 06:03 AM, Fabien DESSENNE wrote: On 09/30/2016 08:49 PM, Derek Foreman wrote: On 30/09/16 04:28 AM, Tomohito Esaki wrote: Multiplanar formats are supported by using drmModeAddFB2 and bypassing gbm. If drmModeAddFB2 isn't available, the existing gbm bo import path is used and multip

Re: [PATCH weston v2 3/3] compositor-drm: Support linux_dmabuf output for sprite planes without gbm

2016-10-03 Thread Fabien DESSENNE
On 09/30/2016 08:49 PM, Derek Foreman wrote: > On 30/09/16 04:28 AM, Tomohito Esaki wrote: >> Multiplanar formats are supported by using drmModeAddFB2 and bypassing >> gbm. If drmModeAddFB2 isn't available, the existing gbm bo import path >> is used and multiplanar formats are unsupported. > I'm n

Re: [PATCH weston v2 3/3] compositor-drm: Support linux_dmabuf output for sprite planes without gbm

2016-09-30 Thread Derek Foreman
On 30/09/16 04:28 AM, Tomohito Esaki wrote: Multiplanar formats are supported by using drmModeAddFB2 and bypassing gbm. If drmModeAddFB2 isn't available, the existing gbm bo import path is used and multiplanar formats are unsupported. I'm not sure we should be doing anything with the existing s

[PATCH weston v2 3/3] compositor-drm: Support linux_dmabuf output for sprite planes without gbm

2016-09-30 Thread Tomohito Esaki
Multiplanar formats are supported by using drmModeAddFB2 and bypassing gbm. If drmModeAddFB2 isn't available, the existing gbm bo import path is used and multiplanar formats are unsupported. Signed-off-by: Tomohito Esaki --- libweston/compositor-drm.c | 53 +++