Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

2018-03-21 Thread Emil Velikov
On 21 March 2018 at 09:28, Daniel Stone wrote: > Hi, > > On 21 March 2018 at 08:27, Pekka Paalanen wrote: >> On Tue, 20 Mar 2018 11:46:32 +, Daniel Stone >> wrote: >>> inconvenience of maintaining a list of every linker's

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

2018-03-21 Thread Daniel Stone
Hi, On 21 March 2018 at 08:27, Pekka Paalanen wrote: > On Tue, 20 Mar 2018 11:46:32 +, Daniel Stone wrote: >> inconvenience of maintaining a list of every linker's implementation >> detail on every platform, outweighs the risk of an exported >>

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

2018-03-21 Thread Pekka Paalanen
On Tue, 20 Mar 2018 11:46:32 + Daniel Stone wrote: > inconvenience of maintaining a list of every linker's implementation > detail on every platform, outweighs the risk of an exported > underscore-prefixed symbol slipping through review. Hi, how about we make it a

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

2018-03-20 Thread Emil Velikov
On 20 March 2018 at 15:09, Derek Foreman wrote: > On 2018-03-20 10:02 AM, Emil Velikov wrote: >> On 20 March 2018 at 14:50, Derek Foreman wrote: >>> On 2018-03-20 07:11 AM, Daniel Stone wrote: On 20 March 2018 at 11:55, Emil Velikov

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

2018-03-20 Thread Derek Foreman
On 2018-03-20 10:02 AM, Emil Velikov wrote: > On 20 March 2018 at 14:50, Derek Foreman wrote: >> On 2018-03-20 07:11 AM, Daniel Stone wrote: >>> On 20 March 2018 at 11:55, Emil Velikov wrote: On 20 March 2018 at 11:46, Daniel Stone

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

2018-03-20 Thread Emil Velikov
On 20 March 2018 at 14:50, Derek Foreman wrote: > On 2018-03-20 07:11 AM, Daniel Stone wrote: >> On 20 March 2018 at 11:55, Emil Velikov wrote: >>> On 20 March 2018 at 11:46, Daniel Stone wrote: Sure. As on IRC though,

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

2018-03-20 Thread Derek Foreman
On 2018-03-20 07:11 AM, Daniel Stone wrote: > On 20 March 2018 at 11:55, Emil Velikov wrote: >> On 20 March 2018 at 11:46, Daniel Stone wrote: >>> Sure. As on IRC though, we definitely need to add at least _ftext for >>> MIPS anyway: >>>

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

2018-03-20 Thread Emil Velikov
On 20 March 2018 at 12:11, Daniel Stone wrote: > On 20 March 2018 at 11:55, Emil Velikov wrote: >> On 20 March 2018 at 11:46, Daniel Stone wrote: >>> Sure. As on IRC though, we definitely need to add at least _ftext for >>>

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

2018-03-20 Thread Daniel Stone
On 20 March 2018 at 11:55, Emil Velikov wrote: > On 20 March 2018 at 11:46, Daniel Stone wrote: >> Sure. As on IRC though, we definitely need to add at least _ftext for >> MIPS anyway: >>

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

2018-03-20 Thread Emil Velikov
On 20 March 2018 at 11:46, Daniel Stone wrote: > Hi Emil, > > On 20 March 2018 at 11:30, Emil Velikov wrote: >> On 20 March 2018 at 11:01, Daniel Stone wrote: >>> Rather than a hard-coded list of platform symbols, just

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

2018-03-20 Thread Daniel Stone
Hi Emil, On 20 March 2018 at 11:30, Emil Velikov wrote: > On 20 March 2018 at 11:01, Daniel Stone wrote: >> Rather than a hard-coded list of platform symbols, just ignore anything >> prefaced with an underscore. This fixes breakage on ARM, which

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

2018-03-20 Thread Emil Velikov
On 20 March 2018 at 11:01, Daniel Stone wrote: > Rather than a hard-coded list of platform symbols, just ignore anything > prefaced with an underscore. This fixes breakage on ARM, which declares > several slightly different platform symbols to x86. > FWIW I've explicitly