Re: [PATCH weston] parse_modeline: Ignore case of {h,v}sync flags

2018-07-03 Thread Guido Günther
Hi, On Tue, Jul 03, 2018 at 12:04:37PM +0300, Pekka Paalanen wrote: > On Tue, 26 Jun 2018 20:40:08 +0200 > Guido Günther wrote: > > > Some modeline generators put out e.g. +HSync instead of +hsync. Accept > > that too since it's not ambigous. > > > > Signed-off-by: Guido Günther > > --- > >

Re: [PATCH weston] parse_modeline: Ignore case of {h,v}sync flags

2018-07-03 Thread Pekka Paalanen
On Tue, 26 Jun 2018 20:40:08 +0200 Guido Günther wrote: > Some modeline generators put out e.g. +HSync instead of +hsync. Accept > that too since it's not ambigous. > > Signed-off-by: Guido Günther > --- > libweston/compositor-drm.c | 8 > 1 file changed, 4 insertions(+), 4

Re: [PATCH weston] parse_modeline: Ignore case of {h,v}sync flags

2018-06-27 Thread Emil Velikov
On 27 June 2018 at 12:42, Guido Günther wrote: > Hi, > On Wed, Jun 27, 2018 at 11:30:40AM +0100, Emil Velikov wrote: >> On 26 June 2018 at 19:40, Guido Günther wrote: >> > Some modeline generators put out e.g. +HSync instead of +hsync. Accept >> > that too since it's not ambigous. >> > >> Hmm

Re: [PATCH weston] parse_modeline: Ignore case of {h,v}sync flags

2018-06-27 Thread Guido Günther
Hi, On Wed, Jun 27, 2018 at 11:30:40AM +0100, Emil Velikov wrote: > On 26 June 2018 at 19:40, Guido Günther wrote: > > Some modeline generators put out e.g. +HSync instead of +hsync. Accept > > that too since it's not ambigous. > > > Hmm which generator is that? The cvt one, given as an example

Re: [PATCH weston] parse_modeline: Ignore case of {h,v}sync flags

2018-06-27 Thread Emil Velikov
On 26 June 2018 at 19:40, Guido Günther wrote: > Some modeline generators put out e.g. +HSync instead of +hsync. Accept > that too since it's not ambigous. > Hmm which generator is that? The cvt one, given as an example seems to produce lowercase ones. Personally I'm inclined to suggest fixing