[PATCH libinput] test: move all the _setup() functions into a special section

This way we can loop through them instead of having to add them manually. Signed-off-by: Peter Hutterer --- test/litest.c| 25 - test/litest.h| 14 ++ test/test-device.c | 3 +--

Re: T480s Trackpoint drifts

On Wed, Mar 21, 2018 at 11:14:28AM +0800, Kai Hendry wrote: > On Tue, 20 Mar 2018, at 12:05 PM, Peter Hutterer wrote: > > what exactly is drift in this context? it moves on its own to the edge of > > the screen? > > It generally just moves diagonally south west for about a cm. Sometimes > all the

[PATCH libinput] touchpad: only keep low-pressure fingers alive for 2+-slot touchpads

Regression introduced by 3979b9e16a5ed141506d95f80ddfd7b94651dcfa, bug 105258. With that commit, we only ended real touches when we had less than nslots fake fingers down. i.e. tripletap on a 2 slot touchpad would not end the first/second touch even if the pressure goes below the threshold. e.g.

Re: T480s Trackpoint drifts

On Tue, 20 Mar 2018, at 12:05 PM, Peter Hutterer wrote: > what exactly is drift in this context? it moves on its own to the edge of > the screen? It generally just moves diagonally south west for about a cm. Sometimes all the way to the bottom left. Initially I googled around and people said it

build tools questions

I'm interested in getting the build up to snuff on Raspberry Pi 2/3. Where should I file bugs? The github repo doesn't have the 'issues' component turned on so there is no way to file an issue. https://github.com/wayland-project/wayland-build-tools

Re: [PATCH] xdg-shell: add enums for tiled window state to toplevel configure

On 2018-03-20 9:52 AM, Mike Blumenkrantz wrote: > this adds implementation from a related discussion long ago in which > it was decided that it would be useful for clients to know if/where their > windows were tiled so that various behaviors and visuals could be modified > to improve UX > > a

[PATCH v2] xwm: Fix memory leak

A memory leak introduced by 6b58ea8c led to me finding a bigger leak, which is xwm was calling frame_create() without calling frame_destroy(). This meant that the associated icon_surface was not being destroyed, leaving the destroy handler for it broken. Here we fix this by calling frame_destroy()

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

On 20 March 2018 at 15:09, Derek Foreman wrote: > On 2018-03-20 10:02 AM, Emil Velikov wrote: >> On 20 March 2018 at 14:50, Derek Foreman wrote: >>> On 2018-03-20 07:11 AM, Daniel Stone wrote: On 20 March 2018 at 11:55, Emil Velikov

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

On 2018-03-20 10:02 AM, Emil Velikov wrote: > On 20 March 2018 at 14:50, Derek Foreman wrote: >> On 2018-03-20 07:11 AM, Daniel Stone wrote: >>> On 20 March 2018 at 11:55, Emil Velikov wrote: On 20 March 2018 at 11:46, Daniel Stone

RE: [PATCH weston 1/7] compositor-drm: remove superfluos get_disable_state call

Hi Daniel, > -Original Message- > From: Daniel Stone [mailto:dan...@fooishbar.org] > Sent: Dienstag, 20. März 2018 15:48 > To: Ucan, Emre (ADITG/ESB) > Cc: wayland-devel@lists.freedesktop.org > Subject: Re: [PATCH weston 1/7] compositor-drm: remove superfluos > get_disable_state call > >

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

On 20 March 2018 at 14:50, Derek Foreman wrote: > On 2018-03-20 07:11 AM, Daniel Stone wrote: >> On 20 March 2018 at 11:55, Emil Velikov wrote: >>> On 20 March 2018 at 11:46, Daniel Stone wrote: Sure. As on IRC though,

Re: [PATCH] xdg-shell: add enums for tiled window state to toplevel configure

On Tue, Mar 20, 2018 at 10:15 AM Simon McVittie wrote: > On Tue, 20 Mar 2018 at 09:52:02 -0400, Mike Blumenkrantz wrote: > > this adds implementation from a related discussion long ago in which > > it was decided that it would be useful for clients to know if/where their > >

Re: T480s Trackpoint drifts

On 20 March 2018 at 04:05, Peter Hutterer wrote: > On Mon, Mar 19, 2018 at 04:28:20PM +0800, Kai Hendry wrote: >> Hi there, >> >> I'm an Archlinux user who has a new T480s Thinkpad and unfortunately >> the Trackpoint can (not always or reproducibly) "drift". I hope that

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

On 2018-03-20 07:11 AM, Daniel Stone wrote: > On 20 March 2018 at 11:55, Emil Velikov wrote: >> On 20 March 2018 at 11:46, Daniel Stone wrote: >>> Sure. As on IRC though, we definitely need to add at least _ftext for >>> MIPS anyway: >>>

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

On 20 March 2018 at 12:11, Daniel Stone wrote: > On 20 March 2018 at 11:55, Emil Velikov wrote: >> On 20 March 2018 at 11:46, Daniel Stone wrote: >>> Sure. As on IRC though, we definitely need to add at least _ftext for >>>

Re: [PATCH weston 1/7] compositor-drm: remove superfluos get_disable_state call

Hi Emre, On 20 March 2018 at 14:28, Emre Ucan wrote: > drm_output_get_disable_state function returns > a duplicated output_state object. > > Here we are creating the object, but we are > never using it. Therefore, it is safe to remove. > > (Found by clang source code

Re: [PATCH] xwm: Fix memory leak

Hi Pekka, On Tue, Mar 20, 2018 at 2:21 AM, Pekka Paalanen wrote: > On Mon, 19 Mar 2018 18:06:03 -0600 > Scott Moreau wrote: > > > Fix memory leak introduced by 6b58ea8c. weston_wm_handle_icon() was > > calling xcb_get_property_reply() without freeing the

[PATCH weston 6/7] compositor: initialize ret in repaint_timer_handler

If output_list of compositor is empty, value of ret is read without initialization. Signed-off-by: Emre Ucan --- libweston/compositor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libweston/compositor.c b/libweston/compositor.c index

[PATCH weston 5/7] gl-renderer: set num_images after import_simple_dmabuf

we have to set num_images after import_simple_dmabuf call. Otherwise, egl_images will not be correctly referenced in gl_renderer_attach_dmabuf. (Found by clang source code analyzer) Signed-off-by: Emre Ucan --- libweston/gl-renderer.c | 1 + 1 file changed, 1 insertion(+)

[PATCH weston 7/7] ivi-shell: remove dead assignments in layer transition

Signed-off-by: Emre Ucan --- ivi-shell/ivi-layout-transition.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/ivi-shell/ivi-layout-transition.c b/ivi-shell/ivi-layout-transition.c index b887ff6..a223b58 100644 ---

[PATCH weston 0/7] Fix source code analyzer findings

These patches fix some of the findings which are found by clang source code analyzer. Emre Ucan (7): compositor-drm: remove superfluos get_disable_state call compositor-drm: remove dead assigment in drm_fb_create_dumb hmi-controller: remove dead assignments in add_launchers input: fix

[PATCH weston 4/7] input: fix use-after-free issue at pointer_cancel

If the constraint is an one-shot constraint, constraint is freed in disable_pointer_constraint function. Therefore, we should not try to read freed memory at "switch (constraint->lifetime)" statement. The removed code is anyway superfluous. Because surface destroy signal is only removed, when

[PATCH weston 3/7] hmi-controller: remove dead assignments in add_launchers

assigned values of x, y, ret and layout_surface are never read. (Found by clang source code analyzer) Signed-off-by: Emre Ucan --- ivi-shell/hmi-controller.c | 4 1 file changed, 4 deletions(-) diff --git a/ivi-shell/hmi-controller.c b/ivi-shell/hmi-controller.c

[PATCH weston 1/7] compositor-drm: remove superfluos get_disable_state call

drm_output_get_disable_state function returns a duplicated output_state object. Here we are creating the object, but we are never using it. Therefore, it is safe to remove. (Found by clang source code analyzer) Signed-off-by: Emre Ucan --- libweston/compositor-drm.c | 1

[PATCH weston 2/7] compositor-drm: remove dead assigment in drm_fb_create_dumb

ret is overwritten by drmModeAddFB2 call (Found by clang source code analyzer) Signed-off-by: Emre Ucan --- libweston/compositor-drm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libweston/compositor-drm.c b/libweston/compositor-drm.c index f8c13ee..506ded5

[PATCH] xdg-shell: add enums for tiled window state to toplevel configure

this adds implementation from a related discussion long ago in which it was decided that it would be useful for clients to know if/where their windows were tiled so that various behaviors and visuals could be modified to improve UX a window which is e.g., tiled on the right side of the screen

Re: [PATCH wayland 1/2] wayland-egl-symbols-check: add ARM specific glib entrypoints

On Tue, 20 Mar 2018 at 11:10:44 +, Emil Velikov wrote: > Subject: [PATCH wayland 1/2] wayland-egl-symbols-check: add ARM specific > glib entrypoints ARM-specific *glibc* entry points, GLib has nothing to do with this :-) smcv ___ wayland-devel

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

On 20 March 2018 at 11:55, Emil Velikov wrote: > On 20 March 2018 at 11:46, Daniel Stone wrote: >> Sure. As on IRC though, we definitely need to add at least _ftext for >> MIPS anyway: >>

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

On 20 March 2018 at 11:46, Daniel Stone wrote: > Hi Emil, > > On 20 March 2018 at 11:30, Emil Velikov wrote: >> On 20 March 2018 at 11:01, Daniel Stone wrote: >>> Rather than a hard-coded list of platform symbols, just

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

Hi Emil, On 20 March 2018 at 11:30, Emil Velikov wrote: > On 20 March 2018 at 11:01, Daniel Stone wrote: >> Rather than a hard-coded list of platform symbols, just ignore anything >> prefaced with an underscore. This fixes breakage on ARM, which

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

On 20 March 2018 at 11:01, Daniel Stone wrote: > Rather than a hard-coded list of platform symbols, just ignore anything > prefaced with an underscore. This fixes breakage on ARM, which declares > several slightly different platform symbols to x86. > FWIW I've explicitly

[PATCH wayland 2/2] .gitignore: add wayland-egl-abi-check

From: Emil Velikov Instruct git go ignore the file, in case we've done an in-tree build. Cc: Derek Foreman Signed-off-by: Emil Velikov --- I've opted for the shortest fix - add an entry instead of renaming files,

[PATCH wayland 1/2] wayland-egl-symbols-check: add ARM specific glib entrypoints

From: Emil Velikov Seems like glibc on ARM (32 or 64 bit) exports a few extra symbols. Add them to the list. Quick look reveals that those are aliases of the already listed symbols, and have been added to glibc since day 1 :-\ Fixes: 21b1f22eb05 ("wayland-egl:

[PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

Rather than a hard-coded list of platform symbols, just ignore anything prefaced with an underscore. This fixes breakage on ARM, which declares several slightly different platform symbols to x86. Signed-off-by: Daniel Stone Fixes: 21b1f22eb056 ("wayland-egl: enhance the

[PATCH weston 3/3] simple-dmabuf-drm: support DRM_FORMAT_LINEAR for NV12 as well

This makes --import-format=NV12 testable on e.g. intel We only set nv12_format_found to true if we found that format and at least one understood modifier. Store modifier verbatim instead of using a boolean flag. Last advertised and supported modifier currently wins. Signed-off-by: Guido Günther

[PATCH weston 1/3] simple-dmabuf-drm: drop superfluous declaration

variable is defined in simple-dmabuf-drm.h Signed-off-by: Guido Günther --- clients/simple-dmabuf-drm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/clients/simple-dmabuf-drm.c b/clients/simple-dmabuf-drm.c index 2975f3a5..1c062fad 100644 ---

[PATCH weston 0/3] simple-dmabuf-drm: support DRM_FORMAT_LINEAR for NV12

This makes NV12 testable on non freedreno as well. E.g. intel supports it. Guido Günther (3): simple-dmabuf-drm: drop superfluous declaration simple-dmabuf-drm: don't exit from create_display simple-dmabuf-drm: support DRM_FORMAT_LINEAR for NV12 as well clients/simple-dmabuf-drm.c | 63

[PATCH weston 2/3] simple-dmabuf-drm: don't exit from create_display

Only exit from main so control flow is in one place. Signed-off-by: Guido Günther --- clients/simple-dmabuf-drm.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/clients/simple-dmabuf-drm.c b/clients/simple-dmabuf-drm.c index 1c062fad..b9681ca4

[PATCH weston v5 3/3] simple-dmabuf-drm: support etnaviv drm as well

Reviewed-by: Derek Foreman Signed-off-by: Guido Günther --- Makefile.am | 1 + clients/simple-dmabuf-drm.c | 68 + configure.ac| 5 +++- 3 files changed, 73 insertions(+), 1

[PATCH weston v5 2/3] simple-dmabuf-drm: simplify fd_map_bo

Signed-off-by: Guido Günther --- clients/simple-dmabuf-drm.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/clients/simple-dmabuf-drm.c b/clients/simple-dmabuf-drm.c index 19e8dbb1..cb04622f 100644 --- a/clients/simple-dmabuf-drm.c +++

[PATCH weston v5 1/3] simple-dmabuf-drm: 0 is a valid fd (freedreno)

Reviewed-by: Eric Engestrom Signed-off-by: Guido Günther --- clients/simple-dmabuf-drm.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/clients/simple-dmabuf-drm.c b/clients/simple-dmabuf-drm.c index 2975f3a5..19e8dbb1 100644

[PATCH weston v5 0/3] simple-dmabuf-drm: Support etnaviv and freedreno cleanups

Former patches 1-2 where already applied thanks Derek. Changes from v4 - configure: use true if etnaviv drm was not found as with other drm backends (avoids an unused variable assignment) - configure: use (hopefully) correct english - simplify several if (cond) return 1; return

Re: [PATCH] xwm: Fix memory leak

On Mon, 19 Mar 2018 18:06:03 -0600 Scott Moreau wrote: > Fix memory leak introduced by 6b58ea8c. weston_wm_handle_icon() was > calling xcb_get_property_reply() without freeing the reply. > --- > xwayland/window-manager.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff

Re: [PATCH weston v4 4/4] simple-dmabuf-drm: support etnaviv drm as well

On Mon, 19 Mar 2018 15:24:12 -0500 Derek Foreman wrote: > On 2018-03-19 11:45 AM, Guido Günther wrote: > > Signed-off-by: Guido Günther > > --- > > Makefile.am | 1 + > > clients/simple-dmabuf-drm.c | 77 > >

Re: [PATCH wayland] wayland-egl: Make symbol test fail on failure

On Mon, 19 Mar 2018 11:59:25 -0500 Derek Foreman wrote: > On 2018-03-19 11:20 AM, Eric Engestrom wrote: > > On Monday, 2018-03-19 16:10:57 +, Daniel Stone wrote: > >> Hi, > >> > >> On 19 March 2018 at 16:08, Eric Engestrom > >> wrote: