Reviewed-by: Matheus Santana
On Tue, Jun 19, 2018 at 9:28 PM, Peter Hutterer
wrote:
> "/usr/include/math.h", line 381: error #20: identifier "_Float32" is
> undefined
> # define _Mdouble__Float32
>
> Same for a few others. Since we don't actually need those anyway, we can
> just
Great. I wasn't aware of the test case. Thanks for the heads up!
Best regards,
Matheus
On Tue, Jun 19, 2018 at 9:32 PM, Peter Hutterer
wrote:
> On Tue, Jun 19, 2018 at 09:22:52PM -0300, Matheus Santana wrote:
> > Reviewed-by: Matheus Santana
> >
> > The check for negatives isn't needed
On Tue, Jun 19, 2018 at 09:22:52PM -0300, Matheus Santana wrote:
> Reviewed-by: Matheus Santana
>
> The check for negatives isn't needed anymore?
you mean zalloc_overflow? good point. I'll leave it in though because it
does test a valid error case. I've added more tests for zalloc(some large
"/usr/include/math.h", line 381: error #20: identifier "_Float32" is undefined
# define _Mdouble__Float32
Same for a few others. Since we don't actually need those anyway, we can just
cast those to the some close-enough sizes. We don't have stdint.h in config.h
and meson cannot have
Reviewed-by: Matheus Santana
The check for negatives isn't needed anymore?
On Tue, Jun 19, 2018 at 8:44 PM, Peter Hutterer
wrote:
> The ssize_t cast upsets coverity for some reason but we can be a lot more
> restrictive here anyway. Quick analysis of the zalloc calls in the test
> suite
>
The ssize_t cast upsets coverity for some reason but we can be a lot more
restrictive here anyway. Quick analysis of the zalloc calls in the test suite
show the largest allocation is 9204 bytes.
Let's put a cap on for one MB, anything above that is likely some memory
corruption and should be
Hi Pekka,
On Tue, Jun 19, 2018 at 5:12 AM Pekka Paalanen wrote:
> I think the aim should be to remove the abort(). I do not see any
> reason to leave it in even as an option.
>
Thank you. Will proceeed in that direction.
> The soft-buffer in libwayland-client is quite small, the kernel
Hi Pekka,
On 18 June 2018 at 14:42, Pekka Paalanen wrote:
> +- Stable ABI or API is not broken.
> +
I think I've just caught one of those ;-)
Thanks for the vast, yet concise writeup. Fwiw
Reviewed-by: Emil Velikov
-Emil
___
wayland-devel mailing
On 18 June 2018 at 15:40, Pekka Paalanen wrote:
> From: Daniel Stone
>
> Rename the IVI tests to be more consistent with the others, and invert
> the naming of plugin/client to make it slightly more clear what's going
> to happen. Handle the renaming by using wet_get_binary_path to rewrite
> the
Hi Pekka,
On 18 June 2018 at 15:40, Pekka Paalanen wrote:
> From: Daniel Stone
>
> Rather than having a hardcoded dependency on the build-directory layout,
> use an explicit module-map environment variable, which rewrites requests
> for modules and helper/libexec binaries to specific paths.
>
>
On 18 June 2018 at 15:40, Pekka Paalanen wrote:
> From: Pekka Paalanen
>
> Now that WESTON_MODULE_MAP supersedes WESTON_BUILD_DIR for libexec
> binaries, we don't need to check in WESTON_BUILD_DIR anymore.
>
> There was only one user of weston_config_get_libexec_dir(), so remove
> the whole
On 18 June 2018 at 14:42, Pekka Paalanen wrote:
> From: Pekka Paalanen
>
> This has been copied from
> https://cgit.freedesktop.org/xorg/app/intel-gpu-tools/tree/CONTRIBUTING?id=eccae1360d6d01e73c6af2bd97122cef708207ef
> and slightly edited to better with Wayland and Weston.
>
> The intention is
On 18 June 2018 at 11:36, Pekka Paalanen wrote:
> On Thu, 14 Jun 2018 16:49:37 +0100
> Emil Velikov wrote:
>
>> Hi all,
>>
>> Here's a take v2 of the series, with the following changes:
>> - don't trim trailing NULL entries from the wl_interfaces* array
>> - updated tests - separate patches to
On Tue, 19 Jun 2018 at 16:21:14 +0200, Michel Dänzer wrote:
> On 2018-06-19 02:22 PM, Simon McVittie wrote:
> > This indirect launching also avoids doing a fork-and-exec in the
> > compositor or session manager, which can be problematic under low-memory
> > conditions: the kernel needs to allocate
On Tue, 19 Jun 2018 11:45:24 +0100
Daniel Stone wrote:
> Hi Pekka,
>
> On Mon, 18 Jun 2018 at 14:43, Pekka Paalanen wrote:
> > This sets up the standards for patch review, and defines when a patch
> > can be merged. I believe these are the practises we have been using
> > already for a long
Hi Pekka,
All your patches are reviewed by me:
Reviewed-by: Emre Ucan
Don't relying on build directory has the major advantage that it is lot easier
to run weston unit-tests in target environment if weston is cross compiled.
Best regards
Emre Ucan
Engineering Software Base (ADITG/ESB)
Tel.
Hello All,
I have read queries for dual display on freedesktop.org
I need your help in the same context.
Currently we are creating one application to support multiple displays with
Wayland.
We are unaware that one compositor will be sufficient for dual display.
We need to know about how
Hi,
While I was testing this patch I ended up with:
interface: 'wl_output', version: 3, name: 14
x: 2732, y: 0, scale: 1,
This happened when I used force-on on second "HDMI-A-2" display.
When I used force-on on HDMI-A-1 everything worked as expected. anx x=y=0
On 2018-06-19 02:22 PM, Simon McVittie wrote:
>
> This indirect launching also avoids doing a fork-and-exec in the
> compositor or session manager, which can be problematic under low-memory
> conditions: the kernel needs to allocate enough virtual memory space for
> a second copy of the parent
On 2018/6月/19 01:39, Simon McVittie wrote:
> On Tue, 19 Jun 2018 at 13:56:22 +0200, Markus Ongyerth wrote:
> > P.S. I just thought about this ab it more, and something else came to my
> > mind:
> > How is env passed with dbus activation? afaik the session bus does not run
> > in
> > under the
On 2018/6月/19 01:22, Simon McVittie wrote:
> On Tue, 19 Jun 2018 at 11:18:17 +0200, Markus Ongyerth wrote:
> > On 2018/6月/18 05:05, Roman Gilg wrote:
> > > * using D-Bus interface only to secure against sandboxed clients
> > What? Why exactly? When I first read this, I expected that the client is
On Mon, 18 Jun 2018 19:54:23 -0700
Lloyd Pique wrote:
> Let me take things back a step. I was a bit too hasty in suggesting
> something that would work for me for the fact that MAX_FDS_OUT is small. In
> our client the buffer creation ends up being serialized, and so only one
> thread will be
On Tue, 19 Jun 2018 at 13:56:22 +0200, Markus Ongyerth wrote:
> P.S. I just thought about this ab it more, and something else came to my mind:
> How is env passed with dbus activation? afaik the session bus does not run in
> under the compositor, so if we aren't on wayland-0 (which can happen
On Tue, 19 Jun 2018 at 11:18:17 +0200, Markus Ongyerth wrote:
> On 2018/6月/18 05:05, Roman Gilg wrote:
> > * using D-Bus interface only to secure against sandboxed clients
> What? Why exactly? When I first read this, I expected that the client is
> supposed to use the portal stuff to call out of
On Mon, 18 Jun 2018 18:41:28 -0700
Lloyd Pique wrote:
> Hi Pekka!
>
> Thank you for the feedback. In the end, I think we have a good basic
> agreement about the patch, and after reading your linked bug (
> https://gitlab.freedesktop.org/wayland/wayland/issues/12), which I was
> previously
On 2018/6月/19 11:18, Markus Ongyerth wrote:
> Hey Roman,
>
> first a general remark:
> I don't see any mention of which state is supposed to be restored. The
> workspace (virtual desktops), geometry (session-restore), just client-side
> window (the embedded usecase)?
> Is this left
Hi Pekka,
On Mon, 18 Jun 2018 at 15:41, Pekka Paalanen wrote:
> these changes are intended to make using Meson easier. Daniel's patches
> are v2, mine are v1.
>
> Daniel Stone (2):
> tests: Don't rely on build directory layout
> tests: Reshuffle IVI layout tests
>
> Pekka Paalanen (2):
>
Hi Pekka,
On Mon, 18 Jun 2018 at 14:43, Pekka Paalanen wrote:
> This sets up the standards for patch review, and defines when a patch
> can be merged. I believe these are the practises we have been using
> already for a long time, now they are just written down explicitly.
>
> It's not an
Hey Roman,
first a general remark:
I don't see any mention of which state is supposed to be restored. The
workspace (virtual desktops), geometry (session-restore), just client-side
window (the embedded usecase)?
Is this left implementation-defined intentionally? If so, I think it would be
nice
29 matches
Mail list logo
