Re: [PATCH weston v2] ivi-shell: use install paths in example config

2018-06-27 Thread Emil Velikov
On 27 June 2018 at 12:12, Emil Velikov wrote: > On 27 June 2018 at 12:01, Michael Tretter wrote: >> Hi, >> >> On Fri, 25 May 2018 08:46:16 +0200, Michael Tretter wrote: >>> On Thu, 24 May 2018 17:08:47 +0200, Emre Ucan wrote: >>> > The example weston.ini file uses source and build >>> >

[PATCH weston] build: don't manually parse the weston.ini.in templates

2018-06-27 Thread Emil Velikov
From: Emil Velikov Adding those to configure.ac ensures that: - the weston.ini files are {re,}generated only when needed - the .in files are shipped in the tarball - all the manual handling of the above can be removed ;-) Note: the abs_top_builddir for weston-flower was swapped with the

Re: [PATCH wayland 0/2] Document review and commit access requirements

2018-06-27 Thread Pekka Paalanen
On Mon, 25 Jun 2018 16:53:12 -0500 Derek Foreman wrote: > On 2018-06-18 08:42 AM, Pekka Paalanen wrote: > > From: Pekka Paalanen > > > > Hi, > > > > for years we have relied on unwritten traditions on how to review > > patches. Gaining commit access has been a secret rite no-one really knew >

Re: [PATCH wayland-protocols v7] unstable: add xdg-decoration protocol

2018-06-27 Thread Simon Ser
Hi Jonas, What do you think of this new version? Wording suggestions and other comments welcome :) Thanks, Simon On June 18, 2018 11:16 AM, Simon Ser wrote: > This adds a new protocol to negotiate server-side rendering of window > decorations for xdg-toplevels. This allows compositors that

Re: [PATCH wayland] contributing: review rules for bugs

2018-06-27 Thread Emil Velikov
Hi Pekka, A couple small ideas come to mind: On 27 June 2018 at 14:47, Pekka Paalanen wrote: > From: Pekka Paalanen > > Half of the ideas came from Daniel but most of them are reworded, the > rest are my thoughts. > > Mention compiler warnings specifically, and be more explicit on what > kind

Re: [PATCH wayland] contributing: review rules for bugs

2018-06-27 Thread Pekka Paalanen
On Wed, 27 Jun 2018 16:47:09 +0300 Pekka Paalanen wrote: > From: Pekka Paalanen > > Half of the ideas came from Daniel but most of them are reworded, the > rest are my thoughts. > > Mention compiler warnings specifically, and be more explicit on what > kind of code or bugs or bug fixes are

[PATCH v8 3/6] launcher-logind: only get a VT on seat0, as only seat0 supports VTs

2018-06-27 Thread nerdopolis
As only seat0 supports TTYs, this changes the logind launcher where it detects a TTY, only if the seat is seat0. This has only been tested for logind --- libweston/launcher-logind.c | 23 +-- libweston/launcher-util.c | 4 2 files changed, 17 insertions(+), 10

[PATCH v8 5/6] compositor-fbdev: detect the first fb device in the seat

2018-06-27 Thread nerdopolis
This adds a function to detect the first framebuffer device in the current seat. Instead of hardcoding /dev/fb0, detect the device with udev, favoring the boot_vga device, and falling back to the first framebuffer device in the seat if there is none. This is very similar to what compositor-drm

[PATCH v8 1/6] libweston: set the seat automatically based on the XDG_SEAT environment variable

2018-06-27 Thread nerdopolis
This will allow the seat to be set by the environment as pam_systemd typically sets the XDG_SEAT variable --- compositor/main.c | 2 +- libweston/compositor-drm.c | 11 --- libweston/compositor-drm.h | 3 ++- man/weston-drm.man | 7 +-- 4 files changed, 16

[PATCH v7 0/6] Make Weston multiseat aware

2018-06-27 Thread nerdopolis
These patches make Weston handle multiple seats. Fixes from the last attempt include updating fbdev_set_screen_info , updating some fuzz, and making the selection of the framebuffer device similar to compositor-drm.c by favoring the boot_vga device, and making requested changes. These now

[PATCH v8 4/6] compositor-fbdev: set fb device info upon the first run.

2018-06-27 Thread nerdopolis
This attempts to wake up secondary framebuffer devices (/dev/fb1 and up) as usually these devices start powered off, and the FBIOPUT_VSCREENINFO ioctl turns it on. This was tested on a qemu system with the options: -vga none -device VGA,id=video0 -device secondary-vga,id=video1 \ -device

[PATCH v8 2/6] compositor-fbdev: support the --seat option, (and XDG_SEAT variable)

2018-06-27 Thread nerdopolis
This allows the fbdev backend to run on, and use devices from the specified seat, similar to the drm backend. --- compositor/main.c| 2 ++ libweston/compositor-fbdev.c | 10 +- libweston/compositor-fbdev.h | 9 + 3 files changed, 20 insertions(+), 1 deletion(-) diff

[PATCH v8 6/6] main: don't configure /dev/fb0 by default

2018-06-27 Thread nerdopolis
The framebuffer backend now detects the framebuffer device dynamically. Don't assume that the framebuffer device is /dev/fb0 --- compositor/main.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/compositor/main.c b/compositor/main.c index 068cdd8f..f1ee02b4 100644 --- a/compositor/main.c

[PATCH wayland] contributing: review rules for bugs

2018-06-27 Thread Pekka Paalanen
From: Pekka Paalanen Half of the ideas came from Daniel but most of them are reworded, the rest are my thoughts. Mention compiler warnings specifically, and be more explicit on what kind of code or bugs or bug fixes are acceptable or not. Clarify commit scope. Cc: Daniel Stone Signed-off-by:

[PATCH libinput 3/5] tools: rely on the libinput and quirks tool to pick the right directories

2018-06-27 Thread Peter Hutterer
Don't use a custom hack here, just make sure the tool ends up in the builddir so it's picked up by the libinput main tool. This means the PATH isn't set up correctly when called directly (./builddir/libinput-measure-touchpad-pressure) but the workaround is to always use the libinput tool - just

[PATCH libinput 5/5] tools: don't add the debug behavior for release builds

2018-06-27 Thread Peter Hutterer
When the meson build type is something other than the debug types, we don't need the special behavior where we adjust executable paths and data dir lookup for tools run directly from the builddir. This avoids leaking the build dir into the final executables. Signed-off-by: Peter Hutterer ---

[PATCH libinput 2/5] tools: quirks: if we're executing from the builddir, use the git datadir

2018-06-27 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- tools/libinput-quirks.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/tools/libinput-quirks.c b/tools/libinput-quirks.c index 88c860e4..862bb0ae 100644 --- a/tools/libinput-quirks.c +++ b/tools/libinput-quirks.c @@ -162,8

[PATCH libinput 4/5] tools: fake-build the other tools the same way as measure touchpad-tap

2018-06-27 Thread Peter Hutterer
Doesn't actually do anything but this way they end up in the builddir and can be picked up by ./builddir/libinput measure fuzz, etc. And rename the source files to .py to signal that they are not supposed to be directly executed. Signed-off-by: Peter Hutterer --- meson.build

[PATCH libinput 1/5] tools: if the execdir is the builddir, add it to the path

2018-06-27 Thread Peter Hutterer
When running libinput tools from the builddir, look up the subtools in the builddir as well. Otherwise, add the install prefix to the list of lookup locations. This ensures that a) we're running builddir stuff against builddir stuff, but also b) that we're not running builddir stuff against

[PATCH libinput] tools: rename list-quirks to the more generic "quirks list"

2018-06-27 Thread Peter Hutterer
Enables us to easily add more tools where needed and it is more consistent with the existing tools. The commands are now: libinput quirks list libinput quirks validate Fixes https://gitlab.freedesktop.org/libinput/libinput/issues/66 Signed-off-by: Peter Hutterer ---

Re: [PATCH weston] parse_modeline: Ignore case of {h,v}sync flags

2018-06-27 Thread Emil Velikov
On 26 June 2018 at 19:40, Guido Günther wrote: > Some modeline generators put out e.g. +HSync instead of +hsync. Accept > that too since it's not ambigous. > Hmm which generator is that? The cvt one, given as an example seems to produce lowercase ones. Personally I'm inclined to suggest fixing

Re: [PATCH v7 3/6] launcher-logind: only get a VT on seat0, as only seat0 supports VTs

2018-06-27 Thread Emil Velikov
On 27 June 2018 at 00:39, nerdopolis wrote: > As only seat0 supports TTYs, this changes the logind launcher where > it detects a TTY, only if the seat is seat0. This has only been > tested for logind > --- > libweston/launcher-logind.c | 22 -- > libweston/launcher-util.c |

Re: [PATCH v7 0/6] Make Weston multiseat aware

2018-06-27 Thread Emil Velikov
On 27 June 2018 at 00:39, nerdopolis wrote: > These patches make Weston handle multiple seats. Fixes from the last > attempt include updating fbdev_set_screen_info , updating some fuzz, > and making the selection of the framebuffer device similar to > compositor-drm.c by favoring the boot_vga

Re: [PATCH v7 5/6] compositor-fbdev: detect the first fb device in the seat

2018-06-27 Thread Emil Velikov
On 27 June 2018 at 00:39, nerdopolis wrote: > This adds a function to detect the first framebuffer device in the > current seat. Instead of hardcoding /dev/fb0, detect the device > with udev, favoring the boot_vga device, and falling back to the > first framebuffer device in the seat if there is

Re: [PATCH weston v2] ivi-shell: use install paths in example config

2018-06-27 Thread Michael Tretter
Hi, On Fri, 25 May 2018 08:46:16 +0200, Michael Tretter wrote: > On Thu, 24 May 2018 17:08:47 +0200, Emre Ucan wrote: > > The example weston.ini file uses source and build > > directory paths. Therefore, it is only useful when > > used on the same system that is used to build Weston. > > > > We

Re: [PATCH weston 1/2] desktop-shell: fix output removal for background/panel

2018-06-27 Thread Pekka Paalanen
On Tue, 26 Jun 2018 09:28:42 + Marius-cristian Vlad wrote: > On Thu, 2018-06-21 at 15:53 +0300, Pekka Paalanen wrote: > > From: Pekka Paalanen > > > > When the compositor has multiple outputs (not clones) and one of them > > is > > removed, the ones remaining to the right will be moved to

Re: [PATCH weston v2] ivi-shell: use install paths in example config

2018-06-27 Thread Emil Velikov
On 27 June 2018 at 12:01, Michael Tretter wrote: > Hi, > > On Fri, 25 May 2018 08:46:16 +0200, Michael Tretter wrote: >> On Thu, 24 May 2018 17:08:47 +0200, Emre Ucan wrote: >> > The example weston.ini file uses source and build >> > directory paths. Therefore, it is only useful when >> > used on

Re: [PATCH weston] parse_modeline: Ignore case of {h,v}sync flags

2018-06-27 Thread Guido Günther
Hi, On Wed, Jun 27, 2018 at 11:30:40AM +0100, Emil Velikov wrote: > On 26 June 2018 at 19:40, Guido Günther wrote: > > Some modeline generators put out e.g. +HSync instead of +hsync. Accept > > that too since it's not ambigous. > > > Hmm which generator is that? The cvt one, given as an example

Re: [PATCH weston] parse_modeline: Ignore case of {h,v}sync flags

2018-06-27 Thread Emil Velikov
On 27 June 2018 at 12:42, Guido Günther wrote: > Hi, > On Wed, Jun 27, 2018 at 11:30:40AM +0100, Emil Velikov wrote: >> On 26 June 2018 at 19:40, Guido Günther wrote: >> > Some modeline generators put out e.g. +HSync instead of +hsync. Accept >> > that too since it's not ambigous. >> > >> Hmm