Re: Wayland generic dmabuf protocol

2014-06-11 Thread Thomas Hellstrom
On 06/09/2014 01:23 PM, Daniel Stone wrote: Hi, On 9 June 2014 12:06, Pekka Paalanen pekka.paala...@collabora.co.uk mailto:pekka.paala...@collabora.co.uk wrote: On Mon, 9 Jun 2014 11:00:04 +0200 Benjamin Gaignard benjamin.gaign...@linaro.org mailto:benjamin.gaign...@linaro.org

Re: Suggestions on implementing Wayland Protocol Dumper.

2014-06-11 Thread Pekka Paalanen
On Mon, 09 Jun 2014 16:54:09 +0800 Boyan Ding stu_...@126.com wrote: Hi, According to [1], from which the idea of protocol dumper came, the purpose of the protocol dumper is to track exactly how a client communicate with the server, and to make a difference with how WAYLAND_DEBUG=server

Re: [PATCH libinput 2/6] test: add litest_assert_empty_queue helper function

2014-06-11 Thread Hans de Goede
Hi, On 06/11/2014 02:11 AM, Peter Hutterer wrote: Checks if the queue is empty and prints informatino about any events before failing. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Looks good: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- test/litest.c |

Re: [PATCH libinput 1/6] touchpad: always call into the the tap state machine

2014-06-11 Thread Hans de Goede
Hi, On 06/11/2014 02:11 AM, Peter Hutterer wrote: A button event consumed by the softbutton or clickpad code does not feed into the tap state machine, leaving it in its current state. The touch generating that event however may have triggered state changes. For some tap/click combinations

Re: [PATCH libinput 3/6] test: add a bunch of test for click behavior on touchpads

2014-06-11 Thread Hans de Goede
Hi, On 06/11/2014 02:11 AM, Peter Hutterer wrote: Mainly testing the behaviour when clicking during a tap or tap-n-drag. Adds a new feature to the litest system, Apple clickpads don't have software buttons by default. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net I've some remarks

Re: [PATCH libinput 5/6] test: Add description for the T440 synaptics touchpad

2014-06-11 Thread Hans de Goede
Hi, On 06/11/2014 02:11 AM, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/Makefile.am | 1 + test/litest-synaptics-t440.c | 112 +++ test/litest.c| 2 + test/litest.h

Re: [PATCH libinput 6/6] test: add a couple of top software button test

2014-06-11 Thread Hans de Goede
Hi, On 06/11/2014 02:11 AM, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/touchpad.c | 124 1 file changed, 124 insertions(+) Looks good: Reviewed-by: Hans de Goede hdego...@redhat.com

Re: Wayland generic dmabuf protocol

2014-06-11 Thread Rob Clark
On Mon, Jun 9, 2014 at 8:44 AM, Pekka Paalanen pekka.paala...@collabora.co.uk wrote: On Mon, 9 Jun 2014 12:23:18 +0100 Daniel Stone dan...@fooishbar.org wrote: Hi, On 9 June 2014 12:06, Pekka Paalanen pekka.paala...@collabora.co.uk wrote: On Mon, 9 Jun 2014 11:00:04 +0200 Benjamin

Re: [PATCH libinput 3/6] test: add a bunch of test for click behavior on touchpads

2014-06-11 Thread Peter Hutterer
On Wed, Jun 11, 2014 at 10:48:07AM +0200, Hans de Goede wrote: Hi, On 06/11/2014 02:11 AM, Peter Hutterer wrote: Mainly testing the behaviour when clicking during a tap or tap-n-drag. Adds a new feature to the litest system, Apple clickpads don't have software buttons by default.

[PATCH 2/2] clients: Maximize window when double touch on title bar

2014-06-11 Thread Xiong Zhang
Signed-off-by: Xiong Zhang xiong.y.zh...@intel.com --- clients/window.c| 26 -- shared/cairo-util.h | 7 +++ shared/frame.c | 49 + 3 files changed, 80 insertions(+), 2 deletions(-) diff --git