[PATCH wayland v2 4/4] tests: add code, public-code and private-code tests

2018-02-22 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> First one is deprecated in favour of the second option. The latter is newly introduced and annotates the generated symbols accordingly. v2: Don't introduce small-public-code.c - reuse small-code.c (Pekka) Cc: Pekka Paalanen <ppaala...@

Re: [PATCH wayland 4/4] tests: add code, public-code and private-code tests

2018-02-22 Thread Emil Velikov
Hi Pekka, Thanks for having a look! On 22 February 2018 at 10:26, Pekka Paalanen wrote: >> +# The existing "code" must produce result identical to "public-code" >> +generate_and_compare "code" "small.xml" "small-public-code.c" >> +generate_and_compare "public-code"

Re: [RFC wayland] wayland-server: Finally remove deprecated struct wl_buffer definition

2018-02-16 Thread Emil Velikov
On 16 February 2018 at 20:22, Derek Foreman <der...@osg.samsung.com> wrote: > On 2018-02-16 12:58 PM, Emil Velikov wrote: >> >> On 16 February 2018 at 18:24, Derek Foreman <der...@osg.samsung.com> >> wrote: >>> >>> On 2018-02-16 11:18 AM, Emi

Re: [RFC wayland] wayland-server: Finally remove deprecated struct wl_buffer definition

2018-02-16 Thread Emil Velikov
On 16 February 2018 at 18:24, Derek Foreman <der...@osg.samsung.com> wrote: > On 2018-02-16 11:18 AM, Emil Velikov wrote: >> >> On 16 February 2018 at 16:54, Derek Foreman <der...@osg.samsung.com> >> wrote: >>> >>> commit d94a8722cb29d8b897672b

Re: [RFC wayland] wayland-server: Finally remove deprecated struct wl_buffer definition

2018-02-16 Thread Emil Velikov
On 16 February 2018 at 16:54, Derek Foreman wrote: > commit d94a8722cb29d8b897672be66ff3c9ff79eab6fe > warned this was coming, back in 2013. > > I've seen libraries that have wayland client and server using functions > in the same file. Since struct wl_buffer still exists

Re: [PATCH wayland 2/6] wayland-egl: make wayland-egl-backend.h C++ safe

2018-02-16 Thread Emil Velikov
On 16 February 2018 at 14:22, Arnaud Vrac <raw...@gmail.com> wrote: > On Fri, Feb 16, 2018 at 2:53 PM, Emil Velikov <emil.l.veli...@gmail.com> > wrote: >> On 16 February 2018 at 10:49, Daniel Stone <dan...@fooishbar.org> wrote: >>> Hi Emil, >>>

[PATCH wayland 4/4] tests: add code, public-code and private-code tests

2018-02-16 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> First one is deprecated in favour of the second option. The latter is newly introduced and annotates the generated symbols accordingly. Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- Makefile.am |

[PATCH wayland 2/4] build: use public-code when using the local wayland-scanner

2018-02-16 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> The core wayland interfaces are public, via the libwayland-server and libwayland-client DSOs. Hence use "public-code" cmdline option, instead of the deprecated code". As the host wayland-scanner may not know about the new o

[PATCH wayland 1/4] scanner: introduce "public-code" and "private-code"

2018-02-16 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> The options are used to indicate how the code will be used - will it be public, as part of a DSO or private. In nearly every instance, people want to use the latter. One noticeable exception is the wayland libraries. They provide th

[PATCH wayland 3/4] scanner: make use of __has_attribute()

2018-02-16 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> A more generic way to evaluating various attributes, __has_attribute is available with gcc, clang, even the Oracle/Sun compiler. Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- src/scanner.c | 6 +- 1 file changed,

Re: [PATCH wayland v2 4/4] build: remove white space in -uninstalled.pc.in files

2018-02-16 Thread Emil Velikov
On 21 February 2017 at 16:14, Emil Velikov <emil.l.veli...@gmail.com> wrote: > From: Emil Velikov <emil.veli...@collabora.com> > > v2: Rebase, address wayland-client-uninstalled > > Signed-off-by: Emil Velikov <emil.veli...@collabora.com> > Reviewed-by: Derek

Re: [PATCH wayland 2/6] wayland-egl: make wayland-egl-backend.h C++ safe

2018-02-16 Thread Emil Velikov
On 16 February 2018 at 10:49, Daniel Stone <dan...@fooishbar.org> wrote: > Hi Emil, > > On 16 February 2018 at 10:40, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> On 15 February 2018 at 23:12, Derek Foreman <der...@osg.samsung.com> wrote: >>> Mayb

Re: [PATCH wayland 2/6] wayland-egl: make wayland-egl-backend.h C++ safe

2018-02-16 Thread Emil Velikov
On 15 February 2018 at 23:12, Derek Foreman <der...@osg.samsung.com> wrote: > On 2018-02-15 12:50 PM, Emil Velikov wrote: >> >> From: Emil Velikov <emil.veli...@collabora.com> >> >> private is a reserved keyworkd in C++. Thus to make things work, we >&

[PATCH wayland 6/6] wayland-egl: bump the version number to 18.1.0

2018-02-15 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Seems like I was overoptimistic with my earlier assumption, namely: "... 17.3.x should be the last version that ships the library." Mesa 18.0.0 and its wayland-egl is about to be released any time soon, so bump the numb

[PATCH wayland 4/6] wayland-egl: fail the symbol check if lib is missing

2018-02-15 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Based on a similar patch (in Mesa) by Eric Engestrom. Cc: Eric Engestrom <eric.engest...@imgtec.com> Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- egl/wayland-egl-symbols-check | 10 +- 1 file changed,

[PATCH wayland 2/6] wayland-egl: make wayland-egl-backend.h C++ safe

2018-02-15 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> private is a reserved keyworkd in C++. Thus to make things work, we should use something else - wl_egl_window::driver_private. Make sure to do so only for C++ contexts, or otherwise it will break the API - leading to build failures whe

[PATCH wayland 5/6] wayland-egl: enhance the symbol test

2018-02-15 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> The current test had a few fall-outs: - it was checking only for T (.text) symbols - did not consider symbol removal Fix that by fetching all the symbols and doing a bidirectional check - for added and removed symbols. Error out with infor

[PATCH wayland 3/6] Revert "wayland-egl-symbols-check: pass the DSO name via the build system"

2018-02-15 Thread Emil Velikov
This reverts commit 85cb5ed64aa8246f4da93fc5b76dfc34096bf803. It seems like we've misread the existing code - the DSO name can be propagated via the build-system. The one available in the script was a simple fall-back. Cc: Daniel Stone --- Makefile.am |

[PATCH wayland 1/6] Revert "wayland-egl: rename wl_egl_window::private to driver_private"

2018-02-15 Thread Emil Velikov
This reverts commit 9fa60983b5799be62b9d88a4059f4d0038d7c80d. The commit preserves the ABI, although breaks the API. This is fine for most cases - building up-to date components, or shipping binary-only drivers. Yet it breaks when using old, released, Mesa alongside new wayland-egl. A simpler

Re: [PATCH weston 1/4] ivi-shell: change layer visibility to bool

2018-02-15 Thread Emil Velikov
On 13 February 2018 at 17:46, Daniel Stone <dan...@fooishbar.org> wrote: > Hi Emil, > > On 13 February 2018 at 16:37, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> The following two questions come to mind: >> - app bugs - using threads? ivi-shell-use

Re: [PATCH weston 1/4] ivi-shell: change layer visibility to bool

2018-02-13 Thread Emil Velikov
On 13 February 2018 at 15:11, Daniel Stone wrote: > Hi, > > On 13 February 2018 at 15:00, Pekka Paalanen wrote: >> On Thu, 8 Feb 2018 13:53:54 + >> "Ucan, Emre (ADITG/ESB)" wrote: >>> Yes I saw a similar problem when I tested

Re: [PATCH 3/5] scanner: introduce --object-type option

2018-01-26 Thread Emil Velikov
On 26 January 2018 at 02:44, Jonas Ådahl <jad...@gmail.com> wrote: > On Thu, Jan 25, 2018 at 05:56:45PM +0000, Emil Velikov wrote: >> On 25 January 2018 at 02:01, Jonas Ådahl <jad...@gmail.com> wrote: >> > On Wed, Jan 24, 2018 at 07:15:09PM +, Emil Velikov wrote:

Re: [PATCH 3/5] scanner: introduce --object-type option

2018-01-25 Thread Emil Velikov
On 25 January 2018 at 02:01, Jonas Ådahl <jad...@gmail.com> wrote: > On Wed, Jan 24, 2018 at 07:15:09PM +0000, Emil Velikov wrote: >> On 24 January 2018 at 18:20, Derek Foreman <der...@osg.samsung.com> wrote: >> > On 2018-01-22 09:30 AM, Emil Velikov wrote: >>

Re: [PATCH 3/5] scanner: introduce --object-type option

2018-01-24 Thread Emil Velikov
On 24 January 2018 at 18:20, Derek Foreman <der...@osg.samsung.com> wrote: > On 2018-01-22 09:30 AM, Emil Velikov wrote: >> >> On 22 August 2017 at 14:02, Emil Velikov <emil.l.veli...@gmail.com> wrote: >>> >>> On 18 August 2017 at 13:0

Re: [PATCH wayland 2/3] scanner: Allow adding a prefix to exported symbols

2018-01-22 Thread Emil Velikov
On 22 January 2018 at 15:09, Pekka Paalanen <ppaala...@gmail.com> wrote: > On Mon, 22 Jan 2018 14:46:15 +0000 > Emil Velikov <emil.l.veli...@gmail.com> wrote: > >> On 19 January 2018 at 15:49, Derek Foreman <der...@osg.samsung.com> wrote: >> >

Re: [PATCH 3/5] scanner: introduce --object-type option

2018-01-22 Thread Emil Velikov
On 22 August 2017 at 14:02, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 18 August 2017 at 13:05, Pekka Paalanen <ppaala...@gmail.com> wrote: > >>> > >>> > The exported configuration would then be: >>> > LOCAL_IN

Re: [PATCH wayland 2/3] scanner: Allow adding a prefix to exported symbols

2018-01-22 Thread Emil Velikov
gt; Derek Foreman <der...@osg.samsung.com> wrote: >>> >>>> On 2017-08-18 07:41 AM, Pekka Paalanen wrote: >>>>> >>>>> On Fri, 28 Jul 2017 14:06:23 +0100 >>>>> Emil Velikov <emil.l.veli...@gmail.com> wrote: >>>>> >&g

Re: Planning for another Wayland release

2018-01-17 Thread Emil Velikov
On 16 January 2018 at 22:10, Daniel Stone wrote: > Hey Bryce, > > On 12 January 2018 at 22:51, Derek Foreman wrote: >> On 2018-01-12 04:00 AM, Daniel Stone wrote: >>> I did a clearout of the review queue last month, but that's not yet >>> complete,

Re: [PATCH] linux-dmabuf: send deprecated format events

2018-01-17 Thread Emil Velikov
st contains ARGB, XRGB, and if the > GL_EXT_texture_rg extension is supported, YUYV, NV12, YUV420, and > YUV444. > > Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> > > diff --git a/libweston/gl-renderer.c b/libweston/gl-renderer.c > index abf556f0..ee31

Re: Planning for another Wayland release

2018-01-15 Thread Emil Velikov
Hi gents, On 12 January 2018 at 22:51, Derek Foreman wrote: > Hi Daniel, > > > On 2018-01-12 04:00 AM, Daniel Stone wrote: >> >> Hi Bryce, >> >> On 12 January 2018 at 00:31, Bryce Harrington >> wrote: >>> >>> Is there interest in another release at

Re: wlroots whitepaper available

2017-12-28 Thread Emil Velikov
On 28 December 2017 at 20:50, Drew DeVault <s...@cmpwn.com> wrote: > On 2017-12-28 8:38 PM, Emil Velikov wrote: >> On 28 December 2017 at 18:05, Drew DeVault <s...@cmpwn.com> wrote: >> Surely you are familiar that weston provides libweston with somewhat >

Re: wlroots whitepaper available

2017-12-28 Thread Emil Velikov
On 28 December 2017 at 18:05, Drew DeVault wrote: > I represent the Sway wayland compositor. As some of you might know, > we've been working for some months on a new library for Wayland > compositor development. Today, Sway is based on the wlc libray, which > provides an

Re: [PATCH wayland v2 0/8] Import wayland-egl frontend library

2017-12-13 Thread Emil Velikov
On 12 December 2017 at 20:48, Arnaud Vrac <raw...@gmail.com> wrote: > Hi Emil, > > On Tue, Oct 10, 2017 at 3:43 PM, Emil Velikov <emil.l.veli...@gmail.com> > wrote: >> Hi all, >> >> Here is a retake of the RFC as originally seen here [1]. >> >>

Re: [PATCH v2] configure.ac: use AC_HEADER_MAJOR to detect major()/minor()

2017-12-13 Thread Emil Velikov
On 13 December 2017 at 07:58, Pekka Paalanen <ppaala...@gmail.com> wrote: > On Tue, 12 Dec 2017 15:41:52 +0000 > Emil Velikov <emil.l.veli...@gmail.com> wrote: > >> On 12 December 2017 at 08:28, Pekka Paalanen <ppaala...@gmail.com> wrote: >> > On Mon, 11 D

Re: [PATCH wayland v2 0/8] Import wayland-egl frontend library

2017-12-12 Thread Emil Velikov
Hi Daniel, On 13 November 2017 at 14:06, Daniel Stone <dan...@fooishbar.org> wrote: > Hi Emil, > > On 8 November 2017 at 14:06, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> On 10 October 2017 at 14:43, Emil Velikov <emil.l.veli...@gmail.com> wrote: >>

Re: [PATCH v2 libinput] FreeBSD portability fixes

2017-12-12 Thread Emil Velikov
On 11 December 2017 at 04:21, Peter Hutterer wrote: >> - ptrace(PTRACE_CONT, NULL, NULL); >> + ptrace(PTRACE_CONT, ppid, NULL, 0); > > split this one out please, I'd rather not have it hidden in a bsd-suppport > patch, thanks. >

Re: [PATCH v2] configure.ac: use AC_HEADER_MAJOR to detect major()/minor()

2017-12-12 Thread Emil Velikov
On 12 December 2017 at 08:28, Pekka Paalanen wrote: > On Mon, 11 Dec 2017 16:16:47 +0200 > Pekka Paalanen wrote: > >> On Wed, 31 May 2017 22:17:50 +0100 >> Sergei Trofimovich wrote: >> >> > This change slightly updates

Re: Building Wayland/weston with a LFS/BLFS minimum packagelist?

2017-12-07 Thread Emil Velikov
On 7 December 2017 at 03:20, scsijon wrote: > Sorry, but i've read a lot of pages on your site and the git repositories > and can't find an answer or hint of one anywhere. > > Does someone have a minimum packageset/packagelist needed, anywhere in their > files to build

Re: [PATCH wayland-protocols 3/3] Remove autotools build system

2017-12-05 Thread Emil Velikov
On 11 October 2017 at 10:22, Jonas Ådahl wrote: >> >> Besides, wayland-protocol doesn't compile/link anything at all, I'm not >> sure what meson buys us here (other than being trendy). > > It does now, as part of the test suite. FWIW, I first opened Makefile.am > and started

[PATCH weston] libweston: drop return type from ::query_dmabuf_{formats, modifiers}

2017-12-05 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Nobody checks for the bool returned by these functions. At the same time: a) the functions set the respective num_foo to zero on error and b) callers honour that variable. Just drop the return type - it's useless. Note: this is an ABI

Re: [PATCH wayland] scanner: Add autoconf macro to check for the proper scanner

2017-12-05 Thread Emil Velikov
On 4 December 2017 at 21:47, Daniel Stone wrote: > Jussi, Tomek, Emil, > > On 18 August 2017 at 10:36, Quentin Glidic > wrote: >> On 8/18/17 11:30 AM, Quentin Glidic wrote: >>> Projects have been using various ways to check for the

Re: [PATCH weston 5/5] gl-renderer: use correct pixel shader for NV12 format uploaded to RG texture

2017-12-04 Thread Emil Velikov
On 29 November 2017 at 14:25, Arnaud Vrac wrote: > Signed-off-by: Arnaud Vrac Please mention how you've spotted and/or verified this. I'm ~90% this is correct, although I would check with the author. Vincent, can you double check the patch/series [1]?

Re: [PATCH weston 3/5] gl-renderer: always enable unpack subimage and RG textures in ES3 contexts

2017-12-04 Thread Emil Velikov
tension string to determine if those features are supported. > Reviewed-by: Emil Velikov <emil.veli...@collabora.com> Out of curiosity: did you notice a ES 3.x driver that doesn't expose these in the extensions string? -Emil ___ wayl

Re: [PATCH weston 4/5] gl-renderer: fix pixel format used in texture uploads when using R/RG textures

2017-12-04 Thread Emil Velikov
^ > GL_RG [1]. > > Make sure we match this requirement, as some drivers will fail with the > current code. > AFAICT the patch is spot on. Trivial suggestion below: Reviewed-by: Emil Velikov <emil.veli...@collabora.com> I'd suggest using something like the following. A reference

Re: [PATCH weston 01/12] shared: Add timespec_is_zero helper

2017-11-27 Thread Emil Velikov
On 27 November 2017 at 08:58, Alexandros Frantzis <alexandros.frant...@collabora.com> wrote: > On Mon, Nov 27, 2017 at 10:20:35AM +0200, Pekka Paalanen wrote: >> On Fri, 24 Nov 2017 18:36:43 + >> Emil Velikov <emil.l.veli...@gmail.com> wrote: >> >> &g

Re: [PATCH weston 01/12] shared: Add timespec_is_zero helper

2017-11-24 Thread Emil Velikov
Hi Alexandros, On 16 November 2017 at 16:20, Alexandros Frantzis wrote: > +ZUC_TEST(timespec_test, timespec_is_zero) > +{ > + struct timespec zero = { 0 }; > + struct timespec non_zero_sec = { 1, 0 }; > + struct timespec non_zero_nsec = { 0,

Re: [RFC PATCH xserver] xwayland: Fix non-argb cursor conversion

2017-11-16 Thread Emil Velikov
attern seems like a common mistake, where one would align after the division instead of the other way around. As width is != 32 the code will provide larger than needed stride, which seems to be exactly what the commit summary says. One might mention exactly what's happening the commit message, since i

Re: [PATCH wayland-protocols] Add the wl_drm protocol

2017-11-15 Thread Emil Velikov
Hi all, On 2 November 2017 at 17:09, Emil Velikov <emil.l.veli...@gmail.com> wrote: > From: Emil Velikov <emil.veli...@collabora.com> > > Import latest version (v2) of the protocol from Mesa. > > From the README: > > Warning! > The goal is to share the pro

Re: [PATCH wayland-protocols] Add the wl_drm protocol

2017-11-14 Thread Emil Velikov
On 14 November 2017 at 08:18, Pekka Paalanen <ppaala...@gmail.com> wrote: > On Mon, 13 Nov 2017 16:27:24 +0000 > Emil Velikov <emil.l.veli...@gmail.com> wrote: > >> On 13 November 2017 at 14:52, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> > On 13

Re: [PATCH wayland-protocols] Add the wl_drm protocol

2017-11-13 Thread Emil Velikov
On 13 November 2017 at 14:52, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 13 November 2017 at 14:21, Daniel Stone <dan...@fooishbar.org> wrote: >> Hi Emil, >> >> On 2 November 2017 at 17:09, Emil Velikov <emil.l.veli...@gmail.com> wrote: >>>

Re: [PATCH wayland-protocols] Add the wl_drm protocol

2017-11-13 Thread Emil Velikov
On 13 November 2017 at 14:21, Daniel Stone <dan...@fooishbar.org> wrote: > Hi Emil, > > On 2 November 2017 at 17:09, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> Import latest version (v2) of the protocol from Mesa. >> >> From the README: >> >

Re: [PATCH wayland v2 0/8] Import wayland-egl frontend library

2017-11-08 Thread Emil Velikov
On 10 October 2017 at 14:43, Emil Velikov <emil.l.veli...@gmail.com> wrote: > Hi all, > > Here is a retake of the RFC as originally seen here [1]. > > In summary - we want the user facing library to live in Wayland with > vendors providing a backend/plugin. Otherwise

[PATCH wayland-protocols] Add the wl_drm protocol

2017-11-02 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Import latest version (v2) of the protocol from Mesa. From the README: Warning! The goal is to share the protocol file across Mesa and other low-level components graphics stack such as libva and Xwayland. File is moved to wayland-pro

Re: [PATCH weston] launcher: don't exit when user is not root

2017-10-31 Thread Emil Velikov
On 31 October 2017 at 16:42, Michal Suchanek wrote: >>> Ever heard of rootless X? >> >> Yes. I believe it uses logind now. > > The documentation says otherwise. > See xserver commit e7b84ca46944895971a8f048c7e34869b7de01c0 and the other work by Hans in the area. I'm

Re: [PATCH wayland] cursor: add forward declaration for struct wl_buffer

2017-10-20 Thread Emil Velikov
On 12 October 2017 at 18:19, Yong Bakos <j...@humanoriented.com> wrote: > Hi Emil, > >> On Oct 12, 2017, at 5:39 AM, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> >> From: Emil Velikov <emil.veli...@collabora.com> >> >> This makes the

Re: [PATCH wayland v2 0/8] Import wayland-egl frontend library

2017-10-13 Thread Emil Velikov
On 10 October 2017 at 14:43, Emil Velikov <emil.l.veli...@gmail.com> wrote: > Hi all, > > Here is a retake of the RFC as originally seen here [1]. > > In summary - we want the user facing library to live in Wayland with > vendors providing a backend/plugin. Otherwise

[PATCH wayland] cursor: add forward declaration for struct wl_buffer

2017-10-12 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> This makes the header self-contained, since the struct is considered opaque from waylad-cursor POV. As we're here move the wl_shm fwd. declaration alongside the others. Making it easier to read and track. Signed-off-by: Emil Velikov <

Re: [PATCH wayland v2 6/8] build: wire-up wayland-egl

2017-10-10 Thread Emil Velikov
On 10 October 2017 at 15:19, Quentin Glidic <sardemff7+wayl...@sardemff7.net> wrote: > On 10/10/17 3:43 PM, Emil Velikov wrote: >> >> From: Emil Velikov <emil.veli...@collabora.com> >> >> Wire-up the imported sources, test and pkg-config files. >

[PATCH wayland v2 7/8] wayland-egl-symbols-check: pass the DSO name via the build system

2017-10-10 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> The location of the file is build system specific so, keep it there. Cc: Daniel Stone <dani...@collabora.com> Suggested-by: Daniel Stone <dani...@collabora.com> Signed-off-by: Emil Velikov <emil.veli...@collabora.

[PATCH wayland v2 8/8] wayland-egl: move the wayland-egl{, -core}.h headers to egl/

2017-10-10 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Now we have all the wayland-egl bits in a single place. Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- Makefile.am | 5 +++-- {src => egl}/wayland-egl-core.h | 0 {src => egl}/wayland-egl.h

[PATCH wayland v2 6/8] build: wire-up wayland-egl

2017-10-10 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Wire-up the imported sources, test and pkg-config files. v2: - Don't mangle with existing EXTRA_DIST list - Add the symbols check script to the `make check' target - Rename wayland-egl-{priv,backend}.h Signed-off-by: Emil Velikov <

[PATCH wayland v2 5/8] wayland-egl: add a note about keeping the backend version in sync

2017-10-10 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- egl/wayland-egl-backend.h | 4 1 file changed, 4 insertions(+) diff --git a/egl/wayland-egl-backend.h b/egl/wayland-egl-backend.h index 82f025c..3c23a56 100644 --- a/egl

[PATCH wayland v2 3/8] wayland-egl: correct wayland-egl.pc description/version

2017-10-10 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Drop the "Mesa" part from the commit message and change the version to 17.4.0. The number bears references from its Mesa heritage. Currently Mesa provides 17.2.x while 17.3.x should be the last version that ships the library. Some

[PATCH wayland v2 4/8] wayland-egl: introduce wayland-egl-backend.pc

2017-10-10 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> File will be installed alongside the backend header. This way vendor implementations have enough information about the interface and they can build their backend/driver library accordingly. Cc: Miguel A. Vico <mvicom...@nvidia.com> Cc:

[PATCH wayland v2 2/8] wayland-egl: reuse the existing WL_EXPORT macro

2017-10-10 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> There's little point if redefining new one ourselves. Just reuse the one that's already available. Cc: Daniel Stone <dani...@collabora.com> Suggested-by: Daniel Stone <dani...@collabora.com> Signed-off-by: Emil Velikov <emil.

[PATCH wayland v2 0/8] Import wayland-egl frontend library

2017-10-10 Thread Emil Velikov
://lists.freedesktop.org/archives/wayland-devel/2017-September/035019.html Emil Velikov (8): wayland-egl: import libwayland-egl.so frontend library from Mesa wayland-egl: reuse the existing WL_EXPORT macro wayland-egl: correct wayland-egl.pc description/version wayland-egl: introduce wayland-egl-backend.pc

[PATCH wayland v2 1/8] wayland-egl: import libwayland-egl.so frontend library from Mesa

2017-10-10 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Currently the client-facing libwayland-egl API is defined by a header file shipped by Wayland, but the implementation is left to each vendor. This can cause collisions when multiple implementations are installed on the same system. Imp

Re: [RFC wayland 2/9] wayland-egl: correct wayland-egl.pc description/version

2017-10-05 Thread Emil Velikov
On 29 September 2017 at 14:00, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 15 September 2017 at 11:29, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> From: Emil Velikov <emil.veli...@collabora.com> >> >> Drop the "Mesa" part from th

Re: [PATCH weston v12 03/40] [TEST] compositor-drm: Allow disabling universal planes

2017-09-29 Thread Emil Velikov
On 26 September 2017 at 18:15, Daniel Stone wrote: > Add a test environment variable to allow disabling universal planes. > > Signed-off-by: Daniel Stone > --- > libweston/compositor-drm.c | 6 -- > 1 file changed, 4 insertions(+), 2

Re: [RFC wayland 2/9] wayland-egl: correct wayland-egl.pc description/version

2017-09-29 Thread Emil Velikov
On 15 September 2017 at 11:29, Emil Velikov <emil.l.veli...@gmail.com> wrote: > From: Emil Velikov <emil.veli...@collabora.com> > > Drop the "Mesa" part from the commit message and change the version to > XXX. The number is based on the following users (and supp

Re: [PATCH weston v2 4/4] gl-renderer: Emit GPU rendering begin and end timeline timepoints

2017-09-27 Thread Emil Velikov
On 27 September 2017 at 13:26, Alexandros Frantzis wrote: > On Mon, Sep 25, 2017 at 05:40:36PM +0300, Pekka Paalanen wrote: >> On Tue, 19 Sep 2017 14:59:11 +0300 >> Alexandros Frantzis wrote: >> >> > Use EGL fence sync objects

Re: [RFC wayland 1/9] wayland-egl: import libwayland-egl.so frontend library from Mesa

2017-09-19 Thread Emil Velikov
On 19 September 2017 at 06:24, Duncan Roe <duncan_...@optusnet.com.au> wrote: > Hi Emil, > > On Mon, Sep 18, 2017 at 02:18:42PM +0100, Emil Velikov wrote: >> Hi Duncan, >> >> On 17 September 2017 at 09:04, Duncan Roe <duncan_...@optusnet.com.au> wrote: >&g

Re: [RFC wayland 1/9] wayland-egl: import libwayland-egl.so frontend library from Mesa

2017-09-19 Thread Emil Velikov
On 19 September 2017 at 05:34, Duncan Roe <duncan_...@optusnet.com.au> wrote: > Hi Emil, > > On Mon, Sep 18, 2017 at 02:18:42PM +0100, Emil Velikov wrote: >> Hi Duncan, >> >> On 17 September 2017 at 09:04, Duncan Roe <duncan_...@optusnet.com.au> wrote: >&g

Re: [RFC wayland 3/9] wayland-egl: introduce wayland-egl-backend.pc

2017-09-18 Thread Emil Velikov
On 17 September 2017 at 13:28, Duncan Roe <duncan_...@optusnet.com.au> wrote: > On Fri, Sep 15, 2017 at 11:29:21AM +0100, Emil Velikov wrote: >> From: Emil Velikov <emil.veli...@collabora.com> >> >> File will be installed alongside the backend header. >>

Re: [RFC wayland 1/9] wayland-egl: import libwayland-egl.so frontend library from Mesa

2017-09-18 Thread Emil Velikov
Hi Duncan, On 17 September 2017 at 09:04, Duncan Roe <duncan_...@optusnet.com.au> wrote: > On Fri, Sep 15, 2017 at 11:29:19AM +0100, Emil Velikov wrote: >> From: Emil Velikov <emil.veli...@collabora.com> > ... >> >> Takanari, Duncan, >> AFAICT the Renesa

Re: [RFC wayland 1/9] wayland-egl: import libwayland-egl.so frontend library from Mesa

2017-09-18 Thread Emil Velikov
On 15 September 2017 at 16:21, Daniel Stone <dan...@fooishbar.org> wrote: > Hi Emil, > > On 15 September 2017 at 15:54, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> On 15 September 2017 at 14:50, Daniel Stone <dan...@fooishbar.org> wrote: >>> Curr

Re: [RFC wayland 1/9] wayland-egl: import libwayland-egl.so frontend library from Mesa

2017-09-15 Thread Emil Velikov
Hi Dan, Thanks for the quick review/feedback. On 15 September 2017 at 14:50, Daniel Stone <dan...@fooishbar.org> wrote: > Hi Emil, > > On 15 September 2017 at 11:29, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> Currently we're in a bit of a pickle - bo

Re: [PATCH] Add m1bpp (monochrome, 1 bit/pixel) pixel format

2017-09-15 Thread Emil Velikov
Hi Drew, Can you add some commit message where this format is doing to be used, how? I'm not sure what Wayland devs' stance is on s-o-b line is, but I'd imagine they won't object to it. On 14 September 2017 at 21:08, Drew DeVault wrote: > --- > This patch is pretty

[RFC wayland 5/9] build: wire-up wayland-egl

2017-09-15 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Wire-up the imported sources, test and pkg-config files. Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- Makefile.am | 18 +- configure.ac | 2 ++ 2 files changed, 19 insertions(+), 1 deletion(-)

[RFC wayland 7/9] wayland-egl: forward declare struct wl_surface

2017-09-15 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> It makes the header self-contained and with next commit we'll remove the unnessesary wayland-client.h include. Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- egl/wayland-egl-priv.h | 2 ++ 1 file changed, 2 insertions(+)

[RFC wayland 9/9] wayland-egl: remove no longer needed wayland-client.h include

2017-09-15 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Was used for wl_surface, which is opaque and forward declared with earlier patch. Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- egl/wayland-egl-priv.h | 1 - egl/wayland-egl.c | 1 - 2 files changed, 2 deletions(-)

[RFC wayland 8/9] wayland-egl: add stdint.h include for intptr_t

2017-09-15 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- egl/wayland-egl-priv.h | 1 + 1 file changed, 1 insertion(+) diff --git a/egl/wayland-egl-priv.h b/egl/wayland-egl-priv.h index ada5226..9e56fbe 100644 --- a/egl/wayland-egl-

[RFC wayland 6/9] wayland-egl: move the wayland-egl{, -core}.h headers to egl/

2017-09-15 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Now we have all the wayland-egl stuff in one place. Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- Makefile.am | 5 +++-- {src => egl}/wayland-egl-core.h | 0 {src => egl}/wayland-egl.h |

[RFC wayland 1/9] wayland-egl: import libwayland-egl.so frontend library from Mesa

2017-09-15 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Currently we're in a bit of a pickle - both from vendor and user POV. - User: The wayland repository defines the wayland-egl interface. At the same time, it leaves the actual implementation (DSO) and ways to manage both files (wayland-

[RFC wayland 4/9] wayland-egl: add a note about keeping the backend version in sync

2017-09-15 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- egl/wayland-egl-priv.h | 4 1 file changed, 4 insertions(+) diff --git a/egl/wayland-egl-priv.h b/egl/wayland-egl-priv.h index 3b59908..2b4ed36 100644 --- a/egl/waylan

[RFC wayland 2/9] wayland-egl: correct wayland-egl.pc description/version

2017-09-15 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Drop the "Mesa" part from the commit message and change the version to XXX. The number is based on the following users (and suppliers). Note: the "users" list was pulled from Ubuntu 17.04. Providers: - Mali: 7

[RFC wayland 3/9] wayland-egl: introduce wayland-egl-backend.pc

2017-09-15 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> File will be installed alongside the backend header. This way Vendor implementations have enough information about the interface and they can build their backend/driver library accordingly. Cc: Miguel A. Vico <mvicom...@nvidia.com> Cc:

[RFC wayland 0/9] Introduce/import wayland-egl frontend library

2017-09-15 Thread Emil Velikov
"new" that hasn't been in use for a while. Please review, Thanks Emil Emil Velikov (9): wayland-egl: import libwayland-egl.so frontend library from Mesa wayland-egl: correct wayland-egl.pc description/version wayland-egl: introduce wayland-egl-backend.pc wayland-egl: add a

[PATCH wayland] build: remove wayland-version.h.in from EXTRA_DIST

2017-09-14 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> All the foo.in files are in the tarball, as long as their foo counterparts are listed in AC_CONFIG_FILES For example - *.pc.in, Makefile.in files, etc. Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- Makefile.am | 3

Re: [PATCH weston 2/3] gl-renderer: Add support for fence sync extensions

2017-09-14 Thread Emil Velikov
Hi Alexandros, On 14 September 2017 at 12:07, Alexandros Frantzis wrote: > Check for the EGL_KHR_fence_sync and EGL_ANDROID_native_fence_sync > extensions and get pointers to required extension functions. > --- > libweston/gl-renderer.c | 16 >

Re: [PATCH weston] clients/nested: fix boolean test

2017-09-11 Thread Emil Velikov
al ;-) >> Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> > > Fixes: ce5b614c80b4dfe8e899 "clients/nested: use weston_check_egl_extension > over strstr" > Cc: Emil Velikov <emil.veli...@collabora.com> Review

[PATCH wayland] wayland-server: document WL_HIDE_DEPRECATED

2017-09-08 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Add some inline information, what the macro is used for, why it came to be and what we shouldn't do if we consider further deprecation in the future deprecation. Cc: Pekka Paalanen <pekka.paala...@collabora.co.uk> Signed-off-by:

Re: [PATCH 0/6] libweston: Support multiple seats better

2017-09-07 Thread Emil Velikov
Hi nerdopolis, I'm mostly an outsider here, so just sharing some observations. On 6 September 2017 at 13:17, nerdopolis wrote: > I am resending as I messed up one of the commit messages, which resulted > in a very long subject by mistake. These patches fix issues

[PATCH wayland 4/4] scanner: initialize .{method, event}_count via ARRAY_SIZE

2017-08-30 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- Since everything is interface->name based, one could even have a macro that results in: DEFINE_INTERFACE(zxdg_surface_v6, 1) --- src/scanner.c | 9 + 1 file change

[PATCH wayland 2/4] scanner: use c99 initializers for the request/events arrays

2017-08-30 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- src/scanner.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/scanner.c b/src/scanner.c index c93ee60..b77641f 100644 --- a/src/scanner.c +++ b/s

[PATCH wayland 3/4] scanner: use c99 initializers for the interface symbols

2017-08-30 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- src/scanner.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/scanner.c b/src/scanner.c index b77641f..b38af52 100644 --- a/src/scanner

[PATCH wayland 1/4] scanner: use c99 initializers for the wl_interface * array

2017-08-30 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Allows us to remove the explicit NULL init, keeping the list shorter and easier to read. Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- src/scanner.c | 26 +- 1 file changed, 9 insertions(+),

Re: [PATCH 4/5] build: set the scanner --object-type option

2017-08-22 Thread Emil Velikov
On 18 August 2017 at 13:14, Pekka Paalanen <ppaala...@gmail.com> wrote: > On Fri, 28 Jul 2017 13:23:46 +0100 > Emil Velikov <emil.l.veli...@gmail.com> wrote: > >> On 27 July 2017 at 14:36, Pekka Paalanen <ppaala...@gmail.com> wrote: >> > On Wed, 26

Re: [PATCH 3/5] scanner: introduce --object-type option

2017-08-22 Thread Emil Velikov
On 18 August 2017 at 13:05, Pekka Paalanen wrote: >> > >> > The exported configuration would then be: >> > LOCAL_INTERFACE_DECL=extern >> > EXTERN_INTERFACE_DECL=extern >> > LOCAL_INTERFACE_DEF=WL_EXPORT >> > >> > That would be far too flexible and no-one would use it right,

[PATCH weston] gl-renderer: remove unneeded cast

2017-07-31 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> The variable num is of EGLint type. Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- Unrelated: The functions gl_renderer_query_dmabuf_* return bool as per the interface. At the same time: - the caller do

<    1   2   3   4   >