Re: [PATCH libinput 0/9] Improvements for clickpad touchpads

Hi Peter, So as you requested I've been looking at your wip/clickpad-improvements branch. I've been mostly reading the code / patches and here is a long list of comments : 1) I like the state-machine concept, and having a diagram. I think this is a good way to deal with this, otherwise we will

Re: [PATCH v2 libinput 1/5] test: add litest helper functions for creating uinput devices

, -1); libevdev_uinput_write_event(uinput, EV_REL, REL_X, -1); libevdev_uinput_write_event(uinput, EV_SYN, SYN_REPORT, 0); ... libevdev_uinput_destroy(uinput); Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Looks good: Reviewed-by: Hans de Goede hdego

Re: [PATCH libinput 2/5] test: if no teardown func is set, use the default

. Only if no init at all is done then for non globals you may get garbage. Other then that, this patch looks good: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans diff --git a/test/litest-generic-highres-touch.c b/test/litest-generic-highres-touch.c index bb226d6..4d21b0d

Re: [PATCH libinput 3/5] test: allow for description-based test devices

struct input_absinfo *abs, + const int *events); + Hmm, shouldn't this be either static, or in a header file ? Other then that, this patch looks good: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans struct litest_device

Re: [PATCH libinput 5/5] test: switch the remaining devices to a description-based device

(+), 432 deletions(-) Looks good: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans p.s. I'm wondering if we should remove support for direct device instantiation, now all devices use the descriptor based approach ? diff --git a/test/litest-bcm5974.c b/test/litest-bcm5974.c index

Self introduction Hans de Goede

Hi All, I guess most of you already know me, but since I'm about to become a whole lot more active on this list, I thought it would be a good idea to start with a self-intro: My name is Hans de Goede, and I'm active as a FOSS contributor / developer since 1997. Recently I've mainly been

[PATCH libinput 02/20] touchpad: after a click, lock the finger to its current position

). HdG: Instead of pinning the lowest touch assuming that that is the one holding the physical button, simply pin all touches, and unpin as soon as a touch is moved more then the threshold. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Hans de Goede hdego...@redhat.com

[PATCH libinput 10/20] touchpad: Add tp_button_touch_active function

-machines poke the is_pointer variabel directly. Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad-buttons.c | 5 + src/evdev-mt-touchpad.h | 3 +++ 2 files changed, 8 insertions(+) diff --git a/src/evdev-mt-touchpad

[PATCH libinput 20/20] Change internal timestamps to uint64_t to properly deal with wrapping

uses 32 bit timestamps (and clients will have to deal with wrapping). Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad-buttons.c | 22 ++--- src/evdev-mt-touchpad-tap.c | 42

[PATCH libinput 08/20] touchpad: Only enable clickfingers on Apple touchpads

behaviour in libinput. For all other touchpads, use the software button areas introduced in a follow-up commit. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Hans de Goede hdego...@redhat.com --- src/evdev-mt-touchpad-buttons.c | 7 ++- src/evdev-mt-touchpad.h | 1

[PATCH libinput 14/20] touchpad: Ignore non left clicks on clickpads

We should never get any non left button events on clickpads, but if we do these might confuse our state, so complain about it and ignore these. Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad-buttons.c | 7 +++ 1

[PATCH libinput 16/20] touchpad: softbuttons: Deal with a click arriving before any touches

touches, wait for the first touch to resolve the click. Also see the new activity diagram for the tp_post_softbutton_buttons method which has been added to doc/touchpad-softbutton-state-machine.svg Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Peter Hutterer peter.hutte...@who-t.net

[PATCH libinput 15/20] touchpad: post_button_events: Remove TOUCHPAD_EVENT_BUTTON_PRESS/RELEASE test

We already check for old != current everywhere, so this is not needed; And in tp_post_softbutton_buttons we want to do delay button down reporting if we don't have touch info yet in which case this check actually gets in the way. Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Peter

[PATCH libinput 18/20] touchpad: Remove clickpad clicked test from 2 finger scrolling handling

This is no longer needed now that we take the button area and pinned fingers into account. Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad.c | 5 - 1 file changed, 5 deletions(-) diff --git a/src/evdev-mt

[PATCH libinput 03/20] touchpad: reset the tap timer_fd to -1 on destroy

From: Peter Hutterer peter.hutte...@who-t.net No real effect, just for safety Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Hans de Goede hdego...@redhat.com --- src/evdev-mt-touchpad-tap.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/evdev

[PATCH libinput 04/20] touchpad: don't allow tapping while any button is down

From: Peter Hutterer peter.hutte...@who-t.net Immediately set the state to DEAD, waiting for the tap release to go back to idle. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Hans de Goede hdego...@redhat.com --- src/evdev-mt-touchpad-tap.c | 2 +- 1 file changed, 1

[PATCH libinput 11/20] touchpad: Rework is_pointer handling

de Goede hdego...@redhat.com Acked-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad.c | 47 +++ 1 file changed, 23 insertions(+), 24 deletions(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index 9df4a78..b671211

[PATCH libinput 07/20] touchpad: save the active clickfinger button

From: Peter Hutterer peter.hutte...@who-t.net To avoid having a button left press and a button right release if the number of fingers changes. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Hans de Goede hdego...@redhat.com --- src/evdev-mt-touchpad-buttons.c | 22

[PATCH libinput 13/20] touchpad: Use INPUT_PROP_BUTTONPAD instead of checking for buttons

And warn if INPUT_PROP_BUTTONPAD mismatches right/middle buttons presence. Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad-buttons.c | 34 ++ src/evdev-mt-touchpad.c | 4

[PATCH libinput 05/20] touchpad: move button-related code into a separate file

de Goede hdego...@redhat.com --- src/Makefile.am | 1 + src/evdev-mt-touchpad-buttons.c | 146 src/evdev-mt-touchpad.c | 102 ++-- src/evdev-mt-touchpad.h | 11 +++ 4 files changed, 162 insertions

[PATCH libinput 06/20] doc: add state machine SVG to EXTRA_DIST

From: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Hans de Goede hdego...@redhat.com --- doc/Makefile.am | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/Makefile.am b/doc/Makefile.am index 31b673b

[PATCH libinput 17/20] touchpad: Ignore fingers in button area for 2 finger scroll

Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index 910bd2a..7333ec9 100644

[PATCH libinput 19/20] touchpad: handle_timeouts: Remove unused return value

Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad-buttons.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/evdev-mt-touchpad-buttons.c b/src/evdev-mt-touchpad-buttons.c index 3b8b07b..c40b05c

[PATCH libinput 00/20] clickpad-improvements v2

Hi All, Here is my improved version of Peter's clickpad-improvements patch-set. Changes in v2: * after a click, lock the finger to its current position Pin all fingers until they move more then the threshold in * touchpad: add clickpad-style software buttons Simplify the state machine used

[PATCH libinput 12/20] Add a log_bug macro

For logging when things happen which should not happen. We may want to do something more fancy in the future but for now this suffices. Modelled after log_bug in libevdev. Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Peter Hutterer peter.hutte...@who-t.net --- src/libinput

[PATCH libinput 01/20] touchpad: set ntouches for single-touch pads depending on key bits

-t.net Signed-off-by: Hans de Goede hdego...@redhat.com --- src/evdev-mt-touchpad.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index bbbd8f3..8021db2 100644 --- a/src/evdev-mt-touchpad.c +++ b/src/evdev

[PATCH libinput 09/20] touchpad: add clickpad-style software buttons

support for a top button area such as can be found one the Thinkpad [2-5]40 series. -Init area.top_edge to INT_MAX in the non soft button case to make the entire state machine a nop in that case Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Hans de Goede hdego...@redhat.com

Re: [PATCH libinput 08/20] touchpad: Only enable clickfingers on Apple touchpads

Hi, On 04/15/2014 03:44 PM, Daniel Stone wrote: Hi, On 15 April 2014 13:28, Hans de Goede hdego...@redhat.com wrote: Apple touchpads don't have visible markings for the software button areas that almost all other vendors use. OS X provides clickfinger behaviour instead, where a click

Re: [PATCH libinput 13/20] touchpad: Use INPUT_PROP_BUTTONPAD instead of checking for buttons

Hi, On 04/24/2014 07:34 AM, Peter Hutterer wrote: On Tue, Apr 15, 2014 at 02:28:10PM +0200, Hans de Goede wrote: And warn if INPUT_PROP_BUTTONPAD mismatches right/middle buttons presence. Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Peter Hutterer peter.hutte...@who-t.net

Re: [PATCH libinput] Name-space the scroll event types

-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/libinput.h | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/libinput.h b/src/libinput.h index d771e21..df9a382 100644 --- a/src/libinput.h +++ b/src/libinput.h @@ -147,8 +147,14 @@ enum

Re: [PATCH libinput 10/20] touchpad: Add tp_button_touch_active function

Hi, On 04/24/2014 07:21 AM, Peter Hutterer wrote: On Tue, Apr 15, 2014 at 02:28:07PM +0200, Hans de Goede wrote: We don't want touches in the button area to cause the pointer to move, add a tp_button_touch_active function which the main code in evdev-mt-touchpad can call to see if a touch

[PATCH libinput v3 11/17] touchpad: Ignore non left clicks on clickpads

We should never get any non left button events on clickpads, but if we do these might confuse our state, so complain about it and ignore these. Signed-off-by: Hans de Goede hdego...@redhat.com Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad-buttons.c | 7 +++ 1

[PATCH libinput v3 16/17] touchpad: handle_timeouts: Remove unused return value

Signed-off-by: Hans de Goede hdego...@redhat.com Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad-buttons.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/evdev-mt-touchpad-buttons.c b/src/evdev-mt-touchpad-buttons.c index c35d14a

[PATCH libinput v3 07/17] touchpad: Only enable clickfingers on Apple touchpads

behaviour in libinput. For all other touchpads, use the software button areas introduced in a follow-up commit. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Hans de Goede hdego...@redhat.com Reviewed-by: Jonas Ådahl jad...@gmail.com Reviewed-by: Hans de Goede hdego

[PATCH libinput v3 10/17] touchpad: Use INPUT_PROP_BUTTONPAD instead of checking for buttons

And warn if INPUT_PROP_BUTTONPAD mismatches right/middle buttons presence. Also fix the bcm5974 to properly advertise INPUT_PROP_BUTTONPAD. Signed-off-by: Hans de Goede hdego...@redhat.com Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad-buttons.c | 34

[PATCH libinput v3 00/17] clickpad-improvements v3

Hans de Goede Tue, 15 Apr 2014 05:29:33 -0700 Hi All, Here is the 3th version of the clickpad-improvements patch-set Peter and I have been working on. Changes in v2: -after a click, lock the finger to its current position Pin all fingers until they move more then the threshold in -touchpad

[PATCH libinput v3 04/17] touchpad: move button-related code into a separate file

de Goede hdego...@redhat.com Reviewed-by: Hans de Goede hdego...@redhat.com --- src/Makefile.am | 1 + src/evdev-mt-touchpad-buttons.c | 145 src/evdev-mt-touchpad.c | 102 ++-- src/evdev-mt-touchpad.h

[PATCH libinput v3 03/17] touchpad: reset the tap timer_fd to -1 on destroy

From: Peter Hutterer peter.hutte...@who-t.net No real effect, just for safety Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Hans de Goede hdego...@redhat.com Reviewed-by: Jonas Ådahl jad...@gmail.com Reviewed-by: Hans de Goede hdego...@redhat.com --- src/evdev-mt

[PATCH libinput v3 02/17] touchpad: after a click, lock the finger to its current position

). HdG: Instead of pinning the lowest touch assuming that that is the one holding the physical button, simply pin all touches, and unpin as soon as a touch is moved more then the threshold. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Hans de Goede hdego...@redhat.com

[PATCH libinput v3 17/17] Change internal timestamps to uint64_t to properly deal with wrapping

uses 32 bit timestamps (and clients will have to deal with wrapping). Signed-off-by: Hans de Goede hdego...@redhat.com Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad-buttons.c | 22 ++--- src/evdev-mt-touchpad-tap.c | 42

[PATCH libinput v3 06/17] touchpad: save the active clickfinger button

From: Peter Hutterer peter.hutte...@who-t.net To avoid having a button left press and a button right release if the number of fingers changes. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Hans de Goede hdego...@redhat.com Reviewed-by: Jonas Ådahl jad...@gmail.com

[PATCH libinput v3 01/17] touchpad: set ntouches for single-touch pads depending on key bits

-t.net Signed-off-by: Hans de Goede hdego...@redhat.com Reviewed-by: Jonas Ådahl jad...@gmail.com Reviewed-by: Hans de Goede hdego...@redhat.com --- src/evdev-mt-touchpad.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt

[PATCH libinput v3 14/17] touchpad: Ignore fingers in button area for 2 finger scroll

Signed-off-by: Hans de Goede hdego...@redhat.com Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index f5e0300..fc4a4f7 100644

[PATCH libinput v3 05/17] doc: add state machine SVG to EXTRA_DIST

From: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Hans de Goede hdego...@redhat.com Reviewed-by: Hans de Goede hdego...@redhat.com --- doc/Makefile.am | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/doc

[PATCH libinput v3 12/17] touchpad: post_button_events: Remove TOUCHPAD_EVENT_BUTTON_PRESS/RELEASE test

We already check for old != current everywhere, so this is not needed; And in tp_post_softbutton_buttons we want to do delay button down reporting if we don't have touch info yet in which case this check actually gets in the way. Signed-off-by: Hans de Goede hdego...@redhat.com Reviewed-by: Peter

[PATCH libinput v3 13/17] touchpad: softbuttons: Deal with a click arriving before any touches

touches, wait for the first touch to resolve the click. Also see the new activity diagram for the tp_post_softbutton_buttons method which has been added to doc/touchpad-softbutton-state-machine.svg Signed-off-by: Hans de Goede hdego...@redhat.com Reviewed-by: Peter Hutterer peter.hutte...@who-t.net

[PATCH libinput v3 08/17] touchpad: Add clickpad-style software buttons

support for a top button area such as can be found one the Thinkpad [2-5]40 series. -Init area.top_edge to INT_MAX in the non soft button case to make the entire state machine a nop in that case Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Hans de Goede hdego...@redhat.com

[PATCH libinput v3 15/17] touchpad: Remove clickpad clicked test from 2 finger scrolling handling

This is no longer needed now that we take the button area and pinned fingers into account. Signed-off-by: Hans de Goede hdego...@redhat.com Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad.c | 5 - 1 file changed, 5 deletions(-) diff --git a/src/evdev-mt

Re: [PATCH libinput v3 02/17] touchpad: after a click, lock the finger to its current position

Hi, On 05/22/2014 08:05 AM, Peter Hutterer wrote: On Tue, May 20, 2014 at 04:34:50PM +0200, Hans de Goede wrote: From: Peter Hutterer peter.hutte...@who-t.net On clickpads, clicking the pad usually causes some motion events. To avoid erroneous movements, lock the finger into position

Re: [PATCH libinput v3 09/17] touchpad: Rework is_pointer handling

On 05/22/2014 05:35 AM, Peter Hutterer wrote: On Tue, May 20, 2014 at 04:34:57PM +0200, Hans de Goede wrote: We don't want touches in the button area to cause the pointer to move. So instead of making a touch the pointer when it moves to TOUCH_BEGIN, wait with making it the pointer until its

Re: [PATCH libinput v3 11/17] touchpad: Ignore non left clicks on clickpads

Hi, On 05/22/2014 03:45 AM, Peter Hutterer wrote: On Tue, May 20, 2014 at 04:34:59PM +0200, Hans de Goede wrote: We should never get any non left button events on clickpads, but if we do these might confuse our state, so complain about it and ignore these. Signed-off-by: Hans de Goede hdego

[PULL] libinput clickpad improvements

) Hans de Goede (9): touchpad: Rework is_pointer handling touchpad: Use INPUT_PROP_BUTTONPAD instead of checking for buttons touchpad: Ignore non left clicks on clickpads touchpad: post_button_events: Remove TOUCHPAD_EVENT_BUTTON_PRESS/RELEASE test

Re: [PATCH libinput 2/4] test: restore log priority after each test

); Restoring the log priority twice here seems excessive :) With this fixed, the entire series is: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans } END_TEST START_TEST(log_userdata) { struct libinput *li; + enum libinput_log_priority pri

Add basic mouse pointer acceleration libinput patch breaks make check

Hi All, I've picked Jonas' 2 mouse accel patches into my local tree, and noticed $subject. This should be fixed before these patches get merged. Regards, Hans ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org

Re: Add basic mouse pointer acceleration libinput patch breaks make check

Hi, On 05/23/2014 02:57 PM, Jonas Ådahl wrote: On Fri, May 23, 2014 at 07:22:38AM -0500, Jason Ekstrand wrote: It might be better to reply to the patch. This e-mail is liable to be forgotten if the patches sit for very long. --Jason Ekstrand I did see it though and made a mental note

[PATCH libinput 4/6] touchpad: Stop scrolling on a button click / tap

On a button click / tap the scrolling event handler no longer gets called, ensure that any in progress scrolling is stopped. Signed-off-by: Hans de Goede hdego...@redhat.com --- src/evdev-mt-touchpad.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/evdev-mt

[PATCH libinput 3/6] touchpad: Refactor tp_post_scroll_events()

Put the actual scroll event posting in the straight path. Signed-off-by: Hans de Goede hdego...@redhat.com --- src/evdev-mt-touchpad.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index 2455c36..ed668ee 100644

[PATCH libinput 6/6] touchpad: Increase 2 finger scrolling threshold

. Signed-off-by: Hans de Goede hdego...@redhat.com --- src/evdev-mt-touchpad.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index e7943f6..4a1bf29 100644 --- a/src/evdev-mt-touchpad.c +++ b/src/evdev-mt-touchpad.c @@ -464,11

[PATCH libinput 2/6] touchpad: Fix sending of scroll stop events

function for this. Signed-off-by: Hans de Goede hdego...@redhat.com --- src/evdev-mt-touchpad.c | 39 +++ 1 file changed, 23 insertions(+), 16 deletions(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index 040939b..2455c36 100644 --- a/src/evdev

[PATCH libinput 5/6] touchpad: Don't allow diagonal scrolling

as that is what the user most likely wants. Signed-off-by: Hans de Goede hdego...@redhat.com --- src/evdev-mt-touchpad.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index f28cd13..e7943f6 100644 --- a/src/evdev-mt

[PATCH libinput 1/6] touchpad: Clear touches being the pointer when doing 2 finger scrolling

de Goede hdego...@redhat.com --- src/evdev-mt-touchpad.c | 4 test/touchpad.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index 89cebd5..040939b 100644 --- a/src/evdev-mt-touchpad.c +++ b/src/evdev-mt

Re: [PATCH libinput 5/6] touchpad: Don't allow diagonal scrolling

, May 23, 2014 at 10:06 AM, Hans de Goede hdego...@redhat.com wrote: We pin scrolling to the initial direction, so a 2 finger scroll starting in the vertical direction, will from then on only generate vertical scroll events, and the same for horizontal. But if the first 2 finger motion

Re: Add basic mouse pointer acceleration libinput patch breaks make check

Hi, On 05/23/2014 05:27 PM, Jonas Ådahl wrote: On Fri, May 23, 2014 at 04:03:56PM +0200, Hans de Goede wrote: Hi, On 05/23/2014 02:57 PM, Jonas Ådahl wrote: On Fri, May 23, 2014 at 07:22:38AM -0500, Jason Ekstrand wrote: It might be better to reply to the patch. This e-mail is liable

Re: [PATCH libinput 5/6] touchpad: Don't allow diagonal scrolling

Hi, On 05/25/2014 10:34 AM, Jonas Ådahl wrote: On Fri, May 23, 2014 at 04:06:26PM +0200, Hans de Goede wrote: We pin scrolling to the initial direction, so a 2 finger scroll starting in the vertical direction, will from then on only generate vertical scroll events, and the same for horizontal

Re: [PATCH libinput 2/6] touchpad: Fix sending of scroll stop events

Hi, On 05/25/2014 02:13 PM, Jonas Ådahl wrote: On Fri, May 23, 2014 at 04:06:23PM +0200, Hans de Goede wrote: Setting tp-scroll.direction = 0 before checking tp-scroll.direction to see if we need to send stop scroll events for vert / horz scrolling does not really work well. Also we need

[PATCH libinput 1/2] evdev-mt-touchpad-buttons: Rename some variables and functions

Rename some clickpad softbutton area variables to have bottom in their name, this is a preperation patch for adding top softbutton area support. Signed-off-by: Hans de Goede hdego...@redhat.com --- src/evdev-mt-touchpad-buttons.c | 26 +- src/evdev-mt-touchpad.h

Re: [PATCH libinput 1/7] filter: Add motion filter destruction helper

Hi, The entire series looks good, and isL Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans On 05/26/2014 11:27 PM, Jonas Ådahl wrote: Signed-off-by: Jonas Ådahl jad...@gmail.com --- src/evdev-mt-touchpad.c | 3 +-- src/filter.c| 9 + src/filter.h

Re: [PATCH libinput 02/10] Add an interface to enable/disable tapping

Hi, On 06/04/2014 10:21 AM, Jonas Ådahl wrote: On Wed, Jun 04, 2014 at 11:17:58AM +1000, Peter Hutterer wrote: On Tue, Jun 03, 2014 at 10:41:16PM +0200, Jonas Ådahl wrote: On Tue, Jun 03, 2014 at 03:34:55PM +1000, Peter Hutterer wrote: Provide an interface to enable/disable tapping, with a

Re: [PATCH libinput 02/10] Add an interface to enable/disable tapping

Hi, On 06/03/2014 07:34 AM, Peter Hutterer wrote: Provide an interface to enable/disable tapping, with a default mapping of 1/2/3 fingers mapping to L/R/M button events, respectively. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/libinput-private.h | 13 +

Re: [PATCH libinput 03/10] touchpad: hook up to the tapping configuration

Hi, On 06/03/2014 07:34 AM, Peter Hutterer wrote: Now that we have run-time changes of the tap.enabled state move the check to the IDLE state only. Otherwise the tap machine may hang if tapping is disabled while a gesture is in progress. Two basic tests are added to check for the tap

Re: [PATCH libinput 02/10] Add an interface to enable/disable tapping

Hi, On 06/03/2014 07:34 AM, Peter Hutterer wrote: Provide an interface to enable/disable tapping, with a default mapping of 1/2/3 fingers mapping to L/R/M button events, respectively. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net I see that in all the other config interfaces you

Re: [PATCH libinput 04/10] Add a config interface for scroll methods

Hi, On 06/03/2014 07:34 AM, Peter Hutterer wrote: --- src/libinput-private.h | 9 ++ src/libinput.c | 35 src/libinput.h | 74 ++ 3 files changed, 118 insertions(+) Looks good to me. Regards,

Re: [PATCH libinput 05/10] touchpad: hook up scroll config

Hi, On 06/03/2014 07:34 AM, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad.c | 43 +++ src/evdev-mt-touchpad.h | 1 + 2 files changed, 44 insertions(+) diff --git a/src/evdev-mt-touchpad.c

Re: [PATCH libinput 06/10] Add a config interface to change device rotation

Hi, On 06/03/2014 07:34 AM, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/libinput-private.h | 9 +++ src/libinput.c | 33 src/libinput.h | 69 ++ 3 files

Re: [PATCH libinput 07/10] Add a basic pointer acceleration API

Hi, On 06/03/2014 07:35 AM, Peter Hutterer wrote: Only exposes two knobs - speed and precision which have historically been the only two knobs exposed anyway on most UIs. We could go for something fancier but really, I think this will be enough. The only open question is whether speed will

Re: [PATCH libinput 09/10] Add config API for pointer modes

Hi, On 06/03/2014 07:35 AM, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/libinput-private.h | 9 ++ src/libinput.c | 37 src/libinput.h | 77 ++ 3 files

Re: [PATCH libinput 10/10] Add config api for middle button emulation

Hi, On 06/03/2014 07:35 AM, Peter Hutterer wrote: --- src/libinput-private.h | 8 src/libinput.c | 33 ++ src/libinput.h | 54 ++ 3 files changed, 95 insertions(+) diff --git

Re: [PATCH libinput] touchpad: Drop the scroll direction lock, increase threshold instead

ran out of time and the simplest approach didn't work that greatly. This patch replaces 5 and 6 of this series (the ones I never pushed) Thanks, looks good: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans src/evdev-mt-touchpad.c | 25 +++-- 1 file

Re: [PATCH libinput 08/10] Add a config API for disable-while-typing

Hi, On 06/03/2014 07:35 AM, Peter Hutterer wrote: --- src/libinput-private.h | 9 src/libinput.c | 33 + src/libinput.h | 56 ++ 3 files changed, 98 insertions(+) diff --git

[PATCH libinput 3/3] evdev-mt-touchpad-tap: Switch over to new timer subsystem

Signed-off-by: Hans de Goede hdego...@redhat.com --- src/evdev-mt-touchpad-tap.c | 76 ++--- src/evdev-mt-touchpad.c | 1 - src/evdev-mt-touchpad.h | 7 + 3 files changed, 10 insertions(+), 74 deletions(-) diff --git a/src/evdev-mt-touchpad

Re: [PATCH libinput 03/10] touchpad: hook up to the tapping configuration

Hi, On 06/04/2014 10:57 PM, Jonas Ådahl wrote: On Wed, Jun 04, 2014 at 11:10:35AM +0200, Hans de Goede wrote: Hi, On 06/03/2014 07:34 AM, Peter Hutterer wrote: Now that we have run-time changes of the tap.enabled state move the check to the IDLE state only. Otherwise the tap machine may

Re: [PATCH libinput 1/3] Add a timer subsystem

Hi, On 06/05/2014 12:18 AM, Jonas Ådahl wrote: On Wed, Jun 04, 2014 at 05:26:34PM +0200, Hans de Goede wrote: Currently we are using DIY timers in the touchpad softbutton and tap handling code, and at least the softbutton code gets its wrong. It uses one timer-fd per touchpad to set a timeout

Re: [PATCH libinput 1/3] Add a timer subsystem

Hi, On 06/05/2014 05:40 AM, Peter Hutterer wrote: On Wed, Jun 04, 2014 at 05:26:34PM +0200, Hans de Goede wrote: Currently we are using DIY timers in the touchpad softbutton and tap handling code, and at least the softbutton code gets its wrong. It uses one timer-fd per touchpad to set

[PATCH libinput 2/3] evdev-mt-touchpad-buttons: Switch over to new timer subsystem

Besides being a nice cleanup, this gives us proper per touch timeouts. Signed-off-by: Hans de Goede hdego...@redhat.com Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad-buttons.c | 95 + src/evdev-mt-touchpad.c | 3

[PATCH libinput 0/3] Add a timer subsystem series v2

Hi, Here is v2 of my timer subsystem series with all the review comments fixed. Regards, Hans ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

[PATCH libinput 1/3] Add a timer subsystem

a timeout for 200 ms from now, then the timeout for touch 1 will come 150 ms too late. This commits adds a proper timer subsystem so that we've one place to deal with timer handling, and so that we can only get it wrong (well hopefully we get it right) in one place. Signed-off-by: Hans de Goede

[PATCH libinput 3/3] evdev-mt-touchpad-tap: Switch over to new timer subsystem

Signed-off-by: Hans de Goede hdego...@redhat.com Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad-tap.c | 76 ++--- src/evdev-mt-touchpad.c | 1 - src/evdev-mt-touchpad.h | 7 + 3 files changed, 10 insertions

Re: [PATCH libinput 1/8] Drop empty FFI_CFLAGS

Hi, All patches in this series look good and are: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans On 06/06/2014 08:18 AM, Peter Hutterer wrote: Leftover from weston Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/Makefile.am | 1 - 1 file changed, 1

[PATCH libinput] Add a log_msg_va function

This is useful for when we use libraries which want us to provide them with a logging callback. Signed-off-by: Hans de Goede hdego...@redhat.com --- src/libinput-private.h | 3 +++ src/libinput.c | 16 +++- 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/src

[PATCH libinput 1/2] Add a log_msg_va function

This is useful for when we use libraries which want us to provide them with a logging callback. Signed-off-by: Hans de Goede hdego...@redhat.com --- src/libinput-private.h | 3 +++ src/libinput.c | 16 +++- 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/src

[PATCH libinput 2/2] timer.h: Add #include libinput-util.h

libinput-util.h is needed for the linked list definitions. Signed-off-by: Hans de Goede hdego...@redhat.com --- src/timer.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/timer.h b/src/timer.h index df12d0e..5e3b89b 100644 --- a/src/timer.h +++ b/src/timer.h @@ -25,6 +25,8

Re: [PATCH libinput 2/6] test: add litest_assert_empty_queue helper function

Hi, On 06/11/2014 02:11 AM, Peter Hutterer wrote: Checks if the queue is empty and prints informatino about any events before failing. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Looks good: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- test/litest.c

Re: [PATCH libinput 1/6] touchpad: always call into the the tap state machine

peter.hutte...@who-t.net Looks good: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/evdev-mt-touchpad.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index 8b502b7..0294eb2 100644 --- a/src

Re: [PATCH libinput 3/6] test: add a bunch of test for click behavior on touchpads

on the last test, with those fixed: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- test/litest-bcm5974.c | 3 +- test/litest.h | 1 + test/touchpad.c | 180 ++ 3 files changed, 183 insertions(+), 1

Re: [PATCH libinput 5/6] test: Add description for the T440 synaptics touchpad

| 2 + 4 files changed, 117 insertions(+) create mode 100644 test/litest-synaptics-t440.c Looks good: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans diff --git a/test/Makefile.am b/test/Makefile.am index 70e83d4..b5dc33c 100644 --- a/test/Makefile.am +++ b/test

Re: [PATCH libinput 6/6] test: add a couple of top software button test

Hi, On 06/11/2014 02:11 AM, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/touchpad.c | 124 1 file changed, 124 insertions(+) Looks good: Reviewed-by: Hans de Goede hdego...@redhat.com

Re: [PATCH libinput 1/3] test: move the interface declaration down

Hi, On 06/13/2014 04:48 AM, Peter Hutterer wrote: No functional changes, just some prep work. The commit message seems wrong, as the interface declaration is actually being moved up, not down (*). With a fixed commit message this is: Reviewed-by: Hans de Goede hdego...@redhat.com Regards

Re: [PATCH libinput 2/3] udev: split libinput_udev context init into two functions

; } + if (libinput_udev_set_seat(*li, seat)) { + fprintf(stderr, Failed to set seat\n); + libinput_destroy(*li); + return 1; + } + return 0; } With the free() removed this patch is: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans

Re: [PATCH libinput 3/3] Change the logging system to be per-context

Initialization and manipulation of seats * * A seat has two identifiers, the physical name and the logical name. The Your removing a bunch of exported symbols here, so you should also bump the soname to indicate ABI breakage. Other then that this looks good to me and is: Reviewed-by: Hans de Goede

Re: [PATCH libinput 02/23] evdev: Add basic support for tablet devices

letter difference in the name really is not enough, please rename one of the functions to make the name more unique. With that fixed this patch is: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans + memset(tablet-changed_axes, 0, sizeof(tablet-changed_axes

  1   2   3   4   5   6   7   8   >