Signed-off-by: Hans de Goede hdego...@redhat.com
---
src/evdev-mt-touchpad.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c
index 0294eb2..92e0651 100644
--- a/src/evdev-mt-touchpad.c
+++ b/src/evdev-mt-touchpad.c
@@ -139,7
Hi,
On 06/19/2014 02:17 AM, Peter Hutterer wrote:
On Wed, Jun 18, 2014 at 02:22:23PM +0200, Hans de Goede wrote:
Signed-off-by: Hans de Goede hdego...@redhat.com
---
src/evdev.c | 2 ++
src/evdev.h | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/evdev.c b/src
Hi,
On 06/19/2014 06:57 AM, Peter Hutterer wrote:
Rather than a single global logging function, make the logging dependent on
the individual context. This way we won't stomp on each other's feet in the
(admittedly unusual) case of having multiple libinput contexts.
The userdata argument to
Hi,
Series looks good to me, and is:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
On 06/19/2014 05:45 AM, Peter Hutterer wrote:
We'll need that later for conversion to mm.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
src/evdev-mt-touchpad-buttons.c | 20
;
case LIBINPUT_TABLET_AXIS_PRESSURE:
tablet-axes[a] = normalize_pressure(absinfo);
Shouldn't we rename normalize_pressure to something less pressure specific then
?
Other then that this patch-set looks good and is:
Reviewed-by: Hans de Goede hdego
Signed-off-by: Hans de Goede hdego...@redhat.com
---
test/touchpad.c | 78 +
1 file changed, 78 insertions(+)
diff --git a/test/touchpad.c b/test/touchpad.c
index 7350c21..585c1d2 100644
--- a/test/touchpad.c
+++ b/test/touchpad.c
Signed-off-by: Hans de Goede hdego...@redhat.com
---
src/timer.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/src/timer.c b/src/timer.c
index 65fdd17..4f465f3 100644
--- a/src/timer.c
+++ b/src/timer.c
@@ -22,6 +22,7 @@
#include assert.h
#include errno.h
+#include
There is no need to loop over the touch points twice.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
src/evdev-mt-touchpad.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c
index 04ea93c..ced9237 100644
--- a/src
And add an example xorg.conf.d .conf file for ignoring these devices under
xorg.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
test/50-litest.conf | 6 ++
test/litest.c | 4 +++-
2 files changed, 9 insertions(+), 1 deletion(-)
create mode 100644 test/50-litest.conf
diff --git
for it we also check for the axis bits
in state.direction, so it is not necessary.
Also add a check to ensure there are no spurious motion events.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
src/evdev-mt-touchpad.c | 17 +++--
src/evdev-mt-touchpad.h | 6 --
test/touchpad.c
Hi,
On 06/25/2014 09:06 AM, Dmitry Kazakov wrote:
Hi, all!
I am a developer from Krita painting application team. We recently did
quite much work on incorporating better tablet support in Krita. I have
several comments about your proposal of the tablet protocol (sorry for nor
replying
Hi,
On 06/27/2014 05:02 AM, Peter Hutterer wrote:
Those three are the ones that matter for logging or device identification in
callers, so let's provide them.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Looks good:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
that switching to the smooth simple accel code, as an added bonus gives
the tp code an accel profile with a threshold and a speed parameter, which
is exactly what is needed for the upcoming configuration interface support.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
src/evdev-mt-touchpad.c | 75
Hi,
On 07/01/2014 07:16 AM, Peter Hutterer wrote:
Motion starting inside the buttons is initially ignored. For pointer motion
along the negative y axis, the finger usually starts south of the touchpad
center. The more distance the motion is intended to cover, the closer to the
bottom edge of
(touchpad_no_first_fg_tap_after_move)
- fixed tests to be called for all touchpads, not just apple ones.
Looks good:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http
Hi,
On 07/01/2014 06:33 AM, Peter Hutterer wrote:
snip
The idea is interesting. Indeed on the T440 with a relatively large and
square-ish touchpad, this is much better now. On the x220 with a small
16:10 ratio touchpad it's better but not yet good. It feels like the pointer
acceleration
that switching to the smooth simple accel code, as an added bonus gives
the tp code an accel profile with a threshold and a speed parameter, which
is exactly what is needed for the upcoming configuration interface support.
Signed-off-by: Hans de Goede hdego...@redhat.com
--
Changes since v1:
-Use
Hi,
On 07/02/2014 08:49 AM, Peter Hutterer wrote:
The original intention of this state was to prevent an accidental move out of
the bottom software button to start moving the cursor. That ends up actually
preventing a number of normal moves that start low enough. Simply drop the
state.
:
_
| // \\ |
| \\_X__\\ |
|\ \ |
+-\ \---+
Oh, pretty ascii art :)
Looks good:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
src/evdev-mt-touchpad
Hi,
On 07/08/2014 01:21 AM, Peter Hutterer wrote:
For better consistency with filter_dispatch(). And move the things around to
keep
the consumable API together.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Looks good, you may add my Reviewed-by for patches 1-3.
Regards,
Hans
Hi,
On 07/11/2014 11:04 AM, Hans de Goede wrote:
Hi,
On 07/11/2014 08:34 AM, Daniel Martin wrote:
On Fri, Jul 11, 2014 at 11:08:53AM +1000, Peter Hutterer wrote:
A large part of palm events are situated on the far edges of the touchpad.
In
a test run on a T440s while typing a long email
.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
IMHO it would be better to make all the test functions taking percentages to use
doubles for the percentage then, and use say 0.5 % .
The rest of the set looks good and is:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
Force a cast of the input arguments to a double before the divide, rather
then after the divide.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
src/evdev-mt-touchpad.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c
, and remove the bogus t-state = TOUCH_NONE.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
src/evdev-mt-touchpad.c | 47 +--
1 file changed, 21 insertions(+), 26 deletions(-)
diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c
index
Don't process fake touches, e.g. re-adding the same position to the motion
history when they are not dirty. This could trigger for example on a button
press.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
src/evdev-mt-touchpad.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions
Multi-touch pads may track less touches then they can report fingers being
present through BTN_TOOL_FOO. So create fake touches for fingers reported
by BTN_TOOL_FOO on multi-touch pads too (when necessary).
This fixes e.g. 3 finger tap not working on the T440s.
Signed-off-by: Hans de Goede hdego
Hi All,
Here is a patch-set to fix 3 finger tapping on mt touchpads which track only 2
fingers + 1 misc. fix.
This patch-set applies on top of Peter's palm detection patch-set (not sure
if there are conflicts if applied directly to master).
Regards,
Hans
are you also reducing the delay here ? That is there to ensure that the
tap state-machine does not see this as a tap. So it should be
DEFAULT_TAP_TIMEOUT_PERIOD
if this works with 100 you're just being lucky.
Other the that this patch looks good and is:
Reviewed-by: Hans de Goede hdego...@redhat.com
.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Looks good:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
---
test/touchpad.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/test/touchpad.c b/test/touchpad.c
index 5a19e05..3052519
Hi,
On 07/18/2014 09:01 AM, Peter Hutterer wrote:
The minimum to start 2fg scrolling is in device units, not pixels. Which is
bad on many levels, but let's correct it in the comment at least.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
src/evdev-mt-touchpad.c | 2 +-
1
of) the apple touchpads.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Looks good:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
---
Should really be two separate patches, but the broken descriptors causes the
tests to break otherwise.
src/evdev-mt-touchpad
Hi,
On 07/21/2014 08:36 AM, Peter Hutterer wrote:
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
Series looks good, just double-check the tests for me please. This needs the
fixed bcm5974 patch I just sent a minute ago to work.
Looks good:
Reviewed-by: Hans de Goede hdego
Hi,
On 07/21/2014 08:40 AM, Peter Hutterer wrote:
More expressive in the caller and less ambiguous about return values (is it 1?
is it non-zero? can it be negative?)
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Looks good, series is:
Reviewed-by: Hans de Goede hdego...@redhat.com
history when nfingers changes on semi-mt pads to avoid this.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
src/evdev-mt-touchpad.c | 8
src/evdev-mt-touchpad.h | 2 ++
2 files changed, 10 insertions(+)
diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c
index b0520c7
Hi,
On 07/22/2014 01:34 AM, Peter Hutterer wrote:
On Mon, Jul 21, 2014 at 03:25:47PM +0200, Hans de Goede wrote:
On semi-mt touchpads the reported position of the first finger down may
jump when the pad switches from st to mt mode. When this happens a large
delta gets seen on the first finger
Hi,
On 07/23/2014 07:58 AM, Peter Hutterer wrote:
On Tue, Jul 22, 2014 at 09:18:26AM +0200, Hans de Goede wrote:
Hi,
On 07/22/2014 01:34 AM, Peter Hutterer wrote:
On Mon, Jul 21, 2014 at 03:25:47PM +0200, Hans de Goede wrote:
On semi-mt touchpads the reported position of the first finger
).
With these 2 fixed this patch is:
Acked-by: Hans de Goede hdego...@redhat.com
+ litest_event(d, EV_ABS, ABS_MT_SLOT, 0);
+ send_abs_mt_xy(d, l, t);
+
+ if (d-ntouches_down == 2) {
+ litest_event(d, EV_ABS, ABS_MT_SLOT, 1);
+ send_abs_mt_xy(d, r, b
Hi,
On 08/04/2014 03:51 AM, Peter Hutterer wrote:
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Looks good:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
---
src/evdev.c | 7 ++-
src/evdev.h | 3 ++-
2 files changed, 8 insertions(+), 2 deletions(-)
diff
Hi All,
As part of Linux Plumbers in Düsseldorf October 15 - 17, there
will be a Wayland miniconference.
I would like to invite all interested people to join us, esp.
if you're already in Düsseldorf for one of the co-hosted events.
If you're not registered for Plumbers yet and plan to come
I
Hutterer peter.hutte...@who-t.net
Ah no more static builds, love it, series is:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
---
test/Makefile.am | 16
tools/Makefile.am | 4 ++--
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/test
...@who-t.net
Looks good:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
---
test/litest.c | 46 ++
test/litest.h | 2 ++
2 files changed, 48 insertions(+)
diff --git a/test/litest.c b/test/litest.c
index 00db464..fcc8de1
Hi,
On 08/27/2014 06:31 AM, Peter Hutterer wrote:
With a non-zero absmin for both axes and different ranges for x/y, just to
detect those errors.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Looks good:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
---
test
Hi,
On 08/27/2014 06:31 AM, Peter Hutterer wrote:
We have a wrapper, use it.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Looks good:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
---
src/udev-seat.c | 27 ++-
1 file changed, 14
Hi,
On 08/27/2014 06:31 AM, Peter Hutterer wrote:
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Looks good:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
---
src/evdev.c | 3 ++-
src/evdev.h | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff
Hi,
On 08/27/2014 06:31 AM, Peter Hutterer wrote:
We apply calibration to single-touch and absolute devices, but we might as
well do so for multitouch events.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
src/evdev.c | 31 +++
1 file changed, 19
Hi,
On 08/27/2014 06:31 AM, Peter Hutterer wrote:
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
src/libinput-util.h | 100
test/misc.c | 78
2 files changed, 178
Hi,
On 08/27/2014 06:31 AM, Peter Hutterer wrote:
WL_CALIBRATION is a weston-specific property that required the translation
component of the matrix to be in pixels. libinput can't provide calibration
based on unknown outputs, so drop support for this property.
The basic functionality is
Looks good:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
---
test/touch.c | 192
+++
1 file changed, 192 insertions(+)
diff --git a/test/touch.c b/test/touch.c
index fee05f1..0aab5c8 100644
--- a/test/touch.c
Looks good:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
---
src/evdev.c| 59 +++-
src/evdev.h| 2 +
src/libinput-private.h | 11
src/libinput.c | 37 +
src/libinput.h | 147
Hi,
On 08/27/2014 06:31 AM, Peter Hutterer wrote:
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Looks good:
Reviewed-by: Hans de Goede hdego...@redhat.com
---
See patch 08/11, not sure we really want that configuration back-channel.
I think it is useful to have.
Regards,
Hans
Hi,
On 08/28/2014 03:12 PM, Hans de Goede wrote:
Hi,
On 08/27/2014 06:31 AM, Peter Hutterer wrote:
WL_CALIBRATION is a weston-specific property that required the translation
component of the matrix to be in pixels. libinput can't provide calibration
based on unknown outputs, so drop
Hi,
On 08/29/2014 01:50 AM, Peter Hutterer wrote:
On Thu, Aug 28, 2014 at 03:02:33PM +0200, Hans de Goede wrote:
Hi,
On 08/27/2014 06:31 AM, Peter Hutterer wrote:
We apply calibration to single-touch and absolute devices, but we might as
well do so for multitouch events.
Signed-off
Hi,
On 08/29/2014 01:51 AM, Peter Hutterer wrote:
On Thu, Aug 28, 2014 at 03:04:30PM +0200, Hans de Goede wrote:
Hi,
On 08/27/2014 06:31 AM, Peter Hutterer wrote:
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
src/libinput-util.h | 100
Hi,
On 08/29/2014 02:04 AM, Peter Hutterer wrote:
On Thu, Aug 28, 2014 at 03:07:26PM +0200, Hans de Goede wrote:
Hi,
On 08/27/2014 06:31 AM, Peter Hutterer wrote:
The big change here is the requirement to have the translation component in
a
device-normalized coordinate space. Without
Most trackpoint users want to be able to scroll using the trackpoint with
the middle button pressed, add support for this.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
include/linux/input.h | 1 +
src/evdev.c | 55 +++
src
So that it can be used for middle button trackpoint scrolling too.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
src/evdev-mt-touchpad.c | 56 +++--
src/evdev-mt-touchpad.h | 4
src/evdev.c | 48
: warning: 'r' may be used uninitialized in this
function [-Wmaybe-uninitialized]
Signed-off-by: Hans de Goede hdego...@redhat.com
---
test/litest-alps-semi-mt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/test/litest-alps-semi-mt.c b/test/litest-alps-semi-mt.c
index
Hi,
On 09/03/2014 05:50 AM, Peter Hutterer wrote:
On Tue, Sep 02, 2014 at 04:34:49PM +0200, Hans de Goede wrote:
So that it can be used for middle button trackpoint scrolling too.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
src/evdev-mt-touchpad.c | 56
Hi,
On 09/03/2014 05:57 AM, Peter Hutterer wrote:
On Tue, Sep 02, 2014 at 04:34:50PM +0200, Hans de Goede wrote:
Most trackpoint users want to be able to scroll using the trackpoint with
the middle button pressed, add support for this.
Signed-off-by: Hans de Goede hdego...@redhat.com
yes
Hi,
First of all patches 1 - 9 look good and are:
Reviewed-by: Hans de Goede hdego...@redhat.com
On 09/03/2014 04:03 AM, Peter Hutterer wrote:
Rather than adding a config interface to disable a device merely allow a
caller to toggle the send events mode on the device. If off, the device
.
Touchpads are currently excluded here, they generate extra events on tapping,
scrolling, and software buttons and need a more complex implementation.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Looks good:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
---
src
of the
device changing.
In a udev context, if the device was removed and libinput_dispatch() was
called, we can short-cut the syspath comparison by setting it to NULL.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Looks good:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards
Hi,
On 09/03/2014 04:03 AM, Peter Hutterer wrote:
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Looks good:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
---
test/Makefile.am | 7 +-
test/device.c| 275
have a key down multiple times on suspend though, log a bug.
The dispatch should release the keys before we even get here (functionality
added in a subsequent patch).
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Looks good:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards
Hi,
On 09/03/2014 04:03 AM, Peter Hutterer wrote:
No functional changes
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Looks good:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
---
src/evdev-mt-touchpad.c | 13 ++---
1 file changed, 10 insertions(+), 3
Hi,
On 09/03/2014 04:03 AM, Peter Hutterer wrote:
We may be in the middle of a software button click or a tap, so make sure we
go back to the device-neutral state by unwinding.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Looks good:
Reviewed-by: Hans de Goede hdego
Hi,
On 09/03/2014 04:03 AM, Peter Hutterer wrote:
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Looks good:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
---
test/device.c | 239
++
1 file changed, 239
://lists.freedesktop.org/archives/wayland-devel/2014-September/017032.html
Patches 1-2 look good to me, they are:
Reviewed-by: Hans de Goede hdego...@redhat.com
For patch 3, esp this bit:
+static void
+tp_device_added(struct evdev_device *device,
+ struct evdev_device *added_device)
+{
+ struct
Hi,
On 09/15/2014 07:33 AM, Peter Hutterer wrote:
On Sun, Sep 14, 2014 at 08:39:17PM +0200, Hans de Goede wrote:
Hi Peter, et al,
On 09/04/2014 08:31 AM, Peter Hutterer wrote:
This patchset adds support for two features:
* disabling the touchpad when a mouse is plugged in
* allow top
Hi,
On 09/15/2014 07:39 AM, Peter Hutterer wrote:
On Thu, Sep 11, 2014 at 04:34:48PM +0200, Bastien Nocera wrote:
On Thu, 2014-08-21 at 16:18 +1000, Peter Hutterer wrote:
replying to myself, now that I've had a bit of a think about this all.
On Wed, Aug 20, 2014 at 01:18:48PM +1000, Peter
) will not. This means that
we will need to clear the touchpad state on resume too, to avoid things
being in an inconsistent state after resume.
This commit factors out the state clearing code into a helper functions, so
that the same code can be used on resume.
No functional changes.
Signed-off-by: Hans de Goede
to the
trackpoint to the touchpad, but does not yet do anything with it.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Signed-off-by: Hans de Goede hdego...@redhat.com
---
src/evdev-mt-touchpad.c | 7 +++
src/evdev-mt-touchpad.h | 2 ++
src/evdev.c | 9 +
src
Hi All,
This patch series adds middle button trackpoint scrolling leaving top
softbuttons working if touchpad is disabled support.
It is based on the recent work by Peter, and it requires the patches
Peter has here:
https://github.com/whot/libinput/commits/wip/trackstick-detection
Minus the
On a TOPBUTTONPAD, we can't disable the touchpad altogether - the trackstick
relies on the touchpad's top software buttons.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
src/evdev-mt-touchpad-buttons.c | 4
src/evdev-mt-touchpad.c | 25 +++--
2 files
-by: Hans de Goede hdego...@redhat.com
---
doc/touchpad-softbutton-state-machine.svg | 200 +-
src/evdev-mt-touchpad-buttons.c | 45 +--
src/evdev-mt-touchpad.c | 17 ++-
src/evdev-mt-touchpad.h | 1 +
4 files changed
for this too.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
src/evdev-mt-touchpad.c | 2 ++
src/evdev.c | 52 +
src/evdev.h | 15 ++
3 files changed, 69 insertions(+)
diff --git a/src/evdev-mt-touchpad.c b/src/evdev
So that it can be used for middle button trackpoint scrolling too.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
src/evdev-mt-touchpad.c | 57 +++--
src/evdev-mt-touchpad.h | 4
src/evdev.c | 49
Most trackpoint users want to be able to scroll using the trackpoint with
the middle button pressed, add support for this.
Signed-off-by: Hans de Goede hdego...@redhat.com
Reviewed-by: Peter Hutterer peter.hutte...@who-t.net
---
include/linux/input.h| 1 +
src/evdev.c | 56
Make check_2fg_scroll functionality available outside of touchpad.c ,
no functional changes.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
test/litest.c | 39 +++
test/litest.h | 1 +
test/touchpad.c | 49
Make it easier to hit the topbutton area when the touchpad is disabled,
normally we don't want to make the topbutton area too big, so as to not
interfere with normal touchpad operation, but when disabled we have no such
worries.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
src/evdev-mt
Hi,
On 09/18/2014 03:49 AM, Peter Hutterer wrote:
On Tue, Sep 16, 2014 at 04:22:36PM +0200, Hans de Goede wrote:
Most trackpoint users want to be able to scroll using the trackpoint with
the middle button pressed, add support for this.
Signed-off-by: Hans de Goede hdego...@redhat.com
Hi,
On 09/18/2014 03:27 AM, Peter Hutterer wrote:
On Wed, Sep 17, 2014 at 03:35:32PM +0200, Hans de Goede wrote:
Signed-off-by: Hans de Goede hdego...@redhat.com
---
test/Makefile.am | 5 +++
test/litest-trackpoint.c | 2 +-
test/litest.h| 1 +
test/trackpoint.c
Hi,
On 09/18/2014 05:17 AM, Peter Hutterer wrote:
From: Hans de Goede hdego...@redhat.com
The touchpad top softbuttons such as found on the Lenove T440 are intended for
use with the trackstick. Route their events through the trackstick, so that
they can be used for e.g. middle button
Hi,
On 09/18/2014 03:09 AM, Peter Hutterer wrote:
On Wed, Sep 17, 2014 at 03:35:30PM +0200, Hans de Goede wrote:
Make it easier to hit the topbutton area when the touchpad is disabled,
normally we don't want to make the topbutton area too big, so as to not
interfere with normal touchpad
Signed-off-by: Hans de Goede hdego...@redhat.com
--
Changes in v2: Use 1 as delta for threshold test, add a no movement test
---
test/Makefile.am | 5 +++
test/litest-trackpoint.c | 2 +-
test/litest.h| 1 +
test/trackpoint.c| 103
Signed-off-by: Hans de Goede hdego...@redhat.com
---
src/libinput-private.h | 5 +
src/libinput.c | 5 -
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/libinput-private.h b/src/libinput-private.h
index 94d6580..3b46c27 100644
--- a/src/libinput-private.h
+++ b
the trackpoint on these devices, except for the buttons, as people may want
to use the touchpad (hardware or soft) buttons while using the trackpoint.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
src/evdev-mt-touchpad.c | 64 +++--
src/evdev-mt
so that the touchpad can listen for (e.g.)
keyboard events, and respond to these itself.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
src/libinput-private.h | 18 ++
src/libinput.c | 27 +++
2 files changed, 45 insertions(+)
diff --git a/src
good, I've found 1 issue, and I've 1 nitpick,
First the issue in [PATCH libinput 5/7] touchpad: only send button events if
we have button events queued
you seem to have forgotten to change tp_post_softbutton_buttons.
All other patches look good and are:
Reviewed-by: Hans de Goede hdego
).
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Patches 1-4 looks good, and are:
Reviewed-by: Hans de Goede hdego...@redhat.com
Comments on this one inline.
---
src/filter.c | 19 +--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/src/filter.c b/src
to the user.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Looks good:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
---
src/libinput-private.h | 9
src/libinput.c | 40 ++
src/libinput.h | 59
+evdev_accel_config_get_default_speed(struct libinput_device *device)
+{
+ return 0;
0.0 please, otherwise looks good:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
+}
+
+static int
configure_pointer_acceleration(struct evdev_device *device)
{
device
Hi,
On 09/19/2014 07:44 AM, Peter Hutterer wrote:
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net ---
This is exactly the same code as in src/evdev.c since evdev-mt-touchpad
derives from evdev, can't it re-use that code somehow ?
Regards,
Hans
src/evdev-mt-touchpad.c | 45
Hi,
On 09/19/2014 07:44 AM, Peter Hutterer wrote:
Hard-coded to 50 devices, because for a debugging tool that's plenty.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
This patch and 10/10 look good and are:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
---
tools
Hi,
On 09/22/2014 07:18 AM, Peter Hutterer wrote:
On Thu, Sep 18, 2014 at 01:11:05PM +0200, Hans de Goede wrote:
Some laptops with both a clickpad and a trackpoint have such a large
touchpad,
that parts of the users hands will touch the pad when using the trackpoint.
Examples
Hi,
On 09/22/2014 02:02 AM, Peter Hutterer wrote:
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
Changes to v1:
- don't duplicate the accel config code, just re-use it for touchpad
Looks good:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
src/evdev-mt
-off-by: Peter Hutterer peter.hutte...@who-t.net
Looks good:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
---
Changes to v1:
- change accel adjustments to use the defaults at speed 0
src/filter.c | 19 +--
1 file changed, 17 insertions(+), 2 deletions
, state);
+ tp_notify_softbutton(tp, time,
+ button,
+ is_top, state);
return 1;
}
Please drop this unrelated reformatting hunk, other then that the entire
patch-set
looks good and is:
Reviewed-by: Hans de
Hi,
On 09/22/2014 07:18 AM, Peter Hutterer wrote:
On Thu, Sep 18, 2014 at 01:11:05PM +0200, Hans de Goede wrote:
Some laptops with both a clickpad and a trackpoint have such a large
touchpad,
that parts of the users hands will touch the pad when using the trackpoint.
Examples
for adding internal event listeners, so that the
callbacks for these can get the full 64 bit timestamps.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
src/libinput-private.h | 18 +-
src/libinput.c | 18 +-
2 files changed, 18 insertions(+), 18
101 - 200 of 718 matches
Mail list logo