Re: [PATCH libinput] touchpad: don't check clickfinger distance for three fingers

. With this fixed: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans @@ -873,10 +871,6 @@ tp_clickfinger_set_button(struct tp_dispatch *tp) first = t; else if (!second) second = t; - else if (!third

Re: [PATCH v2 libinput] touchpad: serial synaptics need to fake new touches on TRIPLETAP

, t, time); tp_begin_touch(tp, t, time); t-state = TOUCH_UPDATE; break; } Rather then use the temporary state variable and have the if (state == ) ... Ack (grmbl) either way: Reviewed-by: Hans de Goede hdego

Re: [PATCH v2 libinput] touchpad: disable 2fg scrolling on Synaptics semi-mt touchpads

= tp_scroll_get_methods(tp); + + if (tp-ntouches = 2 + (methods LIBINPUT_CONFIG_SCROLL_2FG)) + method = LIBINPUT_CONFIG_SCROLL_2FG; No need to test ntouches here, that is already done in tp_scroll_get_methods(), other than that this patch looks good: Reviewed-by: Hans de

Re: [PATCH libinput 06/11] touchpad: scale thumb pressure threshold with the resolution

. https://bugs.freedesktop.org/show_bug.cgi?id=91362 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Tricky, feels a bit like black magic, I cannot think of a better approach though, so lets see how this works out: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src

Re: [PATCH libinput 07/11] touchpad: only try thumb detection in the lowest 15/8mm

Hi, On 22-07-15 07:09, Peter Hutterer wrote: That's the most likely area it will be resting in, if it's sitting anywhere above that it's likely part of an interaction. A thumb in the lowest 15mm needs to trigger the pressure threshold before it's labelled a thumb. A thumb in the lowest 8mm is

Re: [PATCH libinput 1/2] touchpad: make the edge-scroll edge 7mm wide

...@who-t.net Series looks good to me: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/evdev-mt-touchpad-edge-scroll.c | 25 +++-- 1 file changed, 3 insertions(+), 22 deletions(-) diff --git a/src/evdev-mt-touchpad-edge-scroll.c b/src/evdev-mt

Re: [PATCH libinput] touchpad: drop thumb handling from gestures

. Reported-by: Carlos Garnacho carl...@gnome.org Signed-off-by: Peter Hutterer peter.hutte...@who-t.net LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/evdev-mt-touchpad-gestures.c | 19 --- src/evdev-mt-touchpad.c | 2 +- src/evdev-mt

Re: [PATCH libinput 0/4] Fix synaptics cursor jumps for triple-touches

touches we'd get a coordinate jump. 4/4 filters those out now, causing a more stable experience when three-finger tapping or clicking. Series looks good to me: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans ___ wayland-devel mailing list

Re: [PATCH libinput 1/2] touchpad: reduce 2fg scroll threshold to 2mm

-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/evdev-mt-touchpad-gestures.c | 3 ++- test/gestures.c | 10 +- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/src/evdev-mt-touchpad-gestures.c b/src/evdev-mt-touchpad-gestures.c index

Re: [PATCH libinput 05/11] touchpad: use the top-most touch for fake finger positions

touchpad - we know it's big enough to enable thumb detection and that way we don't have to double-check in the how big the touchpad is, etc. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Patches 1 - 5 look good to me: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans

Re: [PATCH libinput 10/11] touchpad: a pressure change alone needs touch processing, mark as dirty

Hi, On 22-07-15 07:09, Peter Hutterer wrote: A thumb may not move, but may change pressure so we need to process accordingly. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Patches 8 - 10 LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/evdev-mt

Re: [PATCH libinput 11/11] touchpad: put a movement threshold on thumb detection

Hi, On 22-07-15 07:09, Peter Hutterer wrote: If a thumb moves around, it's not resting and we should consider it a normal touch. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad.c | 16 src/evdev-mt-touchpad.h | 1 + test/touchpad.c

Re: [PATCH libinput 1/2] Add a configuration interface for enabling/disabling disable-while-typing

where needed. https://bugs.freedesktop.org/show_bug.cgi?id=90624 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Series looks good to me: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/libinput-private.h| 12 ++ src/libinput.c| 42

Re: [PATCH libinput] touchpad: disable 2fg scrolling on semi-mt touchpads

Hi, On 07/16/2015 01:55 AM, Peter Hutterer wrote: On Wed, Jul 15, 2015 at 11:44:47AM -0400, Benjamin Tissoires wrote: On Mon, Jul 13, 2015 at 11:39 PM, Peter Hutterer peter.hutte...@who-t.net wrote: These touchpads have a terrible resolution when two fingers are down, causing scrolling to

Re: [PATCH libinput 11/11] touchpad: put a movement threshold on thumb detection

Hi, On 23-07-15 04:31, Peter Hutterer wrote: On Wed, Jul 22, 2015 at 03:54:02PM +0200, Hans de Goede wrote: Hi, On 22-07-15 07:09, Peter Hutterer wrote: If a thumb moves around, it's not resting and we should consider it a normal touch. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net

Re: [PATCH libinput 1/3] test: only initialize the generic rules/hwdb once

-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/path.c| 2 +- test/litest.c | 34 +- 2 files changed, 22 insertions(+), 14 deletions(-) diff --git a/src/path.c b/src/path.c index ab4d065..04c703c 100644 --- a/src/path.c +++ b/src/path.c @@ -312,7

Re: [PATCH libinput 1/8] tablet: widen the tool id to 64 bits

Hi Peter, Code-wise this series looks good to me. Assuming the new "tip" behavior is the result of discussions with / a request of toolkit people, this series is: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans On 11-11-15 22:12, Peter Hutterer wrote: Sign

Re: [PATCH libinput 1/3] tablet: add missing event type checks for tablet events

Hi, On 16-11-15 00:31, Peter Hutterer wrote: Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Series looks good to me, and is: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- src/libinput.c | 49 ++

Re: [PATCH libinput] touchpad: reduced the 2fg scroll threshold to 1mm

ost of misdetecting some gestures is acceptable. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Otherwise I say lets give this a try and see how it goes (we will likely not know until higher levels in the stack actually start supporting pinch gestures, but ah well): Reviewed-by: Hans de Goe

Re: [PATCH libinput 1/3] evdev: log a bug for missing pointer accel on relative events

Hi, On 30-10-15 02:19, Peter Hutterer wrote: And use the unaccelerated motion events. Better than crashing, and better than a non-moving mouse. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> The entire set looks good to me and is: Reviewed-by: Hans de Goede <hdego...@r

Re: [PATCH libinput 9/9] touchpad: drop fake resolution handling

Hi, On 01-07-15 08:08, Peter Hutterer wrote: Now that we have all devices init a fixed resolution we don't need code to handle custom cases anymore. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/evdev

Re: [PATCH libinput 8/9] touchpad: default to a 69x50mm sized touchpad

. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/evdev-mt-touchpad.c | 40 1 file changed, 40 insertions(+) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt

Re: [PATCH libinput 7/9] udev: add size hint for apple touchpads

Hi, On 01-07-15 08:08, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- udev/90-libinput-model-quirks.hwdb | 1 + 1 file changed, 1 insertion(+) diff --git a/udev/90-libinput-model

Re: [PATCH libinput 6/9] udev: add ALPS firmware detection and size properties

Hi, On 01-07-15 08:08, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- udev/90-libinput-model-quirks.hwdb | 4 udev/libinput-model-quirks.c | 20 2

Re: [PATCH libinput 1/9] udev: make sure the udev callout path is valid for a test run

-by: Peter Hutterer peter.hutte...@who-t.net LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- configure.ac| 10 +- test/Makefile.am| 2 +- udev/.gitignore | 1 + udev/80-libinput

Re: [PATCH libinput 5/9] udev: add Elantech touchpad firmware detection

Hi, On 01-07-15 08:08, Peter Hutterer wrote: Only firmware v4 (and probably whatever comes in the future) have resolution set, for the first couple of touchpads we need size hints. Add a callout that looks at the properties on the touchpad and decides the firmware version. The udev/hwdb is

Re: [PATCH libinput 4/9] evdev: use LIBINPUT_ATTR_SIZE_HINT for resolutions

/60-evdev.hwdb. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- doc/device-configuration-via-udev.dox | 14 +- src/evdev.c | 36 +-- 2 files

Re: [PATCH libinput 3/9] util: add a helper function to parse a WIDTHxHEIGHT property

Hi, On 01-07-15 08:08, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/libinput-util.c | 30 ++ src/libinput-util.h | 2 ++ test/misc.c | 47

Re: [PATCH libinput 2/9] evdev: simplify setting a fake resolution

structs. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/evdev.c | 55 --- 1 file changed, 12 insertions(+), 43 deletions(-) diff --git a/src/evdev.c b

Re: [PATCH libinput] touchpad: be smarter about clickfinger thumb detection

separately and are not regarded as thumb. https://bugs.freedesktop.org/show_bug.cgi?id=91046 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/evdev-mt-touchpad-buttons.c | 50 +++-- test

Re: [PATCH libinput 1/4] test: allow for a default value on LITEST_AUTO_ASSIGNS

itself. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net This feels somwhat adventurous, but I cannot find anything wrong with it, so: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- test/litest-bcm5974.c | 19 ++- test/litest-int.h

Re: [PATCH libinput 1/4] test: allow for a default value on LITEST_AUTO_ASSIGNS

Hi, On 08-07-15 15:11, Hans de Goede wrote: Hi, On 08-07-15 08:56, Peter Hutterer wrote: The touchpads currently all send a default value of 30 for ABS_PRESSURE. For some tests we want to have a custom pressure but changing all tests isn't sensible. So hook each device up to send a default

Re: [PATCH libinput 1/3] test: move enable_edge_scroll up

Hi, On 06-07-15 06:26, Peter Hutterer wrote: No functional changes, just so we can group those helpers together. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net The entire series LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- test/touchpad.c | 26

Re: [PATCH v2 libinput 5.5/9] udev: add a model-quirks callout

the firmware version is the interesting bit. The udev rule is added already to match on that, note that the callout doesn't do anything at this point. The various touchpad-related things will be added separately. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net LGTM: Reviewed-by: Hans de Goede

Re: [PATCH libinput] filter: fix constant acceleration for the X230

-by: Peter Hutterer <peter.hutte...@who-t.net> LGTM: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- src/filter.c | 33 +++-- 1 file changed, 23 insertions(+), 10 deletions(-) diff --git a/src/filter.c b/src/filter.c index 5df50d3..a6

Re: [PATCH libinput] evdev: ignore accelerometer devices

Hi, On 01-09-15 00:37, Peter Hutterer wrote: https://bugs.freedesktop.org/show_bug.cgi?id=91563 Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> LGTM: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- src/evdev.c | 7 +++ test/d

Re: [PATCH v2 libinput] Add an API to change pointer acceleration profiles

/show_bug.cgi?id=89485 Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Bit of a big patch, but I guess there is no easy way to split this up. Otherwise looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- Sorry, left a memleak in t

Re: [PATCH libinput] touchpad: don't tap for 2fg down, followed by a single finger up

- this could eventually be interpreted as a tap, but not for now. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> A what fun. I've reviewed both the state-machine and the code changes and both look good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans

Re: [PATCH libinput] Ignore BTN_TOOL_* events when posting button events

viewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- src/evdev.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/src/evdev.c b/src/evdev.c index ec3abc6..4933185 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -439,8 +439,22 @@ evdev_flush_p

Re: [PATCH libinput 3/8] tablet: drop pressure when either pressure or distance changed

ISTANCE)) && Your checking the same bit twice here, I believe you need to s/DISTANCE/PRESSURE/ in the second check. The rest of the series looks good, so the series, and this one with this fixed is: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans

Re: [PATCH libinput 1/3] test: abort if we have a test that doesn't run for any devices

-t.net> Series looks good to me and is: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- test/litest.c | 9 + 1 file changed, 9 insertions(+) diff --git a/test/litest.c b/test/litest.c index 65be6b5..e235bc9 100644 --- a/test/litest.c +++ b/test/

Re: [PATCH libinput] tablet: handle custom proximity handling

that support a button/lens tool and have a different default threshold are well out of date. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Patch looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans p.s. I've a (serial!) graphire tablet,

Re: [PATCH libinput 1/3] tools: print which scroll axis we have in event-debug

Hi, On 07-12-15 05:23, Peter Hutterer wrote: Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> All patches in this set look good and are: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- tools/event-debug.c | 12 +--- 1 file changed,

Re: [PATCH libinput] touchpad: add a special quirk for the Lenovo x220 with updated firmware

. https://bugzilla.redhat.com/show_bug.cgi?id=1264453 Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Ugh, well nothing we can do about this: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- doc/device-configuration-via-udev.dox | 18

Re: [RFC wayland-protocols 1/1] Add Primary Selection Protocol Version 1

Hi, On 14-12-15 22:20, Lyude wrote: On Mon, 2015-12-14 at 10:45 -0800, Bill Spitzak wrote: On Mon, Dec 14, 2015 at 9:13 AM, Pekka Paalanen wrote: On Mon, 14 Dec 2015 10:39:05 -0500 Lyude wrote: On Sat, 2015-12-12 at 11:29 -0800, Bill Spitzak wrote:

Re: [RFC libinput] Add a "switch" interface for parts of the SW_* range

Hi, On 04-01-16 02:20, Peter Hutterer wrote: This is a first draft to gather some comments, it's not hooked up to anything yet and really just to get the main intention across. Things up for comments and discussion: Unlike buttons, we only expose switches we understand, hence enum

Re: [PATCH libinput] evdev: only reject devices with missing MT x/y if they're MT devices

Hi, On 03-01-16 23:36, Peter Hutterer wrote: A fake MT device may have ABS_MT_POSITION_X but not Y. In this case we don't care, because we don't handle those axes anyway. http://bugs.freedesktop.org/show_bug.cgi?id=93474 Signed-off-by: Peter Hutterer ---

Re: [PATCH libinput] touchpad: fix DWT pairing for Macbook Pro 2015

thored-by: Peter Hutterer <peter.hutte...@who-t.net> Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Patch code looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> I do worry a bit if this will not break dwt on older macbooks though. Maybe we need to

Re: [PATCH libinput] tablet: add libinput_tablet_tool_is_unique()

net> Looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- doc/tablet-support.dox | 4 +++- src/libinput.c | 6 ++ src/libinput.h | 24 ++-- src/libinput.sym | 1 + test/tablet.c

Re: [PATCH libinput 1/9] tablet: dump deltas_discrete, replace with a single wheel_discrete variable

Hi, On 12/21/2015 06:56 AM, Peter Hutterer wrote: Only the wheel has a discrete value, no need to keep arrays for a single value. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Entire series looks good to me and is: Reviewed-by: Hans de Goede <hdego...@redhat.com> Re

Re: [PATCH libinput] tablet: invert tilt axes when left-handed is enabled

Hi, On 12/21/2015 02:46 AM, Peter Hutterer wrote: Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- src/evdev-tablet.c | 4 test/tablet

Re: [PATCH libinput] evdev: drain any pending evdev events on a device

are pending, the state we see is newer than the events we process immediately after initialization. That can lead to confusion. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Patch looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans ---

Re: [PATCH libinput 00/14] tablet: the big "tablet" -> "tablet tool" rename

wer brains :) Patch 14 is new, and has a bunch of documentation on top. Cheers, Peter Big series :) Thanks for splitting it up to make reviewing easier. I cannot find anything wrong with it: Reviewed-by: Hans de Goede <hdego...@redhat.com>

Re: [PATCH v2 libinput] evdev: only reject devices with missing MT x/y if they're MT devices

s good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- Changes to v1: - reduce to the hunk that actually matters. sorry, not sure what happened there, some rebase gone wrong of my original approach and I didn't notice it before sending it. src/evdev

Re: [PATCH libinput] touchpad: disable MT for elantech semi-mt touchpads

axis and the BTN_TOOL_* events. https://bugs.freedesktop.org/show_bug.cgi?id=93583 This kernel patch is required: https://lkml.org/lkml/2016/1/11/171 Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Patch looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Abou

Re: [PATCH libinput] evdev: check model flags for actual booleans

set to something resembling a boolean. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> patch looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- src/evdev.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/e

Re: [PATCH libinput] touchpad: don't warn about kernel jumps on semi-mt devices

viewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- src/evdev-mt-touchpad.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index 56760dc..d01461c 100644 --- a/src/evdev-mt-touchpad.c +++ b/src/evdev-m

Re: [PATCH libinput] touchpad: restore the hysteresis by default

the approach: leave the hysteresis enabled by default but disable it for those touchpads that don't need it. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Seems like the sensible thing to do to me, and the patch looks good: Reviewed-by: Hans de Goede <hdego...@redhat.com&

Re: [PATCH libinput 1/2] touchpad: split palm movement detection into a helper function

Hi, On 06/15/2016 08:52 AM, Peter Hutterer wrote: Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Series looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- src/evdev-mt-touchpad.c | 35 +++ 1 file

Re: [PATCH libinput] touchpad: short-circuit the edge scroll handling when it's not enabled

is for debugging only, and code-wise it is by far the cleanest. Anyways all 3 get the job done in the end, so this patch is: Reviewed-by: Hans de Goede <hdego...@redhat.com> Feel free to pick any of the outlined solutions (including your original one). @@ -350,9 +359,6 @@ tp_edge_scr

Re: [PATCH libinput] touchpad: warn if we have invalid touchpad ranges

and how to fix it. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- doc/Makefile.am| 1 + doc/absolute-coordinate-ranges.dox | 120 +++

Re: [PATCH libinput] touchpad: only check for vertical finger distribution on 2fg gestures

Hutterer <peter.hutte...@who-t.net> Patch looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- src/evdev-mt-touchpad-gestures.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/src/evdev-mt-touchpad-

Re: [PATCH libinput 0/4] Restore hysteresis for all touchpads

removing the hysteresis isn't worth those drawbacks, so just bring it back for all touchpads. The first three patches are just reverts for additions caused by the hysteresis removal, they are not needed anymore now. Series looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> R

Re: [PATCH libinput 1/2] test: when creating an abs test device, force the abs->value to the mimimum

ned-off-by: Peter Hutterer <peter.hutte...@who-t.net> Series looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- test/litest.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/test/litest.c b/test/litest.c index 6

Re: [PATCH libinput] touchpad: fix dwt disabling while a key is still down

Hutterer <peter.hutte...@who-t.net> Looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- src/evdev-mt-touchpad.c | 9 --- test/touchpad.c | 68 + 2 files changed, 73 insertions(+),

Re: [PATCH libinput 1/2] udev: fix ALPS firmware detection

. Expected side-effect: earlier versions of ALPS touchpads now lose their (erroneous) size assignment. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Both patches look good to me and are: Reviewed-by: Hans de Goede <hdego...@redhat.com> Thanks & Regards, Hans

Pre-fosdem cross desktop wayland meetup notes

, EFL/Enlightenment) Mike Blumenkrantz (Samsung, EFL/Enlightenment) Andrew Williams (EFL/Enlightenment) Olivier Fourdan (Red Hat, graphics team) Benjamin Tissoires (Red Hat, graphics team) Hans de Goede (Red Hat, graphics team) Discussed: -Menu position stuff, basically: https://bugzilla.gnome.org

Re: [PATCH libinput] touchpad: if we have a serio keyboard, override any previous dwt pairing

. This is obviously wrong. For now, give priority to serio keyboards, and override existing dwt pairings with the new keyboard. https://bugs.freedesktop.org/show_bug.cgi?id=93983 Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Patch looks good to me: Reviewed-by: Hans de Goede <hdego...@r

Re: [PATCH libinput] touchpad: while a key is held down, don't disable dwt

. This is a corner case and likely hard to trigger by a real user. https://bugs.freedesktop.org/show_bug.cgi?id=93984 Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Patch looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards. Hans --- src/evdev-m

Re: [PATCH libinput] evdev: disable the mode button on the Cyborg RAT 5

accordingly, for now disable the button codes. https://bugs.freedesktop.org/show_bug.cgi?id=92127 Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Patch looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- src/evdev.c

Re: [PATCH libinput] test: add two gesture tests for scrolling with a thumb in the btnarea

looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- test/gestures.c | 60 + 1 file changed, 60 insertions(+) diff --git a/test/gestures.c b/test/gestures.c index 3f7ee83..c814911 100644 --- a/tes

Re: [PATCH v2 libinput] touchpad: drop motion hysteresis by default

ements to slow motion are too good to ignore Ok, lets say how this one plays out: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans src/evdev-mt-touchpad.c| 23 ++- src/evdev.c| 1 + src/evdev.h

Re: [PATCH libinput] touchpad: drop motion hysteresis

Hi, On 01-02-16 07:43, Peter Hutterer wrote: On Mon, Feb 01, 2016 at 12:38:13PM +1000, Peter Hutterer wrote: Some older touchpad devices jitter a fair bit when a finger is resting on the touchpad. That's why the hysteresis was introduced in the synaptics driver back in 2011. However, the

Re: [PATCH libinput] touchpad: if the second finger is within 20x5mm, bias towards 2fg scrolling

<peter.hutte...@who-t.net> Sorry for being a bit slow on reviewing this one, this seems to be a good solution to me (I consider false positives unlikely): Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- src/evdev-mt-touchpad-gestures.c | 11 +-- 1

Re: [PATCH libinput] touchpad: only trigger immediate pinch detection for three fingers

<peter.hutte...@who-t.net> Looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- src/evdev-mt-touchpad-gestures.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/evdev-mt-touchpad-gestures.c b/src/evdev-mt-touchpad-gestures.c index dc8d606..3c

Re: [PATCH libinput 1/4] touchpad: don't try to unhover touches if nothing changed

Hi, On 22-01-16 03:06, Peter Hutterer wrote: If the touch hasn't updated, the distance hasn't changed so there is no need to unhover. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Series looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Re

Re: [PATCH libinput] touchpad: disable MT for all semi-mt devices

Hi, On 22-01-16 03:06, Peter Hutterer wrote: On Wed, Jan 20, 2016 at 11:31:42AM +0100, Hans de Goede wrote: Hi, Then we can also revert: http://cgit.freedesktop.org/wayland/libinput/commit/?id=0d40aefe Making tp_gesture_get_active_touches() look only at real touches again as intended

Re: [PATCH libinput] gestures: average motion by active touches, not moved touches

Hi, On 25-01-16 04:04, Peter Hutterer wrote: Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Patch looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- src/evdev-mt-touchpad-gestures.c | 16 ++-- 1 file changed, 1

Re: [PATCH libinput] touchpad: disable MT for all semi-mt devices

Hi, On 25-01-16 04:03, Peter Hutterer wrote: On Fri, Jan 22, 2016 at 11:15:55AM +0100, Hans de Goede wrote: Hi, On 22-01-16 03:06, Peter Hutterer wrote: On Wed, Jan 20, 2016 at 11:31:42AM +0100, Hans de Goede wrote: Hi, Then we can also revert: http://cgit.freedesktop.org/wayland

Re: [PATCH libinput] gestures: jump straight to swipe for 3+ finger gestures on ST touchpads

Hi, On 25-01-16 04:03, Peter Hutterer wrote: The first/second variables are only needed for pinch, so we can skip them here. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Patch looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans ---

Re: [PATCH libinput] tablet: add hwdb entries to ignore Wacom Cintiq offsets

TABLET_TOOL_ENTERING_PROXIMITY)) delta.x = value - tablet->axes.point.x; tablet->axes.point.x = value; + } point.x = tablet->axes.point.x; This seems like an extra empty line accidentally got added. Otherwise this patch looks

Re: [PATCH libinput] touchpad: move the tapping exclusion zone to the top edge of the button

=93947 Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Patch looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- src/evdev-mt-touchpad.c | 11 +++- src/evdev-mt-touchpad.h | 1 - test/touchpad.c

Re: [PATCH libinput] touchpad: add synaptics semi-mt devices to those needing hysteresis

Hi, On 17-02-16 01:11, Peter Hutterer wrote: https://bugs.freedesktop.org/show_bug.cgi?id=94097 Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Patch looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- src/evdev-mt-tou

Re: [PATCH libinput] touchpad: add quirk for the T450 and T460 generation hardware

:*:pvrThinkPad??60*: +libinput:name:SynPS/2 Synaptics TouchPad:dmi:*svnLENOVO:*:pvrThinkPadX1Carbon3rd:* + LIBINPUT_MODEL_LENOVO_T450_TOUCHPAD=1 + ## # Synaptics ## Otherwise this patch looks good to me and is: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH libinput] touchpad: fix left-handed top software trackpoint buttons

://bugs.freedesktop.org/show_bug.cgi?id=94733 Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Patch looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- src/evdev-mt-touchpad-buttons.c | 23 --- test/trackpoint.c

Re: [PATCH v2 2/4 libinput] evdev: split scroll button state check out

viewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- changes to v1: - replaces previous 2/4 patch src/evdev.c | 4 +++- src/evdev.h | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/evdev.c b/src/evdev.c index 7ffc464..2afec6e 100644 --- a/src/evdev

Re: [PATCH libinput] test: add test for no scroll events before the scroll button timeout

Hi, On 12-04-16 20:50, Peter Hutterer wrote: Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- src/evdev.c| 2 ++ test/pointer.c | 31 +++ 2 files

Re: [PATCH libinput] udev: update the hwdb matches to avoid use of ( and )

. https://bugs.freedesktop.org/show_bug.cgi?id=93846#c12 Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- udev/90-libinput-model-quirks.hwdb | 20 ++-- 1 file

Re: [PATCH libinput] test: set the umask before msktemp to silence coverity

Hi, On 12-04-16 07:11, Peter Hutterer wrote: Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- test/path.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/path.c b/test/path.c index 7d7c

Re: [PATCH libinput 3/4] evdev: enable middle-button scrolling on middle-button emulation

Hi, On 11-04-16 05:54, Peter Hutterer wrote: https://bugs.freedesktop.org/show_bug.cgi?id=94856 Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Patch looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- src/evde

Re: [PATCH libinput 4/4] test: add test to ensure MB emulation doesn't start while the MB is down

emulation should not engage. Test for this. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Patch looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- test/pointer.c | 57 + 1 file

Re: [PATCH libinput 2/4] evdev: check the button scrolling state instead of the hw button state

Hi, On 11-04-16 05:54, Peter Hutterer wrote: The state of button scrolling should determine whether we filter the event, not the hardware button state. Signed-off-by: Peter Hutterer --- src/evdev.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-)

Re: [PATCH libinput] tablet: fix the airbrush slider range

Hi, On 11-04-16 01:32, Peter Hutterer wrote: Supposed to be [-1, 1] but we only generated [0, 1] Reported-by: Carlos Garnacho <carl...@gnome.org> Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Patch looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com&g

Re: [PATCH libinput 1/4] evdev: if we have a quick scroll button release, skip middle button emulation

Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Patch looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- src/evdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index 6bb8986..9b

Re: [PATCH libinput 4/4] touchpad: reset the motion history on significant negative pressure changes

if (!t->dirty) continue; + if (t->pressure_delta < -7) + tp_motion_history_reset(t); + Do you really want to do this on all touchpads and not just on t440 / t450 and friends ? Otherwise this series looks good and is: Reviewed-by

Re: [PATCH libinput] touchpad: add a middle button software area

to only refer to the middle button area now. https://bugs.freedesktop.org/show_bug.cgi?id=94755 Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Patch looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- doc/clickpad-softbuttons

Re: [PATCH libinput 1/3] Make a link to the html docs available as a #define

ere (only RCs?). Just adding a commit message should be sufficient enough to make me happy :) With this fixes this series is: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans Cheers, Benjamin +#define HTTP_DOC_LINK "https://wayland.freedesktop.org/libinput/do

Re: [PATCH libinput] udev: add the Dell Lattitude E5420 to the wobbly touchpads

Hi, On 20-05-16 02:29, Peter Hutterer wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1336084 Signed-off-by: Peter Hutterer --- udev/90-libinput-model-quirks.hwdb | 3 +++ 1 file changed, 3 insertions(+) diff --git a/udev/90-libinput-model-quirks.hwdb

Re: [PATCH libinput] udev: add the Yoga 2 to the wobbly touchpads

uchPad*:dmi:*svnLENOVO*pvrThinkPadEdgeE530:* +# Lenovo Yoga 2013 +libinput:name:*SynPS/2 Synaptics TouchPad*:dmi:*svnLENOVO*pvrLenovoYoga213:* LIBINPUT_MODEL_WOBBLY_TOUCHPAD=1 ## Reviewed-by: Hans de Goede <hdego...@redhat.com> Re

Re: [PATCH libinput] udev: add the Dell Lattitude E5420 to the wobbly touchpads

Hi, On 20-05-16 12:28, Hans de Goede wrote: Hi, On 20-05-16 02:29, Peter Hutterer wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1336084 Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- udev/90-libinput-model-quirks.hwdb | 3 +++ 1 file changed, 3 insertions(+) diff

<    1   2   3   4   5   6   7   8   >