[PATCH wayland-web] Updated additional dependencies for a cleaner Ubuntu 12.04 LTS system.

2014-10-27 Thread Jon A. Cruz
--- ubuntu12.04.html | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/ubuntu12.04.html b/ubuntu12.04.html index 804433e..7576fd4 100644 --- a/ubuntu12.04.html +++ b/ubuntu12.04.html @@ -15,7 +15,8 @@ Building Weston on Ubuntu 12.04/h1 XWayland on an Ubuntu 12.04 LTS

Re: [PATCH wayland-web] Updated additional dependencies for a cleaner Ubuntu 12.04 LTS system.

2014-10-27 Thread Jon A. Cruz
with poor wifi (aka difficult to ssh back to my Linux box). Should I clean up and resubmit? -- Jon A. Cruz j...@joncruz.org ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH 3/9] doc: preserve links produced by Doxygen

2014-11-26 Thread Jon A. Cruz
On 11/25/2014 11:52 PM, Pekka Paalanen wrote: I'd be interested in hearing how we end up with a) missing targets, and b) duplicate targets. Could missing targets be fixed by documenting things that are not yet documented? If yes, that would probably be nice. If we ever get duplicate

[PATCH] doc: Removed redundant xslt output elements.

2014-11-27 Thread Jon A. Cruz
Removed xsl:output elements that were duplicated but with attributes in a different order. Standard tools are required to ignore the order of attributes in an element. Signed-off-by: Jon A. Cruz j...@osg.samsung.com --- doc/publican/protocol-interfaces-to-docbook.xsl | 1 - doc/publican/protocol

[PATCH] doc: Invoke doxygen via the defined make variable.

2014-12-02 Thread Jon A. Cruz
Invoke doxygen via the autoconf-defined make variable instead of directly. This brings it in line with standard makefile practices. Signed-off-by: Jon A. Cruz j...@osg.samsung.com --- doc/doxygen/Makefile.am | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/doxygen

Re: [PATCH 1/4] doc: use markdown tildes for code blocks

2014-12-02 Thread Jon A. Cruz
On 12/02/2014 06:29 PM, Bill Spitzak wrote: This requires doxygen 1.8 or newer. FYI this will cut off support for RHEL6 and corresponding distros such as CentOS and Scientific Linux (I had to track this for my prior day job). On the other hand, RHEL7 is up to Doxygen 1.8.5 so we're good in that

[PATCH] doc: Add config check for doxygen 1.8.0+.

2014-12-02 Thread Jon A. Cruz
Add a config time check for a new enough (1.8.0+) version of doxygen. Signed-off-by: Jon A. Cruz j...@osg.samsung.com --- configure.ac | 8 1 file changed, 8 insertions(+) diff --git a/configure.ac b/configure.ac index 6f8220b..317cdae 100644 --- a/configure.ac +++ b/configure.ac

Re: [PATCH] doc: Add config check for doxygen 1.8.0+.

2014-12-03 Thread Jon A. Cruz
is the tildes for code markup, and that is being questioned right now. On 12/02/2014 09:48 PM, Jon A. Cruz wrote: Add a config time check for a new enough (1.8.0+) version of doxygen. Signed-off-by: Jon A. Cruz j...@osg.samsung.com --- configure.ac | 8 1 file changed, 8 insertions

[PATCH v2] doc: Add config check for doxygen 1.6.0+.

2014-12-03 Thread Jon A. Cruz
Add a config time check for a new enough (1.6.0+) version of doxygen. v2. require 1.6.0+ instead of 1.8.0+ Signed-off-by: Jon A. Cruz j...@osg.samsung.com --- configure.ac | 8 1 file changed, 8 insertions(+) diff --git a/configure.ac b/configure.ac index 6f8220b..12dd94c 100644

Re: [PATCH v2] doc: Add config check for doxygen 1.6.0+.

2014-12-05 Thread Jon A. Cruz
On 12/05/2014 07:09 AM, Pekka Paalanen wrote: Hi, looking at doc/doxygen/wayland.doxygen.in it says # Doxyfile 1.7.6.1 Do we know this works with Doxygen 1.6 or should we require 1.7? Not that it matters too much, since right now we don't have any checks, but I'd prefer some

[PATCH wayland-web] Adding notes regarding Arch Linux dependencies for DocBook.

2014-12-08 Thread Jon A. Cruz
/show_bug.cgi?id=86515 Signed-off-by: Jon A. Cruz j...@osg.samsung.com --- building.html | 4 1 file changed, 4 insertions(+) diff --git a/building.html b/building.html index 401069b..fbedfae 100644 --- a/building.html +++ b/building.html @@ -42,6 +42,8 @@ Linux Mint 17/a, which is derived from

Re: [PATCH libinput 2/3] Implement support for pen barrel rotation

2014-12-08 Thread Jon A. Cruz
On 12/08/2014 12:13 PM, Bill Spitzak wrote: Why not call it Z instead of TWIST? I'm pretty certain that is a common term for this movement, and that twist is a rather strange term (roll is used more). And Z has the advantage that it also implies that counter-clockwise is positive. In that

[PATCH 2/2] doc: Minor makefile cleanup.

2014-12-09 Thread Jon A. Cruz
Split out directory creation to leverage order only prerequisites. Signed-off-by: Jon A. Cruz j...@osg.samsung.com --- doc/doxygen/Makefile.am | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/doc/doxygen/Makefile.am b/doc/doxygen/Makefile.am index f8d636e

[PATCH 1/2] doc: General makefile cleanup.

2014-12-09 Thread Jon A. Cruz
to properly create directories on-demand. Changes also correct missing use of $(builddir) that has gone unnoticed as it defaults to the current directory ('.'). Signed-off-by: Jon A. Cruz j...@osg.samsung.com --- doc/publican/Makefile.am | 77 +--- 1

[PATCH 0/2] doc: General makefile cleanup.

2014-12-09 Thread Jon A. Cruz
These cover some basic makefile cleanup to improve dependency graph generation in preparation for including more generated content in the DocBook output. Jon A. Cruz (2): doc: General makefile cleanup. doc: Minor makefile cleanup. doc/doxygen/Makefile.am | 20 - doc/publican

Re: [PATCH 1/2] doc: General makefile cleanup.

2014-12-09 Thread Jon A. Cruz
On 12/09/2014 12:00 PM, Bill Spitzak wrote: Did you see the patch I posted that merged the client/server stuff together into rules using % so that it is easier to add more doxygen-produced chapters? Yes, but it did appear to not be much in contention with these. I figured that I could easily

Re: [PATCH libinput 4/6] doc: add the various events to the doxygen groups

2014-12-09 Thread Jon A. Cruz
On 12/09/2014 04:34 PM, Peter Hutterer wrote: Makes them show up on the respective page and in the data structures list doxygen generates. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/libinput.h | 29 + 1 file changed, 29 insertions(+)

Re: [PATCH wayland-web] Adding notes regarding Arch Linux dependencies for DocBook.

2014-12-09 Thread Jon A. Cruz
On 12/09/2014 08:35 AM, Derek Foreman wrote: Any way we can print a more descriptive error at failure time instead of just hiding a clue in the docs? Or can we just disable docbook if deps aren't present? I'm not certain Arch will be the only distribution to ever have this problem, and

Re: [PATCH] doc: Reduce the validation errors of the docbook input

2014-12-11 Thread Jon A. Cruz
On 12/09/2014 07:33 PM, Bill Spitzak wrote: PS: it would be useful if somebody who actually knows something about xslt would come up with a way to translate a block of text makde of para commands unchanged, but add para around plain text. Most of the difficulty is that doxygen's output is

[PATCH 1/2] doc: Switch from static image files to generated diagrams.

2014-12-12 Thread Jon A. Cruz
Switches diagrams from using static PNG images to instead generate them via simple graphviz DOT markup files. Signed-off-by: Jon A. Cruz j...@osg.samsung.com --- configure.ac | 13 + doc/doxygen/Makefile.am| 15 -- doc

[PATCH 2/2] doc: Create hot-linked areas in documents.

2014-12-12 Thread Jon A. Cruz
Added xslt processing to give DocBook output diagram image maps/hot-linked areas consistent with those automatically generated by Doxygen. Signed-off-by: Jon A. Cruz j...@osg.samsung.com --- doc/doxygen/Makefile.am | 10 +++-- doc/publican/Makefile.am | 21

[PATCH 0/2] doc: Switch to generated diagrams with hot-linked areas.

2014-12-12 Thread Jon A. Cruz
diagrams to any DocBook pages as needed. Jon A. Cruz (2): doc: Switch from static image files to generated diagrams. doc: Create hot-linked areas in documents. configure.ac | 13 doc/doxygen/Makefile.am| 19 +- doc

[PATCH libinput] Initial move of some wiki contents into main documentation.

2014-12-16 Thread Jon A. Cruz
and thus for overall shorter documentation. Signed-off-by: Jon A. Cruz j...@osg.samsung.com --- configure.ac | 9 doc/Makefile.am | 18 doc/absolute-axes.dox| 37 doc/clickpad-softbuttons.dox | 45

Re: [PATCH libinput] Initial move of some wiki contents into main documentation.

2014-12-17 Thread Jon A. Cruz
On 12/17/2014 02:10 PM, Peter Hutterer wrote: diff --git a/configure.ac b/configure.ac index 33e380c..329f224 100644 --- a/configure.ac +++ b/configure.ac @@ -76,6 +76,15 @@ else fi AM_CONDITIONAL([HAVE_DOXYGEN], [test x$have_doxygen = xyes]) +AC_PATH_PROG(DOT, dot) +if test x$DOT =

[PATCH libinput] Initial move of some wiki contents into main documentation.

2014-12-17 Thread Jon A. Cruz
and thus for overall shorter documentation. Signed-off-by: Jon A. Cruz j...@osg.samsung.com --- configure.ac | 9 ++ doc/Makefile.am | 18 +--- doc/absolute-axes.dox| 64 ++ doc/clickpad-softbuttons.dox | 67

[PATCH libinput v3 2/2] Added configure option for documentation build.

2014-12-18 Thread Jon A. Cruz
Added option with fallback of 'auto' to control building of documentation. Signed-off-by: Jon A. Cruz j...@osg.samsung.com --- configure.ac| 72 ++--- doc/Makefile.am | 2 +- 2 files changed, 55 insertions(+), 19 deletions(-) diff --git

[PATCH libinput v3 1/2] Initial move of some wiki contents into main documentation.

2014-12-18 Thread Jon A. Cruz
and thus for overall shorter documentation. Signed-off-by: Jon A. Cruz j...@osg.samsung.com --- configure.ac | 9 ++ doc/Makefile.am | 18 +--- doc/absolute-axes.dox| 64 ++ doc/clickpad-softbuttons.dox | 67

[PATCH libinput v3 0/2] Moving wiki contents into doxygen.

2014-12-18 Thread Jon A. Cruz
Initial round of moving certain wiki contents into doxygen build. Jon A. Cruz (2): Initial move of some wiki contents into main documentation. Added configure option for documentation build. configure.ac | 63 +++-- doc/Makefile.am

Re: [PATCH libinput v3 2/2] Added configure option for documentation build.

2014-12-18 Thread Jon A. Cruz
On 12/18/2014 02:30 PM, Peter Hutterer wrote: that's quite unusual. libinput.doxygen itself has no dependency on dot or doxygen, so I don't think moving this here is helpful, it just hides it away from a known location. ACK to the rest of the patch, I'll just move this bit back to

Re: [PATCH wayland] doc: Fill in high level description for Surfaces

2014-12-22 Thread Jon A. Cruz
On 12/19/2014 04:25 AM, Pekka Paalanen wrote: On Fri, 12 Dec 2014 20:29:29 + Daniel Stone dan...@fooishbar.org wrote: Hi, On Friday, December 12, 2014, Bill Spitzak spit...@gmail.com wrote: ... I would avoid the use of the term double buffered. Possible alternative: The change does

[PATCH v2 3/3] doc: update diagrams for compatibility.

2014-12-23 Thread Jon A. Cruz
Change attribute separators for compatiblity with graphviz older than 2.30. Signed-off-by: Jon A. Cruz j...@osg.samsung.com --- doc/doxygen/dot/wayland-architecture.gv | 44 ++--- doc/doxygen/dot/x-architecture.gv | 50 - 2 files

[PATCH v2 2/3] doc: Create hot-linked areas in documents.

2014-12-23 Thread Jon A. Cruz
Added xslt processing to give DocBook output diagram image maps/hot-linked areas consistent with those automatically generated by Doxygen. Signed-off-by: Jon A. Cruz j...@osg.samsung.com --- doc/doxygen/Makefile.am | 10 +++-- doc/publican/Makefile.am | 21

[PATCH v2 0/3] doc: Switch to generated diagrams with hot-linked areas.

2014-12-23 Thread Jon A. Cruz
with the way Doxygen does. This should now make it easy to add additional diagrams to any DocBook pages as needed. Jon A. Cruz (3): doc: Switch from static image files to generated diagrams. doc: Create hot-linked areas in documents. doc: update diagrams for compatibility. configure.ac

[PATCH v2 1/3] doc: Switch from static image files to generated diagrams.

2014-12-23 Thread Jon A. Cruz
Switches diagrams from using static PNG images to instead generate them via simple graphviz DOT markup files. Signed-off-by: Jon A. Cruz j...@osg.samsung.com --- configure.ac | 13 + doc/doxygen/Makefile.am| 15 -- doc

Re: [PATCH wayland] test-runner: wait for concrete pid

2015-02-02 Thread Jon A. Cruz
be separate from the issue addressed by this patch. Reviewed-by: Jon A. Cruz j...@osg.samsung.com On 02/02/2015 01:40 AM, Marek Chalupa wrote: After running a test in fork, we were waiting for any child to terminate. It is OK unless the child forks again. If the child calls fork, the waitid can

Re: [PATCH] egl, wayland: RGB565 format support on Back-buffer

2015-02-06 Thread Jon A. Cruz
My initial concern with this is that it changes from one hardcoding to two hardcodings. Is 565 the only other format that will need to be supported? Could XRGB888 or others also be needed? If this needs changing it might be good to be sure it is comprehensive. On 02/03/2015 02:52 PM, Dongwon

Re: [PATH wayland] allow to set server socket dir on a different directory than XDG_RUNTIME_DIR

2015-02-06 Thread Jon A. Cruz
LGTM Reviewed-by: Jon A. Cruz j...@osg.samsung.com On 02/05/2015 02:14 AM, Bettio, Davide wrote: commit 68beb2b60f851c74b982b0a23da4bb1ce375efcf Author: Davide Bettio davide.bet...@ispirata.com Date: Wed Feb 4 13:46:19 2015 +0100 Allow to explicitly set wayland server socket dir

Re: [PATH wayland] allow clients to connect to a socket located on a different dir than XDG_RUNTIME_DIR

2015-02-06 Thread Jon A. Cruz
Looks good (however I did hit some odd formatting error with the patch file itself) Reviewed-by: Jon A. Cruz j...@osg.samsung.com On 02/05/2015 08:42 AM, Bettio, Davide wrote: commit 1ebae6d4f27ff0d336f2df0b8821099d2b2e510e Author: Davide Bettio davide.bet...@ispirata.com Date: Thu Feb 5

Re: [PATCH] egl, wayland: RGB565 format support on Back-buffer

2015-02-06 Thread Jon A. Cruz
On 02/06/2015 03:50 PM, Bryce Harrington wrote: On Fri, Feb 06, 2015 at 12:29:02PM -0800, Jon A. Cruz wrote: My initial concern with this is that it changes from one hardcoding to two hardcodings. Is 565 the only other format that will need to be supported? Could XRGB888 or others also

Re: [PATCH weston] tests: Skip buffer count test if wayland EGL extension isn't present

2015-01-22 Thread Jon A. Cruz
On 01/20/2015 11:16 AM, Derek Foreman wrote: This also skips the test when running on the headless backend. Signed-off-by: Derek Foreman der...@osg.samsung.com Looks good. One less failure here. Reviewed-by: Jon A. Cruz j...@osg.samsung.com --- tests/buffer-count-test.c | 5 + 1

[PATCH v3 3/3] doc: update diagrams for compatibility.

2015-01-28 Thread Jon A. Cruz
Change attribute separators for compatiblity with graphviz older than 2.30. Signed-off-by: Jon A. Cruz j...@osg.samsung.com --- doc/doxygen/dot/wayland-architecture.gv | 44 ++--- doc/doxygen/dot/x-architecture.gv | 50 - 2 files

[PATCH v3 1/3] doc: Switch from static image files to generated diagrams.

2015-01-28 Thread Jon A. Cruz
Switches diagrams from using static PNG images to instead generate them via simple graphviz DOT markup files. Signed-off-by: Jon A. Cruz j...@osg.samsung.com --- configure.ac | 13 + doc/doxygen/Makefile.am| 15 +- doc

[PATCH v3 0/3] doc: Switch to generated diagrams with hot-linked areas.

2015-01-28 Thread Jon A. Cruz
with the way Doxygen does. This should now make it easy to add additional diagrams to any DocBook pages as needed. Jon A. Cruz (3): doc: Switch from static image files to generated diagrams. doc: Create hot-linked areas in documents. doc: update diagrams for compatibility. configure.ac

Re: [PATCH weston] desktop-shell: Remove unnecessary type casts

2015-01-30 Thread Jon A. Cruz
Looks good. Reviewed-by: Jon A. Cruz j...@osg.samsung.com On 01/30/2015 11:24 AM, Derek Foreman wrote: Remove a few instances of casting weston_seat to weston_seat. Signed-off-by: Derek Foreman der...@osg.samsung.com --- desktop-shell/shell.c | 15 +++ 1 file changed, 7

[PATCH] doc: Fix out-of-tree build and also distcheck

2015-01-30 Thread Jon A. Cruz
Corrects an issue that would cause out-of-tree builds to fail and also a few items that would cause distcheck to fail. Signed-off-by: Jon A. Cruz j...@osg.samsung.com --- doc/doxygen/Makefile.am | 4 +++- doc/publican/Makefile.am | 7 ++- 2 files changed, 9 insertions(+), 2 deletions

Re: [PATCH] doc: Correct missing file warnings from files explicitly moved during build.

2015-01-23 Thread Jon A. Cruz
07, 2015 at 06:44:06PM -0800, Jon A. Cruz wrote: --- doc/publican/Makefile.am | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/publican/Makefile.am b/doc/publican/Makefile.am index 278da12..1e3cde0 100644 --- a/doc/publican/Makefile.am +++ b/doc/publican/Makefile.am @@ -91,13

Re: Error making docs for libinput

2015-01-23 Thread Jon A. Cruz
On 01/23/2015 06:34 PM, Bill Spitzak wrote: When I run make on libinput I get these errors: GENhtml/index.html Warning: ignoring unsupported tag `ALLOW_UNICODE_NAMES=' at line 79, file - Warning: ignoring unsupported tag `MAN_SUBDIR =' at line 1787, file - Warning:

Re: [PATCH] doc/publican/Makefile.am: Add a missing order-only prerequisite

2015-01-06 Thread Jon A. Cruz
On 01/06/2015 08:35 AM, Rui Matos wrote: Otherwise a parallel make invocation could fail due to the directory not existing. Signed-off-by: Rui Matos tiagoma...@gmail.com Looks good. Reviewed-by: Jon A. Cruz j...@osg.samsung.com --- doc/publican/Makefile.am | 2 +- 1 file changed, 1

[PATCH] doc: Correct missing file warnings from files explicitly moved during build.

2015-01-07 Thread Jon A. Cruz
--- doc/publican/Makefile.am | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/publican/Makefile.am b/doc/publican/Makefile.am index 278da12..1e3cde0 100644 --- a/doc/publican/Makefile.am +++ b/doc/publican/Makefile.am @@ -91,13 +91,19 @@ $(builddir)/en-US/ProtocolInterfaces.xml:

Re: [PATCH V3] doc: Intro text for doxygen output in it's own file

2015-01-29 Thread Jon A. Cruz
Looks good as far as I can tell. I especially like that the content was moved out of the xsl and into data files. Reviewed-by: Jon A. Cruz j...@osg.samsung.com Tested-by: Jon A. Cruz j...@osg.samsung.com On 01/28/2015 06:44 PM, Bill Spitzak wrote: (This patch has been modified to apply atop

Re: [PATCH wayland v2] doc: Fill in high level description for Surfaces

2015-01-29 Thread Jon A. Cruz
Looks good. Reviewed-by: Jon A. Cruz j...@osg.samsung.com On 01/27/2015 04:32 PM, Bryce Harrington wrote: Signed-off-by: Bryce Harrington br...@osg.samsung.com --- doc/publican/sources/Protocol.xml | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/doc

[PATCH weston] Added simple unit/integration test framework and corresponding test program.

2015-04-29 Thread Jon A. Cruz
Added a simple C-based test framework and an example program that uses it to run through some simple wayland client checks. Signed-off-by: Jon A. Cruz j...@osg.samsung.com --- .gitignore| 3 + Makefile.am | 34 +++ tools/Doxyfile

[PATCH weston v2] Refactored simple unit/integration test framework and corresponding test program.

2015-05-05 Thread Jon A. Cruz
Refactored to a simple C-based test framework and an example program that uses it to run through some simple wayland client checks. Signed-off-by: Jon A. Cruz j...@osg.samsung.com --- .gitignore| 3 + Makefile.am | 34 +++ tools/Doxyfile

Re: [PATCH weston] Added simple unit/integration test framework and corresponding test program.

2015-05-05 Thread Jon A. Cruz
On 05/04/2015 12:22 PM, Pekka Paalanen wrote: On Wed, 29 Apr 2015 15:31:45 -0700 Jon A. Cruz j...@osg.samsung.com wrote: Added a simple C-based test framework and an example program that uses it to run through some simple wayland client checks. Hi Jon, I said I didn't have time to look

Re: [PATCH weston] compositor: Respect WESTON_BUILD_DIR env var in weston_load_module

2015-06-05 Thread Jon A. Cruz
use and follow up. Might just be choice of name and reusing a term from a slightly different context... -- Jon A. Cruz - Senior Open Source Developer Samsung Open Source Group j...@osg.samsung.com ___ wayland-devel mailing list wayland-devel

Re: [PATCH v2 weston] compositor: Respect WESTON_BUILD_DIR env var in weston_load_module

2015-06-09 Thread Jon A. Cruz
as technically null-termination is not guaranteed. -- Jon A. Cruz - Senior Open Source Developer Samsung Open Source Group j...@osg.samsung.com ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo

Re: [PATCH v2 weston] compositor: Respect WESTON_BUILD_DIR env var in weston_load_module

2015-06-09 Thread Jon A. Cruz
On 06/09/2015 04:55 PM, Derek Foreman wrote: On 09/06/15 06:24 PM, Jon A. Cruz wrote: On 06/08/2015 09:46 AM, Derek Foreman wrote: We were loading modules out of the system dirs unconditionally, so tests that loaded modules would use the system ones, or fail if they weren't installed

Re: [PATCH weston] don't attempt to start input method if path is empty

2015-06-09 Thread Jon A. Cruz
*text_backend) if (!text_backend-input_method.path) return; + if (strcmp(text_backend-input_method.path, ) == 0) + return; + if (text_backend-input_method.process.pid != 0) return; -- Jon A. Cruz - Senior Open Source Developer

Re: [PATCH weston] compositor: Separate hardcoded backend related code from compositor

2015-06-23 Thread Jon A. Cruz
://lists.freedesktop.org/mailman/listinfo/wayland-devel -- Jon A. Cruz - Senior Open Source Developer Samsung Open Source Group j...@osg.samsung.com ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo

Re: [PATCH 01/14] tests: test set for ivi-surface normal use case with helper client

2015-06-22 Thread Jon A. Cruz
(ivi_layout_runner, basic_test_names) -- Jon A. Cruz - Senior Open Source Developer Samsung Open Source Group j...@osg.samsung.com ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH] tests: Don't increment variables inside an assert()

2015-06-19 Thread Jon A. Cruz
framework could fail immediately due to this. Looks good. Reviewed-by: Jon A. Cruz j...@osg.samsung.com -- Jon A. Cruz - Senior Open Source Developer Samsung Open Source Group j...@osg.samsung.com ___ wayland-devel mailing list wayland-devel

Re: [PATCH weston v5 2/6] By default, stop test execution if unrecognized parameters are encountered.

2015-06-25 Thread Jon A. Cruz
On 06/25/2015 05:36 AM, Pekka Paalanen wrote: On Sat, 20 Jun 2015 15:47:44 -0700 Jon A. Cruz j...@osg.samsung.com wrote: Signed-off-by: Jon A. Cruz j...@osg.samsung.com --- tools/zunitc/src/main.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/tools

Re: [PATCH wayland] cosmetic: gratuitous whitespace changes in event-loop.c

2015-06-18 Thread Jon A. Cruz
); + TFD_CLOEXEC | TFD_NONBLOCK); source-func = func; return add_source(loop, source-base, WL_EVENT_READABLE, data); Looks good. (Seems like someone had tabs set to 4 and didn't notice.) Reviewed-by: Jon A. Cruz j...@osg.samsung.com -- Jon

Re: [PATCH weston 2/2] Do not install the new helpers macro header file.

2015-06-18 Thread Jon A. Cruz
we want to use, can someone point me to the preferred version? (I had used the text from one of the recent license change patches, but guess I might have missed the final form) -- Jon A. Cruz - Senior Open Source Developer Samsung Open Source Group j...@osg.samsung.com

Re: [PATCH wayland] build: Use AM_CFLAGS instead of GCC_CFLAGS everywhere

2015-06-18 Thread Jon A. Cruz
this in the documentation when checking for some other things I was adding (and disentangling for testing). Reviewed-by: Jon A. Cruz j...@osg.samsung.com -- Jon A. Cruz - Senior Open Source Developer Samsung Open Source Group j...@osg.samsung.com ___ wayland-devel

Re: [PATCH weston] build: Use AM_CFLAGS instead of GCC_CFLAGS

2015-06-18 Thread Jon A. Cruz
A. Cruz j...@osg.samsung.com -- Jon A. Cruz - Senior Open Source Developer Samsung Open Source Group j...@osg.samsung.com ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

[PATCH weston v5 2/6] By default, stop test execution if unrecognized parameters are encountered.

2015-06-20 Thread Jon A. Cruz
Signed-off-by: Jon A. Cruz j...@osg.samsung.com --- tools/zunitc/src/main.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/tools/zunitc/src/main.c b/tools/zunitc/src/main.c index cc86185..8179807 100644 --- a/tools/zunitc/src/main.c +++ b/tools/zunitc/src/main.c

[PATCH weston v5 5/6] Converted the config parser test to the new framework.

2015-06-20 Thread Jon A. Cruz
Signed-off-by: Jon A. Cruz j...@osg.samsung.com --- Makefile.am| 9 +- tests/config-parser-test.c | 368 + 2 files changed, 310 insertions(+), 67 deletions(-) diff --git a/Makefile.am b/Makefile.am index f0ed4d2..8234d2a 100644

[PATCH weston v5 3/6] Enables output in the Test Anything Protocol (TAP) format.

2015-06-20 Thread Jon A. Cruz
Adds basic support for optionally outputting in the Test Anything Protocol (TAP) format. This format is a bit older and simplistic, but certain tools handle it well. https://testanything.org/ Signed-off-by: Jon A. Cruz j...@osg.samsung.com --- Makefile.am | 2 + tools

[PATCH weston v5 0/6] Refactored simple unit/integration test framework and corresponding test program.

2015-06-20 Thread Jon A. Cruz
Doxygen config files to non-defaults only. - Relocated Doxygen specific input files to match Wayland structure. Jon A. Cruz (6): Added simple unit/integration test framework and corresponding test program. By default, stop test execution if unrecognized parameters are encountered

[PATCH weston v5 4/6] Enables output in the JUnit XML format.

2015-06-20 Thread Jon A. Cruz
-by: Jon A. Cruz j...@osg.samsung.com --- Makefile.am | 10 + configure.ac | 6 + tools/zunitc/inc/zunitc/zunitc.h | 10 + tools/zunitc/src/zuc_junit_reporter.c | 464 ++ tools/zunitc/src/zuc_junit_reporter.h

[PATCH weston v5 6/6] Adding doxygen setup and info for the testing framework.

2015-06-20 Thread Jon A. Cruz
Signed-off-by: Jon A. Cruz j...@osg.samsung.com --- .gitignore| 2 + doc/doxygen/devtools.dox | 55 doc/doxygen/tooldev.doxygen | 11 ++ doc/doxygen/tools.dox | 32 doc/doxygen/tools.doxygen | 11 ++ doc

Re: [PATCH v4 1/6] Added simple unit/integration test framework and corresponding test program.

2015-06-24 Thread Jon A. Cruz
On 06/24/2015 09:32 AM, Bill Spitzak wrote: On Tue, Jun 23, 2015 at 9:55 PM, Jon A. Cruz j...@osg.samsung.com wrote: Looking into it more, I think I've figured out much of that on my part comes from C++ and other OO languages I've worked in. Especially with C++ one should start a class

Re: [PATCH 06/14] tests: test set for ivi-layer bad condition with helper-client

2015-06-24 Thread Jon A. Cruz
after a ivi_surface in render order is destoryed Signed-off-by: Nobuhiko Tanibata nobuhiko_tanib...@xddp.denso.co.jp Reviewed-by: Pekka Paalanen pekka.paala...@collabora.co.uk Looks good. Reviewed-by: Jon A. Cruz j...@osg.samsung.com --- tests/ivi_layout-test-plugin.c | 113

Re: [PATCH 02/14] tests: test set for ivi-surface bad condition with helper client

2015-06-24 Thread Jon A. Cruz
-surface, and commit_changes Signed-off-by: Nobuhiko Tanibata nobuhiko_tanib...@xddp.denso.co.jp Reviewed-by: Pekka Paalanen pekka.paala...@collabora.co.uk Looks good. Reviewed-by: Jon A. Cruz j...@osg.samsung.com --- tests/ivi_layout-test-plugin.c | 134

Re: [PATCH 03/14] tests: test set for ivi-surface with bad condition in server side

2015-06-24 Thread Jon A. Cruz
...@collabora.co.uk Looks good. Reviewed-by: Jon A. Cruz j...@osg.samsung.com --- tests/ivi_layout-internal-test.c | 74 1 file changed, 74 insertions(+) diff --git a/tests/ivi_layout-internal-test.c b/tests/ivi_layout-internal-test.c index 3fb5148..3b9d6b9

Re: [PATCH 04/14] tests: test set for ivi-layer normal use case with helper client

2015-06-24 Thread Jon A. Cruz
Tanibata nobuhiko_tanib...@xddp.denso.co.jp Reviewed-by: Pekka Paalanen pekka.paala...@collabora.co.uk Looks good. Reviewed-by: Jon A. Cruz j...@osg.samsung.com --- tests/ivi-test.h | 4 tests/ivi_layout-test-plugin.c | 42

Re: [PATCH 01/14] tests: test set for ivi-surface normal use case with helper client

2015-06-24 Thread Jon A. Cruz
With those details explained, this looks good. Reviewed-by: Jon A. Cruz j...@osg.samsung.com On 06/23/2015 05:56 AM, Pekka Paalanen wrote: On Mon, 22 Jun 2015 17:28:23 -0700 Jon A. Cruz j...@osg.samsung.com wrote: On 06/21/2015 11:33 PM, Nobuhiko Tanibata wrote: From: Nobuhiko Tanibata

Re: [PATCH 09/14] tests: test set for ivi-screen with bad condition in server side

2015-06-24 Thread Jon A. Cruz
order with bad parameter - destroy ivi-layer in the ivi-screen and call commit_changes Signed-off-by: Nobuhiko Tanibata nobuhiko_tanib...@xddp.denso.co.jp Reviewed-by: Pekka Paalanen pekka.paala...@collabora.co.uk Looks good. Reviewed-by: Jon A. Cruz j...@osg.samsung.com --- tests/ivi_layout

Re: [PATCH 08/14] tests: test set for ivi-screen normal use case in server side

2015-06-24 Thread Jon A. Cruz
of ivi-layers in ivi-screen Signed-off-by: Nobuhiko Tanibata nobuhiko_tanib...@xddp.denso.co.jp Reviewed-by: Pekka Paalanen pekka.paala...@collabora.co.uk Looks good. Reviewed-by: Jon A. Cruz j...@osg.samsung.com --- tests/ivi_layout-internal-test.c | 105

Re: [PATCH 07/14] tests: test set for ivi-layer with bad condition in server side

2015-06-24 Thread Jon A. Cruz
Looks good. Reviewed-by: Jon A. Cruz j...@osg.samsung.com --- tests/ivi_layout-internal-test.c | 307 +++ 1 file changed, 307 insertions(+) diff --git a/tests/ivi_layout-internal-test.c b/tests/ivi_layout-internal-test.c index fc7527e..befdf94 100644

Re: [PATCH 05/14] tests: test set for ivi-layer normal use case in server side

2015-06-24 Thread Jon A. Cruz
- orientation - dimension - position - destination rectangle - source rectangle Signed-off-by: Nobuhiko Tanibata nobuhiko_tanib...@xddp.denso.co.jp Reviewed-by: Pekka Paalanen pekka.paala...@collabora.co.uk Looks good. Reviewed-by: Jon A. Cruz j...@osg.samsung.com --- tests/ivi_layout

Re: [PATCH 09/14] tests: test set for ivi-screen with bad condition in server side

2015-06-24 Thread Jon A. Cruz
order with bad parameter - destroy ivi-layer in the ivi-screen and call commit_changes Signed-off-by: Nobuhiko Tanibata nobuhiko_tanib...@xddp.denso.co.jp Reviewed-by: Pekka Paalanen pekka.paala...@collabora.co.uk Looks good. Reviewed-by: Jon A. Cruz j...@osg.samsung.com --- tests/ivi_layout

Re: [PATCH 14/14] tests: test set for ivi-shell notification with bad condition in server side

2015-06-24 Thread Jon A. Cruz
parameter Signed-off-by: Nobuhiko Tanibata nobuhiko_tanib...@xddp.denso.co.jp Reviewed-by: Pekka Paalanen pekka.paala...@collabora.co.uk Looks good. Reviewed-by: Jon A. Cruz j...@osg.samsung.com --- tests/ivi_layout-internal-test.c | 69 1 file

Re: [PATCH 10/14] tests: make the test context persistent

2015-06-24 Thread Jon A. Cruz
serialization checks, rename the global, rewrite commit message.] Signed-off-by: Pekka Paalanen pekka.paala...@collabora.co.uk Looks good. Reviewed-by: Jon A. Cruz j...@osg.samsung.com --- tests/ivi_layout-test-plugin.c | 45 -- 1 file changed, 35 insertions

Re: [PATCH 13/14] tests: test set for ivi-shell notification in bad condition with helper client

2015-06-24 Thread Jon A. Cruz
-by: Nobuhiko Tanibata nobuhiko_tanib...@xddp.denso.co.jp Reviewed-by: Pekka Paalanen pekka.paala...@collabora.co.uk Looks good. Reviewed-by: Jon A. Cruz j...@osg.samsung.com --- tests/ivi_layout-test-plugin.c | 22 ++ tests/ivi_layout-test.c| 1 + 2 files changed

Re: [PATCH 11/14] tests: test set for ivi-shell notification normal use case with helper client

2015-06-24 Thread Jon A. Cruz
-surface configure - notification of creating ivi-surface - notification of removing ivi-surface Signed-off-by: Nobuhiko Tanibata nobuhiko_tanib...@xddp.denso.co.jp Reviewed-by: Pekka Paalanen pekka.paala...@collabora.co.uk Looks good. Reviewed-by: Jon A. Cruz j...@osg.samsung.com

Re: [PATCH v4 1/6] Added simple unit/integration test framework and corresponding test program.

2015-06-23 Thread Jon A. Cruz
considered during design and implementation. Signed-off-by: Jon A. Cruz j...@osg.samsung.com --- .gitignore |3 + Makefile.am| 87 +- tools/waycheck/moretest.c | 89 ++ tools/waycheck/rough_draw.c

Re: [PATCH weston 04/11] make the backends compositor-neutral

2015-06-23 Thread Jon A. Cruz
to me like something we can clean up in a later patchset. -- Jon A. Cruz - Senior Open Source Developer Samsung Open Source Group j...@osg.samsung.com ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman

Re: [PATCH weston 06/11] build a libweston.so used by the weston binary

2015-06-23 Thread Jon A. Cruz
been in a few situations where this really helps. Looks good. Reviewed-by: Jon A. Cruz j...@osg.samsung.com --- Makefile.am | 59 ++- configure.ac | 3 +++ src/input.c | 2 +- 3 files changed, 42 insertions(+), 22 deletions

Re: [PATCH weston 04/11] make the backends compositor-neutral

2015-06-23 Thread Jon A. Cruz
Just a few minor low-level items in this feedback... On 06/22/2015 01:02 PM, Giulio Camuffo wrote: The backends used to have lots of code dealing with weston specific configs. To allow them to be used by other compositors with their own configurations remove all the usage of weston_config from

Re: [PATCH weston 02/11] compositor: add API to manage compositor instances

2015-06-23 Thread Jon A. Cruz
Oh I forgot an item on the placement of comments. On 06/23/2015 04:31 PM, Jon A. Cruz wrote: Minor doxygen note: the explicit \brief is not needed, and the brief description should end with a '.' to allow the auto-brief to pick it up. Overall looks good, but missing a few extra

Re: [PATCH weston 02/11] compositor: add API to manage compositor instances

2015-06-23 Thread Jon A. Cruz
which is set by the libweston application. - weston_compositor_destroy(compositor) is called by the libweston application when tearing down the compositor. The compositor is destroyed and the memory freed. --- Reviewed-by: Jon A. Cruz j...@osg.samsung.com src/compositor-drm.c | 8

Re: [PATCH weston v3 1/5] Expanded unit test framework to cover base requirements.

2015-06-16 Thread Jon A. Cruz
On 06/16/2015 06:21 AM, Pekka Paalanen wrote: On Tue, 9 Jun 2015 15:15:52 +1000 Peter Hutterer peter.hutte...@who-t.net wrote: On Thu, Jun 04, 2015 at 12:50:47AM -0700, Jon A. Cruz wrote: On 06/03/2015 10:15 PM, Peter Hutterer wrote: On Tue, May 26, 2015 at 04:06:37PM -0700, Jon A. Cruz

Re: [PATCH weston v2 2/4] Moved helper macro to a discrete include file.

2015-06-16 Thread Jon A. Cruz
On 06/16/2015 02:48 AM, Pekka Paalanen wrote: On Mon, 15 Jun 2015 15:37:08 -0700 Jon A. Cruz j...@osg.samsung.com wrote: To help reduce code duplication and also 'kitchen-sink' includes the ARRAY_LENGTH macro was moved to a stand-alone file and referenced from the sources consuming

[PATCH weston 2/2] Do not install the new helpers macro header file.

2015-06-16 Thread Jon A. Cruz
Signed-off-by: Jon A. Cruz j...@osg.samsung.com --- Makefile.am | 1 - 1 file changed, 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 1cfc982..125d8c3 100644 --- a/Makefile.am +++ b/Makefile.am @@ -190,7 +190,6 @@ westoninclude_HEADERS = \ src

[PATCH weston 1/2] Added new include file to all SOURCES variables with files that use it.

2015-06-16 Thread Jon A. Cruz
Signed-off-by: Jon A. Cruz j...@osg.samsung.com --- Makefile.am | 129 1 file changed, 95 insertions(+), 34 deletions(-) diff --git a/Makefile.am b/Makefile.am index 261798c..1cfc982 100644 --- a/Makefile.am +++ b/Makefile.am @@ -86,6

[PATCH weston 0/2] Cleanup addition of helpers.h to build.

2015-06-16 Thread Jon A. Cruz
This covers a couple of follow-up items Pekka spotted in the patchset moving a few common macros into the new helpers.h header. Jon A. Cruz (2): Added new include file to all SOURCES variables with files that use it. Do not install the new helpers macro header file. Makefile.am

[PATCH weston 4/4] Unified multiple definitions of container_of() macro.

2015-06-12 Thread Jon A. Cruz
Removed duplicate definitions of the container_of() macro and refactored sources to use the single implementation. Signed-off-by: Jon A. Cruz j...@osg.samsung.com --- clients/clickdot.c | 1 + clients/desktop-shell.c | 1 + clients/window.h| 4

[PATCH weston 2/4] Moved helper macro to a discrete include file.

2015-06-12 Thread Jon A. Cruz
To help reduce code duplication and also 'kitchen-sink' includes the ARRAY_LENGTH macro was moved to a stand-alone file and referenced from the sources consuming it. Other macros will be added in subsequent passes. Signed-off-by: Jon A. Cruz j...@osg.samsung.com --- Makefile.am

  1   2   >