[PATCH libinput 4/9] evdev: add evdev_reject_device to reject a couple of oddball devices

2015-03-16 Thread Peter Hutterer
We really don't need to deal with devices that have x but not y or vice versa. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev.c | 23 + test/device.c | 103 ++ 2 files changed, 126 insertions(+) diff

[PATCH libinput 2/9] touchpad: check for the fake_resolution boolean instead of a res value

2015-03-16 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad-buttons.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/evdev-mt-touchpad-buttons.c b/src/evdev-mt-touchpad-buttons.c index 3ca37b7..18c32fd 100644 --- a/src/evdev-mt-touchpad-buttons.c

[PATCH libinput] tools: don't use deprecated gdk_cursor_new()

2015-03-17 Thread Peter Hutterer
Replaced by gdk_cursor_new_from_display() which means we need to tickle the event until it spits out a GdkDisplay. Deprecated in gdk 3.16 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- If anyone can do a quick double-check that I'm not mis-using gdk here please that'd be appreciated

[PATCH libinput 1/4] filter: switch to normalized_coords

2015-03-18 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad.c | 26 +++-- src/evdev.c | 7 +-- src/filter-private.h| 7 --- src/filter.c| 50 +++-- src/filter.h

[PATCH libinput 4/4] test: add accel test for direction change

2015-03-18 Thread Peter Hutterer
Make sure that if we go in one direction, then change flip over to the other direction we actually stop going into that direction, and the delta is lower than whatever the previous delta was (i.e. acceleration resets). Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/pointer.c

[PATCH libinput 2/4] Switch vector_get_direction to use doubles

2015-03-18 Thread Peter Hutterer
Delta movements on most slower movements are less than 1.0 per event, so we'd end up with an undefined direction for all of them. This led to the velocity being calculated across opposite movements rather than (as intended) across movements within a shared octant. Signed-off-by: Peter Hutterer

[PATCH libinput 3/4] filter: calculate the time delta correctly

2015-03-18 Thread Peter Hutterer
by the test suite. Actual effect was limited, since we cap out acceleration at max_accel we just hit this earlier and it stayed there. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/filter.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/filter.c b/src

Re: [RFC v2 libinput 0/2] Buttonset interface - numbered axes

2015-03-19 Thread Peter Hutterer
On Fri, Mar 20, 2015 at 10:19:06AM +1000, Peter Hutterer wrote: [...] 5) If a device has multiple axes of the same type, is the order supposed to be ABI? Example: gamepads tend to have two analog-sticks. How do applications reliably find the left and right stick? well, our promise

Re: [RFC v2 libinput 2/2] buttonset: implement buttonset handling for Wacom tablet pads

2015-03-19 Thread Peter Hutterer
On Thu, Mar 19, 2015 at 02:01:29PM -0700, Jason Gerecke wrote: David's already asked the API questions that popped in my head, so I'll just wait for feedback on his thread. As far as this patch goes, things look pretty good though there are two comments: On 3/17/2015 11:58 PM, Peter Hutterer

Re: [RFC v2 libinput 0/2] Buttonset interface - numbered axes

2015-03-19 Thread Peter Hutterer
On Thu, Mar 19, 2015 at 01:15:01PM +0100, David Herrmann wrote: Hi On Wed, Mar 18, 2015 at 7:58 AM, Peter Hutterer peter.hutte...@who-t.net wrote: This is a re-vamped version of the buttonset interface. Still WIP but I'd like to get some comments on the API. Changes to the last

Re: [PATCH weston 0/5] fix fbdev transforms

2015-03-19 Thread Peter Hutterer
On Thu, Mar 19, 2015 at 11:45:16AM +0200, Pekka Paalanen wrote: On Thu, 19 Mar 2015 07:13:18 +1000 Peter Hutterer peter.hutte...@who-t.net wrote: On Wed, Mar 18, 2015 at 01:14:52PM +0200, Pekka Paalanen wrote: On Wed, 18 Mar 2015 11:45:01 +0100 Thilo Cestonaro th...@cestona.ro wrote

Re: [Wayland, libinput] Question about libinput

2015-03-19 Thread Peter Hutterer
On Thu, Mar 19, 2015 at 02:29:05PM +0900, Beomho Seo wrote: On 03/12/2015 06:28 AM, Peter Hutterer wrote: On Wed, Mar 11, 2015 at 05:01:32PM +0900, Beomho Seo wrote: Hi everyone, I have a question about libinput. I will handle a rotary input device. It is able to provide angular

libinput - force-push to master

2015-03-19 Thread Peter Hutterer
I had a release script test gone bad and it pushed a fake 0.13.0 release. The commit was only sitting on master for a couple of minutes, I've force-pushed the previous HEAD (1ed07fedce45d817f70f56439aba6e13be7a) Just in case you see something odd, sorry about that. The false commit was

Re: [Wayland, libinput] Question about libinput

2015-03-19 Thread Peter Hutterer
On Thu, Mar 19, 2015 at 09:44:39PM +0900, Beomho Seo wrote: On 03/19/2015 07:25 PM, Peter Hutterer wrote: On Thu, Mar 19, 2015 at 02:29:05PM +0900, Beomho Seo wrote: On 03/12/2015 06:28 AM, Peter Hutterer wrote: On Wed, Mar 11, 2015 at 05:01:32PM +0900, Beomho Seo wrote: Hi everyone

Re: [PATCH libinput] touchpad: Remove unnecessary edge scroll threshold variable

2015-03-09 Thread Peter Hutterer
On Mon, Mar 09, 2015 at 02:22:56PM +0100, Hans de Goede wrote: Now that we've separate handling of the EDGE_NEW vs EDGE states in tp_edge_scroll_post_events() we can drop the threshold variable, in EDGE_NEW we always want to check against DEFAULT_SCROLL_THRESHOLD and in the EDGE state we only

[PATCH libinput 1/2] tablet: rely on libwacom for the list of axis capabilities

2015-03-09 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- configure.ac | 2 +- src/evdev-tablet.c | 56 +- 2 files changed, 27 insertions(+), 31 deletions(-) diff --git a/configure.ac b/configure.ac index 85db1fd..038022e 100644

[PATCH libinput 2/2] tablet: use libwacom_new_from_path() to handle more tablets

2015-03-09 Thread Peter Hutterer
Some tablets cannot be differentiated by pid/vid alone, use the device path instead - that gives libwacom the ability to extract the information required to handle the device (libwacom doesn't open the path, it just reads through the sysfs entry of the device). Signed-off-by: Peter Hutterer

[PATCH libinput 07/12] Use typesafe coordinates for scrolling events

2015-03-12 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad-edge-scroll.c | 8 ++-- src/evdev-mt-touchpad-gestures.c| 2 +- src/evdev.c | 81 + src/evdev.h | 6 +-- src/libinput

[PATCH libinput 02/12] evdev: add helper function to normalize delta coordinates

2015-03-12 Thread Peter Hutterer
No functional changes. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index 70c60ee..645a36b 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -224,6 +224,13

[PATCH libinput 11/12] Add another data type for discrete coordinates

2015-03-12 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad-edge-scroll.c | 8 +--- src/evdev.c | 27 --- src/libinput-private.h | 8 ++-- src/libinput.c | 12 +--- 4 files

Re: [RFC libinput 2/2] touchpad: Implement pinch gesture support (wip)

2015-03-12 Thread Peter Hutterer
On Wed, Mar 11, 2015 at 03:20:55PM +0100, Hans de Goede wrote: Implement touchpad pinch (and rotate) gesture support. WIP: TODO: fix testsuite. Signed-off-by: Hans de Goede hdego...@redhat.com looks good, almost all comments are just related to coding style/shuffling things around. fwiw,

[PATCH libinput 01/12] cosmetic: rename touch to t for consistency

2015-03-12 Thread Peter Hutterer
Everywhere else in the touchpad code we use t for the struct tp_touch. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad-edge-scroll.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/evdev-mt-touchpad-edge-scroll.c b/src/evdev-mt

[PATCH libinput 06/12] touchpad: switch delta handling to typesafe coordinates

2015-03-12 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad-edge-scroll.c | 26 src/evdev-mt-touchpad-gestures.c| 60 +++-- src/evdev-mt-touchpad-tap.c | 6 ++-- src/evdev-mt-touchpad.c | 34

[PATCH libinput 09/12] Use typesafe coordinates in touch events

2015-03-12 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev.c| 13 + src/libinput-private.h | 6 ++ src/libinput.c | 23 +-- 3 files changed, 16 insertions(+), 26 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index d1b0504

[PATCH libinput 00/12] typesafe coordinate wrappers

2015-03-12 Thread Peter Hutterer
libinput has two types of coordinates - device coordinates and coordinates normalized into the 1000 dpi default. we generally use int/double for those two, but it's not always clear or obvious which type of coordinates we're dealing with. So there's a risk of mixing them up and we may not notice

[PATCH libinput 03/12] evdev: start introducing some type-safety for device/normalized coordinates

2015-03-12 Thread Peter Hutterer
Make it clear where we're dealing with device coordinates and where we're dealing with DPI-normalized coordinates. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev.c| 88 +- src/evdev.h| 8 ++--- src

[PATCH libinput 12/12] Store unaccelerated delta as normalized_coords

2015-03-12 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/libinput.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/libinput.c b/src/libinput.c index 8db6997..96df44a 100644 --- a/src/libinput.c +++ b/src/libinput.c @@ -58,10 +58,9 @@ struct

[PATCH libinput 04/12] touchpad: change motion history to typesafe coords

2015-03-12 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad.c | 2 +- src/evdev-mt-touchpad.h | 7 +-- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index 8808850..ebe611f 100644 --- a/src/evdev-mt

[PATCH libinput 10/12] Split deltas/absolute coords in pointer events to separate fields

2015-03-12 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/libinput.c | 29 + 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/src/libinput.c b/src/libinput.c index 3b1d482..1a68069 100644 --- a/src/libinput.c +++ b/src/libinput.c @@ -57,8 +57,8

Re: [Wayland, libinput] Question about libinput

2015-03-11 Thread Peter Hutterer
On Wed, Mar 11, 2015 at 05:01:32PM +0900, Beomho Seo wrote: Hi everyone, I have a question about libinput. I will handle a rotary input device. It is able to provide angular information (increase, decrease), elocity and push/relase(like key) event. I hope to use libinput to handle rotary

Re: [PATCH libinput 1/2] tablet: rely on libwacom for the list of axis capabilities

2015-03-11 Thread Peter Hutterer
On Wed, Mar 11, 2015 at 04:12:58PM -0400, Benjamin Tissoires wrote: On Tue, Mar 10, 2015 at 1:03 AM, Peter Hutterer peter.hutte...@who-t.net wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- configure.ac | 2 +- src/evdev-tablet.c | 56

[PATCH libinput 2/3] touchpad: return normalized deltas from tp_get_delta

2015-03-05 Thread Peter Hutterer
-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad.c | 5 +++-- src/evdev-mt-touchpad.h | 7 +++ 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index b90d84c..9b06522 100644 --- a/src/evdev-mt-touchpad.c

[PATCH libinput 1/3] test: fix/disable two tap test for semi-mt devices

2015-03-05 Thread Peter Hutterer
the other order anyway). Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/touchpad.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/touchpad.c b/test/touchpad.c index 8077f8e..5c8f579 100644 --- a/test/touchpad.c +++ b/test/touchpad.c @@ -2570,8 +2570,8

[PATCH libinput 3/3] touchpad: change tap motion threshold to 3 mm

2015-03-05 Thread Peter Hutterer
this is currently more than 3mm] Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad-tap.c | 12 +--- src/evdev-mt-touchpad.h | 1 + 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/src/evdev-mt-touchpad-tap.c b/src/evdev-mt-touchpad-tap.c

[PATCH v2 libinput 5/3] touchpad: accumulate the initial scroll edge delta

2015-03-08 Thread Peter Hutterer
applies when exceeding the motion threshold, when the timeout triggers the switch to scrolling the first delta posted is the current delta. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Hans de Goede hdego...@redhat.com --- Changes to v1: - use TP_MM_TO_DPI_NORMALIZED - reset

[RFC PATCH] Pointer axis source events (for kinetic scrolling)

2015-03-08 Thread Peter Hutterer
This is a draft/RFC for adding axis sources to the wayland protocol and weston. It's an early version to spark discussion. libinput exports pointer axis sources with each event to tell the caller how an event was generated. The interesting one is FINGER which signals finger-based scrolling

[RFC PATCH wayland] protocol: add wl_pointer.axis_source events

2015-03-08 Thread Peter Hutterer
The axis source determines how an event was generated. That enables clients to judge when to use kinetic scrolling. We can't extend the existing wl_pointer.axis events so instead this new event is prefixed before each wl_pointer.axis event, i.e. the sequence becomes: wl_pointer.axis_source

[RFC PATCH weston 2/2] clients: add fake kinetic-scrolling to eventdemo

2015-03-08 Thread Peter Hutterer
Very much a proof-of-concept only. --- clients/eventdemo.c | 67 + 1 file changed, 67 insertions(+) diff --git a/clients/eventdemo.c b/clients/eventdemo.c index 57aa716..e4e4283 100644 --- a/clients/eventdemo.c +++ b/clients/eventdemo.c @@

[RFC PATCH weston 1/2] Support axis source events

2015-03-08 Thread Peter Hutterer
Extend notify_axis to take source, step_distance and flags and pass them down to the client. We don't do much there with it other than using it to print stop in the event demo when the last event comes in. --- clients/cliptest.c | 5 - clients/eventdemo.c | 38

Re: [PATCH libinput 5/3] touchpad: accumulate the initial scroll edge delta

2015-03-08 Thread Peter Hutterer
On Fri, Mar 06, 2015 at 11:49:37AM +0100, Hans de Goede wrote: Hi, On 06-03-15 06:44, Peter Hutterer wrote: The previous setting of 10 wasn't 10 mm, it was used against the deltas normalized to a 1000DPI mouse, i.e. closer to 4mm. It was also also per-event, so a slow movement or a high

[ANNOUNCE] libinput 0.12.0

2015-03-09 Thread Peter Hutterer
touches delta touchpad: Refactor tp_get_*_touches_delta Peter Hutterer (19): cosmetic: drop more double empty lines Clarify a comment, it's wheel clicks, not mouse clicks evdev: force-assign 10 slots to mtdev devices test: add protocol A touch screen tests evdev

Re: [RFC libinput 1/3] litest: Make touchpad_2fg_scroll_slow_distance take resolution into account

2015-03-12 Thread Peter Hutterer
On Thu, Mar 12, 2015 at 08:05:24PM +0100, Hans de Goede wrote: Currently touchpad_2fg_scroll_slow_distance always moves the touches 10% of the touchpad height during the test. On the wacom-intuos-finger test device this is a much larger distance then on the synaptics test device, triggering

[PATCH libinput 4/6] test: abort() for invalid logging priorities

2015-03-12 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/litest.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/litest.c b/test/litest.c index 3646446..ad0aff2 100644 --- a/test/litest.c +++ b/test/litest.c @@ -372,6 +372,8 @@ litest_log_handler(struct libinput *libinput

[PATCH libinput 1/6] Calling has_axis on a non-axis pointer event is a bug, note this

2015-03-12 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/libinput.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/libinput.h b/src/libinput.h index ca08c3e..9a7829e 100644 --- a/src/libinput.h +++ b/src/libinput.h @@ -668,6 +668,12

[PATCH libinput 6/6] Add event type checking to the various libinput_event_ functions

2015-03-12 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/libinput.c | 191 +++-- 1 file changed, 185 insertions(+), 6 deletions(-) diff --git a/src/libinput.c b/src/libinput.c index 4d88c46..1231783 100644 --- a/src/libinput.c +++ b/src

[PATCH libinput 3/6] Expand documentation on touch events, listing what is permitted when

2015-03-12 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/libinput.h | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/src/libinput.h b/src/libinput.h index f978b37..356c1bf 100644 --- a/src/libinput.h +++ b/src/libinput.h @@ -839,8 +839,11

[PATCH libinput 2/6] Correct documentation on get_slot and get_seat_slot()

2015-03-12 Thread Peter Hutterer
We don't actually use TOUCH_CANCEL in libinput, but either way calling the slot on a cancel should be valid. Calling it on a FRAME event is not. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/libinput.h | 18 ++ 1 file changed, 14 insertions(+), 4 deletions

[PATCH libinput 5/6] Replace event type check switch statements with a helper macro/function

2015-03-12 Thread Peter Hutterer
The helper function now prints an error message if the event type passed is not allowed. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/libinput.c | 142 ++--- test/litest.c | 12 + test/litest.h | 2 + test/misc.c

Re: [RFC libinput 1/2] touchpad: Extend the touchpad gesture API with pinch gestures

2015-03-12 Thread Peter Hutterer
-by: Peter Hutterer peter.hutte...@who-t.net otherwise Cheers, Peter * function returns 0. * * If a device employs pointer acceleration, the delta returned by this @@ -967,7 +970,7 @@ libinput_event_gesture_get_finger_count(struct libinput_event_gesture *event); * 1000dpi resolution

Re: [PATCH v2 libinput 3/3] touchpad: change tap motion threshold to 3 mm

2015-03-08 Thread Peter Hutterer
On Fri, Mar 06, 2015 at 11:41:44AM +0100, Hans de Goede wrote: Hi, On 06-03-15 06:42, Peter Hutterer wrote: Previous code used a device coordinate threshold of 300 which won't work on Elantech touchpads (1280 vs the ~4000 that synaptics has). Convert to normalized DPI and reduce

[PATCH libinput] tools: print wheel axis capability on proximity

2015-03-11 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Turns out the wheel was set and handled, but the event-debug tool didn't print it in the capabilities tools/event-debug.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/event-debug.c b/tools/event-debug.c index bf23bfb

Re: [PATCH libinput 2/2] Change tp_filter_motion to normalized_coords

2015-03-24 Thread Peter Hutterer
dark branch and got mugged. anyway. Reviewed-by: Peter Hutterer peter.hutte...@who-t.net for both - I wouldn't mind if you split the gesture bits out and push the rest straight to master. Cheers, Peter --- src/evdev-mt-touchpad-edge-scroll.c | 3 +-- src/evdev-mt-touchpad-gestures.c| 8

Re: [PATCH libinput 3/3] Add a normalized_length helper function and use this where applicable

2015-03-24 Thread Peter Hutterer
On Tue, Mar 24, 2015 at 01:14:19PM +0100, Hans de Goede wrote: Add a normalized_length helper function and use this where applicable, just a minor cleanup. Signed-off-by: Hans de Goede hdego...@redhat.com thanks, all three merged, with a couple of minor whitespace changes as detailed below.

[PATCH wayland] protocol: add a note about the version bumps on wl_seat

2015-03-24 Thread Peter Hutterer
See the explanation by Jonas here: http://lists.freedesktop.org/archives/wayland-devel/2015-March/020814.html --- One thought while writing this: would it make sense to add a wl_seat.get_pointer_versioned request to request a specific wl_pointer version from the seat? or is that a solution

[RFC PATCH v2 wayland] protocol: add wl_pointer.axis_source, axis_stop and axis_discrete events

2015-03-24 Thread Peter Hutterer
The axis_source event determines how an axis event was generated. This enables clients to judge when to use kinetic scrolling. The axis_stop event notifies a client about the termination of a scroll sequence, likewise needed to calculate kinetic scrolling parameters. The axis_discrete event

Re: [PATCH libinput 2/2] Change tp_filter_motion to normalized_coords

2015-03-25 Thread Peter Hutterer
On Wed, Mar 25, 2015 at 09:44:48AM +0100, Hans de Goede wrote: Hi, On 24-03-15 23:17, Peter Hutterer wrote: On Tue, Mar 24, 2015 at 04:51:35PM +0100, Hans de Goede wrote: Change tp_filter_motion to use normalized_coords, rather then having it take separate x and y values. Signed-off

[PATCH libinput] Revert touchpad: parse the TOUCHPAD_RESOLUTION property

2015-03-22 Thread Peter Hutterer
This reverts commit 0e64837f30c310da878f28961a6db7c4bcd4f282. Rather than a customized touchpad property, let udev handle this and set the absinfo struct during the normal setup procedures. No need for libinput to have a custom workaround here. Signed-off-by: Peter Hutterer peter.hutte...@who

Re: [RFC PATCH wayland] protocol: add wl_pointer.axis_source events

2015-03-22 Thread Peter Hutterer
On Mon, Mar 23, 2015 at 10:23:18AM +0800, Jonas Ã…dahl wrote: On Mon, Mar 09, 2015 at 01:28:04PM +1000, Peter Hutterer wrote: The axis source determines how an event was generated. That enables clients to judge when to use kinetic scrolling. Nice to see this happening! I have

[PATCH libinput] evdev: reject devices with a min == max axis range

2015-03-22 Thread Peter Hutterer
Except for a few axes where this may be correct, a min == max axis range indicates a broken kernel driver. To avoid potential divisions by zero when scaling this axis later, reject such a device outright. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev.c | 34

[PATCH v2 libinput] tablet: sync tools already in proximity at startup

2015-03-02 Thread Peter Hutterer
be fixed in the kernel anyway. Note that this changes the order of events during a udev seat init, before we had all DEVICE_ADDED events in a row, now the proximity event may be interspersed. Reported-by: Jason Gerecke killert...@gmail.com Signed-off-by: Peter Hutterer peter.hutte...@who-t.net

Re: [PATCH v2 libinput] tablet: sync tools already in proximity at startup

2015-03-04 Thread Peter Hutterer
On Tue, Mar 03, 2015 at 12:29:28PM -0500, Benjamin Tissoires wrote: On Mon, Mar 2, 2015 at 10:29 PM, Benjamin Tissoires benjamin.tissoi...@gmail.com wrote: On Mon, Mar 2, 2015 at 7:59 PM, Peter Hutterer peter.hutte...@who-t.net wrote: If a tool is in proximity when we init, send

Re: [PATCH libinput] Extend the touchpad gesture API with zoom/rotate gestures

2015-03-04 Thread Peter Hutterer
On Wed, Mar 04, 2015 at 03:26:30PM +0100, Hans de Goede wrote: Extend the touchpad gesture API with zoom/rotate gestures. Note that this new API offers a single event stream for both zoom and rotate data, this is deliberate as some applications may be interested in getting both at the same

[PATCH libinput 2/2] doc: document recommended handling of fake proximity events in the caller

2015-03-04 Thread Peter Hutterer
it's a bit quirky and leave it at that. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- doc/Makefile.am| 1 + doc/tablet-support.dox | 50 ++ src/libinput.h | 2 ++ 3 files changed, 53 insertions(+) create mode 100644

[PATCH libinput 1/2] tablet: copy distance axis for the mouse/lens cursor devices

2015-03-04 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-tablet.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/evdev-tablet.c b/src/evdev-tablet.c index 8c11409..3e3924c 100644 --- a/src/evdev-tablet.c +++ b/src/evdev-tablet.c @@ -639,6 +639,7 @@ tool_set_bits_from_libwacom

[PATCH libinput 5/7] test: add a Wacom Intuos 5 Finger test device

2015-03-03 Thread Peter Hutterer
Works as a touchpad but has no buttons. Minor change to one of the touchpad tests: because the touch area is so big the slow-scrolling trigger needs to be adjusted. And because the device is an external device, the disable on external mouse test needs to be adjusted. Signed-off-by: Peter

[PATCH libinput 1/7] test: disable tapping for pure motion tests

2015-03-03 Thread Peter Hutterer
No effect, all devices currently have tapping disabled. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/touchpad.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/test/touchpad.c b/test/touchpad.c index b70d373..d1f1257 100644 --- a/test/touchpad.c +++ b/test/touchpad.c

[PATCH libinput 2/7] test: split 3-finger tap-and-drag test

2015-03-03 Thread Peter Hutterer
Split out into a btntool test and a true three-finger test. For consistency, check the number of slots on all those tests rather than having litest-device-specific exclusions. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/touchpad.c | 67

[PATCH libinput 7/7] touchpad: enable tapping by default on buttonless touchpads

2015-03-03 Thread Peter Hutterer
This affects the touch device on graphics tablets. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad-tap.c | 18 +- test/touchpad.c | 20 2 files changed, 33 insertions(+), 5 deletions(-) diff --git a/src/evdev-mt

[PATCH libinput 6/7] touchpad: don't warn about clickpads without left buttons

2015-03-03 Thread Peter Hutterer
Clickpads have BTN_LEFT but no BTN_RIGHT, non-clickpads must have both. Tablet touch devices don't have any buttons, so skip the warning for those. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad-buttons.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[PATCH libinput 3/7] test: add a button requirement to a couple of touchpad tests

2015-03-03 Thread Peter Hutterer
If we send BTN_LEFT or similar, we need the LITEST_BUTTON capability on the device. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/touchpad.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/test/touchpad.c b/test/touchpad.c index 627d64a..246d07a

[PATCH libinput 4/7] test: enable tapping before verifying correct tap events

2015-03-03 Thread Peter Hutterer
These tests make sure we don't get tapping events in certain situations (finger movement, timeouts, ...). Tapping must be enabled for that to be a valid test. The tests can't work on semi-mt devices because we can't end slots independently. Disable the tests there. Signed-off-by: Peter Hutterer

Re: [PATCH libinput 11/26] tablet: use libwacom to identify tablets for left-handedness

2015-03-01 Thread Peter Hutterer
On Thu, Feb 26, 2015 at 11:54:10AM +0100, sardemff7+wayl...@sardemff7.net wrote: On 2015-02-24 07:21, Peter Hutterer wrote: A tablet hotplug event is rare and not a time-critical event, so we load the database on tablet init and throw it away again. Signed-off-by: Peter Hutterer peter.hutte

Re: [PATCH v2 libinput 00/26] tablet: support the remaining tools

2015-03-01 Thread Peter Hutterer
On Tue, Feb 24, 2015 at 04:21:03PM +1000, Peter Hutterer wrote: This is a v2 of the patchset here http://lists.freedesktop.org/archives/wayland-devel/2015-February/020036.html but reshuffled, rebased and a couple of things merged in. Notable: libinput now uses libwacom to get tool/tablet

Re: [PATCH libinput 19/26] tablet: support z-rotation for the mouse/lens tool

2015-03-01 Thread Peter Hutterer
On Thu, Feb 26, 2015 at 04:20:49PM -0500, Benjamin Tissoires wrote: On Tue, Feb 24, 2015 at 1:21 AM, Peter Hutterer peter.hutte...@who-t.net wrote: Needs to be calculated from the x/y tilt values, the mouse has a fixed offset of 175 degrees counterclockwise. Signed-off-by: Peter

Re: [PATCH libinput 19/26] tablet: support z-rotation for the mouse/lens tool

2015-03-05 Thread Peter Hutterer
On Mon, Mar 02, 2015 at 10:38:54AM -0500, Benjamin Tissoires wrote: On Mon, Mar 2, 2015 at 1:53 AM, Peter Hutterer peter.hutte...@who-t.net wrote: On Thu, Feb 26, 2015 at 04:20:49PM -0500, Benjamin Tissoires wrote: On Tue, Feb 24, 2015 at 1:21 AM, Peter Hutterer peter.hutte...@who-t.net

Re: libinput: the road to 1.0

2015-02-23 Thread Peter Hutterer
On Mon, Feb 23, 2015 at 10:50:48AM +0100, Michal Suchanek wrote: Hello, I heard there is attempt to collect a database of mouse speeds (DPI) so all mice behave the same. yep, look at the hwdb/70-mouse.hwdb file in the systemd repo. it's fairly easy to add to it. What is the semantic of

Re: [PATCH libinput 01/11] Add an API for touchpad gesture events

2015-02-20 Thread Peter Hutterer
On 21/02/2015 06:08 , Bill Spitzak wrote: On 02/19/2015 04:49 PM, Peter Hutterer wrote: unless you have the context you cannot know. and the only thing to have that context is the client. sure you can make all sorts of exceptions (but double-tap should always be doubletap) but that just

[ANNOUNCE] libinput 0.11.0

2015-02-22 Thread Peter Hutterer
/udev_config.html The full commit shortlog is below. Benjamin Tissoires (2): evdev: retrieve udev tags Use LIBINPUT_DEVICE_GROUP from udev as group identifier Marek Chalupa (1): add simple symbols leak checker Peter Hutterer (19): Introduce device groups to group logical devices

libinput: the road to 1.0

2015-02-22 Thread Peter Hutterer
Just as a heads-up, here's a short summary on what the plan is for libinput. There are three milestones that are somewhat independent of each other: * API/ABI stability promise * libinput 1.0 * tablet, buttonset and touchpad gesture support I made vague promises (on private channels) that we'll

Re: [PATCH libinput 10/11] touchpad: Refactor tp_get_*_touches_delta

2015-02-22 Thread Peter Hutterer
On Wed, Feb 18, 2015 at 01:26:53PM +0100, Hans de Goede wrote: The two tp_get_*_touches_delta functions are almost identical, refactor them into one function. Signed-off-by: Hans de Goede hdego...@redhat.com --- ACK to the basics, but I'd like to leave the two calls in place and make them

Re: [PATCH libinput 14/15] tablet: add support for libinput_tool_has_button

2015-02-22 Thread Peter Hutterer
On Sun, Feb 22, 2015 at 07:48:03PM -0500, Lyude wrote: On Wed, 2015-02-18 at 15:45 +1000, Peter Hutterer wrote: The mouse like devices have LMR, SIDE and EXTRA. PENCIL (which is the Wacom Inking) and the eraser have no buttons. AIRBRUSH has only one button, all other pens have two

Re: [PATCH libinput 07/11] touchpad: Gesture support preparation

2015-02-22 Thread Peter Hutterer
events at the end of 2fg scrolling when not lifting both fingers at exactly the same time. Signed-off-by: Hans de Goede hdego...@redhat.com only comment I have here: can we rename finger_mode to finger_count? it's less ambiguous. Reviewed-by: Peter Hutterer peter.hutte...@who-t.net

Re: [PATCH libinput 11/11] touchpad: Add support for swipe gestures

2015-02-22 Thread Peter Hutterer
On Wed, Feb 18, 2015 at 01:26:54PM +0100, Hans de Goede wrote: Add support for swipe gestures. Signed-off-by: Hans de Goede hdego...@redhat.com unless noted otherwise, series Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Cheers, Peter --- src/evdev-mt-touchpad-gestures.c | 36

[PATCH libinput 03/26] test: fix double comparison macros

2015-02-23 Thread Peter Hutterer
args needs to be within () to ensure correct calculation Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/litest.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/test/litest.h b/test/litest.h index 4553c87..dd1ad9a 100644 --- a/test/litest.h +++ b

[PATCH libinput 20/26] tablet: support airbrush wheel as slider

2015-02-23 Thread Peter Hutterer
The little wheel isn't a full wheel, it has a ~90 degree rotation angle with a range of 1024 values. To avoid confusion with wheel elsewhere in the API name it slider. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-tablet.c | 9 -- src/evdev-tablet.h | 6

[PATCH libinput 26/26] tablet: add libinput_event_tablet_get_axis_delta_discrete()

2015-02-23 Thread Peter Hutterer
Equivalent to the pointer axis function - it gets the mouse wheel clicks from the tablet mouse. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-tablet.c | 5 - src/libinput-private.h | 3 ++- src/libinput.c | 32 +++- src

[PATCH libinput 21/26] tablet: support artpen rotation

2015-02-23 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-tablet.c | 35 +++- src/evdev-tablet.h | 6 src/libinput.h | 3 +- test/tablet.c | 95 ++ 4 files changed, 130 insertions(+), 9 deletions

[PATCH libinput 10/26] Keep the tablet APIs in a separate symbol version block

2015-02-23 Thread Peter Hutterer
I keep having to move them around after merging from master and often I'm late with it too. It's a lot easier to just have to update the dependency in a single line, and causes less conflicts too. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/libinput.sym | 9 ++--- 1 file

[PATCH libinput 18/26] tablet: rely on libwacom to give us the right tablet axes

2015-02-23 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-tablet.c | 50 +- 1 file changed, 33 insertions(+), 17 deletions(-) diff --git a/src/evdev-tablet.c b/src/evdev-tablet.c index 2b90e08..52742cf 100644 --- a/src/evdev-tablet.c

[PATCH libinput 09/26] tablet: add libinput_tool_get_tool_id()

2015-02-23 Thread Peter Hutterer
The tool ID on wacom tablets is what really defines the tool, so one can differ between say an Intuos Grip Pen, Art Pen or Classic Pen. They're all BTN_TOOL_PEN in the kernel driver. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-tablet.c | 8 src/evdev

[PATCH libinput 16/26] tablet: add support for libinput_tool_has_button

2015-02-23 Thread Peter Hutterer
libwacom can tell us how many buttons we have per stylus, so we map those into BTN_STYLUS and BTN_STYLUS2. BTN_TOUCH is set on all styli. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-tablet.c | 73 ++ src/libinput

[PATCH libinput 01/26] test: fix two tablet tests

2015-02-23 Thread Peter Hutterer
The serial test was broken, it succeeded even if we never got an event. The second test was fine, but complicated. Make it use some of the newer litest features. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/tablet.c | 42 -- 1 file

Re: [PATCH libinput 00/15] tablet: support the remaining tools

2015-02-23 Thread Peter Hutterer
number? If it's 0x100802 then I've just sent a patch for libwacom to fix it up (the database was wrong). Cheers, Peter On Wed, 2015-02-18 at 15:45 +1000, Peter Hutterer wrote: This patchset adds the remaining tools to the tablet branch (at least for Wacom tools). The notable additions

Re: [PATCH libinput 12/26] tablet: explicitly ignore ABS_THROTTLE, ABS_RX, ABS_RY, and ABS_RZ

2015-02-25 Thread Peter Hutterer
On Wed, Feb 25, 2015 at 05:29:49PM -0800, Jason Gerecke wrote: On 2/23/2015 10:21 PM, Peter Hutterer wrote: ABS_THROTTLE: Tablets still advertise this axis but the mouse itself isn't available anymore. The Pad sends the second wheel as ABS_THROTTLE but that's a task

[PATCH libinput] tablet: ignore tools already in proximity at startup

2015-02-25 Thread Peter Hutterer
and their events won't interfere until they actually use it. Reported-by: Jason Gerecke killert...@gmail.com Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-tablet.c | 10 +- test/tablet.c | 43 +++ 2 files changed, 52 insertions

[PATCH libinput] evdev: ignore tablet pad devices explicitly

2015-02-25 Thread Peter Hutterer
We don't have real support for them yet but they have the ID_INPUT_TABLET tag set. Ignore them explicitly before someone thinks they're already working. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions

Re: [PATCH libinput 23/26] tools: only print the tablet axes we have on the tool

2015-02-25 Thread Peter Hutterer
On Wed, Feb 25, 2015 at 05:31:00PM -0800, Jason Gerecke wrote: On 2/23/2015 10:21 PM, Peter Hutterer wrote: This doesn't really have an effect, since we don't set the per-tool axes correctly yet. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- tools/event-debug.c | 106

Re: [PATCH libinput 21/26] tablet: support artpen rotation

2015-02-25 Thread Peter Hutterer
On Wed, Feb 25, 2015 at 05:30:21PM -0800, Jason Gerecke wrote: On 2/23/2015 10:21 PM, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-tablet.c | 35 +++- src/evdev-tablet.h | 6 src/libinput.h | 3 +- test/tablet.c

[PATCH v2 libinput 24/26] tablet: support the rel wheel on the mouse device

2015-02-25 Thread Peter Hutterer
Providing a relative axis in the axis_get_value() is inconsistent with the other axes, this will be fixed in a follow-up commit. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Benjamin Tissoires benjamin.tissoi...@gmail.com --- Changes to v1: - s/break/continue

[PATCH v2 libinput 27/26] test: add tablet wheel test

2015-02-25 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- New patch, I had to re-do the test because it never actually triggered. So rather than complicated rebasing, this is the final test with everything including discrete values. New test sends more than one wheel event and then a couple

<    5   6   7   8   9   10   11   12   13   14   >