Re: [PATCH wayland-protocols v2] unstable: add primary-selection protocol

2018-10-02 Thread Simon Ser
Hi Jonas, Any news about this? Thanks! Simon On Sunday, September 23, 2018 12:52 PM, Simon Ser wrote: > From: emersion cont...@emersion.fr > > This primary selection is similar in spirit to the eponimous > in X11, allowing a quick "select text + middle click"

[PATCH] protocol: allow to send a zero output refresh rate

2018-09-29 Thread Simon Ser
Fixed refresh rate doesn't always make sense for all outputs. In case it's not available or not relevant, allow compositors to send zero. This is for instance the case for outputs with variable refresh rate (such as FreeSync) and virtual outputs. Signed-off-by: Simon Ser --- protocol

Re: [PATCH v2] server: add wl_signal_emit_safe

2018-09-23 Thread Simon Ser
On Tuesday, September 18, 2018 8:43 PM, Derek Foreman wrote: > On 2018-08-08 07:00 AM, Simon Ser wrote: > > > This new function allows listeners to remove themselves or any > > other listener when called. This version only works if listeners > > are properly remove

Re: [PATCH] cursor: use memfd_create or shm_open for anonymous in-memory files

2018-09-23 Thread Simon Ser
Hi all, Any news about this? Thanks, --- Simon Ser https://emersion.fr On Wednesday, August 15, 2018 4:14 PM, Simon Ser wrote: > On Linux, try using memfd_create and file sealing. Fallback to > shm_open on old kernels. > > On FreeBSD, use shm_open with SHM_ANON. > > Other

[PATCH wayland-protocols v2] unstable: add primary-selection protocol

2018-09-23 Thread Simon Ser
From: emersion This primary selection is similar in spirit to the eponimous in X11, allowing a quick "select text + middle click" shortcut to copying and pasting. It's otherwise very similar to its Wayland counterpart, and explicitly made consistent with it. Signed-off-by:

Re: [RFC wayland-protocols] input-method: Add zwp-input-method-v2

2018-09-07 Thread Simon Ser
On 6 August 2018 3:00 PM, Dorota Czaplejewicz wrote: > This protocol is based on v1, and current text-input-v3. > > The pieces passing data relevant to the application on the other side of the > compositor are a mirror copy of text-input-v3 events and requests. > > Compared to input-method-v1: >

Re: [PATCH wayland-protocols] unstable: add xdg-primary-selection protocol

2018-08-16 Thread Simon Ser
tocol. I'm not feeling strongly about this in any case. > Thoughts? If we ignore form factors (desktop vs hand held), where does > it fall, you think? > > Jonas > > > Acked-by: Carlos Garnacho carl...@gnome.org > > On Sun, Jul 8, 2018 at 9:14 PM, Simon Ser co

Re: [PATCH] cursor: use memfd_create or shm_open for anonymous in-memory files

2018-08-16 Thread Simon Ser
On August 16, 2018 11:57 AM, Jan Engelhardt wrote: > On Thursday 2018-08-16 12:41, Emil Velikov wrote: > > > On 15 August 2018 at 15:14, Simon Ser cont...@emersion.fr wrote: > > > > > On Linux, try using memfd_create and file sealing. Fallback to > > > shm_o

[PATCH] cursor: use memfd_create or shm_open for anonymous in-memory files

2018-08-15 Thread Simon Ser
On Linux, try using memfd_create and file sealing. Fallback to shm_open on old kernels. On FreeBSD, use shm_open with SHM_ANON. Otherwise, use shm_open with a random name, making sure the name isn't already taken. Signed-off-by: Simon Ser --- Makefile.am | 2 +- configure.ac

[PATCH v2] server: add wl_signal_emit_safe

2018-08-08 Thread Simon Ser
://patchwork.freedesktop.org/patch/204641/ Signed-off-by: Simon Ser --- Addressed Markus' comments [1]. [1]: https://lists.freedesktop.org/archives/wayland-devel/2018-July/039042.html src/wayland-server-core.h | 3 ++ src/wayland-server.c | 50 +++ tests/signal-test.c | 86

Re: [PATCH v6 wayland-protocols] virtual-keyboard: Add new virtual keyboard protocol

2018-08-03 Thread Simon Ser
gt; > this is the change I wanted to send previously (sorry). > > Regards, > Dorota Czaplejewicz Thanks for this update! Reviewed-by: Simon Ser > Makefile.am| 1 + > unstable/virtual-keyboard/README | 2

Re: [PATCH v11 wayland_protocols] text-input: Add v3 of the text-input protocol

2018-07-30 Thread Simon Ser
ome text from > text_input description there (most of it is still directly relevant to > text_input only). > > It also fixes the done argument by placing it outside the description. > > --Dorota Nice work. This is: Reviewed-by: Simon Ser > Makefile.am

Re: [PATCH wayland-protocols 2/2] tests: Make wayland-scanner strict

2018-07-30 Thread Simon Ser
On July 30, 2018 4:10 PM, Jonas Ådahl wrote: > Pass --strict to wayland-scanner in order to make it exit with failure > if something wasn't correct. > > Signed-off-by: Jonas Ådahl LGTM and catches the inside issue. Reviewed-by: Simon Ser > --- > tests/scan.sh | 8

Re: [PATCH wayland-protocols 1/2] tests: Use public-code and private-code instead of code

2018-07-30 Thread Simon Ser
On July 30, 2018 4:10 PM, Jonas Ådahl wrote: > The wayland-scanner sub-commands private-code and public-code replaced > the old code command, so lets use those in the tests instead. > > Signed-off-by: Jonas Ådahl LGTM and works. Reviewed-by: Simon Ser > --- > tests/scan.sh

Re: [PATCH v10 wayland_protocols] text-input: Add v3 of the text-input protocol

2018-07-30 Thread Simon Ser
On July 30, 2018 3:14 PM, Dorota Czaplejewicz wrote: > From: Carlos Garnacho > > This new protocol description is an evolution of v2. > > - All pre-edit text styling is gone. > - Pre-edit cursor can span characters. > - No events regarding input panel (OSK) state nor covered rectangle. >

Re: [PATCH v4 wayland-protocols] virtual-keyboard: Add new virtual keyboard protocol

2018-07-30 Thread Simon Ser
On July 29, 2018 6:55 PM, Dorota Czaplejewicz wrote: > On Tue, 24 Jul 2018 15:10:29 +0200 > Dorota Czaplejewicz wrote: > > > On Thu, 12 Jul 2018 18:15:32 -0400 > > Simon Ser wrote: > > > > > Hi, > > > > > > Sorry for the

Re: [PATCH wayland-protocols] unstable: add xdg-primary-selection protocol

2018-07-24 Thread Simon Ser
Hi Jonas, Any thoughts about this? Thanks, Simon On July 15, 2018 7:36 PM, Simon Ser wrote: > Hi Jonas, > > What do you think of this proposal? (It's basically the GTK protocol with > some prefix changes) > > Thanks, > > Simon > > On July 8, 2018 8:14 PM, Simo

Re: [PATCH] protocol: allow to send a zero physical output size

2018-07-24 Thread Simon Ser
On July 13, 2018 12:00 PM, Daniel Stone wrote: > Hi, > > On Tue, 3 Jul 2018 at 12:27, Simon Ser wrote: > > Physical size doesn't always make sense for all outputs. In case > > it's not available or not relevant, allow compositors to send zero. > > --- > > In pr

Re: [PATCH v3 2/3] xdg-shell: Make sure wording reflects expectations

2018-07-20 Thread Simon Ser
clients kindly ask for state changes which > the compositor may follow. > This patch ensures the actual protocol text reflects these expectations. Reviewed-By: Simon Ser > --- > stable/xdg-shell/xdg-shell.xml | 45 +- > 1 file changed, 23 insertions(+

Re: [PATCH v3 1/3] xdg-shell: move maximized state definition together

2018-07-20 Thread Simon Ser
on. > > Signed-off-by: Markus Ongyerth > Reviewed-By: Mike Blumenkrantz Reviewed-By: Simon Ser > --- > stable/xdg-shell/xdg-shell.xml | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/stable/xdg-shell/xdg-shell.xml b/stable/xdg-shell/xdg

Re: [PATCH wayland-protocols] xdg-output: add a transform example for the logical size

2018-07-16 Thread Simon Ser
Hi Jonas, What do you think of this patch? Thanks, Simon On July 9, 2018 3:25 PM, Olivier Fourdan wrote: > Hi, > > On Mon, 9 Jul 2018 at 11:09, Simon Ser wrote: > > > > Bump: this is the source of bugs in xwayland [1]. > > > > [1]: https://lists.x.org/arc

Re: [PATCH wayland-protocols] unstable: add xdg-primary-selection protocol

2018-07-15 Thread Simon Ser
Hi Jonas, What do you think of this proposal? (It's basically the GTK protocol with some prefix changes) Thanks, Simon On July 8, 2018 8:14 PM, Simon Ser wrote: > This primary selection is similar in spirit to the eponymous > in X11, allowing a quick "select text + middle clic

[PATCH] server: add wl_signal_emit_safe

2018-07-13 Thread Simon Ser
This new function allows listeners to remove themselves or any other listener when called. This version only works if listeners are properly cleaned up when the wl_signal is free'd. Signed-off-by: Simon Ser --- This is a [1] follow-up. Since we noticed the previous version is not a drop

Re: [PATCH] protocol: allow to send a zero physical output size

2018-07-13 Thread Simon Ser
, Simon Ser wrote: > Physical size doesn't always make sense for all outputs. In case > it's not available or not relevant, allow compositors to send zero. > --- > In practice this doesn't seem to break any client toolkit. We've been > doing that for a long time in wlroots

Re: [PATCH v4 wayland-protocols] virtual-keyboard: Add new virtual keyboard protocol

2018-07-12 Thread Simon Ser
> Provides the ability to emulate keyboards by applications. Complementary to > input-method protocol. > > The interface is a mirror copy of wl_keyboard, with removed serials, and added > seat binding. > > --- > > Hello, > > thank you for giving me a lot of useful feedback in the last round. I

Re: [PATCH v2 0/3] Change wording in xdg-shell stable

2018-07-12 Thread Simon Ser
Hi Jonas, What do you think of these patches? Thanks, Simon On June 29, 2018 11:12 AM, wrote: > From: Markus Ongyerth w...@ongy.net > > Hi, > > This is a v2 of a rather old patch series I more or less forgot about [1]. > > The previous version of patch 1 is [2] > The patch 2 and 3 are based

Re: [PATCH wayland-protocols] xdg-output: add a transform example for the logical size

2018-07-09 Thread Simon Ser
Bump: this is the source of bugs in xwayland [1]. [1]: https://lists.x.org/archives/xorg-devel/2018-July/057285.html On May 18, 2018 9:40 PM, Simon Ser wrote: > Signed-off-by: Simon Ser > --- > > I believe it's easy to understand that transformations are not applied to > t

[PATCH wayland-protocols] unstable: add xdg-primary-selection protocol

2018-07-08 Thread Simon Ser
This primary selection is similar in spirit to the eponimous in X11, allowing a quick "select text + middle click" shortcut to copying and pasting. It's otherwise very similar to its Yayland counterpart, and explicitly made consistent with it. Signed-off-by: Simon Ser --- This is a co

Re: [PATCH wayland-protocols v7] unstable: add xdg-decoration protocol

2018-07-04 Thread Simon Ser
On July 4, 2018 3:45 PM, Jonas Ådahl wrote: > Looks good to me, I think we can go with this. What Reviewed-by:s should > I add, besides my own? I think everybody has replied with a tag as of now. Simon ___ wayland-devel mailing list

Re: [PATCH wayland-protocols v7] unstable: add xdg-decoration protocol

2018-07-04 Thread Simon Ser
Hi Jonas, Any news about this? Thanks, Simon On June 27, 2018 5:23 PM, Simon Ser wrote: > Hi Jonas, > > What do you think of this new version? Wording suggestions and other comments > welcome :) > > Thanks, > > Simon > > On June 18, 2018 11:16 AM, Simon S

[PATCH] protocol: warn clients about some wl_output properties

2018-07-03 Thread Simon Ser
All wl_output properties don't always make sense for all compositors. Some compositors might not implement a "global compositor space", (e.g. 3D compositors) in which case properties like x and y don't make sense. Some compositors might expose virtual outputs, in which case modes, make and model

Re: [PATCH wayland 8/8] fixup! scanner: initialize .{method, event}_count via ARRAY_SIZE

2018-07-03 Thread Simon Ser
On July 3, 2018 12:45 PM, Pekka Paalanen wrote: > On Thu, 14 Jun 2018 16:49:45 +0100 > Emil Velikov wrote: > > > --- > > tests/data/example-code.c | 73 > > + > > tests/data/small-code-core.c| 5 +-- > > tests/data/small-code.c | 5

[PATCH] protocol: allow to send a zero physical output size

2018-07-03 Thread Simon Ser
Physical size doesn't always make sense for all outputs. In case it's not available or not relevant, allow compositors to send zero. --- In practice this doesn't seem to break any client toolkit. We've been doing that for a long time in wlroots. protocol/wayland.xml | 3 +++ 1 file changed, 3

Re: [PATCH] compositor-headless: Report a more realistic physical size

2018-07-02 Thread Simon Ser
> On Thu, 12 Apr 2018 09:31:48 +0200 > Johan Klokkhammer Helsing wrote: > > > Some clients rely on the physical size to determine the physical DPI. With > > the > > previous implementation, we would report 1px==1mm, which is a DPI of 25.4, > > which is incredibly low. > > > > The problem is

Re: [PATCH v2 2/3] xdg-shell: Make sure wording reflects expectations

2018-06-29 Thread Simon Ser
side of the window geometry. Hmm. This belongs to the previous patch, I believe? I think this is a good change otherwise. Reviewed-by: Simon Ser > > > > @@ -866,11 +866,11 @@ > Maximize the surface. > > After requesting that the s

Re: [PATCH v2 1/3] xdg-shell: move maximized state definition together

2018-06-29 Thread Simon Ser
or other decoration outside of the window geometry. Nitpick: there's a line wrapping issue here. Otherwise this is: Reviewed-by: Simon Ser > > > > @@ -865,8 +868,7 @@ > After requesting that the surface should be maximized, th

Re: [PATCH wayland-protocols v7] unstable: add xdg-decoration protocol

2018-06-27 Thread Simon Ser
Hi Jonas, What do you think of this new version? Wording suggestions and other comments welcome :) Thanks, Simon On June 18, 2018 11:16 AM, Simon Ser wrote: > This adds a new protocol to negotiate server-side rendering of window > decorations for xdg-toplevels. This allows compo

Re: [PATCH v3 wayland-protocols] virtual-keyboard: Add new virtual keyboard protocol

2018-06-25 Thread Simon Ser
On June 24, 2018 12:24 PM, Simon Ser wrote: > On June 22, 2018 7:00 PM, Dorota Czaplejewicz > wrote: > > On Fri, 22 Jun 2018 12:36:16 -0400 > > Simon Ser wrote: > > > > > On June 22, 2018 4:20 PM, Dorota Czaplejewicz > > > wrote: > &g

Re: [PATCH v3 wayland-protocols] virtual-keyboard: Add new virtual keyboard protocol

2018-06-24 Thread Simon Ser
On June 22, 2018 7:00 PM, Dorota Czaplejewicz wrote: > On Fri, 22 Jun 2018 12:36:16 -0400 > Simon Ser wrote: > > > On June 22, 2018 4:20 PM, Dorota Czaplejewicz > > wrote: > > > Provides the ability to emulate keyboards by applications. Complementary

Re: [PATCH v3 wayland-protocols] virtual-keyboard: Add new virtual keyboard protocol

2018-06-22 Thread Simon Ser
On June 22, 2018 4:20 PM, Dorota Czaplejewicz wrote: > Provides the ability to emulate keyboards by applications. Complementary to > input-method protocol. > > The interface is a mirror copy of wl_keyboard, with removed serials, and > added seat binding. > --- > Hi, > > this patch is another

[PATCH wayland] doc: update IANA MIME types registry URL

2018-06-18 Thread Simon Ser
Use a more official one, served over HTTP rather than FTP. --- doc/publican/sources/Protocol.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/publican/sources/Protocol.xml b/doc/publican/sources/Protocol.xml index 9fdee9a..fedaaab 100644 ---

[PATCH wayland-protocols v7] unstable: add xdg-decoration protocol

2018-06-18 Thread Simon Ser
by a protocol from KDE [1] which has been implemented in KDE and Sway and was submitted for consideration in 2017 [2]. This patch provides an updated protocol with those concerns taken into account. Signed-off-by: Simon Ser [1] https://github.com/KDE/kwayland/blob/master/src/client/protocols/server

[PATCH wayland-protocols v7] unstable: add xdg-decoration protocol

2018-06-18 Thread Simon Ser
by a protocol from KDE [1] which has been implemented in KDE and Sway and was submitted for consideration in 2017 [2]. This patch provides an updated protocol with those concerns taken into account. Signed-off-by: Simon Ser [1] https://github.com/KDE/kwayland/blob/master/src/client/protocols/server

Re: [PATCH wayland-protocols v6] unstable: add xdg-decoration protocol

2018-06-17 Thread Simon Ser
On June 15, 2018 5:56 PM, Jonas Ådahl wrote: > Hi, Hi Jonas, Thanks for you feedback. > What about when clients change their "preference" in combination with a > window state change? > > Lets assume the compositor prefers server side, and the current state > is that the client has set the

Re: [PATCH wayland-protocols v6] unstable: add xdg-decoration protocol

2018-06-11 Thread Simon Ser
Hi Jonas, Any news about this? Thanks, --- Simon Ser https://emersion.fr On June 4, 2018 9:11 AM, Simon Ser wrote: > Hi Jonas, > > Did you have the chance to have a look at this version? > > Thanks, > --- > Simon Ser > https://emersion.fr > > On May 28, 2018 8:0

Re: [PATCH] scanner: allow referencing foreign enums

2018-06-06 Thread Simon Ser
On May 29, 2018 9:52 AM, Pekka Paalanen wrote: > On Sat, 26 May 2018 09:51:18 +0200 > Silvan Jegen wrote: > > > Hi > > > > On Fri, May 25, 2018 at 05:24:41PM -0400, Simon Ser wrote: > > > It's already possible to reference foreign interfaces, so it > &

Re: [PATCH wayland-protocols v6] unstable: add xdg-decoration protocol

2018-06-04 Thread Simon Ser
Hi Jonas, Did you have the chance to have a look at this version? Thanks, --- Simon Ser https://emersion.fr On May 28, 2018 8:04 AM, Simon Ser wrote: > Hi Jonas, > > What do you think of this new proposal? > > Thanks, > --- > Simon Ser > https://emersion.fr > > O

Re: [PATCH_v2] virtual-keyboard: Add new virtual keyboard protocol

2018-05-29 Thread Simon Ser
t. > + > + > + > + Is it possible to add a request to destroy the manager? Quoting pq from the latest DRM lease protocol review: >This interface is missing a destroy request. Interfaces must always have a >destroy request unless there is a very good reason to not have one. In any >case, every object must be destroyable somehow. > + > + > -- > 2.14.3 > ___ > wayland-devel mailing list > wayland-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/wayland-devel Otherwise, this protocol looks pretty good to me. --- Simon Ser https://emersion.fr ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH wayland-protocols v6] unstable: add xdg-decoration protocol

2018-05-28 Thread Simon Ser
Hi Jonas, What do you think of this new proposal? Thanks, --- Simon Ser https://emersion.fr On May 20, 2018 11:39 AM, Simon Ser <cont...@emersion.fr> wrote: > This adds a new protocol to negotiate server-side rendering of window > decorations for xdg-toplevels. This allows composito

[PATCH] scanner: allow referencing foreign enums

2018-05-25 Thread Simon Ser
It's already possible to reference foreign interfaces, so it should also be possible to reference foreign enums. Signed-off-by: Simon Ser <cont...@emersion.fr> --- src/scanner.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/scanner.c b/src/scanner.c index 1

Re: [PATCH] virtual-keyboard: Add new virtual keyboard protocol

2018-05-21 Thread Simon Ser
On May 21, 2018 12:12 AM, Dorota Czaplejewicz wrote: > Apart from the typo that Silvan spotted, I have also encountered the issue > where > the .c/.h generator complained about undefined key_state and keymap_format > enums > which are defined in wayland.xml. I'm

[PATCH wayland-protocols v6] unstable: add xdg-decoration protocol

2018-05-20 Thread Simon Ser
by a protocol from KDE [1] which has been implemented in KDE and Sway and was submitted for consideration in 2017 [2]. This patch provides an updated protocol with those concerns taken into account. Signed-off-by: Simon Ser <cont...@emersion.fr> [1] https://github.com/KDE/kwayland/blob/master/src/

[PATCH wayland-protocols] xdg-output: add a transform example for the logical size

2018-05-18 Thread Simon Ser
Signed-off-by: Simon Ser <cont...@emersion.fr> --- I believe it's easy to understand that transformations are not applied to the logical size. unstable/xdg-output/xdg-output-unstable-v1.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/unstable/xdg-output/xdg-output-unstable-v1.

Re: [PATCH wayland-protocols v5] unstable: add xdg-decoration protocol

2018-05-08 Thread Simon Ser
On May 8, 2018 4:27 PM, Jonas Ådahl wrote: > Looks fine to me. Are all those Reviewed-by:s also for the trimmed down > version? Ah, no, you're right. Drew DeVault, David Edmundson, Alan Griffiths, Tony Crisci, Eike Hein: if you find this version of the proposal good enough,

Re: [PATCH 1/2] weston-info: Add support for tablet-unstable-v2

2018-04-24 Thread Simon Ser
On April 24, 2018 8:31 AM, wrote: > From: Markus Ongyerth > > This now prints each tablet seat with at least one tablet/pad/tool > attached. > For each tablet seat, each tablet, pad and tool is printed with as much > detail about the device as the protocol

Referencing enums in other protocols

2018-04-23 Thread Simon Ser
. Thanks, ​--- Simon Ser https://emersion.fr​ ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel

[PATCH wayland-protocols v5] unstable: add xdg-decoration protocol

2018-04-18 Thread Simon Ser
by a protocol from KDE [1] which has been implemented in KDE and Sway and was submitted for consideration in 2017 [2]. This patch provides an updated protocol with those concerns taken into account. Signed-off-by: Simon Ser <cont...@emersion.fr> Reviewed-by: Drew DeVault <s...@cmpwn.com> Review

Re: [PATCH wayland-protocols v4] unstable: add xdg-toplevel-decoration protocol

2018-04-18 Thread Simon Ser
On April 18, 2018 1:05 PM, Jonas Ådahl wrote: > Since the issue is more of a race condition kind of issue, it might not > be easily reproducable with a demo client, but must be solved by coming > up with a type of negotiation that doesn't result in incorrect > intermediate

Re: [PATCHv4] Add name event to xdg-output

2018-04-18 Thread Simon Ser
On April 18, 2018 9:57 AM, Jonas Ådahl wrote: > Replying to both Pekka and Drew at the same time here: > > On Mon, Apr 16, 2018 at 11:14:51AM -0400, Drew DeVault wrote: > > On 2018-04-16 2:57 PM, Jonas Ådahl wrote: > > > I'd still like a bit more clarification about what to

Re: [PATCH wayland-protocols v4] unstable: add xdg-toplevel-decoration protocol

2018-04-17 Thread Simon Ser
(Re-sending the message because I forgot to reply to the list) On April 13, 2018 2:56 PM, Jonas Ådahl wrote: > Another thing to consider is whether non-toplevels ever want a similar > kind of protocol? It is not something we need to go into much further > details now, but it

Re: [PATCH v2 2/3] server: Add special case destroy signal emitter

2018-04-16 Thread Simon Ser
Thanks for looking into this, I think it's a great idea to add this behaviour to the ABI. This patch LGTM. Reviewed-by: Simon Ser <cont...@emersion.fr> > --- > > Changes since v1: > In v1 I went through some ugly steps to ensure wl_priv_signal_get() > worked. It seems this is actua

[PATCH wayland-protocols v4] unstable: add xdg-toplevel-decoration protocol

2018-03-24 Thread Simon Ser
by a protocol from KDE [1] which has been implemented in KDE and Sway and was submitted for consideration in 2017 [2]. This patch provides an updated protocol with those concerns taken into account. Signed-off-by: Simon Ser <cont...@emersion.fr> Reviewed-by: Drew DeVault <s...@cmpwn.com> Review

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-22 Thread Simon Ser
On March 22, 2018 2:39 PM, Simon McVittie wrote: > Those dialogs still have all the window-management operation widgets that > the application designer wants them to have - that just happens to mean > "none" in this case. > > Contrast with the same dialogs in a SSD

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-22 Thread Simon Ser
ouldn't draw rounded corners nor shadows. That's why I think using the "SSD/no SSD" vocabulary is more accurate. What do you think? [1] https://developer.gnome.org/hig/stable/dialogs.html.en#message-dialogs [2] https://elementary.io/docs/human-interface-guidelines#d

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-18 Thread Simon Ser
On March 16, 2018 1:22 PM, Pekka Paalanen wrote: > > > I'm missing a comment that describes what happens if the xdg_toplevel is > > > destroyed. There is some object dependency here that needs to be stated. > > > Do > > > we need an event here? Or are we assuming that

Re: [PATCH wayland-protcols v2] unstable: add xdg-toplevel-decoration protocol

2018-03-15 Thread Simon Ser
On March 15, 2018 4:15 PM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 2 March 2018 at 15:33, Simon Ser <cont...@emersion.fr> wrote: > > This adds a new protocol to negotiate server- and client-side rendering of > > window decorations for xdg-toplevels. This a

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-14 Thread Simon Ser
On March 14, 2018 7:33 PM, Drew DeVault <s...@cmpwn.com> wrote: > On 2018-03-14 6:41 AM, Simon Ser wrote: > > > Since we assume CSD by default, this implies that any client must be able > > > to > > > do CSD, which should be explicitly stated here. > >

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-14 Thread Simon Ser
On March 14, 2018 10:22 AM, Peter Hutterer <peter.hutte...@who-t.net> wrote: > sorry about the delay, but better late than too late ;) No problem, thanks for your review! > On Sun, Mar 11, 2018 at 05:53:42PM -0400, Simon Ser wrote: > > This adds a new protocol to negotiate

[PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-11 Thread Simon Ser
by a protocol from KDE [1] which has been implemented in KDE and Sway and was submitted for consideration in 2017 [2]. This patch provides an updated protocol with those concerns taken into account. Signed-off-by: Simon Ser <cont...@emersion.fr> Reviewed-by: Drew DeVault <s...@cmpwn.com&

Re: [PATCH wayland-protcols v2] unstable: add xdg-toplevel-decoration protocol

2018-03-11 Thread Simon Ser
‐‐‐ Original Message ‐‐‐ On March 11, 2018 10:17 PM, Quentin Glidic wrote: > ​​ > > > > > Last but not least: it should be much much clearer that the compositor > > > is in charge here. This is not about magic SSD, clients must support CSD > > > in all

Re: [PATCH wayland-protcols v2] unstable: add xdg-toplevel-decoration protocol

2018-03-11 Thread Simon Ser
On March 3, 2018 12:14 PM, Quentin Glidic <sardemff7+wayl...@sardemff7.net> wrote: > On 3/2/18 4:33 PM, Simon Ser wrote: > > This adds a new protocol to negotiate server- and client-side rendering of > > window decorations for xdg-toplevels. This allows compositors

Re: [PATCH wayland-protocols] unstable: add xdg-toplevel-decoration protocol

2018-03-03 Thread Simon Ser
face properties (just like xdg-toplevel adds properties to xdg-surface). There are a bunch of "See xdg_surface.configure" in the description and as an extension of xdg-shell the protocol assumes the reader knows how xdg-shell works. > Regards, > > Mike > > On Thu, Mar 1, 2018

[PATCH wayland-protcols v2] unstable: add xdg-toplevel-decoration protocol

2018-03-02 Thread Simon Ser
by a protocol from KDE [1] which has been implemented in KDE and Sway and was submitted for consideration in 2017 [2]. This patch provides an updated protocol with those concerns taken into account. Signed-off-by: Simon Ser <cont...@emersion.fr> Reviewed-by: Drew DeVault <s...@cmpwn.com&

Re: [PATCH wayland-protocols] unstable: add xdg-toplevel-decoration protocol

2018-03-01 Thread Simon Ser
can simply destroy the global. > > Please see again my mail on this topic from the previous thread:  > https://lists.freedesktop.org/archives/wayland-devel/2018-January/036495.html > > Regards, > > Mike > > On Sun, Feb 18, 2018 at 3:01 PM Simon Ser <cont...@emersion

[PATCH] core: implement a safe wl_signal_emit

2018-02-14 Thread Simon Ser
The previous implementation tried to be safe but wasn't: a listener couldn't remove the next one. This removes the need for wl_priv_signal. newsignal-test is now merged into signal-test. --- This is followup of "RFC: server: implement wl_priv_signal_emit without emit_list" [1] which removes

Re: [PATCH] RFC: server: implement wl_priv_signal_emit without emit_list

2018-02-02 Thread Simon Ser
Bump! Can you give me feedback please? Having a safe wl_signal_emit would greatly benefit libwayland users. ​--- Simon Ser https://emersion.fr Original Message On January 28, 2018 6:37 PM, Simon Ser <cont...@emersion.fr> wrote: > >This is a RFC to be able to run tes

[PATCH] RFC: server: implement wl_priv_signal_emit without emit_list

2018-01-28 Thread Simon Ser
This is a RFC to be able to run tests and check that this approach is working. The end goal is to remove wl_priv_signal completely and implement a safe wl_signal_emit. --- What do you think of this approach? It passes all the tests. src/wayland-private.h | 1 - src/wayland-server.c | 31

Re: [PATCH v2] server: add wl_display_destroy_clients()

2017-12-13 Thread Simon Ser
> Original Message >Subject: Re: [PATCH v2] server: add wl_display_destroy_clients() >Local Time: December 13, 2017 1:39 PM >UTC Time: December 13, 2017 12:39 PM >From: ppaala...@gmail.com >To: Simon Ser <cont...@emersion.fr> >wayland-devel@lists.fre

Re: [PATCH v2] server: add wl_display_destroy_clients()

2017-12-13 Thread Simon Ser
> Original Message >Subject: Re: [PATCH v2] server: add wl_display_destroy_clients() >Local Time: December 13, 2017 12:11 PM >UTC Time: December 13, 2017 11:11 AM >From: ppaala...@gmail.com >To: emersion >wayland-devel@lists.freedesktop.org > >On Wed, 13 Dec

Add serial to wl_output::geometry?

2017-08-03 Thread Simon Ser
hing like "HS3P505873")? Would it be possible to add it to the protocol or is it too late? Is there another way to identify screens? Thanks, --- Simon Ser https://emersion.fr___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https:

<    1   2   3   4   5