Retiring the GitHub mirrors

Hello everyone, For many years now, we have maintained mirrors of numerous FDo projects on GitHub, under the following organisations: https://github.com/freedesktop https://github.com/mesa3d https://github.com/wayland-project A bit over a month ago, a new security feature in git started

Re: [RFC] Allow fd.o to join forces with X.Org

hat follow X.Org's > purpose as enacted in its bylaws. Other projects can continue to be > hosted on fd.o but won't receive X.Org membership for the mere reason > of > being hosted on fd.o. With my member hat on, I think this is the best choice. Acked-by: Eric Engestrom > &g

[PATCH wayland] TODO: remove "SDL port", it's been done by now

Upstream SDL supports Wayland since v2.0.4 (June 2015): https://forums.libsdl.org/viewtopic.php?t=11294 Just set SDL_VIDEODRIVER=wayland and SDL will do the right thing :) Signed-off-by: Eric Engestrom --- TODO | 3 --- 1 file changed, 3 deletions(-) diff --git a/TODO b/TODO index

Re: [PATCH weston v4 3/4] simple-dmabuf-drm: 0 is a valid fd (freedreno)

On Monday, 2018-03-19 17:45:20 +0100, Guido Günther wrote: > Signed-off-by: Guido Günther <a...@sigxcpu.org> It is indeed :) Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > clients/simple-dmabuf-drm.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 dele

Re: [PATCH weston v4 2/4] simple-dmabuf-drm: use large enough buffer (freedreno)

On Monday, 2018-03-19 17:45:19 +0100, Guido Günther wrote: > Use stride instead of width for buffer calculation. > > Signed-off-by: Guido Günther > --- > clients/simple-dmabuf-drm.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH wayland] wayland-egl: Make symbol test fail on failure

On Monday, 2018-03-19 16:10:57 +, Daniel Stone wrote: > Hi, > > On 19 March 2018 at 16:08, Eric Engestrom <eric.engest...@imgtec.com> wrote: > > On Monday, 2018-03-19 15:13:14 +, Daniel Stone wrote: > >> +if ! test -f "$LIB"; then > >>

Re: [PATCH wayland] wayland-egl: Make symbol test fail on failure

On Monday, 2018-03-19 15:13:14 +, Daniel Stone wrote: > The previous rewrite of the wayland-egl ABI checker introduced checks > for removed symbols as well as added symbols, but broke some failure > conditions. Add an explict return-code variable set in failure paths, > rather than chaining or

Re: [PATCH wayland v3 1/3] wayland-egl: fail the symbol check if lib is missing

On Monday, 2018-03-19 12:11:50 +, Eric Engestrom wrote: > On Monday, 2018-03-19 11:43:08 +, Emil Velikov wrote: > > On 19 March 2018 at 09:56, Pekka Paalanen <ppaala...@gmail.com> wrote: > > > On Fri, 16 Mar 2018 16:18:57 + > > > Emil Velikov

Re: [PATCH wayland v3 1/3] wayland-egl: fail the symbol check if lib is missing

13:52, Pekka Paalanen <ppaala...@gmail.com> wrote: > >> > On Thu, 15 Mar 2018 14:30:27 + > >> > Emil Velikov <emil.l.veli...@gmail.com> wrote: > >> > > >> >> From: Emil Velikov <emil.veli...@collabora.com> > >> >> &

Re: [PATCH wayland] wayland-egl: use correct `nm` path when cross-compiling

On Friday, 2018-02-23 17:31:53 +, Emil Velikov wrote: > From: Emil Velikov <emil.veli...@collabora.com> > > Inspired by Heiko Becker and Eric's work in libdrm and Mesa > respectively. > > Cc: Eric Engestrom <eric.engest...@imgtec.com> > Signed-off-by: Emil Ve

Re: [PATCH wayland 4/6] wayland-egl: fail the symbol check if lib is missing

On February 15, 2018 6:55:14 PM UTC, Emil Velikov <emil.l.veli...@gmail.com> wrote: > From: Emil Velikov <emil.veli...@collabora.com> > > Based on a similar patch (in Mesa) by Eric Engestrom. > > Cc: Eric Engestrom <eric.engest...@imgtec.com> Reviewed-by:

Re: [PATCH libinput] fallback: send key events out immediately upon receiving them

On Friday, 2017-12-08 10:17:17 +1000, Peter Hutterer wrote: > Commit db3b6fe5f7f8 "fallback: change to handle the state at EV_SYN time" > introduced regressions for two types of event sequences. > > One is a kernel bug - some devices/drivers like the asus-wireless send a key > press + release

Re: [PATCH weston 1/2] config-parser: fix `short_name` type

On Tuesday, 2017-12-05 13:47:06 +, Daniel Stone wrote: > Hi Eric, > > On 8 June 2017 at 22:20, Eric Engestrom <eric.engest...@imgtec.com> wrote: > > On Wednesday, 2017-05-24 21:23:14 +0100, Eric Engestrom wrote: > >> This field is populated with chars,

Re: [PATCH] Add m1bpp (monochrome, 1 bit/pixel) pixel format

On Friday, 2017-09-15 11:17:29 -0400, Drew DeVault wrote: > On 2017-09-15 6:06 PM, Pekka Paalanen wrote: > > Indeed, 2 and 4 bit formats are also missing, but 8 and 16 bit ones are > > already defined unless you meant some new variation. > > The 8 and 16 bit ones, so far as I can tell, are 8/16

Re: [PATCH weston] clients/nested: fix boolean test

On Monday, 2017-09-11 16:08:53 +0100, Emil Velikov wrote: > On 11 September 2017 at 15:40, Eric Engestrom <eric.engest...@imgtec.com> > wrote: > > On Monday, 2017-09-11 13:52:28 +0100, Eric Engestrom wrote: > >> weston_check_egl_extension() returns a bool, not a poi

Re: [PATCH weston] clients/nested: fix boolean test

On Monday, 2017-09-11 13:52:28 +0100, Eric Engestrom wrote: > weston_check_egl_extension() returns a bool, not a pointer. > > Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> Fixes: ce5b614c80b4dfe8e899 "clients/nested: use weston_check_egl_extension

[PATCH weston] clients/nested: fix boolean test

weston_check_egl_extension() returns a bool, not a pointer. Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- clients/nested.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clients/nested.c b/clients/nested.c index 173076a6..e9070e9b 100644 --- a/c

Re: [PATCH libinput] tools: add the libinput version to the man pages

On Friday, 2017-06-30 16:21:39 +0100, Eric Engestrom wrote: > On Thursday, 2017-06-29 10:01:10 +1000, Peter Hutterer wrote: > > Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> > > --- > > configure.ac

Re: [PATCH libinput] tools: add the libinput version to the man pages

, Well, it's a shame install_man() doesn't have a `configuration:` argument :( > +install : true, > +install_dir : join_paths(get_option('mandir'), 'man1') Took me a minute to find that get_option() allows you to query builtin options as well [1]. Is there a list of those builtin

Re: [PATCH libinput] meson: restore the SELinux context for our .so file on install

On 21 June 2017 00:43:10 BST, Peter Hutterer <peter.hutte...@who-t.net> wrote: >Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> >--- >A temporary workaround until the meson bit is fixed. Reviewed-by: Eric Engestrom <e...@engestrom.ch > > meson.build

[PATCH libinput] doc: update build instructions for Arch

://www.archlinux.org/news/deprecation-of-abs/ Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- doc/building.dox | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/doc/building.dox b/doc/building.dox index 5ce2146..355c535 100644 --- a/doc/building.dox +++

Re: [PATCH libinput] doc: add instructions for handling SELinux denials

ibinput.so.* > +$> sudo restorecon /usr/lib64/libinput.so.* > + > + > +Pick whichever one is your libdir. You don't need this note if you give that command instead :) $> sudo restorecon /usr/lib*/libinput.so.* Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com>

Re: [PATCH libinput 1/3] meson: rename 'enable-tests' option to just 'tests'

On Tuesday, 2017-06-20 12:26:24 +1000, Peter Hutterer wrote: > All the other config options have a simple true/false as well. > > Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> All 3 patches are: Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > ---

Re: [PATCH weston 1/2] config-parser: fix `short_name` type

On Wednesday, 2017-05-24 21:23:14 +0100, Eric Engestrom wrote: > This field is populated with chars, compared to chars and printed as > a char. It should probably be a char. > > Signed-off-by: Eric Engestrom <e...@engestrom.ch> Humble ping? I don't have commit access eith

Re: [PATCH] test: use unique names for all the test suite names

{ > int in, out, length; > struct created_file *file; > + long int suffixlen; My man says `int suffixlen` (without `long`), but it doesn't really matter. Everything else looks good to me: Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > > file = za

[PATCH weston 1/2] config-parser: fix `short_name` type

This field is populated with chars, compared to chars and printed as a char. It should probably be a char. Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- shared/config-parser.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/shared/config-parser.h b/shared/

[PATCH weston 2/2] option-parser: replace int/0/1 with bool/false/true

These are already used as bools by all callers, let's make that official. Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- shared/option-parser.c | 39 --- 1 file changed, 20 insertions(+), 19 deletions(-) diff --git a/shared/option-parser.c b/

Re: [PATCH libinput 4/4] tools: hook libinput-debug-events into the libinput tool

On Wednesday, 2017-05-17 09:02:32 +1000, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > --- > meson.build | 7 +++-- > tools/Makefile.am | 8 -- > tools/libinput-debug-events.c | 15 +-- > tools/libinput-tool.c

Re: [PATCH libinput] evdev: replace null sentinel with ARRAY_SIZE

On Wednesday, 2017-05-10 17:25:04 +0200, Jan Engelhardt wrote: > > On Wednesday 2017-05-10 17:20, Dima Ryazanov wrote: > > +#define ARRAY_SIZE(a) (sizeof(a)/sizeof(a)[0]) > > > > > >I'm guessing this works, but "sizeof(a)[0]" looks very unintuitive to me. I > >think "sizeof(a[0])" is > >the

[PATCH libinput] libinput: rewrite loop to make it more readable

Rewrite foo(); while(...) { foo(); } into do { foo(); } while(...); to avoid duplication and make the flow easier to read and understand. Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/libinput.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

Re: [PATCH libinput 5/5] evdev: fix a compiler warning about a missing field initializer

On Wednesday, 2017-05-10 13:48:00 +1000, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> This series is Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > src/evdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(

Re: [RESEND] [PATCH] weston: Add support for "--foo bar" style options

if (strncmp(options[k].name, arg + 2, len) != 0) > + continue; > + > + if (options[k].type == WESTON_OPTION_BOOLEAN) > + continue; Am I understanding this right, that you're skipping this here because it is already be handled by long_option()? I think this

Re: [PATCH v2 libinput 3/5] test: allow running the symbols-leak-test.in script directly

Reviewed-by: Eric Engestrom <e...@engestrom.ch> On 2 May 2017 01:01:32 BST, Peter Hutterer <peter.hutte...@who-t.net> wrote: >With autotools, we replace the @top_srcdir@ during configure and then >run >the resulting scripts. > >With meson, it's easier to just pass t

Re: [PATCH libinput 3/5] test: allow running the symbols-leak-test.in script directly

On Wednesday, 2017-04-26 12:20:39 +1000, Peter Hutterer wrote: > With autotools, we replace the @top_srcdir@ during configure and then run teh > resulting scripts. > > With meson, it's easier to just pass top-srcdir it in as argument. > > Signed-off-by: Peter Hutterer

Re: [PATCH weston 1/2] os: Check for EINTR on posix_fallocate()

On Thursday, 2017-03-23 11:59:22 -0500, Derek Foreman wrote: > posix_fallocate() can return EINTR and need to be restarted - I've hit > this when running weston-terminal under gdb. > > Signed-off-by: Derek Foreman <der...@osg.samsung.com> Both patches are: Reviewed-

[PATCH wayland] connection-test: fix assert

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- tests/connection-test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/connection-test.c b/tests/connection-test.c index 8be6c38..157e1bc 100644 --- a/tests/connection-test.c +++ b/tests/connection-

Re: [PATCH] [wayland] configure: add option to disable tests

rwise it'll never match, and you can drop the quotes :) I think allowing to leave out tests is reasonable. I tested it a bit too, to make sure it doesn't break `make check` or `make distcheck`, so with the above fix, you can have my: Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> Tes

Re: [PATCH xserver] xwayland: add envvar XWAYLAND_NO_GLAMOR

acceleration in Xwayland (glamor being used by default). > > Add an environment variable XWAYLAND_NO_GLAMOR t odiable glamor support "to disable" The change itself looks good to me. Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> As to whether it's a good idea to

Re: [PATCH wayland v2 2/4] wayland-util: split out private functionality to separate file

On Tuesday, 2017-02-21 16:14:27 +, Emil Velikov wrote: > From: Emil Velikov > > With next commit we'll make wayland-util a shared library (for reasons > mentioned in the commit). As such we need to make sure that the private > symbols are somewhere that they can

Re: [PATCH weston] clients/simple-egl: add -d option

ndow.geometry; > window.buffer_size = 32; > window.frame_sync = 1; > + window.delay = 0; > > for (i = 1; i < argc; i++) { > - if (strcmp("-f", argv[i]) == 0) > + if (strcmp("-d", argv[i]) == 0 &

Re: [PATCH weston] clients/weston-info: print unknown formats better

* 8); > + str[i] = '\0'; > +} > + > static void > print_shm_info(void *data) > { > + char str[6]; 6? not 5? These are nit-picks, this patch already does what it says on the tin: Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > struct

Re: [PATCH weston] xwm: Add icon support to the frame

On Sunday, 2016-12-04 21:20:47 +, Emmanuel Gil Peyrot wrote: > This fetches the _NET_WM_ICON property of the X11 window, and use the > first image found as the frame icon. > > This has been tested with various X11 programs, and improves usability > and user-friendliness a bit. > >

Re: [PATCH weston v2] xwayland: Fix X11 lock file size confusion

id=774613 > > Signed-off-by: Daniel Stone <dani...@collabora.com> > Cc: Pekka Paalanen <pekka.paala...@collabora.co.uk> > Cc: Eric Engestrom <e...@engestrom.ch> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > xwayland/launcher.c | 24 ++

Re: [PATCH weston 5/9] clients/simple-dmabuf-intel: rename to simple-dmabuf-drm

On Thursday, 2016-11-17 17:25:59 +0530, Varad Gautam wrote: > From: Varad Gautam > > this will allow adding other drm backends later. > > Signed-off-by: Varad Gautam > --- > Makefile.am | 12 +- >

Re: [PATCH weston] xwayland: Fix X11 lock file size confusion

nts. > > Related Mutter issue: https://bugzilla.gnome.org/show_bug.cgi?id=774613 > > Signed-off-by: Daniel Stone <dani...@collabora.com> > Cc: Pekka Paalanen <pekka.paala...@collabora.co.uk> > Cc: Eric Engestrom <e...@engestrom.ch> > --- > xwayland/la

Re: [PATCH weston] xwayland: Remove pointless newline in X11 lock

On Wednesday, 2016-11-16 16:37:59 +, Daniel Stone wrote: > The newline was always chopped off by snprintf: pid is only 11 Don't you mean 10? Reviewed-by: Eric Engestrom <e...@engestrom.ch> > characters long, and we were asking to print 11 characters plus the > terminat

Re: [PATCH weston 1/2] gl-renderer: add support for EGL_KHR_swap_buffers_with_damage

le is to get the entrypoint when you found an extension, how about `swap_buffers_with_damage_ext_to_entrypoint`? Rather long I'll concede, but explicit. You can also drop the middle bit: `swap_damage_ext_to_entrypoint` With an appropriate name here (and the other patch), the

Re: [PATCH libinput 1/3] Mark some internal log functions as printf-style function

const char *format, va_list args) +/* You can also add the attribute here if you prefer */ { (Obviously, the same suggestion applies to all the functions in this patch.) Patches 2 & 3 look good to me: Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > const char *pref

[PATCH weston v2 2/2] config-parser-test: test support for more color formats

Add tests for all the supported colour formats Cc: Bryce Harrington <br...@osg.samsung.com> Cc: Quentin Glidic <sardemff7+wayl...@sardemff7.net> Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- v2: reduce the number of formats supported read #-prefixed values the

[PATCH weston v2 1/2] config-parser: add support for more color formats

Supported colour formats are: - (0x)(AA)RRGGBB - #RGB(A) - #RRGGBB(AA) Cc: Bryce Harrington <br...@osg.samsung.com> Cc: Quentin Glidic <sardemff7+wayl...@sardemff7.net> Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- v2: reduce the number of formats supported read

Re: [PATCH weston 1/2] config-parser: add support for more color formats

On Friday, 2016-10-21 12:30:07 +0200, Quentin Glidic wrote: > Hi, > > On 20/10/2016 00:08, Eric Engestrom wrote: > > Valid colours start with an optional '0x' or '#', followed by: > > - AARRGGBB > > - RRGGBB > > - A R G B > > -R G B > > - X

Re: [weston] gl-renderer: add support of WL_SHM_FORMAT_YUYV

gt; + r.y1 / gs->hsub[j], > + (r.x2 - r.x1) / gs->vsub[j], > + (r.y2 - r.y1) / gs->vsub[j], I think you got your horizontal and vertical subsamplin

[PATCH weston 2/2] config-parser-test: test support for more color formats

Test for all the possible lengths (up to 8), specifying which are expected to be valid and how they should be interpreted. Sprinkle some `#` and `0x` around randomly to make sure those work at any length too. Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- tests/config-parser-test.c

[PATCH weston 1/2] config-parser: add support for more color formats

Valid colours start with an optional '0x' or '#', followed by: - AARRGGBB - RRGGBB - A R G B -R G B - XYXYXY - XX Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- I just stumbled back on this discussion from a few months ago, and decided to give it a go. Once ag

Re: [PATCH weston v3] clients: Add XKB compose key support

> and with no mechanism to load system or user-specified compose keys. > > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=53648 > Signed-off-by: Bryce Harrington <br...@osg.samsung.com> > Reviewed-by: Daniel Stone <dani...@collabora.com> > > Signed-

Re: [PATCH weston v2 2/3] compositor-drm: Add scanout support for linux_dmabuf buffers

On Fri, Sep 30, 2016 at 06:28:52PM +0900, Tomohito Esaki wrote: > This implementations bypasses gbm and passes the dmabuf handles directly > to libdrm for composition. > > Signed-off-by: Tomohito Esaki > --- > libweston/compositor-drm.c | 125 >

Re: [PATCH weston v2 1/3] compositor-drm: refactor destroy drm_fb function

> Signed-off-by: Tomohito Esaki <e...@igel.co.jp> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > libweston/compositor-drm.c | 31 --- > 1 file changed, 16 insertions(+), 15 deletions(-) > > diff --git a/libweston/com

Re: Compiling Weston with musl-libc (WAS: [PATCH weston] weston-launch: use custom error function)

On Fri, Sep 30, 2016 at 02:07:38PM +0200, Armin Krezović wrote: > On 30.09.2016 13:59, Eric Engestrom wrote: > > On Fri, Sep 30, 2016 at 11:36:24AM +0100, Murray Calavera wrote: > >> On 30 September 2016 at 11:10, Eric Engestrom <eric.engest...@imgtec.com> > >>

Compiling Weston with musl-libc (WAS: [PATCH weston] weston-launch: use custom error function)

On Fri, Sep 30, 2016 at 11:36:24AM +0100, Murray Calavera wrote: > On 30 September 2016 at 11:10, Eric Engestrom <eric.engest...@imgtec.com> > wrote: > > > On Thu, Sep 29, 2016 at 09:26:16PM +0100, Murray Calavera wrote: > > > error.h is a gnu extension and not av

Re: [PATCH weston] weston-launch: use custom error function

r me, `CC=musl-gcc ./autogen.sh` stops on: [...] checking for library containing pam_open_session... no configure: error: weston-launch requires pam The code looks good though (with one nit-pick), so even if I couldn't test it, it is: Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> &

Re: [PATCH wayland v2 2/4] wl_array: Set data to invalid address after free

viewed-by: Eric Engestrom <eric.engest...@imgtec.com> (BTW patchwork doesn't understand "the series is", does it? Or does it have to be a specific keyword?) Cheers, Eric ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https:/

Re: [PATCH wayland v2 2/4] wl_array: Set data to invalid address after free

On Tue, Sep 27, 2016 at 01:03:48PM -0500, Yong Bakos wrote: > From: Yong Bakos > > Explicitly set the data member to an invalid memory address during > wl_array_release, such that re-using a freed wl_array without re-initializing > causes a crash. In addition, this

Re: [PATCH weston v2] clients/stacking: Silence a compiler warning

On Tue, Sep 27, 2016 at 12:35:55PM +0200, Armin Krezović wrote: > This patch fixes a compiler warning when building with > clang, since it doesn't support gnu_printf attribute. > > v2: > > - Switch to WL_PRINTF per suggestion from Eric Engestrom. > > Signed-off-by: Arm

Re: [PATCH wayland 2/4] wl_array: Set data to null after free

On Mon, Sep 19, 2016 at 11:59:03AM +0100, Eric Engestrom wrote: > On Fri, Sep 16, 2016 at 03:37:37PM -0700, Yong Bakos wrote: > > From: Yong Bakos <yba...@humanoriented.com> > > > > Explicitly set the data member to NULL during wl_array_release, preventing > > t

Re: [PATCH wayland 2/4] wl_array: Set data to null after free

2,7 @@ WL_EXPORT void > wl_array_release(struct wl_array *array) > { > free(array->data); > + array->data = NULL; If we add array->size = 0; array->alloc = 0; we can then remove this comment from patch #1, right? \note Leaves the array in an

Re: [PATCH libinput] tools: prefix debug output with '.' on device changes

On Thu, Sep 15, 2016 at 07:55:54AM +1000, Peter Hutterer wrote: > On Wed, Sep 14, 2016 at 05:48:26PM +0100, Eric Engestrom wrote: > > On Thu, Sep 08, 2016 at 03:55:47PM +1000, Peter Hutterer wrote: > > > diff --git a/tools/event-debug.c b/tools/event-debug.c > > > in

Re: [PATCH] clients/stacking: Silence a compiler warning

On Sat, Sep 10, 2016 at 10:55:21PM +0200, Armin Krezović wrote: > clang doesn't support gnu_print attribute, so just > leave it out when clang is used. > > Signed-off-by: Armin Krezović > --- > clients/stacking.c | 4 > 1 file changed, 4 insertions(+) > > diff

[PATCH libinput] tools: change pointer to void

This makes it clear that it's not meant to be dereferenced. CC: Peter Hutterer <peter.hutte...@who-t.net> Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- tools/event-debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/event-debug.c b

Re: [PATCH libinput] tools: prefix debug output with '.' on device changes

@ print_event_header(struct libinput_event *ev) > break; > } > > - printf("%-7s%-16s ", libinput_device_get_sysname(dev), type); > + prefix = (last_device != dev) ? '-' : ' '; Nit: that line would be even shorter within the printf than here

Re: [PATCH libinput] doc: extend build instructions for dependencies

On Thu, Sep 01, 2016 at 11:18:12AM +0100, Eric Engestrom wrote: > On Thu, Sep 01, 2016 at 09:53:36AM +1000, Peter Hutterer wrote: > > Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> > > --- > > Mostly sending this out for any hints on how to deal wit

Re: [PATCH libinput] doc: extend build instructions for dependencies

On Thu, Sep 01, 2016 at 09:53:36AM +1000, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > --- > Mostly sending this out for any hints on how to deal with this in Arch or > other distributions not listed here. Let me know and I'll add it to the > list. The Arch

Re: [PATCH wayland 2/2] tests: Add test for wl_list_length

nd insert(e) to make sure duplicates are handled correctly? With or without this, the series is Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > + wl_list_remove(); > + assert(wl_list_length() == 0); > +} > + > TEST(list_iterator) > { > str

Re: [PATCH weston v3 4/5] Add safe_strtoint() helper

ing int32_t, not int :) > > + * successful the result is stored in *value; otherwise *value is > > + * unchanged and errno is set appropriately. > > + * > > + * \return true if number parsed successfully, false on error > > "if the number". IMO you should squ

Re: [PATCH libinput 5/6] touchpad: change palm detection trigger functions to bools

ime)) > + if (tp_palm_detect_dwt_triggered(tp, t, time)) > goto out; > > - if (tp_palm_detect_trackpoint(tp, t, time)) > + if (tp_palm_detect_trackpoint_triggered(tp, t, time)) > goto out; > > if (t->palm.state == PALM_EDGE) { > -- >

Re: [PATCH wayland] (multiple): Include stdint.h

> > Signed-off-by: Yong Bakos <yba...@humanoriented.com> Matches my grep. Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > cursor/cursor-data.h | 2 ++ > cursor/wayland-cursor.c | 1 + > src/event-loop.c | 1 + > src/scanner.c

Re: [PATCH weston] shared: include stdint.h for int32_t

On Mon, Jul 18, 2016 at 09:53:20AM +0100, Eric Engestrom wrote: > On Sat, Jul 16, 2016 at 11:32:49PM +0300, Jussi Kukkonen wrote: > > This fixes build on musl. > > > > Signed-off-by: Jussi Kukkonen <jussi.kukko...@intel.com> > > Reviewed-by: Eric Engestrom <

Re: [PATCH weston] shared: include stdint.h for int32_t

On Sat, Jul 16, 2016 at 11:32:49PM +0300, Jussi Kukkonen wrote: > This fixes build on musl. > > Signed-off-by: Jussi Kukkonen <jussi.kukko...@intel.com> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > shared/xalloc.h | 1 + > 1 file changed,

Re: [PATCH weston 1/2] config-parser: Add weston_config_section_get_color

On Fri, Jul 15, 2016 at 10:13:03AM +0100, Eric Engestrom wrote: > On Thu, Jul 14, 2016 at 11:30:39AM -0700, Bryce Harrington wrote: > > On Thu, Jul 14, 2016 at 01:35:09PM +0100, Eric Engestrom wrote: > > > On Wed, Jul 13, 2016 at 07:01:28PM -0700, Bryce Harrington wrote:

Re: [PATCH weston 1/2] config-parser: Add weston_config_section_get_color

On Thu, Jul 14, 2016 at 11:30:39AM -0700, Bryce Harrington wrote: > On Thu, Jul 14, 2016 at 01:35:09PM +0100, Eric Engestrom wrote: > > On Wed, Jul 13, 2016 at 07:01:28PM -0700, Bryce Harrington wrote: > > > Previously weston_config_section_get_uint was serving dual purpose for

Re: [PATCH weston 1/2] config-parser: Add weston_config_section_get_color

o invalid; } /* ... */ invalid: *color = default_color; errno = EINVAL; return -1; Additionally, I agree with Quentin, since you made a special function for colors, we might as well have it support more color formats, but IMO that sh

Re: [PATCH weston] rdp: Check for non-digits and errno in strtol call

On Mon, Jul 11, 2016 at 05:02:44PM -0700, Bryce Harrington wrote: > Improve error checking for situations like RDP_FD=42foo, or where the > provided number is out of range. > > Suggestion by Yong Bakos. > > Signed-off-by: Bryce Harrington <br...@osg.samsung.com> Rev

Re: [PATCH weston] config-parser: Catch negative numbers assigned to unsigned config values

r of these limits, so the change is believed to have no impact > in practice. > > Also add a test case for negative numbers that catches this error > condition. > > Signed-off-by: Bryce Harrington <br...@osg.samsung.com> Looks good to me. Reviewed-by: Eric Engestrom <eri

Re: [PATCH weston] config-parser: Improve error checks for strtol/strtoul calls

On Fri, Jul 08, 2016 at 10:26:43AM +0100, Eric Engestrom wrote: > On Thu, Jul 07, 2016 at 02:08:28PM -0700, Bryce Harrington wrote: > > + errno = 0; > > *value = strtol(entry->value, , 0); > > - if (*end != '\0') { > > + if (errno != 0 || end == entry->va

Re: [PATCH weston] xwayland: Include missing config.h

On Wed, Jul 06, 2016 at 03:14:20PM -0700, Bryce Harrington wrote: > Signed-off-by: Bryce Harrington <br...@osg.samsung.com> Indeed, this is needed for XSERVER_PATH Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > compositor/xwayland.c | 2 ++ > 1 fi

Re: [PATCH weston] xwayland: Cleanup error message on spawn failure Signed-off-by: Bryce Harrington <br...@osg.samsung.com>

On Wed, Jul 06, 2016 at 03:18:46PM -0700, Bryce Harrington wrote: > Signed-off-by: Bryce Harrington <br...@osg.samsung.com> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > compositor/xwayland.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [PATCH weston] xwayland: Grammar fixes

tected the given \a spawn_func callback will be called to start >* the Xwayland process. >* "an X socket", maybe? Either way, your changes are good: Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> ___ wayland

Re: [PATCH weston] dmabuf: Fix grammar in a comment

On Wed, Jul 06, 2016 at 03:30:54PM -0700, Bryce Harrington wrote: > Signed-off-by: Bryce Harrington <br...@osg.samsung.com> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > libweston/linux-dmabuf.c | 2 +- > 1 file changed, 1 insertion(+), 1 del

Re: [PATCH libinput] gestures: make the gesture movement threshold depending on finger count

On Thu, Jun 30, 2016 at 02:10:24PM +0100, Eric Engestrom wrote: > The threshold now becomes 0 for 1 finger, which I assume was not the Sorry for the noise, I just realized this code only applies to >2 fingers, so you can just ignore my previous m

Re: [PATCH libinput] gestures: make the gesture movement threshold depending on finger count

On Thu, Jun 30, 2016 at 12:22:10PM +1000, Peter Hutterer wrote: > Increase the mm move threshold for 3 and 4 finger gestures to 2 and 3 mm, > respectively. In multi-finger gestures it's common to have minor movement > while all fingers are being put down or before the conscious movement starts. >

[PATCH wayland 3/5] util: fix typo

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/wayland-util.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wayland-util.h b/src/wayland-util.h index cc1999d..8da156c 100644 --- a/src/wayland-util.h +++ b/src/wayland-util.h @@ -300,7 +300,7 @@

[PATCH wayland 1/5] client: fix typo

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/wayland-client.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/wayland-client.c b/src/wayland-client.c index 7af806c..03c087a 100644 --- a/src/wayland-client.c +++ b/src/wayland-client.c @@ -581,7

[PATCH wayland 5/5] tests: fix typo

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- tests/test-runner.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test-runner.c b/tests/test-runner.c index 742b4f0..4aa6667 100644 --- a/tests/test-runner.c +++ b/tests/test-runner.c @@ -205,7 +205,7 @@ ru

[PATCH wayland 2/5] server: fix typo

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/wayland-server.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wayland-server.c b/src/wayland-server.c index ae9365f..f745e62 100644 --- a/src/wayland-server.c +++ b/src/wayland-server.c @@ -1308,7 +

Re: [PATCH wayland] connection: remove redundant assignment

eturn; > } > > first, the object is already NULL, second, the assignment has no effect > since we return from the function right away > > Signed-off-by: Marek Chalupa <mchqwe...@gmail.com> Either way, it's Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> __

[PATCH weston 2/3] xwayland: fix spelling mistake

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- xwayland/selection.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xwayland/selection.c b/xwayland/selection.c index 6f5328d..bd5e28a 100644 --- a/xwayland/selection.c +++ b/xwayland/selection.c @@ -117,7

[PATCH wayland 2/2] wayland-client: fix spelling mistake

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/wayland-client.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/wayland-client.c b/src/wayland-client.c index 297c7a5..33033e7 100644 --- a/src/wayland-client.c +++ b/src/wayland-client.c @@ -1587,7 +

[PATCH weston 3/3] client: fix spelling mistake

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- clients/flower.c | 2 +- clients/scaler.c | 2 +- clients/smoke.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/clients/flower.c b/clients/flower.c index aafc63c..34287fd 100644 --- a/clients/flower.c +++ b/c

[PATCH libinput] fix spelling mistakes

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- doc/t440-support.dox | 2 +- src/evdev-tablet.c | 2 +- src/evdev.c | 2 +- src/filter.c | 2 +- src/libinput.h | 8 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/doc/t440-support.dox

[PATCH weston 1/3] zunitc: fix spelling mistake

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- tools/zunitc/inc/zunitc/zunitc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/zunitc/inc/zunitc/zunitc.h b/tools/zunitc/inc/zunitc/zunitc.h index 0fa78e3..6ac6f39 100644 --- a/tools/zunitc/inc/zunitc/zunitc.h

[PATCH weston] zunitc: remove `break` after `return`

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- tools/zunitc/src/zuc_base_logger.c | 6 -- tools/zunitc/src/zunitc_impl.c | 11 --- 2 files changed, 17 deletions(-) diff --git a/tools/zunitc/src/zuc_base_logger.c b/tools/zunitc/src/zuc_base_logger.c index 1beb60d..c

  1   2   >