Re: wayland-protocols scope and governance

2019-10-16 Thread Mike Blumenkrantz
Hi, I've been following along on this thread, and I really appreciate that you've reached out to me. The current document seems reasonable to me. It will be a positive for the ecosystem to have a clearly-defined method of proposing and stabilizing new protocols for adoption. I'm not quite as

Re: wayland-protocols scope and governance

2019-02-21 Thread Mike Blumenkrantz
Hello, On Thu, Feb 21, 2019 at 10:47 AM Daniel Stone wrote: > > One of Weston's goals is to be a reference compositor. As an active > implementation, it serves as a useful neutral ground for the rest of > the ecosystem: we try to be exhaustively correct in what we do > implement, and gets used

[PATCH] xdg-shell: add enums for tiled window state to toplevel configure

2018-04-13 Thread Mike Blumenkrantz
would set the right|top|bottom tiled states in configure Signed-off-by: Mike Blumenkrantz <zm...@osg.samsung.com> Reviewed-by: Jonas Ådahl <jad...@gmail.com> Changes since v2: simplified docs Changes since v1: added since=2 to enum members --- stable/xdg-shell/xdg-sh

[PATCH] xdg-shell: add enums for tiled window state to toplevel configure

2018-04-10 Thread Mike Blumenkrantz
would set the right|top|bottom tiled states in configure Signed-off-by: Mike Blumenkrantz <zm...@osg.samsung.com> Changes since v1: added since=2 to enum members --- stable/xdg-shell/xdg-shell.xml | 34 +- 1 file changed, 29 insertions(+), 5 deletions(-) diff

Re: [PATCH] xdg-shell: add enums for tiled window state to toplevel configure

2018-03-20 Thread Mike Blumenkrantz
On Tue, Mar 20, 2018 at 10:15 AM Simon McVittie <s...@collabora.com> wrote: > On Tue, 20 Mar 2018 at 09:52:02 -0400, Mike Blumenkrantz wrote: > > this adds implementation from a related discussion long ago in which > > it was decided that it would be useful for cli

[PATCH] xdg-shell: add enums for tiled window state to toplevel configure

2018-03-20 Thread Mike Blumenkrantz
would set the right|top|bottom tiled states in configure Signed-off-by: Mike Blumenkrantz <zm...@osg.samsung.com> --- stable/xdg-shell/xdg-shell.xml | 34 +- 1 file changed, 29 insertions(+), 5 deletions(-) diff --git a/stable/xdg-shell/xdg-shell.xml b/stab

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-15 Thread Mike Blumenkrantz
It seems to me that there is no harm in restating that clients are required to implement CSD inside a protocol which permits adding a separate, optional method of window decoration. Note that it is not an assumption that clients/compositors "support both" modes, it's a hard requirement that

Re: [PATCH wayland-protocols] unstable: add xdg-toplevel-decoration protocol

2018-03-02 Thread Mike Blumenkrantz
s, so that toolkits like > GLFW or winit and apps like mpv don't have to draw decorations that'll look > alien and don't respect the user's preferences > - But still preferring CSDs, so that GTK+ apps can use them > > Also, the CSD mode allows the client to do not draw decorations at all. &

Re: [PATCH wayland-protocols] unstable: add xdg-toplevel-decoration protocol

2018-03-01 Thread Mike Blumenkrantz
Hi, This patch is certainly an improvement upon the previous protocol draft which I reviewed, but it still does not address the most significant issue that I pointed out, which is that it both is too complex and lacks features. Why is there any "mode" when this is a protocol for enabling

Re: [PATCH 1/2] xdg-shell: move maximized state difnition together

2018-02-27 Thread Mike Blumenkrantz
With typos corrected: Reviewed-By: Mike Blumenkrantz <zm...@osg.samsung.com> On Tue, Feb 27, 2018 at 8:23 AM Silvan Jegen <s.je...@gmail.com> wrote: > Hi > > One typo corrected below. > > On Tue, Feb 27, 2018 at 1:24 PM, <w...@ongy.net> wrote: > &g

Re: [PATCH 2/2] xdg-shell: Make sure wording reflects expectations

2018-02-27 Thread Mike Blumenkrantz
Hi, This seems like a reasonable direction for a change, though I would suggest a slightly different approach. For all cases where it reads "the compositor will respond by emitting", instead change to something like "if the compositor decides to apply this state change then it will respond by

[PATCH] unstable: add xdg-session-management protocol

2018-02-26 Thread Mike Blumenkrantz
Signed-off-by: Mike Blumenkrantz <zm...@osg.samsung.com> Signed-off-by: Jonas Ådahl <jad...@gmail.com> --- Makefile.am| 1 + unstable/xdg-session-management/README | 4 + .../xdg-session-management-unstable-v1.xml | 181 ++

[PATCH] xdg-shell: remove harmless typo

2018-01-19 Thread Mike Blumenkrantz
Signed-off-by: Mike Blumenkrantz <zm...@osg.samsung.com> --- stable/xdg-shell/xdg-shell.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stable/xdg-shell/xdg-shell.xml b/stable/xdg-shell/xdg-shell.xml index dc70c7a..d524ea9 100644 --- a/stable/xdg-shell/xdg-shell.xml

Re: Future of xdg-shell v5 support in weston

2018-01-19 Thread Mike Blumenkrantz
I think that keeping it only promotes using it and further propagating its use, so I'm in favor of removal. On Fri, Jan 19, 2018 at 11:22 AM Derek Foreman wrote: > Hello, > > As you all may know, xdg-shell v5 and xdg-shell stable can't currently > co-exist in the same

Re: [PATCH] Add the KDE server decoration protocol

2018-01-12 Thread Mike Blumenkrantz
Hi, Sorry I'm late to the review on this, I've been on an extended vacation. On Wed, Nov 15, 2017 at 8:01 AM David Edmundson wrote: > On Mon, Oct 30, 2017 at 5:03 AM, Jonas Ådahl wrote: > >> On Fri, Oct 27, 2017 at 01:13:15PM +0100, David

Re: connection: add sanity check to avoid buffer overflow

2017-10-19 Thread Mike Blumenkrantz
On one hand it may be dangerous for the scenario that you've described, but on the other hand why are you (or anyone) needing to call internal, non-exported libwayland functions? ?? On Thu, Oct 19, 2017 at 3:11 AM Boram Park wrote: > > > On 2017년 09월 28일 00:13,

Re: [PATCH wayland 8/9] client: Replace the singleton zombie with bespoke zombies

2017-04-11 Thread Mike Blumenkrantz
On Tue, Apr 11, 2017 at 11:39 AM Derek Foreman wrote: > On 07/04/17 03:27 PM, Derek Foreman wrote: > > Using the singleton zombie object doesn't allow us to posthumously retain > > object interface information, which makes it difficult to properly inter > > future events

Re: [PATCH weston] weston-terminal: Add a --maximized command line parameter

2017-03-15 Thread Mike Blumenkrantz
I'd like to see this merged for use with spec testing in Enlightenment. On Thu, Mar 9, 2017 at 3:50 PM Bryce Harrington wrote: > On Wed, Mar 08, 2017 at 11:58:20AM -0600, Derek Foreman wrote: > > This is useful for testing compositor response to a client that > > requests

Re: [PATCH weston] terminal: Fix crash due to race condition in init

2017-02-17 Thread Mike Blumenkrantz
Hi, Reverting this causes a 100% reproducible crash on startup in one of my CI tests for weston-terminal. Here is some of the debugging info: Program terminated with signal SIGSEGV, Segmentation fault. #0 0x0040ab93 in handle_char (terminal=0x6348a0, utf8=...) at clients/terminal.c:1991

Re: [PATCH wayland v2] protocol: Clarify the behaviour of wl_surface.attach

2017-02-15 Thread Mike Blumenkrantz
On Tue, Feb 14, 2017 at 11:17 PM Jonas Ådahl wrote: > On Tue, Feb 14, 2017 at 10:20:06AM -0600, Derek Foreman wrote: > > Attaching a NULL wl_buffer to a surface is not always valid, but > > the previous text indicated it was. > > > > Instead, let's define what NULL attachment

[PATCH] xdg-shell: require popups to intersect with or be adjacent to parent surfaces

2016-12-19 Thread Mike Blumenkrantz
some restrictions must be placed on this or else it becomes legal for the compositor to place popups in unexpected locations Signed-off-by: Mike Blumenkrantz <zm...@osg.samsung.com> --- unstable/xdg-shell/xdg-shell-unstable-v6.xml | 7 +-- 1 file changed, 5 insertions(+), 2 del

[PATCH] xdg-shell: require that popups intersect with parent surfaces

2016-12-08 Thread Mike Blumenkrantz
some restrictions must be placed on this or else it becomes legal for the compositor to place popups in unexpected locations Signed-off-by: Mike Blumenkrantz <zm...@osg.samsung.com> --- unstable/xdg-shell/xdg-shell-unstable-v6.xml | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-)

Re: Proposal to add 'raise' and 'lower' to xdg-shell in wayland-protocols

2016-12-08 Thread Mike Blumenkrantz
Goode <ago...@google.com> wrote: > On Mon, Dec 5, 2016 at 11:11 AM, Mike Blumenkrantz < > michael.blumenkra...@gmail.com> wrote: > > To echo Jonas's comments, I'm also strongly opposed to adding window > stacking manipulation to the xdg-shell protocol. It's already a me

Re: Proposal to add 'raise' and 'lower' to xdg-shell in wayland-protocols

2016-12-05 Thread Mike Blumenkrantz
To echo Jonas's comments, I'm also strongly opposed to adding window stacking manipulation to the xdg-shell protocol. It's already a mess handling windows which try to raise/focus themselves in X11, this is not an issue I want to handle under Wayland. EFL also has functionality in the toolkit for

Re: [PATCH] xdg-shell: clarify popup constrain's slide mechanism

2016-11-30 Thread Mike Blumenkrantz
ing". > > > On Mon, Nov 21, 2016 at 3:52 AM, Jonas Ådahl <jad...@gmail.com> wrote: > > On Mon, Nov 21, 2016 at 06:36:49AM -0500, Mike Blumenkrantz wrote: > >> On Fri, 18 Nov 2016 09:28:56 +0800 > >> Jonas Ådahl <jad...@gmail.com> wrote: > &

Re: [PATCH] xdg-shell: clarify popup constrain's slide mechanism

2016-11-21 Thread Mike Blumenkrantz
On Fri, 18 Nov 2016 09:28:56 +0800 Jonas Ådahl <jad...@gmail.com> wrote: > On Wed, Nov 16, 2016 at 10:23:59AM -0500, Mike Blumenkrantz wrote: > > some restrictions must be placed on this or else it becomes legal for > > the compositor to place popups in unexpected l

Re: [PATCH] xdg-shell: clarify popup constrain's slide mechanism

2016-11-16 Thread Mike Blumenkrantz
that relationship. On Wed, Nov 16, 2016 at 10:24 AM Mike Blumenkrantz <zm...@osg.samsung.com> wrote: > some restrictions must be placed on this or else it becomes legal for > the compositor to place popups in unexpected locations when sliding > is allowed > > Signed-off-by:

[PATCH] xdg-shell: clarify popup constrain's slide mechanism

2016-11-16 Thread Mike Blumenkrantz
some restrictions must be placed on this or else it becomes legal for the compositor to place popups in unexpected locations when sliding is allowed Signed-off-by: Mike Blumenkrantz <zm...@osg.samsung.com> --- unstable/xdg-shell/xdg-shell-unstable-v6.xml | 6 -- 1 file changed, 4 inse

Re: [PATCH wayland-protocols 2/4 v2] xdg-shell: Clarify focus semantics for popup grabs

2016-08-04 Thread Mike Blumenkrantz
Reviewed-By: Mike Blumenkrantz <zm...@osg.samsung.com> On Fri, Jul 29, 2016 at 12:06 AM Jonas Ådahl <jad...@gmail.com> wrote: > Make it clearer what the focus semantics are during a popup grab. In > short, when a grabbing popup is mapped, the top most popup will always >

Re: [PATCH wayland-protocols v2] Introduce xdg-foreign protocol

2016-08-04 Thread Mike Blumenkrantz
Reviewed-By: Mike Blumenkrantz <zm...@osg.samsung.com> On Wed, Jul 27, 2016 at 3:55 AM Jonas Ådahl <jad...@gmail.com> wrote: > xdg-foreign is a protocol meant to enable setting up inter surface > relationships across clients. Potential use cases are out-of-process > dialogs,

Re: [PATCH RFC] xdg-shell: Add tiled states

2016-06-01 Thread Mike Blumenkrantz
On Wed, Jun 1, 2016 at 10:42 AM Olivier Fourdan wrote: > Hi Mike, > > - Original Message - > > I've read the ticket linked in the other mail, but your use of "tiled" > here > > is confusing to me since you (and the ticket) appear to be conflating two > >

Re: [PATCH RFC] xdg-shell: Add tiled states

2016-06-01 Thread Mike Blumenkrantz
Hi, On Wed, Jun 1, 2016 at 5:19 AM Olivier Fourdan wrote: > When tiled, clients must obey the window geometry specified in the > configure event and can choose to hide some of their decorations. > > Signed-off-by: Olivier Fourdan > --- >

Re: [PATCH] xdg-shell: add draw states for xdg_surface

2016-05-31 Thread Mike Blumenkrantz
After a long weekend of not reading mails, I've read some mails; I'll try to make comments to everything in this reply. On Tue, May 31, 2016 at 7:38 AM Olivier Fourdan wrote: > Hey > > - Original Message - > > On Tue, May 31, 2016 at 05:24:35AM -0400, Olivier

Re: [PATCH] xdg-shell: add draw states for xdg_surface

2016-05-28 Thread Mike Blumenkrantz
On Sat, May 28, 2016 at 9:40 AM Yong Bakos <j...@humanoriented.com> wrote: > Hi Mike, > Regarding the combination of type="array" enum="foo"... > > On May 27, 2016, at 12:30 PM, Mike Blumenkrantz < > michael.blumenkra...@gmail.com> wrote: > >

Re: [PATCH] xdg-shell: add draw states for xdg_surface

2016-05-27 Thread Mike Blumenkrantz
I've inlined some replies below. On Fri, May 27, 2016 at 1:13 PM Yong Bakos <j...@humanoriented.com> wrote: > On May 27, 2016, at 10:29 AM, Mike Blumenkrantz <zm...@osg.samsung.com> > wrote: > > > > this adds a method for compositors to change various dra

[PATCH] xdg-shell: add draw states for xdg_surface

2016-05-27 Thread Mike Blumenkrantz
this adds a method for compositors to change various draw attributes for a surface Signed-off-by: Mike Blumenkrantz <zm...@osg.samsung.com> Signed-off-by: Jonas Ådahl <jad...@gmail.com> --- unstable/xdg-shell/xdg-shell-unstable-v6.xml | 69 1 file

Re: writing Was: [PATCH weston 1/5] gl-renderer: Rename gl_renderer_create to gl_renderer_display_create

2016-05-19 Thread Mike Blumenkrantz
016, at 10:31 AM, Daniel Stone <dan...@fooishbar.org> wrote: > > > > Hi, > > > > On 18 May 2016 at 15:25, Derek Foreman <der...@osg.samsung.com> wrote: > >> On 18/05/16 08:41 AM, Mike Blumenkrantz wrote: > >>> In fairness, we'd likely be

Re: [PATCH weston 1/5] gl-renderer: Rename gl_renderer_create to gl_renderer_display_create

2016-05-18 Thread Mike Blumenkrantz
On Wed, May 18, 2016 at 3:51 AM Pekka Paalanen wrote: > On Thu, 12 May 2016 17:20:49 +0200 > Miguel Angel Vico wrote: > > > Thanks Derek. > > > > Inline. > > > > On Thu, 12 May 2016 08:54:26 -0500 > > Derek Foreman wrote: > > >

Re: Protocol for window previews/thumbnails

2016-05-12 Thread Mike Blumenkrantz
On Thu, May 12, 2016 at 3:57 AM Pekka Paalanen wrote: > On Wed, 11 May 2016 23:35:01 +0100 > ade low wrote: > > > Thank you for the feedback, that was very helpful. > > > > On Wed, May 11, 2016 at 9:07 AM, Pekka Paalanen > wrote: >

Re: Introduction and updates from NVIDIA

2016-05-11 Thread Mike Blumenkrantz
On Wed, May 11, 2016 at 7:08 PM James Jones wrote: > On 05/11/2016 02:31 PM, Daniel Stone wrote: > > Hi James, > > > > On 11 May 2016 at 21:43, James Jones wrote: > >> On 05/04/2016 08:56 AM, Daniel Stone wrote: > >>> Right - but as with the point I was

Re: Feedback on xdg-shell v5

2016-04-29 Thread Mike Blumenkrantz
On Fri, Apr 29, 2016 at 4:38 AM Martin Graesslin wrote: > On Thursday, April 28, 2016 5:36:58 PM CEST Jonas Ådahl wrote: > > On Thu, Apr 28, 2016 at 10:36:14AM +0200, Martin Graesslin wrote: > > > Hi Wayland and Plasma, > > > > > > I finished the implementation of xdg-shell

Re: [PATCH weston 3/4] data-device: Update current action even if source version is old

2016-04-21 Thread Mike Blumenkrantz
wl_data_device_send_selection(data_device, > offer->resource); > } else { > wl_data_device_send_selection(data_device, NULL); > } > -- > 2.5.5 > > ___ > wayland-devel mailing list > wayland-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/wayland-devel Reviewed-By: Mike Blumenkrantz <zm...@osg.samsung.com> ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH weston 4/4] input: Don't try to send axis_source when there are no resources

2016-04-21 Thread Mike Blumenkrantz
Functionally Reviewed-By: Mike Blumenkrantz <zm...@osg.samsung.com> but the commit message is a bit confusing On Wed, Apr 20, 2016 at 11:11 PM Jonas Ådahl <jad...@gmail.com> wrote: > We miss to NULL check the focus_client, which is only non-NULL when > there the focused client

Re: [PATCH weston 2/4] desktop-shell: Get rid of some unused fields

2016-04-21 Thread Mike Blumenkrantz
Reviewed-By: Mike Blumenkrantz <zm...@osg.samsung.com> On Wed, Apr 20, 2016 at 11:11 PM Jonas Ådahl <jad...@gmail.com> wrote: > Signed-off-by: Jonas Ådahl <jad...@gmail.com> > --- > desktop-shell/shell.c | 6 -- > 1 file changed, 6 deletions(-) > >

Re: [PATCH weston 1/4] desktop-shell: Unset the shell surface owner when it goes away

2016-04-21 Thread Mike Blumenkrantz
Reviewed-By: Mike Blumenkrantz <zm...@osg.samsung.com> On Wed, Apr 20, 2016 at 11:11 PM Jonas Ådahl <jad...@gmail.com> wrote: > On client destruction, the shell object may be destroyed before the > shell surface objects. If this happens to two surfaces of the same > client,

Re: [PATCH wayland-protocols 7/7] xdg-shell: Introduce xdg_positioner

2016-04-19 Thread Mike Blumenkrantz
jad...@gmail.com> > Signed-off-by: Mike Blumenkrantz <zm...@samsung.com> > --- > unstable/xdg-shell/xdg-shell-unstable-v6.xml | 206 > ++- > 1 file changed, 204 insertions(+), 2 deletions(-) > > diff --git a/unstable/xdg-shell/xdg-shell-unst

Re: [PATCH v6 xdg-shell-unstable-v6] xdg-shell: Add min/max size requests

2016-04-13 Thread Mike Blumenkrantz
Reviewed-By: Mike Blumenkrantz <zm...@osg.samsung.com> On Wed, Apr 13, 2016 at 2:18 PM Olivier Fourdan <ofour...@redhat.com> wrote: > Just a quick note, not that it matters much, but this should have been v7, > not v6, I got confused with the numbering of iterations :) >

Re: [PATCH v5 xdg-shell-unstable-v6] xdg-shell: Add min/max size requests

2016-04-12 Thread Mike Blumenkrantz
Sure, that sounds good to me! On Tue, Apr 12, 2016 at 11:24 AM Olivier Fourdan wrote: > Hi Mike. > > > Okay, if we're not going with uints then at the least can the "use 0 to > > unset min/max" be changed to "use <= 0 to unset min/max" to explicitly > > cover that case? > >

Re: [PATCH v5 xdg-shell-unstable-v6] xdg-shell: Add min/max size requests

2016-04-12 Thread Mike Blumenkrantz
Okay, if we're not going with uints then at the least can the "use 0 to unset min/max" be changed to "use <= 0 to unset min/max" to explicitly cover that case? On Tue, Apr 12, 2016 at 10:40 AM Olivier Fourdan wrote: > Hi, > > > > > Good point. Setting an invalid state

Re: [PATCH v5 xdg-shell-unstable-v6] xdg-shell: Add min/max size requests

2016-04-11 Thread Mike Blumenkrantz
I think this should probably use uint instead of int for params since zero is the "unset" number. Otherwise you have to write something about negative sizes. On Mon, Apr 11, 2016 at 3:11 PM Jasper St. Pierre wrote: > On Mon, Apr 11, 2016 at 12:59 AM, Olivier Fourdan

Re: [PATCH] xdg-shell: add set_max_size request

2016-04-04 Thread Mike Blumenkrantz
On Mon, Apr 4, 2016 at 3:30 PM Olivier Fourdan wrote: > > Hi Mike, > > - Original Message - > > [...] > > > > Yes, I know you are not currently advocating for it, but you've proved my > > point--others will see this go in and then they will push for it. Adding > >

Re: [PATCH] xdg-shell: add set_max_size request

2016-04-04 Thread Mike Blumenkrantz
On Mon, Apr 4, 2016 at 1:17 PM Olivier Fourdan wrote: > Hi Mike, > > > Hm, you raise some interesting points. However, I think your argument is > > somewhat misled by your claim that "this case is unique". If there is an > > application which does not want to be larger than

Re: [PATCH] xdg-shell: add set_max_size request

2016-04-04 Thread Mike Blumenkrantz
Hm, you raise some interesting points. However, I think your argument is somewhat misled by your claim that "this case is unique". If there is an application which does not want to be larger than a certain size, why could there not also be an application which does not want to be smaller than a

Re: [PATCH] xdg-shell: add set_max_size request

2016-04-04 Thread Mike Blumenkrantz
Just to play devil's advocate, do we really want to start getting into size hint type stuff? After this will be min size, then step size, then aspect, ... On Mon, Apr 4, 2016 at 5:14 AM Olivier Fourdan wrote: > Some application may wish to restrict their window in size, but

Re: [PATCH wayland-protocols] unstable: Add the Wayland Wobbly Windows protocol

2016-04-01 Thread Mike Blumenkrantz
Thanks for this detailed and thorough review. I will spend some time to carefully address your comments and follow with a revised version for you to personally inspect. On Fri, Apr 1, 2016 at 12:19 PM Daniel Stone wrote: > Hi, > > On 1 April 2016 at 16:14, Derek Foreman

Re: [RFC wayland 10/18] scanner: Add the concept of "pre hooks"

2016-02-09 Thread Mike Blumenkrantz
On Tue, 09 Feb 2016 10:55:57 -0600 Derek Foreman wrote: > A pre hook is a wayland library call made on the client side before the > request is sent. > > Until now the wayland library has simply passed requests on without any > knowledge of what they mean, and the

Re: Moving bugs to Phabricator

2016-02-03 Thread Mike Blumenkrantz
Hi, It seems that opening any of these links requires a login. A valid use case for bug trackers is something like: * user searches web for issue keywords (eg. "wayland has no ssd!") * results include link to bug * user views bug report Requiring a login will create more hassle and reduce the

Re: [PATCH wayland-protocols 3/3] xdg-shell: Introduce xdg_tooltip

2016-01-18 Thread Mike Blumenkrantz
On Sun, 17 Jan 2016 10:37:09 +0800 Jonas Ådahl <jad...@gmail.com> wrote: > On Sat, Jan 16, 2016 at 03:07:00PM -0500, Mike Blumenkrantz wrote: > > On Sat, 16 Jan 2016 10:28:20 +0800 > > Jonas Ådahl <jad...@gmail.com> wrote: > > > > > On Fri, Jan 15, 2

Re: [PATCH wayland-protocols 3/3] xdg-shell: Introduce xdg_tooltip

2016-01-16 Thread Mike Blumenkrantz
On Sat, 16 Jan 2016 10:28:20 +0800 Jonas Ådahl <jad...@gmail.com> wrote: > On Fri, Jan 15, 2016 at 09:19:34PM -0500, Mike Blumenkrantz wrote: > > Hi, > > > > I have some suggestions which I've inlined below: > > > > On Tue, 12 Jan 2016 16:16:49 +0800 &

Re: [PATCH wayland-protocols 3/3] xdg-shell: Introduce xdg_tooltip

2016-01-15 Thread Mike Blumenkrantz
Hi, I have some suggestions which I've inlined below: On Tue, 12 Jan 2016 16:16:49 +0800 Jonas Ådahl wrote: > An xdg_tooltip is a new window type used to implement tooltip like > surfaces. See the interface documentation for details. > > Signed-off-by: Jonas Ådahl

Re: [PATCH wayland-protocols 2/3] xdg-shell: Make get_popup take a xdg_surface instead of wl_surface

2016-01-15 Thread Mike Blumenkrantz
-unstable-v6.xml > index d1c315e..276d9fc 100644 > --- a/unstable/xdg-shell/xdg-shell-unstable-v6.xml > +++ b/unstable/xdg-shell/xdg-shell-unstable-v6.xml > @@ -176,7 +176,7 @@ > xdg_popup is and how it is used. > > > - > + >

Re: [PATCH wayland-protocols 1/3] xdg-shell: Turn xdg_surface into a generic base interface

2016-01-15 Thread Mike Blumenkrantz
Hi, I have some suggestions which I've inlined below: On Tue, 12 Jan 2016 16:16:47 +0800 Jonas Ådahl wrote: > Split out toplevel window like requests and events into a new interface > called xdg_toplevel, and turn xdg_surface into a generic base interface > which others

Re: [PATCH] xdg-shell: add state range reservation for EFL

2015-12-06 Thread Mike Blumenkrantz
Yeah, that's my mistake, it got lost in the mail. If you don't mind adding Signed-off-by: Mike Blumenkrantz <zm...@osg.samsung.com> I would appreciate it. On Sun, 06 Dec 2015 13:51:20 +0800 Jonas Ådahl <jad...@gmail.com> wrote: > On Fri, Dec 04, 2015 at 12:41:16PM -0500, Mi

[PATCH] xdg-shell: add state range reservation for EFL

2015-12-04 Thread Mike Blumenkrantz
Reviewed-by: Jasper St. Pierre --- unstable/xdg-shell/xdg-shell-unstable-v5.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/unstable/xdg-shell/xdg-shell-unstable-v5.xml b/unstable/xdg-shell/xdg-shell-unstable-v5.xml index 127992b..542491f 100644 ---

Re: [PATCH wayland-protocols v2] xdg-shell: Bump unstable version to 6

2015-12-03 Thread Mike Blumenkrantz
ment. > > It was a realization that most of wayland.xml did this. I don't think > there is enough gain by changing wayland.xml since we'd make git blame > more hard to use, and consistency across protocols is favorable here > IMHO. > git blame -w ? >

Re: [PATCH 1/2] xdg-shell: Bump unstable version to 6

2015-12-02 Thread Mike Blumenkrantz
On Wed, 02 Dec 2015 20:03:27 -0500 Mike Blumenkrantz <zm...@samsung.com> wrote: > This copies the version 5 of the XML to a new version 6 version, while > at the same time the interface names are changed to use the unstable > naming convention. > > A whitespace clean

[PATCH 1/2] xdg-shell: Bump unstable version to 6

2015-12-02 Thread Mike Blumenkrantz
This copies the version 5 of the XML to a new version 6 version, while at the same time the interface names are changed to use the unstable naming convention. A whitespace cleanup was done as no git-blame:ability would be lost anyway. Reviewed-by: Mike Blumenkrantz <zm...@osg.samsung.com>

[PATCH 2/2] xdg-shell: clarify xdg_surface creation semantics regarding buffers

2015-12-02 Thread Mike Blumenkrantz
to creating the xdg surface Reviewed-by: Jasper St. Pierre <jstpie...@mecheye.net> Signed-off-by: Mike Blumenkrantz <zm...@osg.samsung.com> Signed-off-by: Jonas Ådahl <jad...@gmail.com> --- unstable/xdg-shell/xdg-shell-unstable-v6.xml | 14 ++ 1 file changed, 6 insertio

[PATCH 1/2] xdg-shell: Bump unstable version to 6

2015-12-02 Thread Mike Blumenkrantz
This copies the version 5 of the XML to a new version 6 version, while at the same time the interface names are changed to use the unstable naming convention. A whitespace cleanup was done as no git-blame:ability would be lost anyway. Reviewed-by: Mike Blumenkrantz <zm...@osg.samsung.com>

Re: [PATCH wayland] protocol: Improve data source notification around DnD progress

2015-10-16 Thread Mike Blumenkrantz
On Fri, 16 Oct 2015 16:53:28 +0100 Daniel Stone wrote: > Hi, > > On Wednesday, 30 September 2015, Carlos Garnacho > wrote: > > > Currently, there's no means for the DnD origin to know whether the > > destination is actually finished with the DnD

Re: [PATCH wayland v4] protocol: Add DnD actions

2015-10-16 Thread Mike Blumenkrantz
On Fri, 16 Oct 2015 16:52:44 +0100 Daniel Stone wrote: > Hi, > > On Wednesday, 30 September 2015, Carlos Garnacho > wrote: > > > These 2 requests have been added: > > > > - wl_data_source.set_actions: Notifies the compositor of the > > available